[GitHub] spark pull request: [SPARK-529] [sql] Modify SQLConf to use new co...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11570#issuecomment-197051324 **[Test build #53233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53233/consoleFull)** for PR 11570 at commit

[GitHub] spark pull request: [SPARK-529] [sql] Modify SQLConf to use new co...

2016-03-15 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11570#issuecomment-197051108 Another ping? Fixing conflicts is getting kinda boring. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-13038] [PySpark] Add load/save to pipel...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11683#issuecomment-197051160 **[Test build #53231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53231/consoleFull)** for PR 11683 at commit

[GitHub] spark pull request: [SPARK-13325][SQL] Create a 64-bit hashcode ex...

2016-03-15 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11209#discussion_r56250047 --- Diff: sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/XXH64Suite.java --- @@ -0,0 +1,159 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11615#issuecomment-197048186 **[Test build #53232 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53232/consoleFull)** for PR 11615 at commit

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-15 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11615#issuecomment-197047893 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13873] [SQL] Avoid copy of UnsafeRow wh...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11740#issuecomment-197047563 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13873] [SQL] Avoid copy of UnsafeRow wh...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11740#issuecomment-197047561 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13873] [SQL] Avoid copy of UnsafeRow wh...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11740#issuecomment-197047538 **[Test build #53228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53228/consoleFull)** for PR 11740 at commit

[GitHub] spark pull request: [SPARK-13038] [PySpark] Add load/save to pipel...

2016-03-15 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11683#issuecomment-197047449 test it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13038] [PySpark] Add load/save to pipel...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11683#issuecomment-197046776 **[Test build #53231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53231/consoleFull)** for PR 11683 at commit

[GitHub] spark pull request: [SPARK-13869][SQL] Remove redundant conditions...

2016-03-15 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/11670#issuecomment-197046336 yes, I agree. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10788][MLLIB][ML] Remove duplicate bins...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9474#issuecomment-197045280 **[Test build #53230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53230/consoleFull)** for PR 9474 at commit

[GitHub] spark pull request: [SPARK-13895][SQL]Change the return type of Da...

2016-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11731 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13895][SQL] DataFrameReader.text should...

2016-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11739 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13869][SQL] Remove redundant conditions...

2016-03-15 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11670#issuecomment-197043910 I think we need a more general fix for all the predicate push down. I will submit a PR for a general issue instead of fixing `Union` only. --- If your project is

[GitHub] spark pull request: [WIP][SPARK-13883][SQL] Parquet Implementation...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11709#issuecomment-197043761 **[Test build #53229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53229/consoleFull)** for PR 11709 at commit

[GitHub] spark pull request: [SPARK-13895][SQL] DataFrameReader.text should...

2016-03-15 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11739#issuecomment-197043594 LGTM. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11615#issuecomment-197042406 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11615#issuecomment-197042409 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11615#issuecomment-197042177 **[Test build #53221 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53221/consoleFull)** for PR 11615 at commit

[GitHub] spark pull request: [SPARK-13626] [core] Revert change to SparkCon...

2016-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11734 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13873] [SQL] Avoid copy of UnsafeRow wh...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11740#issuecomment-197041376 **[Test build #53228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53228/consoleFull)** for PR 11740 at commit

[GitHub] spark pull request: [SPARK-13917] [SQL] generate broadcast semi jo...

2016-03-15 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11742#issuecomment-197041765 cc @nongli --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13626] [core] Revert change to SparkCon...

2016-03-15 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11734#issuecomment-197040263 unrelated test failure. merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [MINOR] a minor fix for the comments of a meth...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11738#issuecomment-197039845 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [MINOR] a minor fix for the comments of a meth...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11738#issuecomment-197039852 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-197039251 **[Test build #53227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53227/consoleFull)** for PR 10355 at commit

[GitHub] spark pull request: [MINOR] a minor fix for the comments of a meth...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11738#issuecomment-197039440 **[Test build #53214 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53214/consoleFull)** for PR 11738 at commit

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-197039263 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-197039258 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [MINOR] a minor fix for the comments of a meth...

2016-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11738 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [MINOR] a minor fix for the comments of a meth...

2016-03-15 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11738#issuecomment-197038090 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-15 Thread BenFradet
Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-197037079 Here's what's left to do: - IsotonicRegression - GeneralizedLinearRegression - AFTSurvival Otherwise, I'd prefer doing the evaluators and other

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-197035874 **[Test build #53227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53227/consoleFull)** for PR 10355 at commit

[GitHub] spark pull request: [MINOR] a minor fix for the comments of a meth...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11738#issuecomment-197035770 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [MINOR] a minor fix for the comments of a meth...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11738#issuecomment-197035765 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: generate semi join

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11742#issuecomment-197035834 **[Test build #53226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53226/consoleFull)** for PR 11742 at commit

[GitHub] spark pull request: [SPARK-13038] [PySpark] Add load/save to pipel...

2016-03-15 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/11683#discussion_r56246031 --- Diff: python/pyspark/ml/pipeline.py --- @@ -15,116 +15,87 @@ # limitations under the License. # -from abc import ABCMeta,

[GitHub] spark pull request: [MINOR] a minor fix for the comments of a meth...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11738#issuecomment-197034693 **[Test build #53213 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53213/consoleFull)** for PR 11738 at commit

[GitHub] spark pull request: [SPARK-13898][SQL] Merge DatasetHolder and Dat...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11737#issuecomment-197029780 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13873] [SQL] Avoid copy of UnsafeRow wh...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11740#issuecomment-197029142 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13869][SQL] Remove redundant conditions...

2016-03-15 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/11670#issuecomment-197033126 oh I see, a union -- that was a tricky one! The issue with union is that its constraints are an "intersection" of the constraints of its individual children

[GitHub] spark pull request: [WIP][SPARK-13809][SQL] State store for stream...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11645#issuecomment-197032639 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [WIP][SPARK-13809][SQL] State store for stream...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11645#issuecomment-197032614 **[Test build #53225 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53225/consoleFull)** for PR 11645 at commit

[GitHub] spark pull request: [WIP][SPARK-13809][SQL] State store for stream...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11645#issuecomment-197032651 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP][SPARK-13809][SQL] State store for stream...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11645#issuecomment-197031923 **[Test build #53225 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53225/consoleFull)** for PR 11645 at commit

[GitHub] spark pull request: [SPARK-13898][SQL] Merge DatasetHolder and Dat...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11737#issuecomment-197029783 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13898][SQL] Merge DatasetHolder and Dat...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11737#issuecomment-197029327 **[Test build #53215 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53215/consoleFull)** for PR 11737 at commit

[GitHub] spark pull request: [SPARK-13873] [SQL] Avoid copy of UnsafeRow wh...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11740#issuecomment-197029136 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13873] [SQL] Avoid copy of UnsafeRow wh...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11740#issuecomment-197028500 **[Test build #53219 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53219/consoleFull)** for PR 11740 at commit

[GitHub] spark pull request: [SPARK-13325][SQL] Create a 64-bit hashcode ex...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11209#issuecomment-197028097 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13325][SQL] Create a 64-bit hashcode ex...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11209#issuecomment-197028101 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13325][SQL] Create a 64-bit hashcode ex...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11209#issuecomment-197027591 **[Test build #53218 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53218/consoleFull)** for PR 11209 at commit

[GitHub] spark pull request: [SPARK-13895][SQL] DataFrameReader.text should...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11739#issuecomment-197026027 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13895][SQL] DataFrameReader.text should...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11739#issuecomment-197026024 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13895][SQL] DataFrameReader.text should...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11739#issuecomment-197025677 **[Test build #53217 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53217/consoleFull)** for PR 11739 at commit

[GitHub] spark pull request: [SPARK-13793] [CORE] PipedRDD doesn't propagat...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11628#issuecomment-197025539 **[Test build #53224 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53224/consoleFull)** for PR 11628 at commit

[GitHub] spark pull request: generate semi join

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11742#issuecomment-197025538 **[Test build #53223 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53223/consoleFull)** for PR 11742 at commit

[GitHub] spark pull request: [SPARK-13895][SQL] DataFrameReader.text should...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11739#issuecomment-197024999 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13895][SQL] DataFrameReader.text should...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11739#issuecomment-197024994 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13895][SQL] DataFrameReader.text should...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11739#issuecomment-197024567 **[Test build #53216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53216/consoleFull)** for PR 11739 at commit

[GitHub] spark pull request: [SPARK-13793] [CORE] PipedRDD doesn't propagat...

2016-03-15 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11628#issuecomment-197024315 I'm fine with it. This shoudl work well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: generate semi join

2016-03-15 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/11742 generate semi join ## What changes were proposed in this pull request? This PR brings codegen support for broadcast left-semi join. ## How was this patch tested? Existing

[GitHub] spark pull request: [SPARK-13793] [CORE] PipedRDD doesn't propagat...

2016-03-15 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11628#issuecomment-197024340 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13869][SQL] Remove redundant conditions...

2016-03-15 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11670#issuecomment-197024276 I thought you are doing this PR for avoiding to push down the redundant inferred/isnotnull conditions. It sounds like my understanding is wrong. As shown in the

[GitHub] spark pull request: [SPARK-13869][SQL] Remove redundant conditions...

2016-03-15 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/11670#issuecomment-197022980 I actually found this issue while playing around with some tests. @gatorsmile can you give an example for a case where we generate redundant filters? The code

[GitHub] spark pull request: [SPARK-13916][SQL] Add a metric to WholeStageC...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11741#issuecomment-197021400 **[Test build #53222 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53222/consoleFull)** for PR 11741 at commit

[GitHub] spark pull request: [SPARK-13869][SQL] Remove redundant conditions...

2016-03-15 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11670#issuecomment-197020834 @sameeragarwal I plan to submit a PR for avoiding pushing redundant predicates through the operators, since it is blocking another PR:

[GitHub] spark pull request: [SPARK-13869][SQL] Remove redundant conditions...

2016-03-15 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/11670#issuecomment-197020554 Can you be more specific? When does this generate a redundant one? Let's make sure we don't continuously generate them and collapse them. --- If your project is set up

[GitHub] spark pull request: [SPARK-13871][SQL] Support for inferring filte...

2016-03-15 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11665#discussion_r56240703 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -598,50 +598,41 @@ object NullPropagation extends

[GitHub] spark pull request: [SPARK-13871][SQL] Support for inferring filte...

2016-03-15 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11665#discussion_r56239773 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -598,50 +598,41 @@ object NullPropagation extends

[GitHub] spark pull request: [SPARK-13869][SQL] Remove redundant conditions...

2016-03-15 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11670#issuecomment-197017299 https://github.com/apache/spark/pull/11665 could introduce redundant conditions. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-13871][SQL] Support for inferring filte...

2016-03-15 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11665#discussion_r56239534 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -78,7 +78,7 @@ abstract class Optimizer extends

[GitHub] spark pull request: [SPARK-13869][SQL] Remove redundant conditions...

2016-03-15 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/11670#issuecomment-197016555 LGTM How did you decide to do this? Are there other rules that are generating things like this? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-13808] Don't build assembly in dev/run-...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197014949 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13808] Don't build assembly in dev/run-...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197014946 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13808] Don't build assembly in dev/run-...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11701#issuecomment-197014724 **[Test build #53209 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53209/consoleFull)** for PR 11701 at commit

[GitHub] spark pull request: [SPARK-8971][MLLIB][ML] Support balanced class...

2016-03-15 Thread sethah
Github user sethah commented on the pull request: https://github.com/apache/spark/pull/8112#issuecomment-197011427 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13038] [PySpark] Add load/save to pipel...

2016-03-15 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11683#issuecomment-197010062 Sure. Cheers Xusen Yin > On Mar 15, 2016, at 1:35 PM, jkbradley wrote: > > One more comment: I just spoke with

[GitHub] spark pull request: [SPARK-13038] [PySpark] Add load/save to pipel...

2016-03-15 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11683#issuecomment-197009204 One more comment: I just spoke with Xiangrui, and he recommended we not add an underscore to the beginning of private class names (since we don't do that elsewhere).

[GitHub] spark pull request: [SPARK-13793] [CORE] PipedRDD doesn't propagat...

2016-03-15 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/11628#issuecomment-197008054 @srowen : The problem sequence you identified is correct. I agree that doing check both at the start and end is overkill (not to mention the overhead and

[GitHub] spark pull request: [SPARK-13038] [PySpark] Add load/save to pipel...

2016-03-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11683#discussion_r56234912 --- Diff: python/pyspark/ml/pipeline.py --- @@ -15,116 +15,87 @@ # limitations under the License. # -from abc import ABCMeta,

[GitHub] spark pull request: [SPARK-13916][SQL] Add a metric to WholeStageC...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11741#issuecomment-197005790 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13916][SQL] Add a metric to WholeStageC...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11741#issuecomment-197005792 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13916][SQL] Add a metric to WholeStageC...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11741#issuecomment-197005780 **[Test build #53220 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53220/consoleFull)** for PR 11741 at commit

[GitHub] spark pull request: [SPARK-13840] [SQL] Split Optimizer Rule Colum...

2016-03-15 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11682#issuecomment-197004091 After writing more test cases, I found a couple of issues. In addition, we need another split of the rule `ColumnPruning`. Have a new rule

[GitHub] spark pull request: [SPARK-13896][SQL]Dataset.toJSON should return...

2016-03-15 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11732#issuecomment-197005610 i missed the docs ok...my bad --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13916][SQL] Add a metric to WholeStageC...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11741#issuecomment-197005374 **[Test build #53220 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53220/consoleFull)** for PR 11741 at commit

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11615#issuecomment-197005370 **[Test build #53221 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53221/consoleFull)** for PR 11615 at commit

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-15 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11615#discussion_r56233519 --- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala --- @@ -134,7 +134,7 @@ private[spark] abstract class WebUI( def bind() {

[GitHub] spark pull request: [SPARK-13916][SQL] Add a metric to WholeStageC...

2016-03-15 Thread nongli
GitHub user nongli opened a pull request: https://github.com/apache/spark/pull/11741 [SPARK-13916][SQL] Add a metric to WholeStageCodegen to measure duration. ## What changes were proposed in this pull request? WholeStageCodegen naturally breaks the execution into pipelines

[GitHub] spark pull request: [SPARK-13396] Stop using our internal deprecat...

2016-03-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11544#discussion_r56232735 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) extends

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11615#discussion_r56232500 --- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala --- @@ -134,7 +134,7 @@ private[spark] abstract class WebUI( def bind() {

[GitHub] spark pull request: [SPARK-13873] [SQL] Avoid copy of UnsafeRow wh...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11740#issuecomment-197002383 **[Test build #53219 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53219/consoleFull)** for PR 11740 at commit

[GitHub] spark pull request: [SPARK-13873] [SQL] Avoid copy of UnsafeRow wh...

2016-03-15 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/11740 [SPARK-13873] [SQL] Avoid copy of UnsafeRow when there is no join in whole stage codegen ## What changes were proposed in this pull request? We need to copy the UnsafeRow since a Join

[GitHub] spark pull request: [SPARK-13325][SQL] Create a 64-bit hashcode ex...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11209#issuecomment-196996612 **[Test build #53218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53218/consoleFull)** for PR 11209 at commit

[GitHub] spark pull request: [SPARK-13895][SQL] DataFrameReader.text should...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11739#issuecomment-196995045 **[Test build #53217 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53217/consoleFull)** for PR 11739 at commit

[GitHub] spark pull request: [SPARK-13894][SQL] SqlContext.range return typ...

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11730#discussion_r56228579 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java --- @@ -328,7 +328,7 @@ public void testTextLoad() { @Test

[GitHub] spark pull request: [SPARK-13906] Ensure that there are at least 2...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11728#issuecomment-196993001 Test PASSed. Refer to this link for build results (access rights to CI server needed):

<    1   2   3   4   5   6   7   8   9   >