[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12009#discussion_r58168784 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -45,46 +45,135 @@ abstract class NativeDDLCommand(val sql: Strin

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-31 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-204275787 One very minor comment on imports, and think there are now merge conflicts with latest master that need fixing, subject to those LGTM. --- If your project is set up for

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeReduce instead o...

2016-03-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12106#discussion_r58168589 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -451,10 +451,10 @@ final class OnlineLDAOptimizer extends LDAOptimi

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeReduce instead o...

2016-03-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12106#discussion_r58168561 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -451,10 +451,10 @@ final class OnlineLDAOptimizer extends LDAOptimi

[GitHub] spark pull request: [SPARK-14303] [ML] [SparkR] Define and use KMe...

2016-03-31 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12039#issuecomment-204275158 Merged and updated the JIRA to make it more specific. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark pull request: [SPARK-14303] [ML] [SparkR] Define and use KMe...

2016-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12039 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-11262][ML] Unit test for gradient, loss...

2016-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11262][ML] Unit test for gradient, loss...

2016-03-31 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9229#issuecomment-204274118 LGTM. Merged into master. Thanks and sorry for the long delay in code review! --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-31 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/10355#discussion_r58168089 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala --- @@ -26,7 +26,7 @@ import org.apache.spark.mllib.regression.LabeledPoint import org.

[GitHub] spark pull request: [SPARK-14295][SPARK-14274][SQL] Implements bui...

2016-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12088 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13112]CoarsedExecutorBackend register t...

2016-03-31 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/12078#issuecomment-204273968 I think current Spark code already do care about this race condition issue, though not so elegant. From the description of JIRA, I think a more broad problem is how t

[GitHub] spark pull request: [SPARK-14295][SPARK-14274][SQL] Implements bui...

2016-03-31 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12088#issuecomment-204273771 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13995][SQL] Extract correct IsNotNull c...

2016-03-31 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11809#issuecomment-204269003 @sameeragarwal Thanks for reviewing. Waiting for @marmbrus checking this. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14191][SQL] Remove invalid Expand opera...

2016-03-31 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11995#issuecomment-204268904 ping @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-03-31 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/12099#discussion_r58166528 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala --- @@ -101,4 +101,19 @@ class HiveExplainSuite extends Quer

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-03-31 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/12099#discussion_r58166375 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -576,7 +576,7 @@ frameBound explainOption

[GitHub] spark pull request: SPARK-14321. [SQL] Reduce date format cost and...

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12105#issuecomment-204267311 **[Test build #2721 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2721/consoleFull)** for PR 12105 at commit [`6fd07db`](https://g

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-03-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12099#discussion_r58165643 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -237,15 +237,18 @@ case class ExplainCommand( logicalPl

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-03-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12099#discussion_r58165608 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -576,7 +576,7 @@ frameBound explainOption -

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-03-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12099#discussion_r58165593 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala --- @@ -101,4 +101,19 @@ class HiveExplainSuite extends QueryTest

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-03-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12099#discussion_r58165570 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala --- @@ -81,29 +100,11 @@ package object debug { * WholeStageCodeg

[GitHub] spark pull request: [SPARK-14070] [SQL] Use ORC data source for SQ...

2016-03-31 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/11891#issuecomment-204259326 ping @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-03-31 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-204257179 @kiszk Now I'm inspecting this patch and I noticed some defects so far. 1. I ran a job like as follows. ``` sc.parallelize(1 to 1, 1).toDF.show

[GitHub] spark pull request: SPARK-14113. Consider marking JobConf closure-...

2016-03-31 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11978#issuecomment-204255875 @rajeshbalamohan you need to clean `sc.hadoopRDD` too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: SPARK-14113. Consider marking JobConf closure-...

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11978#issuecomment-204255888 **[Test build #54687 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54687/consoleFull)** for PR 11978 at commit [`0c53ed2`](https://gi

[GitHub] spark pull request: SPARK-14113. Consider marking JobConf closure-...

2016-03-31 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11978#issuecomment-204255624 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13674][SQL] Add wholestage codegen supp...

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11517#issuecomment-204251175 **[Test build #54686 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54686/consoleFull)** for PR 11517 at commit [`ef588db`](https://gi

[GitHub] spark pull request: [SPARK-14320][SQL] Make ColumnarBatch.Row muta...

2016-03-31 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/12103#discussion_r58162424 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java --- @@ -232,6 +233,56 @@ public MapData getMap(int ordinal) {

[GitHub] spark pull request: [SPARK-12864][YARN] initialize executorIdCount...

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10794#issuecomment-204248244 **[Test build #54685 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54685/consoleFull)** for PR 10794 at commit [`ebe3c7f`](https://gi

[GitHub] spark pull request: [SPARK-13674][SQL] Add wholestage codegen supp...

2016-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11517#discussion_r58161386 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -61,6 +63,14 @@ public long durationMs() { public abs

[GitHub] spark pull request: [SPARK-14303] [ML] [SparkR] Define and use KMe...

2016-03-31 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12039#issuecomment-204241139 LGTM. Having some issues with the merge script. I will merge it later. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeReduce instead o...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12106#issuecomment-204240413 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeReduce instead o...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12106#issuecomment-204240409 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeReduce instead o...

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12106#issuecomment-204240344 **[Test build #54684 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54684/consoleFull)** for PR 12106 at commit [`38cf0f3`](https://g

[GitHub] spark pull request: [SPARK-13674][SQL] Add wholestage codegen supp...

2016-03-31 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11517#discussion_r58160147 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -61,6 +63,14 @@ public long durationMs() { public abs

[GitHub] spark pull request: [SPARK-14255] [SQL] Streaming Aggregation

2016-03-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/12048#discussion_r58160046 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -28,37 +28,36 @@ package object state { implicit c

[GitHub] spark pull request: [SPARK-14255] [SQL] Streaming Aggregation

2016-03-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/12048#discussion_r58160004 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala --- @@ -0,0 +1,72 @@ +/* +* Licensed to the Apach

[GitHub] spark pull request: [SPARK-14255] [SQL] Streaming Aggregation

2016-03-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/12048#discussion_r58159893 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/utils.scala --- @@ -261,4 +246,90 @@ object Utils { finalAndCompleteAg

[GitHub] spark pull request: [SPARK-13674][SQL] Add wholestage codegen supp...

2016-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11517#discussion_r58159707 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -61,6 +63,14 @@ public long durationMs() { public abs

[GitHub] spark pull request: [SPARK-14255] [SQL] Streaming Aggregation

2016-03-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/12048#discussion_r58159654 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StreamTest.scala --- @@ -224,11 +239,8 @@ trait StreamTest extends QueryTest with Timeouts {

[GitHub] spark pull request: [SPARK-13674][SQL] Add wholestage codegen supp...

2016-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11517#discussion_r58159480 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -61,6 +63,14 @@ public long durationMs() { public abs

[GitHub] spark pull request: [SPARK-13674][SQL] Add wholestage codegen supp...

2016-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11517#discussion_r58159371 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -61,6 +63,14 @@ public long durationMs() { public abs

[GitHub] spark pull request: [SPARK-13674][SQL] Add wholestage codegen supp...

2016-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11517#discussion_r58158879 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -61,6 +63,14 @@ public long durationMs() { public abs

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeReduce instead o...

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12106#issuecomment-204229682 **[Test build #54684 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54684/consoleFull)** for PR 12106 at commit [`38cf0f3`](https://gi

[GitHub] spark pull request: [SPARK-14322] [MLlib] Use treeReduce instead o...

2016-03-31 Thread hhbyyh
GitHub user hhbyyh opened a pull request: https://github.com/apache/spark/pull/12106 [SPARK-14322] [MLlib] Use treeReduce instead of reduce in OnlineLDAOptimizer ## What changes were proposed in this pull request? OnlineLDAOptimizer uses RDD.reduce in two places where it cou

[GitHub] spark pull request: [SPARK-14137] [SQL] Cleanup hash join

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12102#issuecomment-204228061 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: SPARK-14321. [SQL] Reduce date format cost and...

2016-03-31 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12105#issuecomment-204228144 Jenkins, OK to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-14137] [SQL] Cleanup hash join

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12102#issuecomment-204228059 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14242][CORE][Network] avoid copy in com...

2016-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12038 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13674][SQL] Add wholestage codegen supp...

2016-03-31 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11517#discussion_r58157898 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -61,6 +63,14 @@ public long durationMs() { public abs

[GitHub] spark pull request: [SPARK-13674][SQL] Add wholestage codegen supp...

2016-03-31 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11517#discussion_r58157878 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -61,6 +63,14 @@ public long durationMs() { public abs

[GitHub] spark pull request: [SPARK-14137] [SQL] Cleanup hash join

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12102#issuecomment-204227840 **[Test build #54683 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54683/consoleFull)** for PR 12102 at commit [`37724be`](https://g

[GitHub] spark pull request: [SPARK-14242][CORE][Network] avoid copy in com...

2016-03-31 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/12038#issuecomment-204227663 Merging to master. Thanks, @liyezhang556520 ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: SPARK-14321. [SQL] Reduce date format cost and...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12105#issuecomment-204227649 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: SPARK-14321. [SQL] Reduce date format cost and...

2016-03-31 Thread rajeshbalamohan
GitHub user rajeshbalamohan opened a pull request: https://github.com/apache/spark/pull/12105 SPARK-14321. [SQL] Reduce date format cost and string-to-date cost i… ## What changes were proposed in this pull request? Here is the generated code snippet when executing date f

[GitHub] spark pull request: [SPARK-3724][ML] RandomForest: More options fo...

2016-03-31 Thread sethah
Github user sethah commented on the pull request: https://github.com/apache/spark/pull/11989#issuecomment-204225070 @yongtang I believe only Spark committers can do that. Maybe @jkbradley could help? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] spark pull request: [SPARK-13674][SQL] Add wholestage codegen supp...

2016-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11517#discussion_r58157092 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -61,6 +63,14 @@ public long durationMs() { public abs

[GitHub] spark pull request: [SPARK-13992] Add support for off-heap caching

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-204221481 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13992] Add support for off-heap caching

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-204221480 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13992] Add support for off-heap caching

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-204221322 **[Test build #54682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54682/consoleFull)** for PR 11805 at commit [`a604078`](https://g

[GitHub] spark pull request: [SPARK-13992] Add support for off-heap caching

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-204219686 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13992] Add support for off-heap caching

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-204219684 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13992] Add support for off-heap caching

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-204219598 **[Test build #54681 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54681/consoleFull)** for PR 11805 at commit [`fde020f`](https://g

[GitHub] spark pull request: [SPARK-14123][SQL] Implement function related ...

2016-03-31 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12036#issuecomment-204217824 @yhuai OK. Please let me know if any changes are not clear to you. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] spark pull request: [SPARK-14123][SQL] Implement function related ...

2016-03-31 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12036#issuecomment-204208195 @viirya Thank you for working on it. I think the overall approach makes sense. Looks like we can adjust how we organize SessionState, SessionCatalog, and FunctionRegistry

[GitHub] spark pull request: [SPARK-14290][CORE][Network] avoid significant...

2016-03-31 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/12083#issuecomment-204207886 Hi @vanzin , the memory copy place is given out by @zsxwing , the call stack is as follows: ``` at java.nio.Bits.copyFromArray(Bits.java:754)

[GitHub] spark pull request: [SPARK-13825][CORE] Upgrade to Scala 2.11.8

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11681#issuecomment-204204935 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13825][CORE] Upgrade to Scala 2.11.8

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11681#issuecomment-204204937 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-3724][ML] RandomForest: More options fo...

2016-03-31 Thread yongtang
Github user yongtang commented on the pull request: https://github.com/apache/spark/pull/11989#issuecomment-204204858 Hi @sethah by the way, could you help start a Jenkins test if possible? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-13825][CORE] Upgrade to Scala 2.11.8

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11681#issuecomment-204204607 **[Test build #54679 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54679/consoleFull)** for PR 11681 at commit [`3e3356c`](https://g

[GitHub] spark pull request: [SPARK-3724][ML] RandomForest: More options fo...

2016-03-31 Thread yongtang
Github user yongtang commented on the pull request: https://github.com/apache/spark/pull/11989#issuecomment-204204359 Hi @sethah thanks for the review. There are some issues with the regex but managed to get it done. The test also has been moved to ML. Let me know if there are any ot

[GitHub] spark pull request: [SPARK-14137] [SQL] Cleanup hash join

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12102#issuecomment-204204056 **[Test build #54683 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54683/consoleFull)** for PR 12102 at commit [`37724be`](https://gi

[GitHub] spark pull request: [SPARK-14123][SQL] Implement function related ...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12036#issuecomment-204204179 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14123][SQL] Implement function related ...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12036#issuecomment-204204182 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14123][SQL] Implement function related ...

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12036#issuecomment-204203643 **[Test build #54680 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54680/consoleFull)** for PR 12036 at commit [`05709f0`](https://g

[GitHub] spark pull request: SPARK-14113. Consider marking JobConf closure-...

2016-03-31 Thread rajeshbalamohan
Github user rajeshbalamohan commented on the pull request: https://github.com/apache/spark/pull/11978#issuecomment-204200260 Thanks @andrewor14 . Addressed your review comments in latest commit. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: [SPARK-529] [sql] Modify SQLConf to use new co...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11570#issuecomment-204199961 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-529] [sql] Modify SQLConf to use new co...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11570#issuecomment-204199960 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14242][CORE][Network] avoid copy in com...

2016-03-31 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/12038#issuecomment-204199865 @zsxwing , I updated the commit description. Thank you @zsxwing and @vanzin for reviewing. --- If your project is set up for it, you can reply to this email an

[GitHub] spark pull request: [SPARK-529] [sql] Modify SQLConf to use new co...

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11570#issuecomment-204199841 **[Test build #54675 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54675/consoleFull)** for PR 11570 at commit [`de594b6`](https://g

[GitHub] spark pull request: [SPARK-14224] [SPARK-14223] [SQL] fix RowEncod...

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12047#issuecomment-204197995 **[Test build #2720 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2720/consoleFull)** for PR 12047 at commit [`872ecf5`](https://

[GitHub] spark pull request: Backport [SPARK-11327] [MESOS] Dispatcher does...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12101#issuecomment-204197800 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: Backport [SPARK-11327] [MESOS] Dispatcher does...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12101#issuecomment-204197799 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: Backport [SPARK-11327] [MESOS] Dispatcher does...

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12101#issuecomment-204197711 **[Test build #54672 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54672/consoleFull)** for PR 12101 at commit [`8cd2a24`](https://g

[GitHub] spark pull request: [SPARK-14323] [SQL] fix the show functions by ...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12104#issuecomment-204197089 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-14323] [SQL] fix the show functions by ...

2016-03-31 Thread bomeng
GitHub user bomeng opened a pull request: https://github.com/apache/spark/pull/12104 [SPARK-14323] [SQL] fix the show functions by using catalog listFunctions ## What changes were proposed in this pull request? The syntax of "SHOW FUNCTIONS" can be found here: [https://

[GitHub] spark pull request: [SPARK-14294] [SQL] native support alter table...

2016-03-31 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12086#issuecomment-204194142 Thanks @bomeng, I will post the PR shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-11262][ML] Unit test for gradient, loss...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9229#issuecomment-204193466 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5

[GitHub] spark pull request: [SPARK-13992] Add support for off-heap caching

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-204193556 **[Test build #54682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54682/consoleFull)** for PR 11805 at commit [`a604078`](https://gi

[GitHub] spark pull request: [SPARK-11262][ML] Unit test for gradient, loss...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9229#issuecomment-204193464 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-03-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12099#issuecomment-204193533 Hi, @rxin . Could you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14320][SQL] Make ColumnarBatch.Row muta...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12103#issuecomment-204193375 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14320][SQL] Make ColumnarBatch.Row muta...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12103#issuecomment-204193378 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-11262][ML] Unit test for gradient, loss...

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9229#issuecomment-204193319 **[Test build #54671 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54671/consoleFull)** for PR 9229 at commit [`94dcec0`](https://git

[GitHub] spark pull request: [SPARK-14320][SQL] Make ColumnarBatch.Row muta...

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12103#issuecomment-204193208 **[Test build #54676 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54676/consoleFull)** for PR 12103 at commit [`a1fe9f8`](https://g

[GitHub] spark pull request: [SPARK-13992] Add support for off-heap caching

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-204192959 **[Test build #54681 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54681/consoleFull)** for PR 11805 at commit [`fde020f`](https://gi

[GitHub] spark pull request: [SPARK-13992] Add support for off-heap caching

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-204192677 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13992] Add support for off-heap caching

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-204192674 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13992] Add support for off-heap caching

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-204192578 **[Test build #54678 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54678/consoleFull)** for PR 11805 at commit [`61920a9`](https://g

[GitHub] spark pull request: [SPARK-14251][SQL] Add SQL command for printin...

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12099#issuecomment-204191621 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

  1   2   3   4   5   6   7   8   >