Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12318#discussion_r59328586
--- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala ---
@@ -155,6 +156,7 @@ private[spark] class HttpServer(
throw new ServerStateExceptio
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12318#discussion_r59328490
--- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala ---
@@ -155,6 +156,7 @@ private[spark] class HttpServer(
throw new ServerStateExceptio
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/11301#issuecomment-208738779
@sarutak, for 4), I made `TreeNode` serializable. However, I found six
errors in
[#55576](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55576/console
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12224#issuecomment-208736955
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12224#issuecomment-208736937
**[Test build #55593 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55593/consoleFull)**
for PR 12224 at commit
[`e223b22`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12224#issuecomment-208736949
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12224#issuecomment-208735924
**[Test build #55593 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55593/consoleFull)**
for PR 12224 at commit
[`e223b22`](https://gi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r59327943
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -74,9 +75,18 @@ private[sql] class HiveSessionCatalog(
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/12285#discussion_r59327396
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -69,7 +72,11 @@ public int numRecords() {
return pos
Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/11601#issuecomment-208732599
@MLnick @jkbradley updates:
1. limit the input type to numeric only.
2. support imputing for null, with ut.
3. use approxQuantile for median.
---
If your pro
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11601#issuecomment-208731746
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11601#issuecomment-208731747
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11601#issuecomment-208731666
**[Test build #55591 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55591/consoleFull)**
for PR 11601 at commit
[`fdd6f94`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12320#issuecomment-208728557
**[Test build #55592 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55592/consoleFull)**
for PR 12320 at commit
[`da63975`](https://gi
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/spark/pull/12318#discussion_r59326211
--- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala ---
@@ -155,6 +156,7 @@ private[spark] class HttpServer(
throw new ServerStateExcept
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-208727358
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-208727350
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-208727165
**[Test build #55588 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55588/consoleFull)**
for PR 12081 at commit
[`592ba1c`](https://g
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12285#discussion_r59325768
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -69,7 +72,11 @@ public int numRecords() {
return pos;
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12161#discussion_r59325685
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ColumnarAggMapCodeGenerator.scala
---
@@ -0,0 +1,193 @@
+/*
+ * Licensed to
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12318#discussion_r59325455
--- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala ---
@@ -155,6 +156,7 @@ private[spark] class HttpServer(
throw new ServerStateExceptio
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12319#issuecomment-208725255
cc @liancheng for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user devaraj-kavali commented on the pull request:
https://github.com/apache/spark/pull/12031#issuecomment-208725033
@andrewor14, Can you have a look into this when you find some time? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12319#discussion_r59325255
--- Diff:
sql/core/src/main/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordReader.java ---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foun
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12319#issuecomment-208724505
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/12285#discussion_r59325160
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -69,7 +72,11 @@ public int numRecords() {
return pos
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12314#issuecomment-208724448
@bomeng this no longer merges cleanly. Can you rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12318#discussion_r59325045
--- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala ---
@@ -155,6 +156,7 @@ private[spark] class HttpServer(
throw new ServerStateExceptio
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12318#discussion_r59324981
--- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala ---
@@ -155,6 +158,7 @@ private[spark] class HttpServer(
throw new ServerStateExceptio
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12311#issuecomment-208723841
**[Test build #2778 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2778/consoleFull)**
for PR 12311 at commit
[`b25701f`](https://g
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/12285#discussion_r59324765
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -69,7 +72,11 @@ public int numRecords() {
return pos
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/12285#discussion_r59324780
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java ---
@@ -255,6 +253,10 @@ public long spill(long size, MemoryConsumer
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12311#issuecomment-208723430
**[Test build #2776 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2776/consoleFull)**
for PR 12311 at commit
[`b25701f`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12315#issuecomment-208722482
**[Test build #2775 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2775/consoleFull)**
for PR 12315 at commit
[`70b5e82`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11601#issuecomment-208722190
**[Test build #55591 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55591/consoleFull)**
for PR 11601 at commit
[`fdd6f94`](https://gi
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12322
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12300#issuecomment-208720757
Thanks. Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12322#issuecomment-208720658
Thanks. Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12246#issuecomment-208720591
**[Test build #55590 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55590/consoleFull)**
for PR 12246 at commit
[`6aa5554`](https://gi
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12285#discussion_r59324092
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -69,7 +72,11 @@ public int numRecords() {
return pos;
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/12316#discussion_r59323956
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -1432,4 +1432,15 @@ class DataFrameSuite extends QueryTest with
SharedSQL
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12285#discussion_r59323954
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java ---
@@ -255,6 +253,10 @@ public long spill(long size, MemoryConsumer tri
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12285#discussion_r59323906
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -69,7 +72,11 @@ public int numRecords() {
return pos;
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12285#discussion_r59323828
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -69,7 +72,11 @@ public int numRecords() {
return pos;
Github user chtyim commented on the pull request:
https://github.com/apache/spark/pull/12318#issuecomment-208718393
Addressed comment. Please have a look again. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12285#issuecomment-208718277
That make sense, thanks for the explanation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12285#issuecomment-208718272
**[Test build #2777 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2777/consoleFull)**
for PR 12285 at commit
[`c318a35`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12322#issuecomment-208717963
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12322#issuecomment-208717961
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12322#issuecomment-208717794
**[Test build #55586 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55586/consoleFull)**
for PR 12322 at commit
[`4d63e15`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12300#issuecomment-208717455
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12300#issuecomment-208717457
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12300#issuecomment-208717307
**[Test build #55585 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55585/consoleFull)**
for PR 12300 at commit
[`ca2a94b`](https://g
Github user sitalkedia commented on the pull request:
https://github.com/apache/spark/pull/12285#issuecomment-208717200
@davies Thanks for the explanation, your calculation makes sense. You are
right that freeing the array can only make a difference of 15% in ideal case.
But what we a
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12300#issuecomment-208716501
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/11601#discussion_r59323059
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala ---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r59323049
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -74,9 +75,18 @@ private[sql] class HiveSessionCatalog(
// |
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/11601#discussion_r59323032
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala ---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12321
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12323#issuecomment-208715736
@srowen @zsxwing would you mind taking a look at this? Thanks! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12321#issuecomment-208715496
LGTM. Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12322#issuecomment-208712945
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12322#issuecomment-208712946
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12322#issuecomment-208712642
**[Test build #55584 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55584/consoleFull)**
for PR 12322 at commit
[`0ad1194`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12323#issuecomment-208712262
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12317#issuecomment-208712225
**[Test build #55589 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55589/consoleFull)**
for PR 12317 at commit
[`f9473f5`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12323#issuecomment-208712263
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12323#issuecomment-208712096
**[Test build #55583 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55583/consoleFull)**
for PR 12323 at commit
[`bdc0260`](https://g
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12285#issuecomment-208710183
In your case, inside sorting, the key has 4 columns, the row has 6 columns,
so each pair will need about 90 bytes, the array used by sort needs 16 bytes,
so the memory u
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12321#issuecomment-208710078
cc @andrewor14 @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12173#issuecomment-208709983
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12173#issuecomment-208709982
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12173#issuecomment-208709842
**[Test build #55582 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55582/consoleFull)**
for PR 12173 at commit
[`b8dd628`](https://g
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12322#issuecomment-208706693
ok updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12321#issuecomment-208704967
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12321#issuecomment-208704966
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12321#issuecomment-208704828
**[Test build #55578 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55578/consoleFull)**
for PR 12321 at commit
[`e0ca231`](https://g
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/spark/pull/12318#discussion_r59320494
--- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala ---
@@ -155,6 +158,7 @@ private[spark] class HttpServer(
throw new ServerStateExcept
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12314#issuecomment-208703324
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12314#issuecomment-208703320
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-208703105
**[Test build #55588 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55588/consoleFull)**
for PR 12081 at commit
[`592ba1c`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12314#issuecomment-208703085
**[Test build #55577 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55577/consoleFull)**
for PR 12314 at commit
[`b12229f`](https://g
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12322#issuecomment-208703073
LGTM, could you update the description?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user sitalkedia commented on the pull request:
https://github.com/apache/spark/pull/12285#issuecomment-208702898
@davies - Thanks for looking into it. I agree with you that its not a
memory leak because that memory may be used later. However, not reducing the
pointer array size
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208700359
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208700356
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208700160
**[Test build #55587 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55587/consoleFull)**
for PR 12079 at commit
[`9c2b4ab`](https://g
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r59319679
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -74,9 +75,18 @@ private[sql] class HiveSessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r59319585
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -121,8 +123,13 @@ class SessionCatalog(
Github user yongtang commented on the pull request:
https://github.com/apache/spark/pull/12305#issuecomment-208698736
Thanks @srowen. It looks like my previous understanding of the issue might
be incorrect. Let me take a detailed look and see if I could update this pull
request.
---
Github user yongtang commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208697614
@holdenk The Scala implementation has ben completed in SPARK-13963. I
updated the description of this pull request to show the linkage between this
issue (SPARK-14238)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r59319388
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -74,9 +75,18 @@ private[sql] class HiveSessionCatalog(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12322#issuecomment-208696633
**[Test build #55586 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55586/consoleFull)**
for PR 12322 at commit
[`4d63e15`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12079#issuecomment-208696634
**[Test build #55587 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55587/consoleFull)**
for PR 12079 at commit
[`9c2b4ab`](https://gi
Github user yongtang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r59319063
--- Diff: python/pyspark/mllib/feature.py ---
@@ -379,6 +379,17 @@ class HashingTF(object):
"""
def __init__(self, numFeatures=1 << 20):
Github user yongtang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12079#discussion_r59318934
--- Diff: python/pyspark/ml/feature.py ---
@@ -512,14 +512,19 @@ class HashingTF(JavaTransformer, HasInputCol,
HasOutputCol, HasNumFeatures, Java
.
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r59318684
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -74,9 +75,18 @@ private[sql] class HiveSessionCatalog(
// |
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12311#issuecomment-208695373
**[Test build #2776 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2776/consoleFull)**
for PR 12311 at commit
[`b25701f`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12300#issuecomment-208694952
**[Test build #55585 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55585/consoleFull)**
for PR 12300 at commit
[`ca2a94b`](https://gi
1 - 100 of 702 matches
Mail list logo
