[GitHub] spark issue #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When LIMIT/TA...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14034 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When LIMIT/TA...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14034 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62073/ Test FAILed. ---

[GitHub] spark issue #14131: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14131 **[Test build #62076 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62076/consoleFull)** for PR 14131 at commit

[GitHub] spark issue #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When LIMIT/TA...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14034 **[Test build #62073 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62073/consoleFull)** for PR 14034 at commit

[GitHub] spark pull request #14114: [SPARK-16458][SQL] SessionCatalog should support ...

2016-07-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14114#discussion_r70204413 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -246,9 +246,27 @@ class SessionCatalog(

[GitHub] spark issue #14131: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/14131 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #14114: [SPARK-16458][SQL] SessionCatalog should support ...

2016-07-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14114#discussion_r70204393 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -425,10 +443,11 @@ class SessionCatalog(

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 Here it is for branch-2.0. https://github.com/apache/spark/pull/14131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #14131: [SPARK-16318][SQL] Implement all remaining xpath ...

2016-07-10 Thread petermaxlee
GitHub user petermaxlee opened a pull request: https://github.com/apache/spark/pull/14131 [SPARK-16318][SQL] Implement all remaining xpath functions (branch-2.0) ## What changes were proposed in this pull request? This patch implements all remaining xpath functions that Hive

[GitHub] spark issue #14112: [SPARK-16240][ML] Model loading backward compatibility f...

2016-07-10 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/14112 @hhbyyh I think offline test should be OK for now, since we don't have unified save/load compatibility test framework until now. It's better we can get this feature in the next RC. --- If your

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70204050 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Reflect.scala --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 @cloud-fan thanks for merging! @yhuai I think the degree to which we want to add more tests also depend on how much we trust the library we are using. XPath (with Query) is almost as

[GitHub] spark pull request #13991: [SPARK-16318][SQL] Implement all remaining xpath ...

2016-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13991 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13991 Thanks, merging to master! This doesn't merge clearly to 2.0, @petermaxlee can you submit a new PR against 2.0? thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13969 You can also remove half of the test cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13969 One thing ... it might be better to remove the ability to call non-static methods. At least to me it'd make the things slightly simpler and more clear. --- If your project is set up for it, you can

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/13991 OK. Thanks. Then, it will be good to add more tests for cases that are not covered by those hive tests. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #11317: [SPARK-12639] [SQL] Mark Filters Fully Handled By Source...

2016-07-10 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/11317 tes this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 BTW I have to say Hive's test coverage in this area is very spotty, so I don't actually think it's great to follow, but I used those. --- If your project is set up for it, you can reply to

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 Actually I created the unit tests based on those. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #14114: [SPARK-16458][SQL] SessionCatalog should support ...

2016-07-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14114#discussion_r70203557 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -246,9 +246,27 @@ class SessionCatalog( def

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/13991 As a follow-up task. Can you take a look at the following query files and add useful tests in your test? Thanks. ```

[GitHub] spark pull request #14114: [SPARK-16458][SQL] SessionCatalog should support ...

2016-07-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14114#discussion_r70203553 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -425,10 +443,11 @@ class SessionCatalog( def

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70203510 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Reflect.scala --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] spark issue #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13969 what's hive's behaviour if calling a non-static method but the class doesn't have no-arg constructor? null or exception? --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #12414: [SPARK-14657] [ML] RFormula w/o intercept should output ...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12414 **[Test build #62074 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62074/consoleFull)** for PR 12414 at commit

[GitHub] spark issue #14120: [SPARK-16199][SQL] Add a method to list the referenced c...

2016-07-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14120 This can be updated once #14130 is merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70203430 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MiscFunctionsSuite.scala --- @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #12414: [SPARK-14657] [ML] RFormula w/o intercept should output ...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12414 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62074/ Test FAILed. ---

[GitHub] spark issue #12414: [SPARK-14657] [ML] RFormula w/o intercept should output ...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12414 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14130: [SPARK-16477] Bump master version to 2.1.0-SNAPSHOT

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14130 **[Test build #62075 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62075/consoleFull)** for PR 14130 at commit

[GitHub] spark pull request #14130: [SPARK-16477] Bump master version to 2.1.0-SNAPSH...

2016-07-10 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/14130 [SPARK-16477] Bump master version to 2.1.0-SNAPSHOT ## What changes were proposed in this pull request? After SPARK-16476, we can finally bump the version number. ## How was this patch

[GitHub] spark issue #14130: [SPARK-16477] Bump master version to 2.1.0-SNAPSHOT

2016-07-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14130 cc @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70202991 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MiscFunctionsSuite.scala --- @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #12414: [SPARK-14657] [ML] RFormula w/o intercept should output ...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12414 **[Test build #62074 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62074/consoleFull)** for PR 12414 at commit

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70202906 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MiscFunctionsSuite.scala --- @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #13704: [SPARK-15985][SQL] Reduce runtime overhead of a program ...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13704 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62071/ Test PASSed. ---

[GitHub] spark issue #13704: [SPARK-15985][SQL] Reduce runtime overhead of a program ...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13704 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13704: [SPARK-15985][SQL] Reduce runtime overhead of a program ...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13704 **[Test build #62071 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62071/consoleFull)** for PR 13704 at commit

[GitHub] spark pull request #14090: [SPARK-16112][SparkR] Programming guide for gappl...

2016-07-10 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/14090#discussion_r70202736 --- Diff: docs/sparkr.md --- @@ -306,6 +306,64 @@ head(ldf, 3) {% endhighlight %} + Run a given function on a large dataset grouping

[GitHub] spark pull request #14128: [SPARK-16476] Restructure MimaExcludes for easier...

2016-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14128: [SPARK-16476] Restructure MimaExcludes for easier union ...

2016-07-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14128 I'm going to merge this since this is a simple formatting change. I will submit a patch that updates the pom files and show what this can do. --- If your project is set up for it, you can reply to

[GitHub] spark issue #14128: [SPARK-16476] Restructure MimaExcludes for easier union ...

2016-07-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14128 Merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70202613 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Reflect.scala --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62070/ Test PASSed. ---

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14090: [SPARK-16112][SparkR] Programming guide for gappl...

2016-07-10 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/14090#discussion_r70202560 --- Diff: docs/sparkr.md --- @@ -306,6 +306,64 @@ head(ldf, 3) {% endhighlight %} + Run a given function on a large dataset

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #62070 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62070/consoleFull)** for PR 13991 at commit

[GitHub] spark pull request #14090: [SPARK-16112][SparkR] Programming guide for gappl...

2016-07-10 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/14090#discussion_r70202321 --- Diff: docs/sparkr.md --- @@ -306,6 +306,64 @@ head(ldf, 3) {% endhighlight %} + Run a given function on a large dataset grouping

[GitHub] spark issue #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When LIMIT/TA...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14034 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62069/ Test PASSed. ---

[GitHub] spark issue #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When LIMIT/TA...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14034 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When LIMIT/TA...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14034 **[Test build #62069 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62069/consoleFull)** for PR 14034 at commit

[GitHub] spark pull request #14090: [SPARK-16112][SparkR] Programming guide for gappl...

2016-07-10 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/14090#discussion_r70202064 --- Diff: docs/sparkr.md --- @@ -306,6 +306,64 @@ head(ldf, 3) {% endhighlight %} + Run a given function on a large dataset

[GitHub] spark pull request #13704: [SPARK-15985][SQL] Reduce runtime overhead of a p...

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13704#discussion_r70202042 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2018,6 +2018,8 @@ class Analyzer(

[GitHub] spark issue #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When LIMIT/TA...

2016-07-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14034 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 I guess whatever generates that message is buggy? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When LIMIT/TA...

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14034 LGTM, pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70201874 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MiscFunctionsSuite.scala --- @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70201875 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Reflect.scala --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] spark issue #14123: [SPARK-16471] [SQL] Remove Hive-specific CreateHiveTable...

2016-07-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14123 @cloud-fan Yeah! Will be in [WIP] until https://github.com/apache/spark/pull/14071 is merged. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70201841 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Reflect.scala --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] spark issue #14123: [SPARK-16471] [SQL] Remove Hive-specific CreateHiveTable...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14123 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70201786 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Reflect.scala --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13991 The latest result is `This patch does not merge cleanly.`, I just wanna double check it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #14123: [SPARK-16471] [SQL] Remove Hive-specific CreateHiveTable...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14123 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62068/ Test PASSed. ---

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70201691 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MiscFunctionsSuite.scala --- @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #14123: [SPARK-16471] [SQL] Remove Hive-specific CreateHiveTable...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14123 **[Test build #62068 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62068/consoleFull)** for PR 14123 at commit

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70201642 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Reflect.scala --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70201559 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Reflect.scala --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70201417 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Reflect.scala --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 @cloud-fan Jenkins already ran twice successfully before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70200185 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Reflect.scala --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70200163 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Reflect.scala --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] spark issue #14081: [SPARK-16403][Examples] Cleanup to remove unused imports...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14081 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62072/ Test PASSed. ---

[GitHub] spark issue #14081: [SPARK-16403][Examples] Cleanup to remove unused imports...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14081 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When LIMIT/TA...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14034 **[Test build #62073 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62073/consoleFull)** for PR 14034 at commit

[GitHub] spark issue #14081: [SPARK-16403][Examples] Cleanup to remove unused imports...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14081 **[Test build #62072 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62072/consoleFull)** for PR 14081 at commit

[GitHub] spark pull request #13704: [SPARK-15985][SQL] Reduce runtime overhead of a p...

2016-07-10 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13704#discussion_r70199583 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2018,6 +2018,8 @@ class Analyzer(

[GitHub] spark issue #14081: [SPARK-16403][Examples] Cleanup to remove unused imports...

2016-07-10 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/14081 I realized that the "PipelineExample"s are included in the docs, while the "SimpleTextClassificationExample"s are not, so it might be better to keep those instead. I just changed the data and

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14114 Now, it's back for review again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70198925 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Reflect.scala --- @@ -0,0 +1,170 @@ +/* + * Licensed to the

[GitHub] spark issue #14081: [SPARK-16403][Examples] Cleanup to remove unused imports...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14081 **[Test build #62072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62072/consoleFull)** for PR 14081 at commit

[GitHub] spark pull request #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13969#discussion_r70198848 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Reflect.scala --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14114 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62067/ Test PASSed. ---

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14114 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14114: [SPARK-16458][SQL] SessionCatalog should support `listCo...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14114 **[Test build #62067 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62067/consoleFull)** for PR 14114 at commit

[GitHub] spark issue #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When LIMIT/TA...

2016-07-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14034 uh... Thanks! Let me do it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #14090: [SPARK-16112][SparkR] Programming guide for gappl...

2016-07-10 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/14090#discussion_r70198331 --- Diff: docs/sparkr.md --- @@ -306,6 +306,64 @@ head(ldf, 3) {% endhighlight %} + Run a given function on a large dataset grouping

[GitHub] spark issue #14124: [SPARK-16472][SQL] Inconsistent nullability in schema af...

2016-07-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14124 @viirya Thanks for your comment! Actually, that's I want to have some feedback for from @marmbrus . It seems forcing to a nullable schema all is already happening when you read/write

[GitHub] spark pull request #13778: [SPARK-16062][SPARK-15989][SQL] Fix two bugs of P...

2016-07-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13778#discussion_r70198204 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -346,14 +346,47 @@ case class

[GitHub] spark pull request #13248: [SPARK-15194] [ML] Add Python ML API for Multivar...

2016-07-10 Thread lins05
Github user lins05 commented on a diff in the pull request: https://github.com/apache/spark/pull/13248#discussion_r70198232 --- Diff: python/pyspark/ml/stat/distribution.py --- @@ -0,0 +1,267 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] spark pull request #14048: [SPARK-16370][SQL] Union queries should not be ex...

2016-07-10 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/14048 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...

2016-07-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14048 Hmm. Okay, I didn't prevent all. I see. I'll close. Thank you for decision, @cloud-fan . --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14048 ``` case Union(children) if children.forall(x => x.isInstanceOf[InsertIntoTable] || x.isInstanceOf[InsertIntoHadoopFsRelationCommand]) => ``` This doesn't indicate a muliti-insert

[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...

2016-07-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14048 Ah, I see. You mean Union of `INSERT INTO`s, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...

2016-07-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14048 This PR fixes that with minimal efforts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When LIMIT/TA...

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14034 you missed one comment : https://github.com/apache/spark/pull/14034/files#r70183958 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #13704: [SPARK-15985][SQL] Reduce runtime overhead of a program ...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13704 **[Test build #62071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62071/consoleFull)** for PR 13704 at commit

[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...

2016-07-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14048 Ur, what do you mean? > With your patch, we can still create union queries with side effect which will be executed eagerly. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #14048: [SPARK-16370][SQL] Union queries should not be executed ...

2016-07-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14048 The current one looks like this. ``` case Union(children) if children.forall(x => x.isInstanceOf[InsertIntoTable] || x.isInstanceOf[InsertIntoHadoopFsRelationCommand]) => ```

  1   2   3   4   >