[GitHub] spark issue #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashMapGener...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14174 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62497/ Test PASSed. ---

[GitHub] spark issue #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashMapGener...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14174 **[Test build #62497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62497/consoleFull)** for PR 14174 at commit

[GitHub] spark issue #14204: [SPARK-16520] [WEBUI] Link executors to corresponding wo...

2016-07-18 Thread nblintao
Github user nblintao commented on the issue: https://github.com/apache/spark/pull/14204 @ajbozarth Thanks for pointing out how to fix this. I'll try to fix it tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14132 First of all, I will update this right now. Second, 10+ rules mean? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14022 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62494/ Test PASSed. ---

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14022 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite to chec...

2016-07-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14235 Sure. I've been looking that. It's on my list. I'll make a JIRA issue and proceed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14022 **[Test build #62494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62494/consoleFull)** for PR 14022 at commit

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-18 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14132 Is there a better way to handle sql generation that's not adding 10+ rules? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-18 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14132 Can you update this now the sql generation pull request has been merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14252: [SPARK-16615][SQL] Expose sqlContext in SparkSession

2016-07-18 Thread marmbrus
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/14252 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite to chec...

2016-07-18 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14235 @dongjoon-hyun can you also look into having stable identifiers for gen_attr? Right now the golden files look really weird because gen_attr is used more than once. --- If your project is set up for

[GitHub] spark issue #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite to chec...

2016-07-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14235 Oh, thank you for merging, @rxin ! Also, thank you for review, @gatorsmile and @liancheng . --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashMapGener...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/14174 This looks pretty solid! I left some non-critical comments around readability and structuring. I'll take a pass on the test suites once those are addressed. --- If your project is set up

[GitHub] spark pull request #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite ...

2016-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14235 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71254476 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala --- @@ -0,0 +1,338 @@ +/* + *

[GitHub] spark pull request #14252: [SPARK-16615][SQL] Expose sqlContext in SparkSess...

2016-07-18 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14252#discussion_r71254442 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -115,9 +115,11 @@ class SparkSession private( /** * A

[GitHub] spark issue #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite to chec...

2016-07-18 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14235 Thanks - merging in master / 2.0. I'm also merging this in 2.0 since it is a test only change and will reduce merge conflicts. --- If your project is set up for it, you can reply to

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71254165 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71254034 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253992 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark pull request #12944: [SPARK-15074][Shuffle] Cache shuffle index file t...

2016-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/12944#discussion_r71254024 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleIndexRecord.java --- @@ -0,0 +1,39 @@ +/* + * Licensed

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253933 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253903 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253796 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark issue #14036: [SPARK-16323] [SQL] Add IntegerDivide to avoid unnecessa...

2016-07-18 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/14036 @techaddict Can you test the performance with and without your change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread ooq
Github user ooq commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253773 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + * Licensed to the

[GitHub] spark issue #14251: [SPARK-16602][SQL] `Nvl` function should support various...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14251 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62495/ Test FAILed. ---

[GitHub] spark issue #14251: [SPARK-16602][SQL] `Nvl` function should support various...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14251 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253765 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark issue #14251: [SPARK-16602][SQL] `Nvl` function should support various...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14251 **[Test build #62495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62495/consoleFull)** for PR 14251 at commit

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253615 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253373 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253434 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253283 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253225 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253164 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253124 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark pull request #12944: [SPARK-15074][Shuffle] Cache shuffle index file t...

2016-07-18 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/12944#discussion_r71253134 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleIndexCache.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] spark issue #13950: [SPARK-15487] [Web UI] Spark Master UI to reverse proxy ...

2016-07-18 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/13950 I'll try and take a look at this tomorrow --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71253029 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71252969 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark issue #13670: [SPARK-15951] Change Executors Page to use datatables to...

2016-07-18 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/13670 Sorry I couldn't get to this today, I'll do my best to take a look in the morning --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web UI's SQ...

2016-07-18 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/14158 I'll try to take a look at this tomorrow --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashM...

2016-07-18 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/14174#discussion_r71252862 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatch.java --- @@ -0,0 +1,322 @@ +/* + *

[GitHub] spark issue #14204: [SPARK-16520] [WEBUI] Link executors to corresponding wo...

2016-07-18 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/14204 I'll try to take a look at this tomorrow, but you're failing MiMa tests because you added a param to `ExecutorInfo` which is part of the developer api. You'll have to add an exclude to

[GitHub] spark pull request #12944: [SPARK-15074][Shuffle] Cache shuffle index file t...

2016-07-18 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/12944#discussion_r71251461 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleIndexCache.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] spark pull request #12944: [SPARK-15074][Shuffle] Cache shuffle index file t...

2016-07-18 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/12944#discussion_r71251332 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleIndexInformation.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to

[GitHub] spark pull request #12944: [SPARK-15074][Shuffle] Cache shuffle index file t...

2016-07-18 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/12944#discussion_r71251280 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleIndexCache.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] spark pull request #12944: [SPARK-15074][Shuffle] Cache shuffle index file t...

2016-07-18 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/12944#discussion_r71251245 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java --- @@ -66,6 +67,16 @@

[GitHub] spark pull request #12944: [SPARK-15074][Shuffle] Cache shuffle index file t...

2016-07-18 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/12944#discussion_r71251177 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleIndexRecord.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to the

[GitHub] spark pull request #12944: [SPARK-15074][Shuffle] Cache shuffle index file t...

2016-07-18 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/12944#discussion_r71251123 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleIndexInformation.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to

[GitHub] spark issue #14251: [SPARK-16602][SQL] `Nvl` function should support various...

2016-07-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14251 Ah. I see. I missed that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14132 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62491/ Test PASSed. ---

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14132 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14132 **[Test build #62491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62491/consoleFull)** for PR 14132 at commit

[GitHub] spark issue #14251: [SPARK-16602][SQL] `Nvl` function should support various...

2016-07-18 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14251 @dongjoon-hyun again we cannot change the type checking for coalesce. Let's not confuse analyzer level type coercion with type checking in expressions for resolution. --- If your project is set up

[GitHub] spark issue #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite to chec...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14235 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite to chec...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14235 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62493/ Test PASSed. ---

[GitHub] spark issue #13986: [SPARK-16617] Upgrade to Avro 1.8.1

2016-07-18 Thread benmccann
Github user benmccann commented on the issue: https://github.com/apache/spark/pull/13986 >At least run the script that updates the deps/ files to see that impact Can you point me to the script you're referring to? > Figure out what the upside is in updating to 1.8

[GitHub] spark issue #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite to chec...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14235 **[Test build #62493 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62493/consoleFull)** for PR 14235 at commit

[GitHub] spark pull request #14251: [SPARK-16602][SQL] `Nvl` function should support ...

2016-07-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14251#discussion_r71247244 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2965,4 +2965,19 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #14250: [SPARKR][DOCS] minor code sample update in R prog...

2016-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14250 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14251: [SPARK-16602][SQL] `Nvl` function should support various...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14251 **[Test build #62499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62499/consoleFull)** for PR 14251 at commit

[GitHub] spark issue #14250: [SPARKR][DOCS] minor code sample update in R programming...

2016-07-18 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14250 LGTM. Merging this to master, branch-2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashMapGener...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14174 **[Test build #62498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62498/consoleFull)** for PR 14174 at commit

[GitHub] spark issue #14251: [SPARK-16602][SQL] `Nvl` function should support various...

2016-07-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14251 Yep. Thank you for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #14252: [SPARK-16615][SQL] Expose sqlContext in SparkSess...

2016-07-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14252#discussion_r71243812 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -115,9 +115,11 @@ class SparkSession private( /**

[GitHub] spark issue #14251: [SPARK-16602][SQL] `Nvl` function should support various...

2016-07-18 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14251 We need that checking. Coalesce supports multiple types because in the analyzer (TypeCoercion) we explicitly coerce the types. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #14251: [SPARK-16602][SQL] `Nvl` function should support various...

2016-07-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14251 Basically, `Coalesce` also should accept various types. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14251: [SPARK-16602][SQL] `Nvl` function should support various...

2016-07-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14251 I'll check them more. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14251: [SPARK-16602][SQL] `Nvl` function should support various...

2016-07-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14251 I think so since NullFunctionSuite is passed. If there is side-effect, I will handle them too. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14022 **[Test build #62489 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62489/consoleFull)** for PR 14022 at commit

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14022 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14174: [SPARK-16524][SQL] Add RowBatch and RowBasedHashMapGener...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14174 **[Test build #62497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62497/consoleFull)** for PR 14174 at commit

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14022 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62489/ Test FAILed. ---

[GitHub] spark issue #14252: [SPARK-16615][SQL] Expose sqlContext in SparkSession

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14252 **[Test build #62496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62496/consoleFull)** for PR 14252 at commit

[GitHub] spark issue #14251: [SPARK-16602][SQL] `Nvl` function should support various...

2016-07-18 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14251 Doesn't this break coalesce's type checking? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14252: [SPARK-16615][SQL] Expose sqlContext in SparkSess...

2016-07-18 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/14252 [SPARK-16615][SQL] Expose sqlContext in SparkSession ## What changes were proposed in this pull request? This patch removes the private[spark] qualifier for SparkSession.sqlContext, as discussed

[GitHub] spark issue #14251: [SPARK-16602][SQL] Coalesce should support various types...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14251 **[Test build #62495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62495/consoleFull)** for PR 14251 at commit

[GitHub] spark pull request #14251: [SPARK-16602][SQL] Coalesce should support variou...

2016-07-18 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/14251 [SPARK-16602][SQL] Coalesce should support various types. ## What changes were proposed in this pull request? ``` sql("select nvl('0', '1'), nvl('0', 1)") ``` ## How

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14022 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14022 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62488/ Test FAILed. ---

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14022 **[Test build #62488 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62488/consoleFull)** for PR 14022 at commit

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14022 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62485/ Test PASSed. ---

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14022 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14022 **[Test build #62485 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62485/consoleFull)** for PR 14022 at commit

[GitHub] spark issue #14022: [SPARK-16272][core] Allow config values to reference con...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14022 **[Test build #62494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62494/consoleFull)** for PR 14022 at commit

[GitHub] spark issue #14250: [SPARKR][DOCS] minor code sample update in R programming...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14250 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62492/ Test PASSed. ---

[GitHub] spark issue #14250: [SPARKR][DOCS] minor code sample update in R programming...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14250 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14250: [SPARKR][DOCS] minor code sample update in R programming...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14250 **[Test build #62492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62492/consoleFull)** for PR 14250 at commit

[GitHub] spark issue #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite to chec...

2016-07-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14235 Jenkins is restarted, but the current last commit is efaa4d0 having the passed Jenkins test. Could you review and merge this first if possible, @rxin ? ``` Test build #62469 has

[GitHub] spark issue #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite to chec...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14235 **[Test build #62493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62493/consoleFull)** for PR 14235 at commit

[GitHub] spark issue #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite to chec...

2016-07-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14235 Hmm, HiveCompatibilitySuite has some dependency on `gen_attr_`. I reverted the last attempt. I will try as another PR as planed before. --- If your project is set up for it, you can

[GitHub] spark issue #14225: [WIP][SPARK-16334] Maintain single dictionary per row-ba...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14225 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14225: [WIP][SPARK-16334] Maintain single dictionary per row-ba...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14225 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62484/ Test PASSed. ---

[GitHub] spark issue #14225: [WIP][SPARK-16334] Maintain single dictionary per row-ba...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14225 **[Test build #62484 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62484/consoleFull)** for PR 14225 at commit

[GitHub] spark issue #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite to chec...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14235 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite to chec...

2016-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14235 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62487/ Test FAILed. ---

[GitHub] spark issue #14235: [SPARK-16590][SQL] Improve LogicalPlanToSQLSuite to chec...

2016-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14235 **[Test build #62487 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62487/consoleFull)** for PR 14235 at commit

<    1   2   3   4   5   6   >