Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14308
It's probably OK on the whole, improving or standardizing examples
slightly. I left a number of small questions. Some of the changes didn't feel
quite worth making but maybe I miss the logic.
---
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14308#discussion_r72778614
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaWord2VecExample.java ---
@@ -55,10 +56,14 @@ public static void main(String[] args) {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14308#discussion_r72778582
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaTokenizerExample.java
---
@@ -23,17 +23,23 @@
import java.util.Arrays;
import
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14308#discussion_r72778529
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaPolynomialExpansionExample.java
---
@@ -48,23 +48,19 @@ public static void main(String[]
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14308#discussion_r72778518
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaOneVsRestExample.java
---
@@ -75,7 +75,7 @@ public static void main(String[] args) {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14308#discussion_r72778479
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaNGramExample.java ---
@@ -55,16 +55,12 @@ public static void main(String[] args) {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14308#discussion_r72778384
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaMaxAbsScalerExample.java
---
@@ -34,10 +44,17 @@ public static void main(String[] args) {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14308#discussion_r72778289
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaGaussianMixtureExample.java
---
@@ -54,6 +54,7 @@ public static void main(String[] args) {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14308#discussion_r72778075
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaIsotonicRegressionExample.java
---
@@ -50,8 +50,8 @@ public static void main(String[]
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14324
Merged to master/2.0/1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14324
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14332
**[Test build #63003 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63003/consoleFull)**
for PR 14332 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14332
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14333
If the last problem is really pretty related to this code, then it should
change here as well. However if you're not sure there's an easy fix, we can
leave it for later. Are you comfortable that the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14389#discussion_r72773724
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -99,45 +99,13 @@ object TypeCoercion {
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14400
Good catch!
LGTM except the style comment given by @ueshin . And please also use full
word for variable name, e.g. `originalSchema`, `targetSchema`
---
If your project is set up for it,
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/13334
@andrewor14 ping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14401
**[Test build #63002 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63002/consoleFull)**
for PR 14401 at commit
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/14401
[SPARK-16793][SQL]Set the temporary warehouse path to sc'conf in TestHive.
## What changes were proposed in this pull request?
With SPARK-15034, we could use the value of
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14400#discussion_r72770823
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -727,6 +727,19 @@ class CastSuite extends
Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/14400#discussion_r72769633
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -727,6 +727,19 @@ class CastSuite extends
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/14308
@BryanCutler yeah if there are some changes that are more bug-fixes to make
the examples work, let's separate those out into a new JIRA & PR. That should
be a little higher priority for `2.0.1`
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14389
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63001/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14389
**[Test build #63001 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63001/consoleFull)**
for PR 14389 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14389
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zzcclp commented on the issue:
https://github.com/apache/spark/pull/12000
Hi, @srowen @JoshRosen @mchalek , this issue still exists on
branch-2.0/master, if I add "driver=com.mysql.jdbc.Driver" property to
write.jdbc's properties params, it was ok, otherwise failed.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14389
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63000/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14389
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14389
**[Test build #63000 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63000/consoleFull)**
for PR 14389 at commit
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14400#discussion_r72764975
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -727,6 +727,19 @@ class CastSuite extends
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/14400
Good catch!
I have some comments, please check them.
/cc @marmbrus @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14400#discussion_r72764850
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -416,7 +416,7 @@ case class Cast(child: Expression,
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14400#discussion_r72764866
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -727,6 +727,19 @@ class CastSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14400#discussion_r72764858
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -727,6 +727,19 @@ class CastSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14400#discussion_r72764872
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -727,6 +727,19 @@ class CastSuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14399
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62998/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14399
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14389
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14399
**[Test build #62998 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62998/consoleFull)**
for PR 14399 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14389
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62999/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14389
**[Test build #62999 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62999/consoleFull)**
for PR 14389 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14389
Have you read this comment?
>We are discussing this internally, can you hold it for a while? We may
decide to increase the max precision to 76 and keep max scale as 38, then we
don't
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/14400
@ueshin , you seem to be the original committer of this code. can you
please have a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user petermaxlee commented on the issue:
https://github.com/apache/spark/pull/14389
@HyukjinKwon FWIW I don't think it makes sense to handle everything except
greatest/least. It also does not make sense to automatically coerce from
decimal to double type for these two
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14389#discussion_r72755300
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -99,45 +99,13 @@ object TypeCoercion {
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14389#discussion_r72755318
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -99,45 +99,13 @@ object TypeCoercion {
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14389#discussion_r72755309
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -99,45 +99,13 @@ object TypeCoercion {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14400
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user eyalfa opened a pull request:
https://github.com/apache/spark/pull/14400
[Spark-16791] [SQL] cast struct with timestamp field fails
## What changes were proposed in this pull request?
a failing test case + fix to SPARK-16791
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14389
**[Test build #63001 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63001/consoleFull)**
for PR 14389 at commit
Github user petermaxlee commented on the issue:
https://github.com/apache/spark/pull/14389
I've pushed a new change to make it consistent for all the instances that I
could find. I believe the new one has more consistent behavior across functions
and simpler to understand.
---
If
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14389
@petermaxlee At least for `least` and `greatest`, please refer
https://issues.apache.org/jira/browse/SPARK-16646. It seems we should hold it.
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14398
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14398
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62997/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14398
**[Test build #62997 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62997/consoleFull)**
for PR 14398 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14389
**[Test build #63000 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63000/consoleFull)**
for PR 14389 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14389
**[Test build #62999 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62999/consoleFull)**
for PR 14389 at commit
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r72752972
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/security/HDFSCredentialProvider.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14399
**[Test build #62998 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62998/consoleFull)**
for PR 14399 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14399
cc @holdenk and @liancheng
Thanks @holdenk, I was stupid and indeed, the alternative of `listType` is
not necessarily `listOfElements` but we can actually work around.
---
If your
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/14399
[SPARK-16777][SQL] Do not use deprecated listType API in
ParquetSchemaConverter
## What changes were proposed in this pull request?
This PR removes build waning as below.
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r72750534
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/security/HDFSCredentialProviderSuite.scala
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r72750018
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/security/CredentialUpdater.scala
---
@@ -107,8 +110,16 @@ private[spark] class
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14258
I see - since the local test uses the downloaded JARs, not the one built
from master source files, but the test code used is from master - this causes
the problem. I will first disable the tests
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r72749483
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/security/CredentialUpdater.scala
---
@@ -41,16 +43,18 @@ private[spark] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62995/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14397
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14397
**[Test build #62995 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62995/consoleFull)**
for PR 14397 at commit
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r72747890
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ConfigurableCredentialManager.scala
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14396
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14396
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62994/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14396
**[Test build #62994 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62994/consoleFull)**
for PR 14396 at commit
Github user wangmiao1981 commented on the issue:
https://github.com/apache/spark/pull/14182
@felixcheung @yanboliang @junyangq I have addressed all your comments.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/14398
cc @ckadner & @davies - still think the longterm solution is a larger
rewrite of this into a thin wrapper around something like JSR-310, but in the
meantime this should be some progress.
---
If
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14398
**[Test build #62997 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62997/consoleFull)**
for PR 14398 at commit
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/14398
[SPARK-16774][SQL] Fix use of deprecated timestamp constructor & improve
timezone handling
## What changes were proposed in this pull request?
Removes the deprecated timestamp constructor
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/14340
Thanks a lot @rxin for your comments, let me close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jerryshao closed the pull request at:
https://github.com/apache/spark/pull/14340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14241#discussion_r72745117
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -275,62 +272,161 @@ private[sql] case class RowDataSourceScanExec(
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14396
cc @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
301 - 380 of 380 matches
Mail list logo
