[GitHub] spark issue #14596: [SPARK-12370] [Documentation] [Documentation should link...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14596 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request #14596: [SPARK-12370] [Documentation] [Documentation shou...

2016-08-10 Thread jagadeesanas2
GitHub user jagadeesanas2 opened a pull request: https://github.com/apache/spark/pull/14596 [SPARK-12370] [Documentation] [Documentation should link to examples … ## What changes were proposed in this pull request? When documentation is built is should reference examples f

[GitHub] spark pull request #14594: [SPARK-17016][SQL] Improve group-by/order-by ordi...

2016-08-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14594#discussion_r74374927 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -547,8 +547,7 @@ class Analyzer( case a: Agg

[GitHub] spark pull request #14594: [SPARK-17016][SQL] Improve group-by/order-by ordi...

2016-08-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14594#discussion_r74374768 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -547,8 +547,7 @@ class Analyzer( case a: Agg

[GitHub] spark pull request #14102: [SPARK-16434][SQL] Avoid per-record type dispatch...

2016-08-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14102#discussion_r74374585 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala --- @@ -35,184 +34,289 @@ import org.apache.spark.

[GitHub] spark pull request #14102: [SPARK-16434][SQL] Avoid per-record type dispatch...

2016-08-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14102#discussion_r74374015 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala --- @@ -35,184 +34,289 @@ import org.apache.spark.ut

[GitHub] spark pull request #14102: [SPARK-16434][SQL] Avoid per-record type dispatch...

2016-08-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14102#discussion_r74373952 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala --- @@ -35,184 +34,289 @@ import org.apache.spark.ut

[GitHub] spark issue #14592: [SPARK-17011][SQL] Support testing exceptions in SQLQuer...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14592 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14592: [SPARK-17011][SQL] Support testing exceptions in SQLQuer...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14592 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63582/ Test PASSed. ---

[GitHub] spark pull request #14397: [SPARK-16771][SQL] WITH clause should not fall in...

2016-08-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14397#discussion_r74373762 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2938,4 +2938,26 @@ class SQLQuerySuite extends QueryTest with Share

[GitHub] spark pull request #14102: [SPARK-16434][SQL] Avoid per-record type dispatch...

2016-08-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14102#discussion_r74373725 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala --- @@ -35,184 +34,289 @@ import org.apache.spark.ut

[GitHub] spark issue #14592: [SPARK-17011][SQL] Support testing exceptions in SQLQuer...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14592 **[Test build #63582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63582/consoleFull)** for PR 14592 at commit [`76defce`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14397: [SPARK-16771][SQL] WITH clause should not fall in...

2016-08-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14397#discussion_r74373681 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2938,4 +2938,26 @@ class SQLQuerySuite extends QueryTest with Share

[GitHub] spark issue #14454: [Minor] [ML] Rename TreeEnsembleModels to TreeEnsembleMo...

2016-08-10 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/14454 I'm sort of neutral on the change - it's certainly unfortunate about the naming, but it's not such a big deal IMO. However, now that we're here I do agree that it should be "private" so ok to make th

[GitHub] spark issue #14595: [SPARK-17015][SQL] group-by/order-by ordinal and arithme...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14595 **[Test build #63591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63591/consoleFull)** for PR 14595 at commit [`3b9540c`](https://github.com/apache/spark/commit/3

[GitHub] spark pull request #14102: [SPARK-16434][SQL] Avoid per-record type dispatch...

2016-08-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14102#discussion_r74373524 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala --- @@ -35,184 +34,289 @@ import org.apache.spark.ut

[GitHub] spark pull request #14397: [SPARK-16771][SQL] WITH clause should not fall in...

2016-08-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14397#discussion_r74373465 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2938,4 +2938,26 @@ class SQLQuerySuite extends QueryTest with Share

[GitHub] spark issue #14594: [SPARK-17016][SQL] Improve group-by/order-by ordinal err...

2016-08-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/14594 Everything is tested here: https://github.com/apache/spark/pull/14595 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request #14595: [SPARK-17015][SQL] group-by/order-by ordinal and ...

2016-08-10 Thread petermaxlee
GitHub user petermaxlee opened a pull request: https://github.com/apache/spark/pull/14595 [SPARK-17015][SQL] group-by/order-by ordinal and arithmetic tests ## What changes were proposed in this pull request? This patch adds three test files: 1. arithmetic.sql.out 2. order

[GitHub] spark issue #14579: [SPARK-16921][PYSPARK] RDD/DataFrame persist()/cache() s...

2016-08-10 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/14579 After looking at it and considering all the above, I would say the options are (1) do nothing; or (2) if we want to support this use case, then we implement a single utility method (I would say calle

[GitHub] spark issue #14579: [SPARK-16921][PYSPARK] RDD/DataFrame persist()/cache() s...

2016-08-10 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/14579 @nchammas a utility method (e.g. `cached`) - actually it will be a context manager class implemented in the same way as `closing` - will work because it only needs to return the context manager, not

[GitHub] spark issue #13775: [SPARK-16060][SQL] Vectorized Orc reader

2016-08-10 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/13775 @yhuai I ran another benchmark for the scan operation. The results are updated in the pr description. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #14594: [SPARK-17016][SQL] Improve group-by/order-by ordi...

2016-08-10 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14594#discussion_r74373149 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -547,8 +547,7 @@ class Analyzer( case a: A

[GitHub] spark pull request #14592: [SPARK-17011][SQL] Support testing exceptions in ...

2016-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14592 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14546: [SPARK-16955][SQL] Using ordinals in ORDER BY and GROUP ...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14546 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63579/ Test PASSed. ---

[GitHub] spark pull request #14397: [SPARK-16771][SQL] WITH clause should not fall in...

2016-08-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14397#discussion_r74372952 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2938,4 +2938,26 @@ class SQLQuerySuite extends QueryTest with SharedSQLConte

[GitHub] spark issue #14546: [SPARK-16955][SQL] Using ordinals in ORDER BY and GROUP ...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14546 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14546: [SPARK-16955][SQL] Using ordinals in ORDER BY and GROUP ...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14546 **[Test build #63579 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63579/consoleFull)** for PR 14546 at commit [`32c639c`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14592: [SPARK-17011][SQL] Support testing exceptions in SQLQuer...

2016-08-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14592 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14592: [SPARK-17011][SQL] Support testing exceptions in SQLQuer...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14592 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14592: [SPARK-17011][SQL] Support testing exceptions in SQLQuer...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14592 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63580/ Test PASSed. ---

[GitHub] spark pull request #14102: [SPARK-16434][SQL] Avoid per-record type dispatch...

2016-08-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14102#discussion_r74372641 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala --- @@ -35,184 +34,289 @@ import org.apache.spark.

[GitHub] spark issue #14592: [SPARK-17011][SQL] Support testing exceptions in SQLQuer...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14592 **[Test build #63580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63580/consoleFull)** for PR 14592 at commit [`1a7cdc0`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14594: [SPARK-17016][SQL] Improve group-by/order-by ordinal err...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14594 **[Test build #63590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63590/consoleFull)** for PR 14594 at commit [`3e1b6b3`](https://github.com/apache/spark/commit/3

[GitHub] spark pull request #14594: [SPARK-17016][SQL] Improve group-by/order-by ordi...

2016-08-10 Thread petermaxlee
GitHub user petermaxlee opened a pull request: https://github.com/apache/spark/pull/14594 [SPARK-17016][SQL] Improve group-by/order-by ordinal error reporting ## What changes were proposed in this pull request? This patch improves error handling for group-by/order-by ordinals:

[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63578/ Test PASSed. ---

[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63577/ Test PASSed. ---

[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63578/consoleFull)** for PR 14397 at commit [`178813e`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63577 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63577/consoleFull)** for PR 14397 at commit [`624bb3d`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14583: [SPARK-16994][SQL] PushDownPredicate should not ignore l...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14583 **[Test build #63589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63589/consoleFull)** for PR 14583 at commit [`d23d348`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #14583: [SPARK-16994][SQL] PushDownPredicate should not ignore l...

2016-08-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14583 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #14102: [SPARK-16434][SQL] Avoid per-record type dispatch...

2016-08-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14102#discussion_r74372103 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala --- @@ -35,184 +34,289 @@ import org.apache.spark.

[GitHub] spark issue #14583: [SPARK-16994][SQL] PushDownPredicate should not ignore l...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14583 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14583: [SPARK-16994][SQL] PushDownPredicate should not ignore l...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14583 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63581/ Test FAILed. ---

[GitHub] spark issue #14583: [SPARK-16994][SQL] PushDownPredicate should not ignore l...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14583 **[Test build #63581 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63581/consoleFull)** for PR 14583 at commit [`d23d348`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14102: [SPARK-16434][SQL] Avoid per-record type dispatch...

2016-08-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14102#discussion_r74371723 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala --- @@ -35,184 +34,289 @@ import org.apache.spark.ut

[GitHub] spark issue #14579: [SPARK-16921][PYSPARK] RDD/DataFrame persist()/cache() s...

2016-08-10 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14579 Right I wouldn't expect it to error with subclassing - just not pipeline successfully - but only in a very long shot corner case. I think the try/finally with persistance is not an uncommon

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14580 Oracle supports it... http://docs.oracle.com/javadb/10.10.1.2/ref/rrefsqljusing.html --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark issue #12004: [SPARK-7481][build] [WIP] Add Hadoop 2.6+ spark-cloud mo...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12004 **[Test build #63588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63588/consoleFull)** for PR 12004 at commit [`cb07c1d`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #14590: [SPARK-17008][SPARK-17009][SQL] Normalization and isolat...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14590 **[Test build #3216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3216/consoleFull)** for PR 14590 at commit [`e061820`](https://github.com/apache/spark/commit

[GitHub] spark issue #14454: [Minor] [ML] Rename TreeEnsembleModels to TreeEnsembleMo...

2016-08-10 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/14454 ping @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63587 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63587/consoleFull)** for PR 14559 at commit [`57be055`](https://github.com/apache/spark/commit/5

[GitHub] spark pull request #14591: [SPARK-17010][MINOR][DOC]Wrong description in mem...

2016-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14591 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-10 Thread GraceH
Github user GraceH commented on the issue: https://github.com/apache/spark/pull/14559 @HyukjinKwon and @srowen, here is the initial proposal. Please let me know your comment. I will refine that with unit test later. BTW, the readwriter.py calls high level api of jdbc(url, tabl

[GitHub] spark issue #14592: [SPARK-17011][SQL] Support testing exceptions in SQLQuer...

2016-08-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14592 LGTM pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14591: [SPARK-17010][MINOR][DOC]Wrong description in memory man...

2016-08-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14591 Merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #14592: [SPARK-17011][SQL] Support testing exceptions in ...

2016-08-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14592#discussion_r74370013 --- Diff: sql/core/src/test/resources/sql-tests/results/number-format.sql.out --- @@ -19,16 +19,24 @@ struct<2147483648:bigint,(-2147483649):bigint>

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14580 Which NoSQL platforms support `Using Outer Join`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark issue #14593: [MINOR][DOCS] Fix style in examples and inconsistent ind...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14593 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14593: [MINOR][DOCS] Fix style in examples and inconsistent ind...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14593 **[Test build #63586 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63586/consoleFull)** for PR 14593 at commit [`e4a832e`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14593: [MINOR][DOCS] Fix style in examples and inconsistent ind...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14593 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63586/ Test PASSed. ---

[GitHub] spark issue #13775: [SPARK-16060][SQL] Vectorized Orc reader

2016-08-10 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/13775 @yhuai You mean just using `sql("SELECT * FROM t").count()`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request #13775: [SPARK-16060][SQL] Vectorized Orc reader

2016-08-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13775#discussion_r74369496 --- Diff: sql/hive/src/main/java/org/apache/hadoop/hive/ql/io/orc/VectorizedSparkOrcNewRecordReader.java --- @@ -0,0 +1,318 @@ +/* + * Licensed to th

[GitHub] spark pull request #14592: [SPARK-17011][SQL] Support testing exceptions in ...

2016-08-10 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14592#discussion_r74369492 --- Diff: sql/core/src/test/resources/sql-tests/results/number-format.sql.out --- @@ -19,16 +19,24 @@ struct<2147483648:bigint,(-2147483649):bigint>

[GitHub] spark pull request #14592: [SPARK-17011][SQL] Support testing exceptions in ...

2016-08-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14592#discussion_r74369336 --- Diff: sql/core/src/test/resources/sql-tests/results/number-format.sql.out --- @@ -19,16 +19,24 @@ struct<2147483648:bigint,(-2147483649):bigint>

[GitHub] spark pull request #14592: [SPARK-17011][SQL] Support testing exceptions in ...

2016-08-10 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14592#discussion_r74369163 --- Diff: sql/core/src/test/resources/sql-tests/results/number-format.sql.out --- @@ -19,16 +19,24 @@ struct<2147483648:bigint,(-2147483649):bigint>

[GitHub] spark issue #14593: [MINOR][DOCS] Fix style in examples and inconsistent ind...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14593 **[Test build #63586 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63586/consoleFull)** for PR 14593 at commit [`e4a832e`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #14593: [MINOR][DOCS] Fix style in examples and inconsistent ind...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14593 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63583/ Test PASSed. ---

[GitHub] spark issue #14593: [MINOR][DOCS] Fix style in examples and inconsistent ind...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14593 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #14592: [SPARK-17011][SQL] Support testing exceptions in ...

2016-08-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14592#discussion_r74369002 --- Diff: sql/core/src/test/resources/sql-tests/results/number-format.sql.out --- @@ -19,16 +19,24 @@ struct<2147483648:bigint,(-2147483649):bigint>

[GitHub] spark issue #14593: [MINOR][DOCS] Fix style in examples and inconsistent ind...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14593 **[Test build #63583 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63583/consoleFull)** for PR 14593 at commit [`3cff947`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14592: [SPARK-17011][SQL] Support testing exceptions in ...

2016-08-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14592#discussion_r74368974 --- Diff: sql/core/src/test/resources/sql-tests/results/number-format.sql.out --- @@ -19,16 +19,24 @@ struct<2147483648:bigint,(-2147483649):bigint>

[GitHub] spark issue #13775: [SPARK-16060][SQL] Vectorized Orc reader

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13775 **[Test build #63585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63585/consoleFull)** for PR 13775 at commit [`06066eb`](https://github.com/apache/spark/commit/0

[GitHub] spark pull request #13775: [SPARK-16060][SQL] Vectorized Orc reader

2016-08-10 Thread dafrista
Github user dafrista commented on a diff in the pull request: https://github.com/apache/spark/pull/13775#discussion_r74368871 --- Diff: sql/hive/src/main/java/org/apache/hadoop/hive/ql/io/orc/VectorizedSparkOrcNewRecordReader.java --- @@ -0,0 +1,318 @@ +/* + * Licensed to

[GitHub] spark issue #14592: [SPARK-17011][SQL] Support testing exceptions in SQLQuer...

2016-08-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14592 I'd like to do it incrementally, and ideally one SQL testing file(xxx.sql) one PR, but we can have many PRs at the same time, they are not likely to get conflicted. --- If your project is set up

[GitHub] spark pull request #14590: [SPARK-17008][SPARK-17009][SQL] Normalization and...

2016-08-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14590#discussion_r74368764 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -126,14 +129,18 @@ class SQLQueryTestSuite extends QueryTest with SharedS

[GitHub] spark pull request #14592: [SPARK-17011][SQL] Support testing exceptions in ...

2016-08-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14592#discussion_r74368708 --- Diff: sql/core/src/test/resources/sql-tests/results/number-format.sql.out --- @@ -19,16 +19,24 @@ struct<2147483648:bigint,(-2147483649):bigint>

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14580 **[Test build #63584 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63584/consoleFull)** for PR 14580 at commit [`ddb4ddd`](https://github.com/apache/spark/commit/d

[GitHub] spark pull request #14590: [SPARK-17008][SPARK-17009][SQL] Normalization and...

2016-08-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14590#discussion_r74368596 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -126,14 +129,18 @@ class SQLQueryTestSuite extends QueryTest with Sh

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14568 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63576/ Test FAILed. ---

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-10 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14580 I think we should think out of the SQL box. We know that Spark is not a subset of DBMS. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14568 **[Test build #63576 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63576/consoleFull)** for PR 14568 at commit [`b4d4ea6`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13775: [SPARK-16060][SQL] Vectorized Orc reader

2016-08-10 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/13775 for the benchmark, how about we just test the scan operation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark issue #14593: [MINOR][DOCS] Fix style in examples and inconsistent ind...

2016-08-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14593 Also just for reviewers, the inconsistent stuffs I listed in the PR description happen randomly across documentation. So, this fixes them to be consistent according to style guide lines and rese

[GitHub] spark issue #14593: [MINOR][DOCS] Fix style in examples and inconsistent ind...

2016-08-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14593 BTW, this is not fixing some wrong examples and inconsistent indentation codes in `structured-streaming-programming-guide.md` because https://github.com/apache/spark/pull/14564 is handling them.

[GitHub] spark issue #14593: [MINOR][DOCS] Fix style in examples and inconsistent ind...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14593 **[Test build #63583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63583/consoleFull)** for PR 14593 at commit [`3cff947`](https://github.com/apache/spark/commit/3

[GitHub] spark pull request #14593: [MINOR][DOCS] Fix style in examples and inconsist...

2016-08-10 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/14593 [MINOR][DOCS] Fix style in examples and inconsistent indentation across documentation ## What changes were proposed in this pull request? This PR fixes the documentation as below:

[GitHub] spark issue #14592: [SPARK-17011][SQL] Support testing exceptions in SQLQuer...

2016-08-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/14592 @cloud-fan after adding enough features to the test harness, do you think I should port all tests over in a single pull request, or more incremental? --- If your project is set up for it, you

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14580 Not sure which RDBMS are supporting `Using Outer Join`. `NULL` generated by outer joins are removed. This sounds a little bit strange. After all, `NULL` also has a meaning. In the plan

[GitHub] spark issue #14592: [SPARK-17011][SQL] Support testing exceptions in SQLQuer...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14592 **[Test build #63582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63582/consoleFull)** for PR 14592 at commit [`76defce`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #13775: [SPARK-16060][SQL] Vectorized Orc reader

2016-08-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13775#discussion_r74367827 --- Diff: sql/hive/src/main/java/org/apache/hadoop/hive/ql/io/orc/VectorizedSparkOrcNewRecordReader.java --- @@ -0,0 +1,318 @@ +/* + * Licensed to th

[GitHub] spark issue #14588: [SPARK-17005][SQL] fix method tpe in trait AnnotationApi...

2016-08-10 Thread keypointt
Github user keypointt commented on the issue: https://github.com/apache/spark/pull/14588 Oh I'm so sorry. It's breaking 2.10 anyway. I'll double check scala version compatibility next time submitting a PR --- If your project is set up for it, you can reply to this email and h

[GitHub] spark pull request #14588: [SPARK-17005][SQL] fix method tpe in trait Annota...

2016-08-10 Thread keypointt
Github user keypointt closed the pull request at: https://github.com/apache/spark/pull/14588 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14102 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63575/ Test PASSed. ---

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14102 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14102: [SPARK-16434][SQL] Avoid per-record type dispatch in JSO...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14102 **[Test build #63575 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63575/consoleFull)** for PR 14102 at commit [`bceda7b`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14589: [SPARK-17007][SQL] Move test data files into a te...

2016-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14589 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

  1   2   3   4   5   6   7   8   >