[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74869532 --- Diff: R/pkg/R/mllib.R --- @@ -605,6 +701,69 @@ setMethod("spark.survreg", signature(data = "SparkDataFrame", formula = "formula

[GitHub] spark issue #14506: [SPARK-16916][SQL] serde/storage properties should not h...

2016-08-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14506 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #8880: [SPARK-5682][Core] Add encrypted shuffle in spark

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/8880 **[Test build #63817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63817/consoleFull)** for PR 8880 at commit

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74869399 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +307,92 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14656 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63814/ Test PASSed. ---

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14656 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14656 **[Test build #63814 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63814/consoleFull)** for PR 14656 at commit

[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13428 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63812/ Test PASSed. ---

[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13428 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74868660 --- Diff: R/pkg/R/generics.R --- @@ -1279,6 +1279,19 @@ setGeneric("spark.naiveBayes", function(data, formula, ...) { standardGeneric("s #' @export

[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13428 **[Test build #63812 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63812/consoleFull)** for PR 13428 at commit

[GitHub] spark pull request #14384: [Spark-16443][SparkR] Alternating Least Squares (...

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14384#discussion_r74868483 --- Diff: R/pkg/R/mllib.R --- @@ -632,3 +642,159 @@ setMethod("predict", signature(object = "AFTSurvivalRegressionModel"),

[GitHub] spark pull request #14384: [Spark-16443][SparkR] Alternating Least Squares (...

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14384#discussion_r74868437 --- Diff: R/pkg/R/mllib.R --- @@ -632,3 +642,159 @@ setMethod("predict", signature(object = "AFTSurvivalRegressionModel"),

[GitHub] spark pull request #14656: [SPARK-17069] Expose spark.range() as table-value...

2016-08-15 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14656#discussion_r74868227 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala --- @@ -0,0 +1,115 @@ +/* + * Licensed

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74868095 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +307,92 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark issue #8880: [SPARK-5682][Core] Add encrypted shuffle in spark

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/8880 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #8880: [SPARK-5682][Core] Add encrypted shuffle in spark

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/8880 **[Test build #63816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63816/consoleFull)** for PR 8880 at commit

[GitHub] spark issue #8880: [SPARK-5682][Core] Add encrypted shuffle in spark

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/8880 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63816/ Test FAILed. ---

[GitHub] spark issue #8880: [SPARK-5682][Core] Add encrypted shuffle in spark

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/8880 **[Test build #63816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63816/consoleFull)** for PR 8880 at commit

[GitHub] spark pull request #14384: [Spark-16443][SparkR] Alternating Least Squares (...

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14384#discussion_r74867735 --- Diff: R/pkg/R/mllib.R --- @@ -632,3 +642,159 @@ setMethod("predict", signature(object = "AFTSurvivalRegressionModel"),

[GitHub] spark pull request #14384: [Spark-16443][SparkR] Alternating Least Squares (...

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14384#discussion_r74867708 --- Diff: R/pkg/R/mllib.R --- @@ -632,3 +642,159 @@ setMethod("predict", signature(object = "AFTSurvivalRegressionModel"),

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-08-15 Thread sun-rui
Github user sun-rui commented on the issue: https://github.com/apache/spark/pull/11157 has this change be documented to spark on mesos guide? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74866841 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +307,92 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-15 Thread nsyca
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/14580 @dongjoon-hyun, My apologies on the terse comment I put in previously. There is nothing wrong with the ```full outer join``` with ```using``` What I tried to explain is the ```using``` is a

[GitHub] spark issue #14657: [SPARK-17068][SQL] Make view-usage visible during analys...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14657 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63811/ Test PASSed. ---

[GitHub] spark issue #14657: [SPARK-17068][SQL] Make view-usage visible during analys...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14657 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14657: [SPARK-17068][SQL] Make view-usage visible during analys...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14657 **[Test build #63811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63811/consoleFull)** for PR 14657 at commit

[GitHub] spark pull request #14626: [SPARK-16519][SPARKR] Handle SparkR RDD generics ...

2016-08-15 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/14626#discussion_r74866185 --- Diff: R/pkg/R/generics.R --- @@ -152,9 +146,9 @@ setGeneric("getNumPartitions", function(x) { standardGeneric("getNumPartitions") # @export

[GitHub] spark pull request #14182: [SPARK-16444][SparkR]: Isotonic Regression wrappe...

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14182#discussion_r74866111 --- Diff: R/pkg/R/mllib.R --- @@ -533,6 +628,24 @@ setMethod("write.ml", signature(object = "KMeansModel", path = "character"),

[GitHub] spark pull request #14626: [SPARK-16519][SPARKR] Handle SparkR RDD generics ...

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14626#discussion_r74865876 --- Diff: R/pkg/R/generics.R --- @@ -152,9 +146,9 @@ setGeneric("getNumPartitions", function(x) { standardGeneric("getNumPartitions") # @export

[GitHub] spark issue #14648: [SPARK-16995][SQL] TreeNodeException when flat mapping R...

2016-08-15 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/14648 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14656 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63810/ Test PASSed. ---

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14656 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14656 **[Test build #63810 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63810/consoleFull)** for PR 14656 at commit

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74865027 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +307,92 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74864994 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +307,92 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark pull request #14229: [SPARK-16447][ML][SparkR] LDA wrapper in SparkR

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14229#discussion_r74864948 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +307,92 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark pull request #14182: [SPARK-16444][SparkR]: Isotonic Regression wrappe...

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14182#discussion_r74864827 --- Diff: R/pkg/R/mllib.R --- @@ -533,6 +628,24 @@ setMethod("write.ml", signature(object = "KMeansModel", path = "character"),

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14656 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14656 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63809/ Test PASSed. ---

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14656 **[Test build #63809 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63809/consoleFull)** for PR 14656 at commit

[GitHub] spark pull request #14182: [SPARK-16444][SparkR]: Isotonic Regression wrappe...

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14182#discussion_r74863441 --- Diff: R/pkg/R/mllib.R --- @@ -533,6 +628,24 @@ setMethod("write.ml", signature(object = "KMeansModel", path = "character"),

[GitHub] spark issue #14481: [WIP][SPARK-16844][SQL] Generate code for sort based agg...

2016-08-15 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/14481 @hvanhovell thanks very much for the advice, yes, I will post the benchmark results first. And it is WIP, I will post a generated codes, but kindly not review the codes details at present, I am

[GitHub] spark issue #14506: [SPARK-16916][SQL] serde/storage properties should not h...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14506 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14506: [SPARK-16916][SQL] serde/storage properties should not h...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14506 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63808/ Test FAILed. ---

[GitHub] spark issue #14506: [SPARK-16916][SQL] serde/storage properties should not h...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14506 **[Test build #63808 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63808/consoleFull)** for PR 14506 at commit

[GitHub] spark issue #7625: [WIP] [skip ci] Fuzz testing in Spark SQL

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/7625 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #7625: [WIP] [skip ci] Fuzz testing in Spark SQL

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/7625 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63815/ Test FAILed. ---

[GitHub] spark issue #7625: [WIP] [skip ci] Fuzz testing in Spark SQL

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/7625 **[Test build #63815 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63815/consoleFull)** for PR 7625 at commit

[GitHub] spark issue #7625: [WIP] [skip ci] Fuzz testing in Spark SQL

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/7625 **[Test build #63815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63815/consoleFull)** for PR 7625 at commit

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14656 **[Test build #63814 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63814/consoleFull)** for PR 14656 at commit

[GitHub] spark pull request #14656: [SPARK-17069] Expose spark.range() as table-value...

2016-08-15 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14656#discussion_r74861427 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -122,6 +122,44 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark issue #7625: [WIP] [skip ci] Fuzz testing in Spark SQL

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/7625 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63813/ Test FAILed. ---

[GitHub] spark issue #7625: [WIP] [skip ci] Fuzz testing in Spark SQL

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/7625 **[Test build #63813 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63813/consoleFull)** for PR 7625 at commit

[GitHub] spark issue #7625: [WIP] [skip ci] Fuzz testing in Spark SQL

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/7625 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14182: [SPARK-16444][SparkR]: Isotonic Regression wrappe...

2016-08-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14182#discussion_r74861441 --- Diff: R/pkg/R/mllib.R --- @@ -299,6 +308,91 @@ setMethod("summary", signature(object = "NaiveBayesModel"), return(list(apriori =

[GitHub] spark issue #7625: [WIP] [skip ci] Fuzz testing in Spark SQL

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/7625 **[Test build #63813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63813/consoleFull)** for PR 7625 at commit

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14656 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63807/ Test FAILed. ---

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14656 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14656 **[Test build #63807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63807/consoleFull)** for PR 14656 at commit

[GitHub] spark pull request #7625: [WIP] [skip ci] Fuzz testing in Spark SQL

2016-08-15 Thread JoshRosen
GitHub user JoshRosen reopened a pull request: https://github.com/apache/spark/pull/7625 [WIP] [skip ci] Fuzz testing in Spark SQL [skip ci] This is a WIP pull request for some expression fuzz testing code that I'm working on as part of a hackathon. I'm creating this

[GitHub] spark pull request #14649: [SPARK-17059][SQL] Allow FileFormat to specify pa...

2016-08-15 Thread andreweduffy
Github user andreweduffy commented on a diff in the pull request: https://github.com/apache/spark/pull/14649#discussion_r74860656 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetQuerySuite.scala --- @@ -703,6 +703,16 @@ class

[GitHub] spark pull request #14656: [SPARK-17069] Expose spark.range() as table-value...

2016-08-15 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14656#discussion_r74860010 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala --- @@ -0,0 +1,115 @@ +/* + * Licensed

[GitHub] spark pull request #14656: [SPARK-17069] Expose spark.range() as table-value...

2016-08-15 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14656#discussion_r74859905 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -653,6 +653,19 @@ class AstBuilder extends

[GitHub] spark issue #13428: [SPARK-12666][CORE] SparkSubmit packages fix for when 'd...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13428 **[Test build #63812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63812/consoleFull)** for PR 13428 at commit

[GitHub] spark issue #13796: [SPARK-7159][ML] Add multiclass logistic regression to S...

2016-08-15 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/13796 Maybe we could move the shared code `MultiClassSummarizer`, `LogisticAggregator` and `LogisticCostFun` into `LogisticRegressionUtils.scala`? --- If your project is set up for it, you can reply to

[GitHub] spark issue #14631: [SPARK-17035][SQL][PYSPARK] Improve Timestamp not to los...

2016-08-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14631 Hi, @davies . Could you review this PR about `Timestamp precision` again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-15 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74859089 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultinomialLogisticRegression.scala --- @@ -0,0 +1,626 @@ +/* + * Licensed to the

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14433 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63805/ Test PASSed. ---

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14433 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14583: [SPARK-16994][SQL] PushDownPredicate should not ignore l...

2016-08-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14583 Hi, @rxin . Could you review this PR about `PushDownPredicate`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14433 **[Test build #63805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63805/consoleFull)** for PR 14433 at commit

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14580 Could you give us some examples we miss incorrectly here? We had better discuss on more concrete examples for other audiences. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #14568: [SPARK-10868] monotonicallyIncreasingId() supports offse...

2016-08-15 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/spark/pull/14568 @hvanhovell As Martin said in JIRA: * Add the index column to A' - this time starting at 200, as there are already entries with id's from 0 to 199 (here, monotonicallyInreasingID( 200 )

[GitHub] spark pull request #14467: [SPARK-16861][PYSPARK][CORE] Refactor PySpark acc...

2016-08-15 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/14467#discussion_r74857555 --- Diff: python/pyspark/context.py --- @@ -173,9 +173,8 @@ def _do_init(self, master, appName, sparkHome, pyFiles, environment, batchSize, #

[GitHub] spark issue #14657: [SPARK-17068][SQL] Make view-usage visible during analys...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14657 **[Test build #63811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63811/consoleFull)** for PR 14657 at commit

[GitHub] spark pull request #14657: [SPARK-17068][SQL] Make view-usage visible during...

2016-08-15 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/14657 [SPARK-17068][SQL] Make view-usage visible during analysis [WIP] ## What changes were proposed in this pull request? This PR adds a field to subquery alias in order to make the usage of

[GitHub] spark issue #14654: [SPARK-16964][SQL] Remove private[hive] from sql.hive.ex...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14654 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14654: [SPARK-16964][SQL] Remove private[hive] from sql.hive.ex...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14654 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63806/ Test PASSed. ---

[GitHub] spark issue #14654: [SPARK-16964][SQL] Remove private[hive] from sql.hive.ex...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14654 **[Test build #63806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63806/consoleFull)** for PR 14654 at commit

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14656 **[Test build #63810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63810/consoleFull)** for PR 14656 at commit

[GitHub] spark issue #14652: [SPARK-16964][SQL] Remove private[sql] and private[spark...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14652 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63803/ Test PASSed. ---

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14656 @ericl this looks pretty good. I left a few comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14652: [SPARK-16964][SQL] Remove private[sql] and private[spark...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14652 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14652: [SPARK-16964][SQL] Remove private[sql] and private[spark...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14652 **[Test build #63803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63803/consoleFull)** for PR 14652 at commit

[GitHub] spark pull request #14656: [SPARK-17069] Expose spark.range() as table-value...

2016-08-15 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14656#discussion_r74855514 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -122,6 +122,44 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #14656: [SPARK-17069] Expose spark.range() as table-value...

2016-08-15 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14656#discussion_r74855344 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala --- @@ -0,0 +1,115 @@ +/* + *

[GitHub] spark pull request #14656: [SPARK-17069] Expose spark.range() as table-value...

2016-08-15 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14656#discussion_r74854797 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -653,6 +653,19 @@ class AstBuilder extends

[GitHub] spark pull request #14656: [SPARK-17069] Expose spark.range() as table-value...

2016-08-15 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14656#discussion_r74854575 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala --- @@ -0,0 +1,115 @@ +/* + *

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14580 @dongjoon-hyun The root cause is not in the optimizer rule `EliminateOuterJoin`. Your fix will reduce the chances we can eliminate the outer-join. This is not a right fix. The existing way we

[GitHub] spark pull request #14656: [SPARK-17069] Expose spark.range() as table-value...

2016-08-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14656#discussion_r74854090 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -653,6 +653,19 @@ class AstBuilder extends

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14656 **[Test build #63809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63809/consoleFull)** for PR 14656 at commit

[GitHub] spark pull request #14656: [SPARK-17069] Expose spark.range() as table-value...

2016-08-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14656#discussion_r74853965 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -122,6 +122,44 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #14656: [SPARK-17069] Expose spark.range() as table-value...

2016-08-15 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14656#discussion_r74853782 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/TableValuedFunctionSuite.scala --- @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #14656: [SPARK-17069] Expose spark.range() as table-value...

2016-08-15 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14656#discussion_r74853793 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableValuedFunctions.scala --- @@ -0,0 +1,115 @@ +/* --- End diff --

[GitHub] spark issue #14580: [SPARK-16991][SQL] Fix `EliminateOuterJoin` optimizer to...

2016-08-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14580 @hvanhovell The output schema is different. They are not equivalent. Thus, the existing way to handle `using/natural joins` is wrong. We need to introduce new join types. Let me show

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r74852722 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -689,4 +689,38 @@ class HiveDDLSuite )) }

[GitHub] spark pull request #14656: [SPARK-17069] Expose spark.range() as table-value...

2016-08-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14656#discussion_r74852451 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/TableValuedFunctionSuite.scala --- @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #14656: [SPARK-17069] Expose spark.range() as table-valued funct...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14656 **[Test build #63807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63807/consoleFull)** for PR 14656 at commit

[GitHub] spark issue #14506: [SPARK-16916][SQL] serde/storage properties should not h...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14506 **[Test build #63808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63808/consoleFull)** for PR 14506 at commit

<    1   2   3   4   5   6   >