Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14874
**[Test build #64703 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64703/consoleFull)**
for PR 14874 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14531#discussion_r76932912
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -58,18 +63,32 @@ case class CreateTableLikeCommand(
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14823
I missed this ping. Will review it tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14859
**[Test build #64702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64702/consoleFull)**
for PR 14859 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14712#discussion_r76932253
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -140,7 +145,12 @@ private[hive] case class MetastoreRelation(
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14889
Thanks @HyukjinKwon - This is a great catch. LGTM pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14874#discussion_r76932176
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite.scala
---
@@ -274,6 +276,75 @@ class SQLViewSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14874#discussion_r76932113
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite.scala
---
@@ -274,6 +276,75 @@ class SQLViewSuite extends QueryTest
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14859
HiveContext tests with SparkR is already being skipped due to
https://github.com/apache/spark/pull/14889.
I manually fixed this and tested this, here.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13873
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64698/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13873
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14874#discussion_r76931872
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite.scala
---
@@ -274,6 +276,75 @@ class SQLViewSuite extends QueryTest
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14874
LGTM except one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14889
**[Test build #64700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64700/consoleFull)**
for PR 14889 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14862
**[Test build #64701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64701/consoleFull)**
for PR 14862 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13873
**[Test build #64698 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64698/consoleFull)**
for PR 13873 at commit
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/14712#discussion_r76931629
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -235,14 +235,18 @@ class SessionCatalog(
*
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14712#discussion_r76931067
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -140,7 +145,12 @@ private[hive] case class MetastoreRelation(
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14883
After reading the code, it sounds like adding session-scoped ADD JAR is not
simple if we want to pass it to every worker node after the PR:
https://github.com/apache/spark/pull/8909
CC
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14889
cc @rxin, @felixcheung and @shivaram
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/14889
[SPARK-17326][SPARKR] Fix tests with HiveContext in SparkR not to be
skipped always
## What changes were proposed in this pull request?
Currently, `HiveContext` in SparkR is not being
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14531#discussion_r76930695
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -58,18 +63,32 @@ case class CreateTableLikeCommand(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14712#discussion_r76930682
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -140,7 +145,12 @@ private[hive] case class MetastoreRelation(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14531#discussion_r76930187
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -58,18 +63,32 @@ case class CreateTableLikeCommand(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14710
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64697/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14710
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14710
**[Test build #64697 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64697/consoleFull)**
for PR 14710 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14883
@cloud-fan @viirya After reading Hive's code, the JAR's scope should be
session based. See the code:
Github user clarkfitzg commented on the issue:
https://github.com/apache/spark/pull/14783
Yes, this is only for a bug fix. @shivaram mentioned in a previous email
exchange it would be good to see some performance benchmarks as well.
---
If your project is set up for it, you can
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/14712#discussion_r76929362
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(conf:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14531
**[Test build #64699 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64699/consoleFull)**
for PR 14531 at commit
601 - 631 of 631 matches
Mail list logo