Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15441
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67417/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15441
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15441
**[Test build #67417 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67417/consoleFull)**
for PR 15441 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15602
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67419/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15602
**[Test build #67419 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67419/consoleFull)**
for PR 15602 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15603
**[Test build #67420 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67420/consoleFull)**
for PR 15603 at commit
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/15603
[WEBUI][MINOR] Return types in methods + cleanup
## What changes were proposed in this pull request?
The main purpose of the change is to discuss the purpose of `SparkUITab`
class
Github user yinxusen commented on the issue:
https://github.com/apache/spark/pull/9
How about the following:
1. Since the new generated model is derived from an estimator, the model
should have the same params as its parent estimator. That's why there is no
need to
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15602
LGTM - pending jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15596
@JoshRosen could you shed some light on why we are not using the regular
`EnsureRequirements` based code path for `CollectLimitExec`?
---
If your project is set up for it, you can reply to this
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/15595#discussion_r84600741
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -377,4 +377,23 @@ class AnalysisSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15602
**[Test build #67419 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67419/consoleFull)**
for PR 15602 at commit
GitHub user CodingCat opened a pull request:
https://github.com/apache/spark/pull/15602
[SPARK-18058][SQL] [BACKPORT-2.0]Comparing column types ignoring
Nullability in Union and SetOperation
## What changes were proposed in this pull request?
The PR tries to fix
Github user felixcheung closed the pull request at:
https://github.com/apache/spark/pull/15589
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15589
merged to branch-2.0 and then cherry-picked to master for the error message
fix not in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15541
**[Test build #67418 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67418/consoleFull)**
for PR 15541 at commit
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/15595
Just saw that this got merged. I had a tiny nit but its ok without it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15595#discussion_r84600424
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -377,4 +377,23 @@ class AnalysisSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15441
**[Test build #67417 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67417/consoleFull)**
for PR 15441 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15595
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user CodingCat commented on the issue:
https://github.com/apache/spark/pull/15595
sure, doing that now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15595
@CodingCat could you open a backport for branch-2.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15595
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15595
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14136
It is relatively straight forward to test `ImperativeAggregate`s. See:
-
org.apache.spark.sql.catalyst.expressions.aggregate.HyperLogLogPlusPlusSuite
-
Github user ajbozarth commented on a diff in the pull request:
https://github.com/apache/spark/pull/15441#discussion_r84599733
--- Diff: core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala ---
@@ -651,6 +671,15 @@ class UISeleniumSuite extends SparkFunSuite with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67415/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15513
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15595
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15513
**[Test build #67415 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67415/consoleFull)**
for PR 15513 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15595
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67416/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15595
**[Test build #67416 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67416/consoleFull)**
for PR 15595 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15417
Sorry, will review it soon. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15513
We should also add the default value in the argument description. Below is
an example.
```
Arguments:
col - a numeric expression.
percentage - a numeric literal or
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15513
Another example:
```
Arguments:
expr1 - a numeric expression.
expr2 - a numeric expression.
```
->
```
Arguments:
expr1 - Data type: numeric.
expr2
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15513
I prefer to minimizing the words without showing any information. Below is
an example.
```
Arguments:
class - a string literal that represents a fully-qualified class name.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84597837
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -49,21 +49,29 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84597661
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -692,9 +722,11 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84597610
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -150,8 +206,16 @@ case class XPathString(xml:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84597530
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -970,9 +1270,19 @@ case class Round(child:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15595
**[Test build #67416 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67416/consoleFull)**
for PR 15595 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15513
**[Test build #67415 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67415/consoleFull)**
for PR 15513 at commit
Github user techaddict closed the pull request at:
https://github.com/apache/spark/pull/15433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/15433
closing this since, its maybe not the right way to do this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/spark/pull/15601
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15601
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67413/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15601
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15601
**[Test build #67413 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67413/consoleFull)**
for PR 15601 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15601
LGTM. Merging to branch-2.0. Could you close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15601
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15601
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67412/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15601
**[Test build #67412 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67412/consoleFull)**
for PR 15601 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15413
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67414/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15413
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15413
**[Test build #67414 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67414/consoleFull)**
for PR 15413 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15513
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67411/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15513
**[Test build #67411 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67411/consoleFull)**
for PR 15513 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15582
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14957
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15354
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14957
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67410/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15354
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67409/
Test PASSed.
---
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15582
Merging to master. Thanks! Ping me for the follow-up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14957
**[Test build #67410 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67410/consoleFull)**
for PR 14957 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15553
For development time, use an IDE or maybe SBT to do incremental
compilation, which is even faster. I don't otherwise see a strong use case for
not compiling tests. Yes it's slower to compile tests,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15354
**[Test build #67409 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67409/consoleFull)**
for PR 15354 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15575
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15575
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15413
**[Test build #67414 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67414/consoleFull)**
for PR 15413 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15599
I think we don't know exactly what the real exception is. The NPE occurs
while handling the exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15601
**[Test build #67413 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67413/consoleFull)**
for PR 15601 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15601
**[Test build #67412 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67412/consoleFull)**
for PR 15601 at commit
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/15601
[SPARK-17123][SQL][BRANCH-2.0] Use type-widened encoder for DataFrame for
set operations
## What changes were proposed in this pull request?
This PR backports
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15354
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15354
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67408/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15354
**[Test build #67408 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67408/consoleFull)**
for PR 15354 at commit
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/14957#discussion_r84592883
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -661,6 +666,8 @@ private[sql] class SQLConf extends Serializable
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/14957#discussion_r84592888
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetQuerySuite.scala
---
@@ -571,6 +571,37 @@ class
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/14957#discussion_r84592876
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -212,6 +212,11 @@ object SQLConf {
.booleanConf
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/14957#discussion_r84592865
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
---
@@ -126,4 +136,52 @@ object
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15513
**[Test build #67411 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67411/consoleFull)**
for PR 15513 at commit
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/14957#discussion_r84592821
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
---
@@ -126,4 +136,52 @@ object
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/14957#discussion_r84592816
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
---
@@ -126,4 +136,52 @@ object
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/14957#discussion_r84592818
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
---
@@ -126,4 +136,52 @@ object
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14957
**[Test build #67410 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67410/consoleFull)**
for PR 14957 at commit
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/14957#discussion_r84592806
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
---
@@ -97,7 +99,15 @@ object FileSourceStrategy
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/14957#discussion_r84592805
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
---
@@ -97,7 +99,15 @@ object FileSourceStrategy
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15354
**[Test build #67409 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67409/consoleFull)**
for PR 15354 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15354
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67407/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15354
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15354
**[Test build #67407 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67407/consoleFull)**
for PR 15354 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15354
**[Test build #67408 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67408/consoleFull)**
for PR 15354 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15354
@marmbrus Sure (I didn't mean I am not going to do this..), I just handled
the case in this PR for `to_json`.
BTW, I would like to note that there are the same problems in other JSON
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15354
**[Test build #67407 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67407/consoleFull)**
for PR 15354 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15597
cc @sameeragarwal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14136
Is there a way we can add some expression level unit tests for this? I
realized we don't really have existing infrastructure for unit testing
aggregate expressions (only for non-aggregate
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r84591480
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -613,6 +613,46 @@ object functions {
def min(columnName: String): Column =
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r84591475
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1455,50 +1455,59 @@ class DDLSuite extends QueryTest
101 - 200 of 236 matches
Mail list logo
