[GitHub] spark pull request #16429: [SPARK-19019][PYTHON] Fix hijacked `collections.n...

2017-01-02 Thread azmras
Github user azmras commented on a diff in the pull request: https://github.com/apache/spark/pull/16429#discussion_r94367710 --- Diff: python/pyspark/serializers.py --- @@ -382,18 +382,30 @@ def _hijack_namedtuple(): return global _old_namedtuple # or it

[GitHub] spark issue #16233: [SPARK-18801][SQL] Support resolve a nested view

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16233 **[Test build #70806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70806/testReport)** for PR 16233 at commit

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2017-01-02 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94367053 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -377,6 +378,39 @@ case class

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2017-01-02 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94366859 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -377,6 +378,39 @@ case class

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2017-01-02 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94366640 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -510,32 +510,94 @@ class Analyzer( *

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double numeric d...

2017-01-02 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/15314 ping @srowen @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #12135: [SPARK-14352][SQL] approxQuantile should support multi c...

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12135 **[Test build #70805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70805/testReport)** for PR 12135 at commit

[GitHub] spark issue #16371: [SPARK-18932][SQL] Support partial aggregation for colle...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16371 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2017-01-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15880 Just for your reference, below is the conversion charts of MS SQL Server. It includes both implicit and explicit conversion rules. ![screenshot 2017-01-02 23 18

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94365473 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -377,6 +378,39 @@ case class

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94365429 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -377,6 +378,39 @@ case class

[GitHub] spark issue #15240: [SPARK-17556] [CORE] [SQL] Executor side broadcast for b...

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15240 **[Test build #70804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70804/testReport)** for PR 15240 at commit

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15324 **[Test build #70803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70803/testReport)** for PR 15324 at commit

[GitHub] spark issue #15240: [SPARK-17556] [CORE] [SQL] Executor side broadcast for b...

2017-01-02 Thread scwf
Github user scwf commented on the issue: https://github.com/apache/spark/pull/15240 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15324 **[Test build #70799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70799/testReport)** for PR 15324 at commit

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15324 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70799/ Test FAILed. ---

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15324 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15324 **[Test build #70802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70802/testReport)** for PR 15324 at commit

[GitHub] spark issue #16371: [SPARK-18932][SQL] Support partial aggregation for colle...

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16371 **[Test build #70801 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70801/testReport)** for PR 16371 at commit

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94364696 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -510,32 +510,94 @@ class Analyzer( * Replaces

[GitHub] spark issue #16233: [SPARK-18801][SQL] Support resolve a nested view

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16233 **[Test build #70800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70800/testReport)** for PR 16233 at commit

[GitHub] spark issue #15730: [SPARK-18218][ML][MLLib] Optimize BlockMatrix multiplica...

2017-01-02 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/15730 @WeichenXu123 Thanks! Will take a look once I get back from vacation (in a week). Happy new year! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #16371: [SPARK-18932][SQL] Support partial aggregation fo...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16371#discussion_r94363919 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala --- @@ -88,19 +92,19 @@ abstract class Collect

[GitHub] spark pull request #16371: [SPARK-18932][SQL] Support partial aggregation fo...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16371#discussion_r94363879 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala --- @@ -88,19 +92,19 @@ abstract class Collect

[GitHub] spark pull request #16371: [SPARK-18932][SQL] Support partial aggregation fo...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16371#discussion_r94363844 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregatesSuite.scala --- @@ -16,16 +16,16 @@ */

[GitHub] spark issue #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on Decima...

2017-01-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16320 The test case coverage in the suite `CSVInferSchemaSuite.scala` looks random. I am afraid the future code changes could easily break the existing type inference rules. Could you improve it in a

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15324 **[Test build #70799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70799/testReport)** for PR 15324 at commit

[GitHub] spark issue #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on Decima...

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16320 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on Decima...

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70795/ Test PASSed. ---

[GitHub] spark issue #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on Decima...

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16320 **[Test build #70795 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70795/testReport)** for PR 16320 at commit

[GitHub] spark issue #15730: [SPARK-18218][ML][MLLib] Optimize BlockMatrix multiplica...

2017-01-02 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15730 @brkyvz I update code and attach a running result screenshot, waiting for your review, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on Decima...

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16320 **[Test build #70798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70798/testReport)** for PR 16320 at commit

[GitHub] spark issue #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on Decima...

2017-01-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16320 Yep. I added the testcase, too. @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15819: [SPARK-18372][SQL][Branch-1.6].Staging directory ...

2017-01-02 Thread merlintang
Github user merlintang commented on a diff in the pull request: https://github.com/apache/spark/pull/15819#discussion_r94361979 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -216,5 +218,37 @@ class VersionsSuite extends SparkFunSuite

[GitHub] spark pull request #16255: [SPARK-18609][SQL]Fix when CTE with Join between ...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16255#discussion_r94361717 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -200,6 +200,8 @@ object RemoveAliasOnlyProject

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15880 **[Test build #70797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70797/testReport)** for PR 15880 at commit

[GitHub] spark pull request #16255: [SPARK-18609][SQL]Fix when CTE with Join between ...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16255#discussion_r94361709 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -200,6 +200,8 @@ object RemoveAliasOnlyProject

[GitHub] spark issue #16448: [SPARK-19048] [SQL] Delete Partition Location when Dropp...

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16448 **[Test build #70796 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70796/testReport)** for PR 16448 at commit

[GitHub] spark issue #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on Decima...

2017-01-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16320 I assumed this one. Right? ```scala val path = "/tmp/test1" Seq(s"${Long.MaxValue}1", "2015-12-01 00:00:00", "1").toDF().coalesce(1).write.text(path)

[GitHub] spark pull request #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATT...

2017-01-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16422#discussion_r94361604 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15880 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on Decima...

2017-01-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16320 Please add the test case? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2017-01-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r94360417 --- Diff: sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/simple-in.sql.out --- @@ -0,0 +1,176 @@ +-- Automatically generated by

[GitHub] spark pull request #15819: [SPARK-18372][SQL][Branch-1.6].Staging directory ...

2017-01-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15819#discussion_r94360355 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -216,5 +218,37 @@ class VersionsSuite extends SparkFunSuite

[GitHub] spark pull request #15819: [SPARK-18372][SQL][Branch-1.6].Staging directory ...

2017-01-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15819#discussion_r94360173 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -216,5 +218,37 @@ class VersionsSuite extends SparkFunSuite

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2017-01-02 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r94360158 --- Diff: sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/simple-in.sql.out --- @@ -0,0 +1,176 @@ +-- Automatically generated by

[GitHub] spark pull request #16337: [SPARK-18871][SQL] New test cases for IN/NOT IN s...

2017-01-02 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/16337#discussion_r94359988 --- Diff: sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/simple-in.sql.out --- @@ -0,0 +1,176 @@ +-- Automatically generated by

[GitHub] spark pull request #15819: [SPARK-18372][SQL][Branch-1.6].Staging directory ...

2017-01-02 Thread merlintang
Github user merlintang commented on a diff in the pull request: https://github.com/apache/spark/pull/15819#discussion_r94359244 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -216,5 +218,37 @@ class VersionsSuite extends SparkFunSuite

[GitHub] spark issue #16401: [SPARK-18998] [SQL] Add a cbo conf to switch between def...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16401 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16456: [SPARK-18994] clean up the local directories for applica...

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16456 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #16456: [SPARK-18994] clean up the local directories for ...

2017-01-02 Thread liujianhuiouc
GitHub user liujianhuiouc opened a pull request: https://github.com/apache/spark/pull/16456 [SPARK-18994] clean up the local directories for application in future by annother thread ## What changes were proposed in this pull request? clean up the directories of the app by

[GitHub] spark pull request #16401: [SPARK-18998] [SQL] Add a cbo conf to switch betw...

2017-01-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16401 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15324 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15324 **[Test build #70794 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70794/testReport)** for PR 15324 at commit

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15324 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70794/ Test FAILed. ---

[GitHub] spark pull request #16452: [ML] fix getThresholds logic error

2017-01-02 Thread mpjlu
Github user mpjlu closed the pull request at: https://github.com/apache/spark/pull/16452 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16452: [ML] fix getThresholds logic error

2017-01-02 Thread mpjlu
Github user mpjlu commented on the issue: https://github.com/apache/spark/pull/16452 @sethah , thanks, I got it wrong. I will close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on Decima...

2017-01-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16320 Thank you again, @cloud-fan and @HyukjinKwon . I updated the fallback datatype. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on Decima...

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16320 **[Test build #70795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70795/testReport)** for PR 16320 at commit

[GitHub] spark pull request #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on...

2017-01-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16320#discussion_r94358461 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -85,7 +85,9 @@ private[csv] object

[GitHub] spark pull request #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on...

2017-01-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16320#discussion_r94358447 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -85,7 +85,9 @@ private[csv] object

[GitHub] spark issue #16454: [SPARK-19055][SQL][PySpark] Fix SparkSession initializat...

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16454 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70793/ Test PASSed. ---

[GitHub] spark pull request #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on...

2017-01-02 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16320#discussion_r94358365 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -85,7 +85,9 @@ private[csv] object

[GitHub] spark issue #16454: [SPARK-19055][SQL][PySpark] Fix SparkSession initializat...

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16454 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16454: [SPARK-19055][SQL][PySpark] Fix SparkSession initializat...

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16454 **[Test build #70793 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70793/testReport)** for PR 16454 at commit

[GitHub] spark issue #16453: [SPARK-19054][ML] Eliminate extra pass in NB

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16453 **[Test build #70792 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70792/testReport)** for PR 16453 at commit

[GitHub] spark issue #16453: [SPARK-19054][ML] Eliminate extra pass in NB

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16453 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70792/ Test PASSed. ---

[GitHub] spark issue #16453: [SPARK-19054][ML] Eliminate extra pass in NB

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16453 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16452: [ML] fix getThresholds logic error

2017-01-02 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/16452 @mpjlu This is the behavior I get: scala scala> import org.apache.spark.ml.classification.LogisticRegression import org.apache.spark.ml.classification.LogisticRegression

[GitHub] spark pull request #16438: [SPARK-19029] [SQL] Remove databaseName from Simp...

2017-01-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16438 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15923: [SPARK-4105] retry the fetch or stage if shuffle ...

2017-01-02 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15923#discussion_r94358078 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -305,40 +316,84 @@ final class ShuffleBlockFetcherIterator(

[GitHub] spark issue #16438: [SPARK-19029] [SQL] Remove databaseName from SimpleCatal...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16438 LGTM, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATT...

2017-01-02 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/16422#discussion_r94357987 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark issue #16455: [MINOR][DOCS] Remove the duplicated word/ typo in Stream...

2017-01-02 Thread neurons
Github user neurons commented on the issue: https://github.com/apache/spark/pull/16455 @tdas could you accept this small PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16320#discussion_r94357821 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -85,7 +85,9 @@ private[csv] object

[GitHub] spark issue #16455: [MINOR][DOCS] Remove the duplicated word/ typo in Stream...

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16455 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16401: [SPARK-18998] [SQL] Add a cbo conf to switch between def...

2017-01-02 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/16401 @cloud-fan In the current stage, we have Filter, Agg, Join, Project, etc. Although there are only four plans, the `if` code is still repeated. Moreover, in the future, when we have other kind of

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15324 **[Test build #70794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70794/testReport)** for PR 15324 at commit

[GitHub] spark pull request #16455: [MINOR][DOCS] Remove the duplicated word/ typo in...

2017-01-02 Thread neurons
GitHub user neurons opened a pull request: https://github.com/apache/spark/pull/16455 [MINOR][DOCS] Remove the duplicated word/ typo in Streaming Docs ## What changes were proposed in this pull request? In the section **Handling Late Data and Watermarking** in Structured

[GitHub] spark issue #16454: [SPARK-19055][SQL][PySpark] Fix SparkSession initializat...

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16454 **[Test build #70793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70793/testReport)** for PR 16454 at commit

[GitHub] spark issue #16119: [SPARK-18687][Pyspark][SQL]Backward compatibility - crea...

2017-01-02 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16119 The test failure is caused by another issue. I've submitted another PR to fix it: #16454. Once that is fixed, this test can be passed. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request #16454: [SPARK-19055][SQL][PySpark] Fix SparkSession init...

2017-01-02 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/16454 [SPARK-19055][SQL][PySpark] Fix SparkSession initialization when SparkContext is stopped ## What changes were proposed in this pull request? In SparkSession initialization, we

[GitHub] spark issue #16448: [SPARK-19048] [SQL] Delete Partition Location when Dropp...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16448 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #16448: [SPARK-19048] [SQL] Delete Partition Location whe...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16448#discussion_r94357410 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala --- @@ -346,6 +346,46 @@ abstract class

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2017-01-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16404 Found a bug filed in a JIRA https://issues.apache.org/jira/browse/SPARK-19035. This PR does not resolves it. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #16401: [SPARK-18998] [SQL] Add a cbo conf to switch between def...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16401 > Then we need to modify all the existing implementation of statistics and do if(cboEnabled) test in each of them. That would be tedious. hm? I think we only need to do `if(cboEnabled)`

[GitHub] spark issue #16437: [SPARK-19028] [SQL] Fixed non-thread-safe functions used...

2017-01-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16437 @gatorsmile it conflicts with branch 2.0, please send a new PR, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16452: [ML] fix getThresholds logic error

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16452 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16452: [ML] fix getThresholds logic error

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16452 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70790/ Test FAILed. ---

[GitHub] spark issue #16452: [ML] fix getThresholds logic error

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16452 **[Test build #70790 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70790/testReport)** for PR 16452 at commit

[GitHub] spark issue #16453: [SPARK-19054][ML] Eliminate extra pass in NB

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16453 **[Test build #70792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70792/testReport)** for PR 16453 at commit

[GitHub] spark pull request #16453: [SPARK-19054][ML] Eliminate extra pass in NB

2017-01-02 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/16453 [SPARK-19054][ML] Eliminate extra pass in NB ## What changes were proposed in this pull request? eliminate unnecessary extra pass in NB's train ## How was this patch tested?

[GitHub] spark issue #15829: [SPARK-18379][SQL] Make the parallelism of parallelParti...

2017-01-02 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15829 Sure. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #16452: [ML] fix getThresholds logic error

2017-01-02 Thread mpjlu
Github user mpjlu commented on the issue: https://github.com/apache/spark/pull/16452 If both threshold and thresholds are not set, the master will return thresholds. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #16452: [ML] fix getThresholds logic error

2017-01-02 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/16452 What is not right? Could you be more specific? The behavior for master branch seems to align with the comments, but maybe I'm missing it. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15324 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70791/ Test FAILed. ---

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15324 **[Test build #70791 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70791/testReport)** for PR 15324 at commit

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15324 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15923: [SPARK-4105] retry the fetch or stage if shuffle ...

2017-01-02 Thread Tagar
Github user Tagar commented on a diff in the pull request: https://github.com/apache/spark/pull/15923#discussion_r94356127 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -305,40 +316,84 @@ final class ShuffleBlockFetcherIterator(

[GitHub] spark issue #15324: [SPARK-16872][ML] Gaussian Naive Bayes Classifier

2017-01-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15324 **[Test build #70791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70791/testReport)** for PR 15324 at commit

  1   2   >