[GitHub] spark pull request #16503: [SPARK-18113] Use ask to replace askWithRetry in ...

2017-01-12 Thread ash211
Github user ash211 commented on a diff in the pull request: https://github.com/apache/spark/pull/16503#discussion_r95660339 --- Diff: core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala --- @@ -165,9 +167,14 @@ private[spark] class OutputCommitCoordinator(c

[GitHub] spark pull request #16503: [SPARK-18113] Use ask to replace askWithRetry in ...

2017-01-12 Thread ash211
Github user ash211 commented on a diff in the pull request: https://github.com/apache/spark/pull/16503#discussion_r95659921 --- Diff: core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala --- @@ -221,6 +227,22 @@ private case class OutputCommitFunctions

[GitHub] spark pull request #16503: [SPARK-18113] Use ask to replace askWithRetry in ...

2017-01-12 Thread ash211
Github user ash211 commented on a diff in the pull request: https://github.com/apache/spark/pull/16503#discussion_r95659396 --- Diff: core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala --- @@ -189,6 +188,13 @@ class OutputCommitCoordinatorSuite exten

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2017-01-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16404 I am fine to merge this at first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark issue #16404: [SPARK-18969][SQL] Support grouping by nondeterministic ...

2017-01-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16404 Agree. Oracle behaves the same. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16558: Fix missing close-parens for In filter's toString

2017-01-12 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16558 Oops - LGTM pending tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16550: [SPARK-19178][SQL] convert string of large numbers to in...

2017-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16550 **[Test build #71250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71250/testReport)** for PR 16550 at commit [`beb4fd8`](https://github.com/apache/spark/commit/be

<    1   2   3   4   5