[GitHub] spark issue #16672: [SPARK-19329][SQL]insert data to a not exist location da...

2017-01-25 Thread windpiger
Github user windpiger commented on the issue: https://github.com/apache/spark/pull/16672 @gatorsmile could you give some suggestion? thanks very much! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #16700: [SPARK-19359][SQL]clear useless path after rename a part...

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16700 **[Test build #72017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72017/testReport)** for PR 16700 at commit

[GitHub] spark issue #16709: [SPARK-19333][SPARKR] Add Apache License headers to R fi...

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16709 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16709: [SPARK-19333][SPARKR] Add Apache License headers to R fi...

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16709 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72015/ Test PASSed. ---

[GitHub] spark issue #16709: [SPARK-19333][SPARKR] Add Apache License headers to R fi...

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16709 **[Test build #72015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72015/testReport)** for PR 16709 at commit

[GitHub] spark issue #13300: [SPARK-15463][SQL] support creating dataframe out of Dat...

2017-01-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/13300 Yea, I also think `json` and `csv` stuffs should be consistent and they'd be better to have the same code structure and behaviour as @HyukjinKwon said. Since we do not have

[GitHub] spark issue #16708: [SPARK-19366][SQL] add getNumPartitions to Dataset

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16708 **[Test build #72016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72016/testReport)** for PR 16708 at commit

[GitHub] spark issue #13300: [SPARK-15463][SQL] support creating dataframe out of Dat...

2017-01-25 Thread xwu0226
Github user xwu0226 commented on the issue: https://github.com/apache/spark/pull/13300 @HyukjinKwon Thanks! After your #16680 is merged, submit a PR with the code you show above. then. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #13300: [SPARK-15463][SQL] support creating dataframe out of Dat...

2017-01-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/13300 Actually, this feature might not be urgent as said above but IMO I like this feature to be honest. I guess the reason it was hold is that IMHO it does not look a clean fix. I recently

[GitHub] spark pull request #16670: [SPARK-19324][SPARKR] Spark VJM stdout output is ...

2017-01-25 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16670#discussion_r97939920 --- Diff: R/pkg/inst/tests/testthat/test_Windows.R --- @@ -20,7 +20,7 @@ test_that("sparkJars tag in SparkContext", { if (.Platform$OS.type !=

[GitHub] spark issue #16709: [SPARK-19333][SPARKR] Add Apache License headers to R fi...

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16709 **[Test build #72015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72015/testReport)** for PR 16709 at commit

[GitHub] spark pull request #16709: [SPARK-19333][SPARKR] Add Apache License headers ...

2017-01-25 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/16709 [SPARK-19333][SPARKR] Add Apache License headers to R files ## What changes were proposed in this pull request? add header ## How was this patch tested? Manual run to

[GitHub] spark issue #16700: [SPARK-19359][SQL]clear useless path after rename a part...

2017-01-25 Thread windpiger
Github user windpiger commented on the issue: https://github.com/apache/spark/pull/16700 1. renamePartition: A=1/B=2/C=3 -> A=4/B=5/C=6 path created by Hive after renamePartition: /path/a=4/b=5/c=6 and SparkSQL rename it /path/A=4/B=5/C=6, and this pr will delete

[GitHub] spark pull request #13300: [SPARK-15463][SQL] support creating dataframe out...

2017-01-25 Thread xwu0226
Github user xwu0226 closed the pull request at: https://github.com/apache/spark/pull/13300 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13300: [SPARK-15463][SQL] support creating dataframe out of Dat...

2017-01-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/13300 This pr seems stale and inactive. I know this kind of API changes has lower priorities now. So, how about closing this pr for now and setting `LATER` in the corresponding JIRA? Thought? cc: @rxin

[GitHub] spark issue #16700: [SPARK-19359][SQL]clear useless path after rename a part...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16700 Yeah, if we having three columns, does your solution resolve all the issues? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #16700: [SPARK-19359][SQL]clear useless path after rename a part...

2017-01-25 Thread windpiger
Github user windpiger commented on the issue: https://github.com/apache/spark/pull/16700 the example showed A/B are two partition columns --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #16700: [SPARK-19359][SQL]clear useless path after rename...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16700#discussion_r97938408 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala --- @@ -120,6 +120,17 @@ object

[GitHub] spark pull request #16700: [SPARK-19359][SQL]clear useless path after rename...

2017-01-25 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16700#discussion_r97938358 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala --- @@ -120,6 +120,17 @@ object

[GitHub] spark issue #16707: [SPARK-19338][SQL] Add UDF names in explain

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16707 **[Test build #72014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72014/testReport)** for PR 16707 at commit

[GitHub] spark issue #16707: [SPARK-19338][SQL] Add UDF names in explain

2017-01-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/16707 It seems the latest test failure does not relate to this pr..., I'll test again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #16707: [SPARK-19338][SQL] Add UDF names in explain

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16707 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16707: [SPARK-19338][SQL] Add UDF names in explain

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16707 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72010/ Test FAILed. ---

[GitHub] spark issue #16707: [SPARK-19338][SQL] Add UDF names in explain

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16707 **[Test build #72010 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72010/testReport)** for PR 16707 at commit

[GitHub] spark pull request #16707: [SPARK-19338][SQL] Add UDF names in explain

2017-01-25 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/16707#discussion_r97937869 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala --- @@ -125,7 +125,7 @@ class UDFRegistration private[sql] (functionRegistry:

[GitHub] spark pull request #16707: [SPARK-19338][SQL] Add UDF names in explain

2017-01-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16707#discussion_r97937744 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala --- @@ -125,7 +125,7 @@ class UDFRegistration private[sql]

[GitHub] spark issue #16707: [SPARK-19338][SQL] Add UDF names in explain

2017-01-25 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16707 LGTM pending jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16707: [SPARK-19338][SQL] Add UDF names in explain

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16707 **[Test build #72013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72013/testReport)** for PR 16707 at commit

[GitHub] spark issue #16308: [SPARK-18936][SQL] Infrastructure for session local time...

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16308 **[Test build #72012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72012/testReport)** for PR 16308 at commit

[GitHub] spark issue #16685: [SPARK-19335] Introduce insert, update, and upsert comma...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16685 Thank you! I prefer to pushing down the UPSERT workloads into the underlying DBMS, but not all the JDBC sources support it. Thus, maybe we can provide users two solutions at the same

[GitHub] spark issue #16674: [SPARK-19331][SQL][TESTS] Improve the test coverage of S...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16674 Happy New Year! : ) I double checked all the test case change. The changes makes sense to me. Could you resolve the conflicts? BTW, a general suggestion. Could you please add

[GitHub] spark issue #16708: [SPARK-19366][SQL] add getNumPartitions to Dataset

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16708 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16708: [SPARK-19366][SQL] add getNumPartitions to Dataset

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16708 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72011/ Test FAILed. ---

[GitHub] spark issue #16708: [SPARK-19366][SQL] add getNumPartitions to Dataset

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16708 **[Test build #72011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72011/testReport)** for PR 16708 at commit

[GitHub] spark issue #16706: [SPARK-19365][Core]Optimize RequestMessage serialization

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16706 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72008/ Test FAILed. ---

[GitHub] spark issue #16706: [SPARK-19365][Core]Optimize RequestMessage serialization

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16706 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16707: [SPARK-19338][SQL] Add UDF names in explain

2017-01-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/16707 Aha, SGTM. I'll fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16706: [SPARK-19365][Core]Optimize RequestMessage serialization

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16706 **[Test build #72008 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72008/testReport)** for PR 16706 at commit

[GitHub] spark issue #16708: [SPARK-19366][SQL] add getNumPartitions to Dataset

2017-01-25 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16708 Actually - why do we need this? I worry it can be a confusing API due to optimizer behavior. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #16708: [SPARK-19366][SQL] add getNumPartitions to Dataset

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16708 **[Test build #72011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72011/testReport)** for PR 16708 at commit

[GitHub] spark pull request #16708: [SPARK-19366][SQL] add getNumPartitions to Datase...

2017-01-25 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16708#discussion_r97935710 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2421,6 +2421,13 @@ class Dataset[T] private[sql]( } /** +

[GitHub] spark issue #16707: [SPARK-19338][SQL] Add UDF names in explain

2017-01-25 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16707 Maybe add a prefix so it is clear a UDF? e.g. `UDF:func_name(...)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #16708: [SPARK-19366][SQL] add getNumPartitions to Datase...

2017-01-25 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/16708 [SPARK-19366][SQL] add getNumPartitions to Dataset ## What changes were proposed in this pull request? As suggested by @cloud-fan

[GitHub] spark pull request #16308: [SPARK-18936][SQL] Infrastructure for session loc...

2017-01-25 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r97935192 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -250,6 +252,8 @@ class Dataset[T] private[sql]( val hasMoreData =

[GitHub] spark pull request #16688: [TESTS][SQL] Setup testdata at the beginning for ...

2017-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16688 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16688: [TESTS][SQL] Setup testdata at the beginning for tests t...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16688 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #16308: [SPARK-18936][SQL] Infrastructure for session loc...

2017-01-25 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r97934467 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala --- @@ -177,180 +177,186 @@ class DateTimeUtilsSuite

[GitHub] spark pull request #16308: [SPARK-18936][SQL] Infrastructure for session loc...

2017-01-25 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r97934459 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala --- @@ -107,108 +109,119 @@ class CastSuite extends

[GitHub] spark pull request #16308: [SPARK-18936][SQL] Infrastructure for session loc...

2017-01-25 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r97934309 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1056,7 +1057,8 @@ object DecimalAggregates extends

[GitHub] spark pull request #16308: [SPARK-18936][SQL] Infrastructure for session loc...

2017-01-25 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r97934297 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -490,7 +569,11 @@ abstract class UnixTime

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16603 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72009/ Test PASSed. ---

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16603 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16308: [SPARK-18936][SQL] Infrastructure for session loc...

2017-01-25 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r97934304 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1044,7 +1044,8 @@ object DecimalAggregates extends

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16603 **[Test build #72009 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72009/testReport)** for PR 16603 at commit

[GitHub] spark issue #16700: [SPARK-19359][SQL]clear useless path after rename a part...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16700 What happens if the partitioning columns have more than two columns? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #16700: [SPARK-19359][SQL]clear useless path after rename...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16700#discussion_r97933750 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala --- @@ -120,6 +120,17 @@ object

[GitHub] spark pull request #16700: [SPARK-19359][SQL]clear useless path after rename...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16700#discussion_r97933674 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala --- @@ -120,6 +120,17 @@ object

[GitHub] spark issue #16696: [SPARK-19350] [SQL] Cardinality estimation of Limit and ...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16696 Overall looks good to me. : ) Could you add a few more test cases? - One is the child has less row counts than the limit. - Another is having zero row counts but `sizeInBytes` is

[GitHub] spark pull request #16696: [SPARK-19350] [SQL] Cardinality estimation of Lim...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16696#discussion_r97933241 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala --- @@ -18,12 +18,41 @@ package

[GitHub] spark pull request #16696: [SPARK-19350] [SQL] Cardinality estimation of Lim...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16696#discussion_r97933222 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala --- @@ -18,12 +18,41 @@ package

[GitHub] spark pull request #16696: [SPARK-19350] [SQL] Cardinality estimation of Lim...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16696#discussion_r97933132 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala --- @@ -48,6 +77,14 @@ class

[GitHub] spark issue #16707: [SPARK-19338][SQL] Add UDF names in explain

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16707 **[Test build #72010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72010/testReport)** for PR 16707 at commit

[GitHub] spark pull request #16707: [SPARK-19338][SQL] Add UDF names in explain

2017-01-25 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/16707 [SPARK-19338][SQL] Add UDF names in explain ## What changes were proposed in this pull request? This pr added a variable for a UDF name in `ScalaUDF`. Then, if the variable filled,

[GitHub] spark pull request #16696: [SPARK-19350] [SQL] Cardinality estimation of Lim...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16696#discussion_r97933053 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala --- @@ -48,6 +77,14 @@ class

[GitHub] spark pull request #16696: [SPARK-19350] [SQL] Cardinality estimation of Lim...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16696#discussion_r97932867 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala --- @@ -18,12 +18,41 @@ package

[GitHub] spark issue #16387: [SPARK-18986][Core] ExternalAppendOnlyMap shouldn't fail...

2017-01-25 Thread samkum
Github user samkum commented on the issue: https://github.com/apache/spark/pull/16387 ok..I will get back to you in next couple of days. -Sameer. On Thu, Jan 26, 2017 at 3:56 AM, Marcelo Vanzin wrote: > Nope, I didn't tested it

[GitHub] spark pull request #16696: [SPARK-19350] [SQL] Cardinality estimation of Lim...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16696#discussion_r97932053 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -727,37 +728,18 @@ case class

[GitHub] spark pull request #16696: [SPARK-19350] [SQL] Cardinality estimation of Lim...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16696#discussion_r97932007 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -727,37 +728,18 @@ case class

[GitHub] spark pull request #16696: [SPARK-19350] [SQL] Cardinality estimation of Lim...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16696#discussion_r97931646 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -791,12 +773,14 @@ case class

[GitHub] spark pull request #16696: [SPARK-19350] [SQL] Cardinality estimation of Lim...

2017-01-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16696#discussion_r97931570 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala --- @@ -29,6 +31,8 @@ object

[GitHub] spark pull request #16696: [SPARK-19350] [SQL] Cardinality estimation of Lim...

2017-01-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16696#discussion_r97928605 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -727,37 +728,18 @@ case class

[GitHub] spark issue #16689: [SPARK-19342][SPARKR] bug fixed in collect method for co...

2017-01-25 Thread titicaca
Github user titicaca commented on the issue: https://github.com/apache/spark/pull/16689 I have modified the codes and tests, including the existed tests @test_sparkSQL.R#1280 and @test_sparkSQL.R#1282. Like in local R, now NA column of the SparkDataFrame will also be

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16603 **[Test build #72009 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72009/testReport)** for PR 16603 at commit

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-25 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16603 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16603 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72006/ Test FAILed. ---

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16603 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16603 **[Test build #72006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72006/testReport)** for PR 16603 at commit

[GitHub] spark issue #15237: [SPARK-17663] [CORE] SchedulableBuilder should handle in...

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15237 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72005/ Test PASSed. ---

[GitHub] spark issue #15237: [SPARK-17663] [CORE] SchedulableBuilder should handle in...

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15237 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15237: [SPARK-17663] [CORE] SchedulableBuilder should handle in...

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15237 **[Test build #72005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72005/testReport)** for PR 15237 at commit

[GitHub] spark pull request #16706: [SPARK-19365][Core]Optimize RequestMessage serial...

2017-01-25 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16706#discussion_r97921119 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala --- @@ -501,34 +498,105 @@ private[netty] class NettyRpcEndpointRef(

[GitHub] spark pull request #16706: [SPARK-19365][Core]Optimize RequestMessage serial...

2017-01-25 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16706#discussion_r97920967 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala --- @@ -480,16 +480,13 @@ private[rpc] class NettyRpcEnvFactory extends

[GitHub] spark issue #16706: [SPARK-19365][Core]Optimize RequestMessage serialization

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16706 **[Test build #72008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72008/testReport)** for PR 16706 at commit

[GitHub] spark pull request #16706: [SPARK-19365][Core]Optimize RequestMessage serial...

2017-01-25 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16706#discussion_r97920768 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala --- @@ -501,34 +498,105 @@ private[netty] class NettyRpcEndpointRef(

[GitHub] spark pull request #16706: [SPARK-19365][Core]Optimize RequestMessage serial...

2017-01-25 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/16706 [SPARK-19365][Core]Optimize RequestMessage serialization ## What changes were proposed in this pull request? Right now Netty PRC serializes `RequestMessage` using Java serialization, and

[GitHub] spark pull request #16213: [SPARK-18020][Streaming][Kinesis] Checkpoint SHAR...

2017-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16213: [SPARK-18020][Streaming][Kinesis] Checkpoint SHARD_END t...

2017-01-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/16213 great, haha! Many thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15237: [SPARK-17663] [CORE] SchedulableBuilder should handle in...

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15237 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15237: [SPARK-17663] [CORE] SchedulableBuilder should handle in...

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15237 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72004/ Test PASSed. ---

[GitHub] spark issue #16213: [SPARK-18020][Streaming][Kinesis] Checkpoint SHARD_END t...

2017-01-25 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/16213 Thanks a lot! Merging to master! (May take a while, going to be my first merge!) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #15237: [SPARK-17663] [CORE] SchedulableBuilder should handle in...

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15237 **[Test build #72004 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72004/testReport)** for PR 15237 at commit

[GitHub] spark pull request #16545: [SPARK-19166][SQL]rename from InsertIntoHadoopFsR...

2017-01-25 Thread windpiger
Github user windpiger closed the pull request at: https://github.com/apache/spark/pull/16545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16213: [SPARK-18020][Streaming][Kinesis] Checkpoint SHARD_END t...

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16213 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72007/ Test PASSed. ---

[GitHub] spark issue #16213: [SPARK-18020][Streaming][Kinesis] Checkpoint SHARD_END t...

2017-01-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16213 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16213: [SPARK-18020][Streaming][Kinesis] Checkpoint SHARD_END t...

2017-01-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16213 **[Test build #72007 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72007/testReport)** for PR 16213 at commit

[GitHub] spark issue #16213: [SPARK-18020][Streaming][Kinesis] Checkpoint SHARD_END t...

2017-01-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/16213 Many thanks! Also, congrats, commiter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16702: [SPARK-18495][UI] Document meaning of green dot i...

2017-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16702 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16702: [SPARK-18495][UI] Document meaning of green dot in DAG v...

2017-01-25 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16702 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #15396: [SPARK-14804][Spark][Graphx] Fix checkpointing of...

2017-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15396 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16685: [SPARK-19335] Introduce insert, update, and upsert comma...

2017-01-25 Thread ilganeli
Github user ilganeli commented on the issue: https://github.com/apache/spark/pull/16685 @gatorsmile I'll submit a PR with just the UPDATE functionality, how do you suggest proceeding on the UPSERT front? --- If your project is set up for it, you can reply to this email and have

  1   2   3   4   >