Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16868
BTW: Hive can allow location of external table to be same as the source
table. Can you please try that ? It should work. In the test case validations I
see this check which will fail in such
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16868
You have good coverage for DDL statements. How about a test case for
reading from external table creating using the command this PR enables ?
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16672
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72759/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16672
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16672
**[Test build #72759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72759/testReport)**
for PR 16672 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16868
Please update the PR description. This statement can be used for data
source tables too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685218
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -969,15 +1053,19 @@ class HiveDDLSuite
val
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72760/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16777
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72760 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72760/testReport)**
for PR 16777 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685186
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -926,38 +993,55 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685175
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -926,38 +993,55 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685183
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -891,32 +932,58 @@ class HiveDDLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685179
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -926,38 +993,55 @@ class HiveDDLSuite
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16870
`format` could also be invalid. Since the model we are going with is to
return `null` for bad inputs, the same could be done for `format`. Please add a
test case for this.
---
If your project
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685148
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -833,54 +833,95 @@ class HiveDDLSuite
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685152
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -833,54 +833,95 @@ class HiveDDLSuite
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685143
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -833,54 +833,95 @@ class HiveDDLSuite
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685138
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -833,54 +833,95 @@ class HiveDDLSuite
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685120
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -70,12 +71,19 @@ case class CreateTableLikeCommand(
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16890
@muyannian Could you click the "Close pull request" button below?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685105
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -70,12 +71,19 @@ case class CreateTableLikeCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100685099
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -70,12 +71,19 @@ case class CreateTableLikeCommand(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16882
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100685083
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSQLViewSuite.scala
---
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16882
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72756/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16882
**[Test build #72756 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72756/testReport)**
for PR 16882 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100684983
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ---
@@ -452,311 +534,96 @@ class SQLViewSuite extends QueryTest with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16620
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72757/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16620
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16620
**[Test build #72757 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72757/testReport)**
for PR 16620 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16832
**[Test build #72763 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72763/testReport)**
for PR 16832 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r100684516
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -617,13 +617,17 @@ class Analyzer(
private
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16787
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16787
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16832
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72758/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16832
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16832
**[Test build #72758 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72758/testReport)**
for PR 16832 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16787
Thank you very much! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/16672
yes, let me add these test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100684307
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1431,4 +1431,30 @@ class HiveDDLSuite
}
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16787
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16787
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72754/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16787
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72753/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16787
**[Test build #72754 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72754/testReport)**
for PR 16787 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16787
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16787
**[Test build #72753 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72753/testReport)**
for PR 16787 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
The test case also can check another INSERT mode. INSERT OVERWRITE? Also
verifying the behaviors for Hive Serde tables?
---
If your project is set up for it, you can reply to this email and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
More test cases for non pre-existing locations? For example, INESRT without
an ALTER LOCATION? You can simply drop the directory. This scenario is
reasonable when the table is external.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16724
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72751/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16724
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100684204
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1431,4 +1431,30 @@ class HiveDDLSuite
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16724
**[Test build #72751 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72751/testReport)**
for PR 16724 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
: ) `success` is a noun and `exist` is a verb.
`insert/read data to a not exist location datasource table should success`
-> `Reading from or writing to a data-source table with a non
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16832
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72755/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16832
**[Test build #72755 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72755/testReport)**
for PR 16832 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16832
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72762 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72762/testReport)**
for PR 16777 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16777
@cloud-fan, I just addressed your comments and test a build with Scala 2.10.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16776#discussion_r100684044
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -63,44 +63,49 @@ final class DataFrameStatFunctions
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16776#discussion_r100684027
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -58,49 +58,56 @@ final class DataFrameStatFunctions
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16620
**[Test build #72761 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72761/testReport)**
for PR 16620 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16882#discussion_r100683913
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,7 +116,7 @@ object TypeCoercion {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16777
**[Test build #72760 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72760/testReport)**
for PR 16777 at commit
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16870#discussion_r100683849
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -95,9 +95,10 @@ object DateTimeUtils {
sdf
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16672
**[Test build #72759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72759/testReport)**
for PR 16672 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15125
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15125
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72748/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15125
**[Test build #72748 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72748/testReport)**
for PR 15125 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16832
**[Test build #72758 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72758/testReport)**
for PR 16832 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16895
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72749/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16895
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16895
**[Test build #72749 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72749/testReport)**
for PR 16895 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16620
**[Test build #72757 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72757/testReport)**
for PR 16620 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16882
**[Test build #72756 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72756/testReport)**
for PR 16882 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16832
**[Test build #72755 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72755/testReport)**
for PR 16832 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16882#discussion_r100683242
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -116,7 +116,7 @@ object TypeCoercion {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16672
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16672
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72746/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16672
**[Test build #72746 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72746/testReport)**
for PR 16672 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16787
**[Test build #72754 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72754/testReport)**
for PR 16787 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16787
**[Test build #72753 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72753/testReport)**
for PR 16787 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16787
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16787
**[Test build #72752 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72752/testReport)**
for PR 16787 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16787
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72752/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16787
**[Test build #72752 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72752/testReport)**
for PR 16787 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16868
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16868
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72745/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16868
**[Test build #72745 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72745/testReport)**
for PR 16868 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16832
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72750/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16832
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16832
**[Test build #72750 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72750/testReport)**
for PR 16832 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16897
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user yucai opened a pull request:
https://github.com/apache/spark/pull/16897
Remove two useless blank lines in HashJoin.scala
## What changes were proposed in this pull request?
Remove two useless blank lines in HashJoin.scala
## How was this patch tested?
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16724
**[Test build #72751 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72751/testReport)**
for PR 16724 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100682391
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1690,6 +1690,16 @@ class DDLSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100682360
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100682316
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100682314
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
The changes in this PR affects both read and write paths. Please update the
PR description and title. Thanks!
---
If your project is set up for it, you can reply to this email and have your
1 - 100 of 248 matches
Mail list logo
