[GitHub] spark issue #17307: [SPARK-13369] Make number of consecutive fetch failures ...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17307 **[Test build #74624 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74624/testReport)** for PR 17307 at commit [`88800fa`](https://github.com/apache/spark/commit/88

[GitHub] spark pull request #17307: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/17307#discussion_r106305175 --- Diff: docs/configuration.md --- @@ -1506,6 +1506,11 @@ Apart from these, the following properties are also available, and may be useful o

[GitHub] spark issue #17307: [SPARK-13369] Make number of consecutive fetch failures ...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17307 **[Test build #74623 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74623/testReport)** for PR 17307 at commit [`6767a68`](https://github.com/apache/spark/commit/67

[GitHub] spark pull request #17307: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/17307#discussion_r106304743 --- Diff: docs/configuration.md --- @@ -1506,6 +1506,11 @@ Apart from these, the following properties are also available, and may be useful of t

[GitHub] spark pull request #17307: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/17307#discussion_r106304656 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -187,6 +187,11 @@ class DAGScheduler( /** If enabled, FetchFail

[GitHub] spark pull request #17307: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/17307#discussion_r106304720 --- Diff: core/src/main/scala/org/apache/spark/scheduler/ResultStage.scala --- @@ -34,8 +34,10 @@ private[spark] class ResultStage( val partitio

[GitHub] spark pull request #17307: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/17307#discussion_r106304670 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -187,6 +187,11 @@ class DAGScheduler( /** If enabled, FetchFail

[GitHub] spark pull request #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage polic...

2017-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15604 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage policies tes...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on the issue: https://github.com/apache/spark/pull/15604 Thanks for your work on this @erenavsarogullari. I've merged this into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #15770: [SPARK-15784][ML]:Add Power Iteration Clustering to spar...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15770 **[Test build #74622 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74622/testReport)** for PR 15770 at commit [`c938758`](https://github.com/apache/spark/commit/c9

[GitHub] spark issue #17282: [SPARK-19872][PYTHON] Use the correct deserializer for R...

2017-03-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17282 Thank you both @davies and @viirya --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark issue #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage policies tes...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15604 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74616/ Test PASSed. ---

[GitHub] spark issue #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage policies tes...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15604 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage policies tes...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15604 **[Test build #74616 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74616/testReport)** for PR 15604 at commit [`f13ad3d`](https://github.com/apache/spark/commit/f

[GitHub] spark pull request #16341: [SQL] [WIP] Switch internal catalog types to use ...

2017-03-15 Thread ericl
Github user ericl closed the pull request at: https://github.com/apache/spark/pull/16341 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark issue #17268: [SPARK-19932][SS] Also save event time into StateStore f...

2017-03-15 Thread marmbrus
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/17268 Sorry, I wasn't suggestion we mandate this. There may be use cases where users are okay deduping a short lived stream w/o a watermark. I'm only saying the timestamp is mandatory for the watermark

[GitHub] spark pull request #15363: [SPARK-17791][SQL] Join reordering using star sch...

2017-03-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15363#discussion_r106298859 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -51,6 +51,11 @@ case class CostBasedJoin

[GitHub] spark issue #15363: [SPARK-17791][SQL] Join reordering using star schema det...

2017-03-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15363 See [the list of paper that cited K. Ono](https://scholar.google.com/scholar?start=0&hl=en&as_sdt=0,5&sciodt=0,5&cites=5144610119819043766&scipsc=) of `Measuring the Complexity of Join Enumeratio

[GitHub] spark pull request #17307: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/17307#discussion_r106298407 --- Diff: docs/configuration.md --- @@ -1506,6 +1506,11 @@ Apart from these, the following properties are also available, and may be useful o

[GitHub] spark pull request #17307: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/17307#discussion_r106298013 --- Diff: core/src/main/scala/org/apache/spark/scheduler/ResultStage.scala --- @@ -34,8 +34,10 @@ private[spark] class ResultStage( val parti

[GitHub] spark pull request #17307: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/17307#discussion_r106298195 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -187,6 +187,11 @@ class DAGScheduler( /** If enabled, FetchF

[GitHub] spark pull request #17307: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/17307#discussion_r106298559 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -187,6 +187,11 @@ class DAGScheduler( /** If enabled, FetchF

[GitHub] spark issue #17307: [SPARK-13369] Make number of consecutive fetch failures ...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17307 **[Test build #74621 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74621/testReport)** for PR 17307 at commit [`bd4eadb`](https://github.com/apache/spark/commit/bd

[GitHub] spark pull request #17307: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/17307#discussion_r106297978 --- Diff: core/src/main/scala/org/apache/spark/scheduler/ShuffleMapStage.scala --- @@ -41,9 +41,10 @@ private[spark] class ShuffleMapStage( n

[GitHub] spark pull request #17307: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/17307#discussion_r106297948 --- Diff: core/src/main/scala/org/apache/spark/scheduler/Stage.scala --- @@ -59,6 +59,7 @@ private[scheduler] abstract class Stage( val numTas

[GitHub] spark issue #17216: [SPARK-19873][SS] Record num shuffle partitions in offse...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17216 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17216: [SPARK-19873][SS] Record num shuffle partitions in offse...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17216 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74617/ Test PASSed. ---

[GitHub] spark issue #17216: [SPARK-19873][SS] Record num shuffle partitions in offse...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17216 **[Test build #74617 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74617/testReport)** for PR 17216 at commit [`dfae7be`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #17307: [SPARK-13369] Make number of consecutive fetch failures ...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17307 **[Test build #74619 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74619/testReport)** for PR 17307 at commit [`67d4ce4`](https://github.com/apache/spark/commit/67

[GitHub] spark issue #16905: [SPARK-19567][CORE][SCHEDULER] Support some Schedulable ...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16905 **[Test build #74620 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74620/testReport)** for PR 16905 at commit [`18657d4`](https://github.com/apache/spark/commit/18

[GitHub] spark issue #11254: [SPARK-13369] Make number of consecutive fetch failures ...

2017-03-15 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/11254 @squito, @kayousterhout - Sorry, I accidentally deleted the old branch. Created a new PR https://github.com/apache/spark/pull/17307 with suggested change. --- If your project is set up for it,

[GitHub] spark issue #17235: [SPARK-19320][MESOS][WIP]allow specifying a hard limit o...

2017-03-15 Thread klueska
Github user klueska commented on the issue: https://github.com/apache/spark/pull/17235 Can you give a bit more context on what this new parameter is supposed to enforce? Maybe it's just the same of the parameter that's confusing me. --- If your project is set up for it, you can reply

[GitHub] spark issue #16905: [SPARK-19567][CORE][SCHEDULER] Support some Schedulable ...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on the issue: https://github.com/apache/spark/pull/16905 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16905: [SPARK-19567][CORE][SCHEDULER] Support some Schedulable ...

2017-03-15 Thread erenavsarogullari
Github user erenavsarogullari commented on the issue: https://github.com/apache/spark/pull/16905 Thanks @kayousterhout and @squito for review this ;) Last comment is also addressed via last commit: 18657d4. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request #11254: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread sitalkedia
Github user sitalkedia closed the pull request at: https://github.com/apache/spark/pull/11254 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17273: [MINOR][CORE] Fix a info message of `prunePartitions`

2017-03-15 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17273 Thank you, @rxin and @srowen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request #17273: [MINOR][CORE] Fix a info message of `prunePartiti...

2017-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #17303: [SPARK-19112][CORE] add codec for ZStandard

2017-03-15 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17303 Yes it'd be nice to have some benchmark on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark issue #17273: [MINOR][CORE] Fix a info message of `prunePartitions` in...

2017-03-15 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17273 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #17304: [SPARK-19960][CORE] Move `SparkHadoopWriter` to `...

2017-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17304 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #11254: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/11254#discussion_r106293790 --- Diff: core/src/main/scala/org/apache/spark/scheduler/Stage.scala --- @@ -118,7 +119,7 @@ private[scheduler] abstract class Stage( */

[GitHub] spark issue #16541: [SPARK-19088][SQL] Optimize sequence type deserializatio...

2017-03-15 Thread michalsenkyr
Github user michalsenkyr commented on the issue: https://github.com/apache/spark/pull/16541 That seems to be the case here, yes. What about the other benefits I mentioned (adding support for Java `List`s and future Scala 2.13 compatibility)? I think the codegen is also more s

[GitHub] spark issue #17304: [SPARK-19960][CORE] Move `SparkHadoopWriter` to `interna...

2017-03-15 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17304 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #17113: [SPARK-13669][Core] Improve the blacklist mechanism to h...

2017-03-15 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17113 sorry i was vague -- I'm saying I'm ok with this as long as its (a) off by default and (b) experimental so we can change it around (which it is). --- If your project is set up for it, you can reply

[GitHub] spark pull request #11254: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/11254#discussion_r106292588 --- Diff: core/src/main/scala/org/apache/spark/scheduler/Stage.scala --- @@ -58,6 +58,7 @@ private[scheduler] abstract class Stage( val numTas

[GitHub] spark pull request #11254: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/11254#discussion_r106292533 --- Diff: core/src/main/scala/org/apache/spark/scheduler/Stage.scala --- @@ -145,6 +146,6 @@ private[scheduler] abstract class Stage( }

[GitHub] spark pull request #11254: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/11254#discussion_r106292014 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -180,6 +180,11 @@ class DAGScheduler( /** If enabled, FetchF

[GitHub] spark issue #11254: [SPARK-13369] Make number of consecutive fetch failures ...

2017-03-15 Thread kayousterhout
Github user kayousterhout commented on the issue: https://github.com/apache/spark/pull/11254 GIven discussion with @sitalkedia on other PRs I agree that it makes sense to add now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] spark issue #17113: [SPARK-13669][Core] Improve the blacklist mechanism to h...

2017-03-15 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/17113 > Another thing I thought about as I was reviewing this -- spark currently assumes that a fetchfailure is always the fault of the source, never the destination. I almost wonder if we should count

[GitHub] spark pull request #11254: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11254#discussion_r106289378 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -180,6 +180,11 @@ class DAGScheduler( /** If enabled, FetchFailed w

[GitHub] spark pull request #11254: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11254#discussion_r106289559 --- Diff: docs/configuration.md --- @@ -1157,6 +1157,13 @@ Apart from these, the following properties are also available, and may be useful Should b

[GitHub] spark pull request #15363: [SPARK-17791][SQL] Join reordering using star sch...

2017-03-15 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/15363#discussion_r106290042 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -51,6 +51,11 @@ case class CostBasedJoinReord

[GitHub] spark issue #17273: [MINOR][CORE] Fix a info message of `prunePartitions` in...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17273 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74615/ Test PASSed. ---

[GitHub] spark issue #17273: [MINOR][CORE] Fix a info message of `prunePartitions` in...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17273 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #11254: [SPARK-13369] Make number of consecutive fetch failures ...

2017-03-15 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/11254 @squito - Thanks for taking a look. I am working on resolving the conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark pull request #11254: [SPARK-13369] Make number of consecutive fetch fa...

2017-03-15 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11254#discussion_r106289060 --- Diff: core/src/main/scala/org/apache/spark/scheduler/Stage.scala --- @@ -118,7 +119,7 @@ private[scheduler] abstract class Stage( */ privat

[GitHub] spark issue #17273: [MINOR][CORE] Fix a info message of `prunePartitions` in...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17273 **[Test build #74615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74615/testReport)** for PR 17273 at commit [`33d24ba`](https://github.com/apache/spark/commit/3

[GitHub] spark pull request #17113: [SPARK-13669][Core] Improve the blacklist mechani...

2017-03-15 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/17113#discussion_r106287979 --- Diff: docs/configuration.md --- @@ -1411,6 +1411,15 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark issue #11254: [SPARK-13369] Make number of consecutive fetch failures ...

2017-03-15 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/11254 sorry this has sat around so long, I agree this is useful following up on discussion here: https://github.com/apache/spark/pull/17088 I'd reword the description to something more like this:

[GitHub] spark pull request #15363: [SPARK-17791][SQL] Join reordering using star sch...

2017-03-15 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/15363#discussion_r106285527 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -51,6 +51,11 @@ case class CostBasedJoinReor

[GitHub] spark pull request #17216: [SPARK-19873][SS] Record num shuffle partitions i...

2017-03-15 Thread kunalkhamar
Github user kunalkhamar commented on a diff in the pull request: https://github.com/apache/spark/pull/17216#discussion_r106285230 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -380,7 +387,27 @@ class StreamExecution(

[GitHub] spark issue #17306: [MLLIB] Allow multiple pipelines when tuning

2017-03-15 Thread leifker
Github user leifker commented on the issue: https://github.com/apache/spark/pull/17306 Looking over the contributing link, I should open a jira issue it seems? The intent is like you said, to run the CrossValidator with different pipelines. The same could be done usin

[GitHub] spark pull request #15363: [SPARK-17791][SQL] Join reordering using star sch...

2017-03-15 Thread ioana-delaney
Github user ioana-delaney commented on a diff in the pull request: https://github.com/apache/spark/pull/15363#discussion_r106282966 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -51,6 +51,11 @@ case class CostBasedJ

[GitHub] spark issue #17302: [SPARK-19959][SQL] Fix to throw NullPointerException in ...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17302 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74614/ Test FAILed. ---

[GitHub] spark issue #17302: [SPARK-19959][SQL] Fix to throw NullPointerException in ...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17302 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17302: [SPARK-19959][SQL] Fix to throw NullPointerException in ...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17302 **[Test build #74614 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74614/testReport)** for PR 17302 at commit [`2deeba8`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage policies tes...

2017-03-15 Thread erenavsarogullari
Github user erenavsarogullari commented on the issue: https://github.com/apache/spark/pull/15604 Many thanks @kayousterhout for reviewing this again. Last comment has also been addressed. Also the following Jira has been created for previous second UT failure. https://issu

[GitHub] spark pull request #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage polic...

2017-03-15 Thread erenavsarogullari
Github user erenavsarogullari commented on a diff in the pull request: https://github.com/apache/spark/pull/15604#discussion_r106280052 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala --- @@ -191,7 +191,10 @@ private[spark] class FairSchedulableBui

[GitHub] spark issue #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage policies tes...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15604 **[Test build #74618 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74618/testReport)** for PR 15604 at commit [`b7f2629`](https://github.com/apache/spark/commit/b7

[GitHub] spark issue #17088: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-03-15 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/17088 >> Its clear to me there is an important reason why users would want a higher limit, so lets make it a config. @squito - I already have a PR (very old) to do that - can you take a look

[GitHub] spark issue #17216: [SPARK-19873][SS] Record num shuffle partitions in offse...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17216 **[Test build #74617 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74617/testReport)** for PR 17216 at commit [`dfae7be`](https://github.com/apache/spark/commit/df

[GitHub] spark pull request #17216: [SPARK-19873][SS] Record num shuffle partitions i...

2017-03-15 Thread kunalkhamar
Github user kunalkhamar commented on a diff in the pull request: https://github.com/apache/spark/pull/17216#discussion_r106269036 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -389,6 +392,102 @@ class StreamSuite extends StreamTest {

[GitHub] spark pull request #17216: [SPARK-19873][SS] Record num shuffle partitions i...

2017-03-15 Thread kunalkhamar
Github user kunalkhamar commented on a diff in the pull request: https://github.com/apache/spark/pull/17216#discussion_r106266808 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -380,7 +387,27 @@ class StreamExecution(

[GitHub] spark issue #17088: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-03-15 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17088 first, I think we should change the hard-coded limit of 4 stage retries. Its clear to me there is an important reason why users would want a higher limit, so lets make it a config. That is a very s

[GitHub] spark pull request #17216: [SPARK-19873][SS] Record num shuffle partitions i...

2017-03-15 Thread kunalkhamar
Github user kunalkhamar commented on a diff in the pull request: https://github.com/apache/spark/pull/17216#discussion_r106269742 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -389,6 +392,102 @@ class StreamSuite extends StreamTest {

[GitHub] spark pull request #17216: [SPARK-19873][SS] Record num shuffle partitions i...

2017-03-15 Thread kunalkhamar
Github user kunalkhamar commented on a diff in the pull request: https://github.com/apache/spark/pull/17216#discussion_r106269427 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -389,6 +392,102 @@ class StreamSuite extends StreamTest {

[GitHub] spark pull request #17216: [SPARK-19873][SS] Record num shuffle partitions i...

2017-03-15 Thread kunalkhamar
Github user kunalkhamar commented on a diff in the pull request: https://github.com/apache/spark/pull/17216#discussion_r106269722 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -389,6 +392,102 @@ class StreamSuite extends StreamTest {

[GitHub] spark pull request #17216: [SPARK-19873][SS] Record num shuffle partitions i...

2017-03-15 Thread kunalkhamar
Github user kunalkhamar commented on a diff in the pull request: https://github.com/apache/spark/pull/17216#discussion_r106266038 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -389,6 +392,102 @@ class StreamSuite extends StreamTest {

[GitHub] spark pull request #17216: [SPARK-19873][SS] Record num shuffle partitions i...

2017-03-15 Thread kunalkhamar
Github user kunalkhamar commented on a diff in the pull request: https://github.com/apache/spark/pull/17216#discussion_r106267528 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -437,25 +464,28 @@ class StreamExecution(

[GitHub] spark pull request #15363: [SPARK-17791][SQL] Join reordering using star sch...

2017-03-15 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/15363#discussion_r106271250 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -51,6 +51,11 @@ case class CostBasedJoinReor

[GitHub] spark issue #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage policies tes...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15604 **[Test build #74616 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74616/testReport)** for PR 15604 at commit [`f13ad3d`](https://github.com/apache/spark/commit/f1

[GitHub] spark issue #17273: [MINOR][CORE] Fix a info message of `prunePartitions` in...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17273 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17273: [MINOR][CORE] Fix a info message of `prunePartitions` in...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17273 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74613/ Test PASSed. ---

[GitHub] spark issue #17273: [MINOR][CORE] Fix a info message of `prunePartitions` in...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17273 **[Test build #74613 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74613/testReport)** for PR 17273 at commit [`21fdea1`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #16781: [SPARK-12297][SQL] Hive compatibility for Parquet Timest...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16781 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74611/ Test PASSed. ---

[GitHub] spark issue #16781: [SPARK-12297][SQL] Hive compatibility for Parquet Timest...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16781 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17273: [MINOR][CORE] Fix a info message of `prunePartitions` in...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17273 **[Test build #74615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74615/testReport)** for PR 17273 at commit [`33d24ba`](https://github.com/apache/spark/commit/33

[GitHub] spark issue #16781: [SPARK-12297][SQL] Hive compatibility for Parquet Timest...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16781 **[Test build #74611 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74611/testReport)** for PR 16781 at commit [`d951443`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #17302: [SPARK-19959][SQL] Fix to throw NullPointerException in ...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17302 **[Test build #74614 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74614/testReport)** for PR 17302 at commit [`2deeba8`](https://github.com/apache/spark/commit/2d

[GitHub] spark issue #17302: [SPARK-19959][SQL] Fix to throw NullPointerException in ...

2017-03-15 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/17302 jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] spark issue #17273: [MINOR][CORE] Fix a info message of `prunePartitions` in...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17273 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74612/ Test PASSed. ---

[GitHub] spark issue #17273: [MINOR][CORE] Fix a info message of `prunePartitions` in...

2017-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17273 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17273: [MINOR][CORE] Fix a info message of `prunePartitions` in...

2017-03-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17273 **[Test build #74612 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74612/testReport)** for PR 17273 at commit [`85d818f`](https://github.com/apache/spark/commit/8

[GitHub] spark pull request #16909: [SPARK-13450] Introduce ExternalAppendOnlyUnsafeR...

2017-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16909 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #16909: [SPARK-13450] Introduce ExternalAppendOnlyUnsafeRowArray...

2017-03-15 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16909 LGTM - merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...

2017-03-15 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/15009#discussion_r106258149 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -735,7 +749,12 @@ object SparkSubmit extends CommandLineUtils { }

[GitHub] spark issue #17297: [SPARK-14649][CORE] DagScheduler should not run duplicat...

2017-03-15 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/17297 @kayousterhout - I understand your concern and I agree that canceling the running tasks is definitely a simpler approach, but this is very inefficient for large jobs where tasks can run for hours

[GitHub] spark pull request #15363: [SPARK-17791][SQL] Join reordering using star sch...

2017-03-15 Thread ioana-delaney
Github user ioana-delaney commented on a diff in the pull request: https://github.com/apache/spark/pull/15363#discussion_r106255224 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -51,6 +51,11 @@ case class CostBasedJ

[GitHub] spark pull request #17113: [SPARK-13669][Core] Improve the blacklist mechani...

2017-03-15 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17113#discussion_r106249028 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala --- @@ -1039,6 +1039,40 @@ class TaskSetManagerSuite extends SparkFunSuite

[GitHub] spark pull request #17113: [SPARK-13669][Core] Improve the blacklist mechani...

2017-03-15 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17113#discussion_r106246809 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -145,6 +146,63 @@ private[scheduler] class BlacklistTracker (

<    1   2   3   4   5   6   >