[GitHub] spark issue #17574: [SPARK-20264][SQL] asm should be non-test dependency in ...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17574 **[Test build #75618 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75618/testReport)** for PR 17574 at commit

[GitHub] spark pull request #17574: [SPARK-20264][SQL] asm should be non-test depende...

2017-04-07 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/17574 [SPARK-20264][SQL] asm should be non-test dependency in sql/core ## What changes were proposed in this pull request? sq/core module currently declares asm as a test scope dependency. Transitively

[GitHub] spark pull request #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks ...

2017-04-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17569#discussion_r110510848 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -225,20 +225,28 @@ case class Invoke(

[GitHub] spark pull request #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks ...

2017-04-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17569#discussion_r110510800 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -608,7 +616,7 @@ case class MapObjects

[GitHub] spark pull request #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks ...

2017-04-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17569#discussion_r110510776 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -577,7 +584,7 @@ object ScalaReflection extends

[GitHub] spark pull request #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks ...

2017-04-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17569#discussion_r110510779 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -586,7 +593,7 @@ object ScalaReflection extends

[GitHub] spark pull request #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks ...

2017-04-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17569#discussion_r110510765 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -356,7 +361,8 @@ object ScalaReflection extends

[GitHub] spark pull request #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks ...

2017-04-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17569#discussion_r110510773 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -365,7 +371,8 @@ object ScalaReflection extends

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r110510575 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2230,6 +2230,8 @@ class Analyzer( val

[GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...

2017-04-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17568#discussion_r110510454 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2230,6 +2230,8 @@ class Analyzer( val

[GitHub] spark issue #17573: [SPARK-20262][SQL] AssertNotNull should throw NullPointe...

2017-04-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17573 Thanks! Merging to master/2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #17573: [SPARK-20262][SQL] AssertNotNull should throw Nul...

2017-04-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17562: [SPARK-20246][SQL] should not push predicate down...

2017-04-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17562 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17562: [SPARK-20246][SQL] should not push predicate down throug...

2017-04-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17562 Thanks! Merging to master/2.1/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17573: [SPARK-20262][SQL] AssertNotNull should throw NullPointe...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17573 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75617/ Test PASSed. ---

[GitHub] spark issue #17573: [SPARK-20262][SQL] AssertNotNull should throw NullPointe...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17573 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17573: [SPARK-20262][SQL] AssertNotNull should throw NullPointe...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17573 **[Test build #75617 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75617/testReport)** for PR 17573 at commit

[GitHub] spark issue #17567: [SPARK-19991][CORE][YARN] FileSegmentManagedBuffer perfo...

2017-04-07 Thread witgo
Github user witgo commented on the issue: https://github.com/apache/spark/pull/17567 LGTM. Are there any performance test reports? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17546: [SPARK-20233] [SQL] Apply star-join filter heuristics to...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17546 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17546: [SPARK-20233] [SQL] Apply star-join filter heuristics to...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17546 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75616/ Test PASSed. ---

[GitHub] spark issue #17546: [SPARK-20233] [SQL] Apply star-join filter heuristics to...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17546 **[Test build #75616 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75616/testReport)** for PR 17546 at commit

[GitHub] spark issue #17568: [SPARK-20254][SQL] Remove unnecessary data conversion fo...

2017-04-07 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/17568 @cloud-fan could you please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks of a re...

2017-04-07 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/17569 @cloud-fan could you please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17573: [SPARK-20262][SQL] AssertNotNull should throw Nul...

2017-04-07 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/17573 [SPARK-20262][SQL] AssertNotNull should throw NullPointerException ## What changes were proposed in this pull request? AssertNotNull currently throws RuntimeException. It should throw

[GitHub] spark issue #17573: [SPARK-20262][SQL] AssertNotNull should throw NullPointe...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17573 **[Test build #75617 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75617/testReport)** for PR 17573 at commit

[GitHub] spark issue #17546: [SPARK-20233] [SQL] Apply star-join filter heuristics to...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17546 **[Test build #75616 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75616/testReport)** for PR 17546 at commit

[GitHub] spark pull request #17546: [SPARK-20233] [SQL] Apply star-join filter heuris...

2017-04-07 Thread ioana-delaney
Github user ioana-delaney commented on a diff in the pull request: https://github.com/apache/spark/pull/17546#discussion_r110495345 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -736,6 +736,12 @@ object SQLConf {

[GitHub] spark issue #17469: [SPARK-20132][Docs] Add documentation for column string ...

2017-04-07 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17469 It seems somethine goes wrong with @holdnk and Jenkins. I think I dont have a permission to trigger this. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #17567: [SPARK-19991][CORE][YARN] FileSegmentManagedBuffer perfo...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17567 **[Test build #3646 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3646/testReport)** for PR 17567 at commit

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17527 **[Test build #3647 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3647/testReport)** for PR 17527 at commit

[GitHub] spark issue #17572: String interpolation required for error message

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17572 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17572: String interpolation required for error message

2017-04-07 Thread vijaykramesh
Github user vijaykramesh commented on the issue: https://github.com/apache/spark/pull/17572 I'm not sure if I should open my own jira for this issue or if that is handled by the project maintainers? Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request #17572: String interpolation required for error message

2017-04-07 Thread vijaykramesh
GitHub user vijaykramesh opened a pull request: https://github.com/apache/spark/pull/17572 String interpolation required for error message ## What changes were proposed in this pull request? This error message doesn't get properly formatted because of a missing `s`. Currently

[GitHub] spark issue #17469: [SPARK-20132][Docs] Add documentation for column string ...

2017-04-07 Thread map222
Github user map222 commented on the issue: https://github.com/apache/spark/pull/17469 @HyukjinKwon Do I need to do something to start the Jenkins test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #17570: [SPARK-20255] Move listLeafFiles() to InMemoryFil...

2017-04-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17570: [SPARK-20255] Move listLeafFiles() to InMemoryFileIndex

2017-04-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17570 Merging in master/branch-2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks of a re...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17569 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75614/ Test PASSed. ---

[GitHub] spark issue #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks of a re...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17569 **[Test build #75614 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75614/testReport)** for PR 17569 at commit

[GitHub] spark pull request #17546: [SPARK-20233] [SQL] Apply star-join filter heuris...

2017-04-07 Thread ron8hu
Github user ron8hu commented on a diff in the pull request: https://github.com/apache/spark/pull/17546#discussion_r110480494 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -736,6 +736,12 @@ object SQLConf { .checkValue(weight =>

[GitHub] spark issue #13206: [SPARK-15420] [SQL] Add repartition and sort to prepare ...

2017-04-07 Thread Downchuck
Github user Downchuck commented on the issue: https://github.com/apache/spark/pull/13206 may be fixed in https://github.com/apache/spark/pull/16898 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #17558: [SPARK-20247][CORE] Add jar but this jar is missing late...

2017-04-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17558 agreed, why would the jar be missing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17567: [SPARK-19991][CORE][YARN] FileSegmentManagedBuffer perfo...

2017-04-07 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17567 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #17570: [SPARK-20255] Move listLeafFiles() to InMemoryFileIndex

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17570 **[Test build #3645 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3645/testReport)** for PR 17570 at commit

[GitHub] spark pull request #17546: [SPARK-20233] [SQL] Apply star-join filter heuris...

2017-04-07 Thread ioana-delaney
Github user ioana-delaney commented on a diff in the pull request: https://github.com/apache/spark/pull/17546#discussion_r110466604 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -736,6 +736,12 @@ object SQLConf {

[GitHub] spark pull request #17557: [SPARK-20208][WIP][R][DOCS] Document R fpGrowth s...

2017-04-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17557#discussion_r110465373 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -906,6 +910,24 @@ predicted <- predict(model, df) head(predicted) ``` +

[GitHub] spark pull request #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic re...

2017-04-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic regressio...

2017-04-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17571 merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic regressio...

2017-04-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17571 right, tests don't run example anyway... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17568: [SPARK-20254][SQL] Remove unnecessary data conversion fo...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17568 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17568: [SPARK-20254][SQL] Remove unnecessary data conversion fo...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17568 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75610/ Test PASSed. ---

[GitHub] spark issue #17568: [SPARK-20254][SQL] Remove unnecessary data conversion fo...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17568 **[Test build #75610 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75610/testReport)** for PR 17568 at commit

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17527 **[Test build #3647 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3647/testReport)** for PR 17527 at commit

[GitHub] spark issue #17567: [SPARK-19991][CORE][YARN] FileSegmentManagedBuffer perfo...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17567 **[Test build #3646 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3646/testReport)** for PR 17567 at commit

[GitHub] spark issue #17567: [SPARK-19991][CORE][YARN] FileSegmentManagedBuffer perfo...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17567 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75609/ Test FAILed. ---

[GitHub] spark issue #17567: [SPARK-19991][CORE][YARN] FileSegmentManagedBuffer perfo...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17567 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17567: [SPARK-19991][CORE][YARN] FileSegmentManagedBuffer perfo...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17567 **[Test build #75609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75609/testReport)** for PR 17567 at commit

[GitHub] spark issue #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic regressio...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic regressio...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75615/ Test PASSed. ---

[GitHub] spark issue #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic regressio...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17571 **[Test build #75615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75615/testReport)** for PR 17571 at commit

[GitHub] spark pull request #17557: [SPARK-20208][WIP][R][DOCS] Document R fpGrowth s...

2017-04-07 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17557#discussion_r110459968 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -906,6 +910,24 @@ predicted <- predict(model, df) head(predicted) ``` +

[GitHub] spark issue #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic regressio...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17571 **[Test build #75613 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75613/testReport)** for PR 17571 at commit

[GitHub] spark issue #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic regressio...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17571 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75613/ Test PASSed. ---

[GitHub] spark issue #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic regressio...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17571 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic regressio...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17571 **[Test build #75615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75615/testReport)** for PR 17571 at commit

[GitHub] spark pull request #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic re...

2017-04-07 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/17571#discussion_r110457676 --- Diff: examples/src/main/r/ml/glm.R --- @@ -44,8 +44,9 @@ gaussianGLM2 <- glm(label ~ features, gaussianDF, family = "gaussian")

[GitHub] spark pull request #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic re...

2017-04-07 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/17571#discussion_r110457466 --- Diff: examples/src/main/r/ml/glm.R --- @@ -44,8 +44,9 @@ gaussianGLM2 <- glm(label ~ features, gaussianDF, family = "gaussian")

[GitHub] spark pull request #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic re...

2017-04-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17571#discussion_r110457459 --- Diff: examples/src/main/r/ml/glm.R --- @@ -44,8 +44,9 @@ gaussianGLM2 <- glm(label ~ features, gaussianDF, family = "gaussian")

[GitHub] spark issue #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic regressio...

2017-04-07 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/17571 @felixcheung Just noticed that the current example for logistic regression in the programming guide did not seem to be a good one. It did not converge using IRWLS, and Quasi-Newton

[GitHub] spark pull request #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic re...

2017-04-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17571#discussion_r110457201 --- Diff: examples/src/main/r/ml/glm.R --- @@ -44,8 +44,9 @@ gaussianGLM2 <- glm(label ~ features, gaussianDF, family = "gaussian")

[GitHub] spark issue #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic regressio...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17571 **[Test build #75613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75613/testReport)** for PR 17571 at commit

[GitHub] spark issue #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks of a re...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17569 **[Test build #75614 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75614/testReport)** for PR 17569 at commit

[GitHub] spark pull request #17571: [SPARK-20258][Doc][SparkR] Fix SparkR logistic re...

2017-04-07 Thread actuaryzhang
GitHub user actuaryzhang opened a pull request: https://github.com/apache/spark/pull/17571 [SPARK-20258][Doc][SparkR] Fix SparkR logistic regression example in programming guide (did not converge) ## What changes were proposed in this pull request? SparkR logistic

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17527 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17527 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75608/ Test FAILed. ---

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17527 **[Test build #75608 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75608/testReport)** for PR 17527 at commit

[GitHub] spark issue #17566: [SPARK-19518][SQL] IGNORE NULLS in first / last in SQL

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17566 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17566: [SPARK-19518][SQL] IGNORE NULLS in first / last in SQL

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17566 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75607/ Test PASSed. ---

[GitHub] spark issue #17566: [SPARK-19518][SQL] IGNORE NULLS in first / last in SQL

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17566 **[Test build #75607 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75607/testReport)** for PR 17566 at commit

[GitHub] spark pull request #17516: [SPARK-20197][SPARKR] CRAN check fail with packag...

2017-04-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17516 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17516: [SPARK-20197][SPARKR] CRAN check fail with package insta...

2017-04-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17516 merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17516: [SPARK-20197][SPARKR] CRAN check fail with package insta...

2017-04-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17516 thanks, I find it rather odd but probably by design that the current directory is different when running `R CMD check .tgz`. will need to look at the more --- If your project is set up for

[GitHub] spark pull request #17557: [SPARK-20208][WIP][R][DOCS] Document R fpGrowth s...

2017-04-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17557#discussion_r110450322 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -906,6 +910,24 @@ predicted <- predict(model, df) head(predicted) ``` +

[GitHub] spark issue #17516: [SPARK-20197][SPARKR] CRAN check fail with package insta...

2017-04-07 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/17516 Got it. LGTM. Thanks for explanation. I'm fine with merging this to master ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17570: [SPARK-20255] Move listLeafFiles() to InMemoryFileIndex

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17570 **[Test build #3645 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3645/testReport)** for PR 17570 at commit

[GitHub] spark issue #17570: [SPARK-20255] Move listLeafFiles() to InMemoryFileIndex

2017-04-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17570 LGTM pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #17570: [SPARK-20255] Move listLeafFiles() to InMemoryFileIndex

2017-04-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17570 Jenkins, add to whitelist. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17553: [SPARK-20026][Doc][SparkR] Add Tweedie example fo...

2017-04-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17553 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17553: [SPARK-20026][Doc][SparkR] Add Tweedie example for Spark...

2017-04-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17553 merged to master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17553: [SPARK-20026][Doc][SparkR] Add Tweedie example for Spark...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17553 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17553: [SPARK-20026][Doc][SparkR] Add Tweedie example for Spark...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17553 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75612/ Test PASSed. ---

[GitHub] spark issue #17553: [SPARK-20026][Doc][SparkR] Add Tweedie example for Spark...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17553 **[Test build #75612 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75612/testReport)** for PR 17553 at commit

[GitHub] spark issue #17516: [SPARK-20197][SPARKR] CRAN check fail with package insta...

2017-04-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17516 There are two parts to the branch-2.1 fix First, the reason why the test failed was because `SPARK_HOME` was not set before calling `spark.install()` when running as a package. This

[GitHub] spark issue #17553: [SPARK-20026][Doc][SparkR] Add Tweedie example for Spark...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17553 **[Test build #75612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75612/testReport)** for PR 17553 at commit

[GitHub] spark issue #17570: [SPARK-20255] Move listLeafFiles() to InMemoryFileIndex

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17570 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks of a re...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17569 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks of a re...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17569 **[Test build #75611 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75611/testReport)** for PR 17569 at commit

[GitHub] spark issue #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks of a re...

2017-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17569 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75611/ Test FAILed. ---

[GitHub] spark pull request #17570: [SPARK-20255] Move listLeafFiles() to InMemoryFil...

2017-04-07 Thread adrian-ionescu
GitHub user adrian-ionescu opened a pull request: https://github.com/apache/spark/pull/17570 [SPARK-20255] Move listLeafFiles() to InMemoryFileIndex ## What changes were proposed in this pull request Trying to get a grip on the `FileIndex` hierarchy, I was confused by the

[GitHub] spark issue #17553: [SPARK-20026][Doc][SparkR] Add Tweedie example for Spark...

2017-04-07 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/17553 Issues fixed. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17569: [SPARK-20253][SQL] Remove unnecessary nullchecks of a re...

2017-04-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17569 **[Test build #75611 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75611/testReport)** for PR 17569 at commit

  1   2   3   >