[GitHub] spark pull request #17717: [SPARK-20430][SQL] Initialise RangeExec parameter...

2017-04-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17717: [SPARK-20430][SQL] Initialise RangeExec parameters in a ...

2017-04-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17717 Thanks! Merging to master and 2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17728 **[Test build #76067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76067/testReport)** for PR 17728 at commit

[GitHub] spark issue #17727: [SQL][MINOR] Remove misleading comment (and tags do bett...

2017-04-22 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17727 Fair enough. Let's do it here. Quoting directly from the code: > Converts a logical plan into zero or more SparkPlans. This API is exposed for experimenting with the query planner

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17728 Jenkins retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17728 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76066/ Test PASSed. ---

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17728 **[Test build #76066 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76066/testReport)** for PR 17728 at commit

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17728 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17728 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17728 **[Test build #76065 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76065/testReport)** for PR 17728 at commit

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17728 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76065/ Test FAILed. ---

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17728 **[Test build #76066 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76066/testReport)** for PR 17728 at commit

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17728 **[Test build #76065 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76065/testReport)** for PR 17728 at commit

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17728 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76064/ Test FAILed. ---

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17728 **[Test build #76064 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76064/testReport)** for PR 17728 at commit

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17728 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17728 Jenkins retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17728 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17728 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76063/ Test FAILed. ---

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17728 **[Test build #76063 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76063/testReport)** for PR 17728 at commit

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17728 **[Test build #76064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76064/testReport)** for PR 17728 at commit

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17728 **[Test build #76063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76063/testReport)** for PR 17728 at commit

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17728 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17728 **[Test build #76062 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76062/testReport)** for PR 17728 at commit

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17728 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76062/ Test FAILed. ---

[GitHub] spark issue #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17728 **[Test build #76062 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76062/testReport)** for PR 17728 at commit

[GitHub] spark pull request #17728: [SPARK-20437][R] R wrappers for rollup and cube

2017-04-22 Thread zero323
GitHub user zero323 opened a pull request: https://github.com/apache/spark/pull/17728 [SPARK-20437][R] R wrappers for rollup and cube ## What changes were proposed in this pull request? - Add `roolup` and `cube` methods and corresponding generics. - Add short

[GitHub] spark issue #17467: [SPARK-20140][DStream] Remove hardcoded kinesis retry wa...

2017-04-22 Thread yssharma
Github user yssharma commented on the issue: https://github.com/apache/spark/pull/17467 @budde - Not sure if we can exactly test the configured timeouts. I have debugged the flow in my testcase to verify that the custom values are passed down to the Kinesis backed block rdd. --- If

[GitHub] spark issue #17467: [SPARK-20140][DStream] Remove hardcoded kinesis retry wa...

2017-04-22 Thread yssharma
Github user yssharma commented on the issue: https://github.com/apache/spark/pull/17467 @budde : Implemented review changes and checked scala code style checks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17683: [SPARK-20386][Spark Core]modify the log info if the bloc...

2017-04-22 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17683 Merged to master/2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #17683: [SPARK-20386][Spark Core]modify the log info if t...

2017-04-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17683 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17719: [SPARK-20431][SQL] Specify a schema by using a DDL-forma...

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17719 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76061/ Test PASSed. ---

[GitHub] spark issue #17719: [SPARK-20431][SQL] Specify a schema by using a DDL-forma...

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17719 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17727: [SQL][MINOR] Remove misleading comment (and tags do bett...

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17727 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17727: [SQL][MINOR] Remove misleading comment (and tags do bett...

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17727 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76060/ Test PASSed. ---

[GitHub] spark issue #17719: [SPARK-20431][SQL] Specify a schema by using a DDL-forma...

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17719 **[Test build #76061 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76061/testReport)** for PR 17719 at commit

[GitHub] spark issue #17727: [SQL][MINOR] Remove misleading comment (and tags do bett...

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17727 **[Test build #76060 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76060/testReport)** for PR 17727 at commit

[GitHub] spark issue #17712: [SPARK-20416][SQL] Print UDF names in EXPLAIN

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17712 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76059/ Test PASSed. ---

[GitHub] spark issue #17712: [SPARK-20416][SQL] Print UDF names in EXPLAIN

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17712 **[Test build #76059 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76059/testReport)** for PR 17712 at commit

[GitHub] spark issue #17712: [SPARK-20416][SQL] Print UDF names in EXPLAIN

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17712 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17717: [SPARK-20430][SQL] Initialise RangeExec parameters in a ...

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17717 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76058/ Test PASSed. ---

[GitHub] spark issue #17717: [SPARK-20430][SQL] Initialise RangeExec parameters in a ...

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17717 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17717: [SPARK-20430][SQL] Initialise RangeExec parameters in a ...

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17717 **[Test build #76058 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76058/testReport)** for PR 17717 at commit

[GitHub] spark issue #17727: [SQL][MINOR] Remove misleading comment (and tags do bett...

2017-04-22 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17727 Nothing here explains why you think it's misleading --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17727: [SQL][MINOR] Remove misleading comment (and tags do bett...

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17727 **[Test build #76060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76060/testReport)** for PR 17727 at commit

[GitHub] spark issue #17719: [SPARK-20431][SQL] Specify a schema by using a DDL-forma...

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17719 **[Test build #76061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76061/testReport)** for PR 17719 at commit

[GitHub] spark pull request #17727: [SQL][MINOR] Remove misleading comment (and tags ...

2017-04-22 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/17727 [SQL][MINOR] Remove misleading comment (and tags do better) ## What changes were proposed in this pull request? Misleading comment removed (and tags do a better job to express

[GitHub] spark pull request #17719: [SPARK-20431][SQL] Specify a schema by using a DD...

2017-04-22 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17719#discussion_r112805934 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -68,6 +68,18 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark issue #17726: [SPARK-17928] [Mesos] No driver.memoryOverhead setting f...

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17726 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17726: [SPARK-17928] [Mesos] No driver.memoryOverhead se...

2017-04-22 Thread devaraj-kavali
GitHub user devaraj-kavali opened a pull request: https://github.com/apache/spark/pull/17726 [SPARK-17928] [Mesos] No driver.memoryOverhead setting for mesos cluster mode ## What changes were proposed in this pull request? Added a new configuration

[GitHub] spark pull request #17623: [SPARK-20292][SQL] Clean up string representation...

2017-04-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17623#discussion_r112805879 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala --- @@ -111,6 +111,11 @@ case class

[GitHub] spark pull request #17623: [SPARK-20292][SQL] Clean up string representation...

2017-04-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17623#discussion_r112805866 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala --- @@ -111,6 +111,11 @@ case class

[GitHub] spark pull request #17623: [SPARK-20292][SQL] Clean up string representation...

2017-04-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17623#discussion_r112805843 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -149,6 +149,7 @@ case class Cast(child: Expression,

[GitHub] spark pull request #17695: [SPARK-20400][DOCS] Remove References to 3rd Part...

2017-04-22 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17695#discussion_r112805801 --- Diff: docs/configuration.md --- @@ -2248,8 +2248,8 @@ should be included on Spark's classpath: * `hdfs-site.xml`, which provides default behaviors

[GitHub] spark issue #17712: [SPARK-20416][SQL] Print UDF names in EXPLAIN

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17712 **[Test build #76059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76059/testReport)** for PR 17712 at commit

[GitHub] spark pull request #17719: [SPARK-20431][SQL] Specify a schema by using a DD...

2017-04-22 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17719#discussion_r112805444 --- Diff: python/pyspark/sql/readwriter.py --- @@ -96,14 +96,17 @@ def schema(self, schema): By specifying the schema here, the underlying data

[GitHub] spark issue #17711: [SPARK-19951][SQL] Add string concatenate operator || to...

2017-04-22 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17711 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #17712: [SPARK-20416][SQL] Print UDF names in EXPLAIN

2017-04-22 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17712 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17697: [SPARK-20414][MLLIB] avoid creating only 16 reduc...

2017-04-22 Thread yangyangyyy
Github user yangyangyyy commented on a diff in the pull request: https://github.com/apache/spark/pull/17697#discussion_r112805342 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/rdd/MLPairRDDFunctionsSuite.scala --- @@ -33,4 +33,16 @@ class MLPairRDDFunctionsSuite extends

[GitHub] spark pull request #17697: [SPARK-20414][MLLIB] avoid creating only 16 reduc...

2017-04-22 Thread yangyangyyy
Github user yangyangyyy commented on a diff in the pull request: https://github.com/apache/spark/pull/17697#discussion_r112805327 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/rdd/MLPairRDDFunctions.scala --- @@ -49,6 +49,18 @@ class MLPairRDDFunctions[K: ClassTag, V:

[GitHub] spark pull request #17713: [SPARK-20417][SQL] Move subquery error handling t...

2017-04-22 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17713#discussion_r112805110 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/negative-cases/subq-input-typecheck.sql --- @@ -0,0 +1,47 @@ +-- The test file

[GitHub] spark pull request #17697: [SPARK-20414][MLLIB] avoid creating only 16 reduc...

2017-04-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17697#discussion_r112804787 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/rdd/MLPairRDDFunctionsSuite.scala --- @@ -33,4 +33,16 @@ class MLPairRDDFunctionsSuite extends

[GitHub] spark pull request #17713: [SPARK-20417][SQL] Move subquery error handling t...

2017-04-22 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17713#discussion_r112804747 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -414,4 +352,269 @@ trait CheckAnalysis extends

[GitHub] spark pull request #17716: [SPARK-19952][SQL] Remove various analysis except...

2017-04-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17716#discussion_r112804650 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala --- @@ -160,7 +159,7 @@ abstract class SQLViewSuite extends

[GitHub] spark pull request #17713: [SPARK-20417][SQL] Move subquery error handling t...

2017-04-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17713#discussion_r112804589 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/negative-cases/subq-input-typecheck.sql --- @@ -0,0 +1,47 @@ +-- The test file

[GitHub] spark pull request #17713: [SPARK-20417][SQL] Move subquery error handling t...

2017-04-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17713#discussion_r112804573 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -414,4 +352,269 @@ trait CheckAnalysis extends

[GitHub] spark pull request #17719: [SPARK-20431][SQL] Specify a schema by using a DD...

2017-04-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17719#discussion_r112804550 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -68,6 +68,18 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark pull request #17697: [SPARK-20414][MLLIB] avoid creating only 16 reduc...

2017-04-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17697#discussion_r112804479 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/rdd/MLPairRDDFunctions.scala --- @@ -49,6 +49,18 @@ class MLPairRDDFunctions[K: ClassTag, V:

[GitHub] spark pull request #17719: [SPARK-20431][SQL] Specify a schema by using a DD...

2017-04-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17719#discussion_r112804528 --- Diff: python/pyspark/sql/readwriter.py --- @@ -96,14 +96,17 @@ def schema(self, schema): By specifying the schema here, the underlying

[GitHub] spark pull request #17697: [SPARK-20414][MLLIB] avoid creating only 16 reduc...

2017-04-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17697#discussion_r112804455 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/rdd/MLPairRDDFunctionsSuite.scala --- @@ -33,4 +33,16 @@ class MLPairRDDFunctionsSuite extends

[GitHub] spark issue #17717: [SPARK-20430][SQL] Initialise RangeExec parameters in a ...

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17717 **[Test build #76058 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76058/testReport)** for PR 17717 at commit

[GitHub] spark issue #17717: [SPARK-20430][SQL] Initialise RangeExec parameters in a ...

2017-04-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17717 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #17724: [SPARK-18127] Add hooks and extension points to Spark

2017-04-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17724 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #17725: [SPARK-20435][CORE] More thorough redaction of sensitive...

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17725 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76055/ Test FAILed. ---

[GitHub] spark issue #17717: [SPARK-20430][SQL] Initialise RangeExec parameters in a ...

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17717 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76056/ Test FAILed. ---

[GitHub] spark issue #17712: [SPARK-20416][SQL] Print UDF names in EXPLAIN

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17712 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17712: [SPARK-20416][SQL] Print UDF names in EXPLAIN

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17712 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76057/ Test FAILed. ---

[GitHub] spark issue #17725: [SPARK-20435][CORE] More thorough redaction of sensitive...

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17725 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17717: [SPARK-20430][SQL] Initialise RangeExec parameters in a ...

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17717 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17724: [SPARK-18127] Add hooks and extension points to S...

2017-04-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17724#discussion_r112804293 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala --- @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #17725: [SPARK-20435][CORE] More thorough redaction of sensitive...

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17725 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76054/ Test PASSed. ---

[GitHub] spark issue #17725: [SPARK-20435][CORE] More thorough redaction of sensitive...

2017-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17725 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17725: [SPARK-20435][CORE] More thorough redaction of sensitive...

2017-04-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17725 **[Test build #76054 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76054/testReport)** for PR 17725 at commit

[GitHub] spark issue #17688: [MINOR][DOCS][PYTHON] Adding missing boolean type for re...

2017-04-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17688 LGTM too. I just quickly checked if there are similar instances but I could not find and I checked R's one and Scala one. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #17680: [SPARK-20364][SQL] Support Parquet predicate pushdown on...

2017-04-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17680 gentle ping @liancheng and @davies. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17724: [SPARK-18127] Add hooks and extension points to S...

2017-04-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17724#discussion_r112803968 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -848,6 +851,17 @@ object SparkSession { } /**

<    1   2