[GitHub] spark issue #17897: [SPARK-20635][SQL] No SQL tab in Spark UI

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17897 oh, seems it's included by https://github.com/apache/spark/pull/17540 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark issue #17540: [SPARK-20213][SQL][UI] Fix DataFrameWriter operations in...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17540 Hi @rdblue , I have sent you a PR to fix the missing metrics issue of `ExecutedCommandExec`, and we also need to fix the streaming batch metrics issue, then we are ready to go. --- If your proje

[GitHub] spark pull request #17880: [SPARK-20620][TEST]Improve some unit tests for Nu...

2017-05-08 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17880#discussion_r115244928 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala --- @@ -484,24 +484,50 @@ class TypeCoercionSuite

[GitHub] spark issue #17896: [SPARK-20373][SQL][SS] Batch queries with 'Dataset/DataF...

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17896 **[Test build #76576 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76576/testReport)** for PR 17896 at commit [`5637212`](https://github.com/apache/spark/commit/56

[GitHub] spark issue #17869: [SPARK-20609][CORE]Run the SortShuffleSuite unit tests h...

2017-05-08 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17869 @heary-cao, could you try to add `Utils.clearLocalRootDirs()` in the first of `beforeEach` and in the last of `afterEach` and check out the results? It looks initial local directory is c

[GitHub] spark issue #17896: [SPARK-20373][SQL][SS] Batch queries with 'Dataset/DataF...

2017-05-08 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/17896 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #17686: [SPARK-20393][Webu UI] Strengthen Spark to prevent XSS v...

2017-05-08 Thread n-marion
Github user n-marion commented on the issue: https://github.com/apache/spark/pull/17686 Missed the import organization. Just ran it locally. Didn't hit same problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark issue #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not ge...

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17886 **[Test build #76572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76572/testReport)** for PR 17886 at commit [`6696502`](https://github.com/apache/spark/commit/66

[GitHub] spark issue #17845: [SPARK-20587][ML] Improve performance of ML ALS recommen...

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17845 **[Test build #76571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76571/testReport)** for PR 17845 at commit [`cf35eea`](https://github.com/apache/spark/commit/cf

[GitHub] spark issue #17876: [SPARK-20569][SQL] RuntimeReplaceable functions should n...

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17876 **[Test build #76570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76570/testReport)** for PR 17876 at commit [`fcbeeb9`](https://github.com/apache/spark/commit/fc

[GitHub] spark issue #16989: [SPARK-19659] Fetch big blocks to disk when shuffle-read...

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16989 **[Test build #76574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76574/testReport)** for PR 16989 at commit [`4ad6bda`](https://github.com/apache/spark/commit/4a

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #76573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76573/testReport)** for PR 15435 at commit [`b7dcd16`](https://github.com/apache/spark/commit/b7

[GitHub] spark issue #17897: [SPARK-20635][SQL] No SQL tab in Spark UI

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17897 **[Test build #76575 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76575/testReport)** for PR 17897 at commit [`1adaf6e`](https://github.com/apache/spark/commit/1a

[GitHub] spark issue #17844: [SPARK-20548][FLAKY-TEST] share one REPL instance among ...

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17844 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17844: [SPARK-20548][FLAKY-TEST] share one REPL instance among ...

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17844 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76569/ Test FAILed. ---

[GitHub] spark issue #17844: [SPARK-20548][FLAKY-TEST] share one REPL instance among ...

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17844 **[Test build #76569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76569/testReport)** for PR 17844 at commit [`fd5b43b`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #17897: [SPARK-20635][SQL] No SQL tab in Spark UI

2017-05-08 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/17897 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-05-08 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15435 jenkins test please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16989: [SPARK-19659] Fetch big blocks to disk when shuffle-read...

2017-05-08 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16989 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] spark pull request #17897: [SPARK-20635][SQL] No SQL tab in Spark UI

2017-05-08 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17897#discussion_r115238974 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -1025,3 +1025,5 @@ case class ShowCreateTableCommand(table: Tabl

[GitHub] spark issue #17869: [SPARK-20609][CORE]Run the SortShuffleSuite unit tests h...

2017-05-08 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/17869 @HyukjinKwon ok thanks. I wish you the best A happy holiday. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark issue #17308: [SPARK-19968][SS] Use a cached instance of `KafkaProduce...

2017-05-08 Thread ScrapCodes
Github user ScrapCodes commented on the issue: https://github.com/apache/spark/pull/17308 Hi @marmbrus and @brkyvz, Thanks a lot of taking a look. @marmbrus You are right, we should have another way to canonicalize kafka params. I can only think of appending a unique id to kaf

[GitHub] spark issue #17666: [SPARK-20311][SQL] Support aliases for table value funct...

2017-05-08 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17666 @hvanhovell ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-05-08 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15435 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17898: Optimize the CartesianRDD to reduce repeatedly da...

2017-05-08 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/17898#discussion_r115232250 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -72,8 +72,10 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( over

[GitHub] spark issue #16989: [SPARK-19659] Fetch big blocks to disk when shuffle-read...

2017-05-08 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16989 @cloud-fan Thank you very much for reviewing this thus far :) >How about we always fetch to disk if the block size is over maxBytesInFlight? I super agree with this. It's to use `maxBy

[GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...

2017-05-08 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/16989#discussion_r115230064 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -163,6 +173,8 @@ final class ShuffleBlockFetcherIterator(

[GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...

2017-05-08 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/16989#discussion_r115229995 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -175,33 +187,45 @@ final class ShuffleBlockFetcherIterato

[GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...

2017-05-08 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/16989#discussion_r115229968 --- Diff: core/src/test/scala/org/apache/spark/scheduler/MapStatusSuite.scala --- @@ -128,4 +130,22 @@ class MapStatusSuite extends SparkFunSuite {

[GitHub] spark issue #17300: [SPARK-19956][Core]Optimize a location order of blocks w...

2017-05-08 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/17300 Thanks @cloud-fan @mridulm @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request #17890: [MINOR][BUILD] Fix lint-java breaks.

2017-05-08 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/17890#discussion_r115229257 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala --- @@ -379,7 +379,7 @@ final class DataStreamWriter[T] private[sq

[GitHub] spark pull request #17540: [SPARK-20213][SQL][UI] Fix DataFrameWriter operat...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17540#discussion_r115229230 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -283,44 +283,57 @@ class StreamExecution(

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-05-08 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15435 Jenkins test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #17890: [MINOR][BUILD] Fix lint-java breaks.

2017-05-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17890#discussion_r115222829 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala --- @@ -379,7 +379,7 @@ final class DataStreamWriter[T] private[sql]

[GitHub] spark issue #17742: [Spark-11968][ML][MLLIB]Optimize MLLIB ALS recommendForA...

2017-05-08 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/17742 LGTM - I think #17845 and this should go in 2.2. Let me know any objections @srowen @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #17845: [SPARK-20587][ML] Improve performance of ML ALS recommen...

2017-05-08 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/17845 jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] spark issue #16989: [SPARK-19659] Fetch big blocks to disk when shuffle-read...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16989 looks pretty good, one last comment: since the shuffle fetcher doesn't support spilling to disk, we should be very careful to avoid allocating a lot of memory. Normally this should be fine as the

[GitHub] spark pull request #17860: [SPARK-20596][ML][TEST] Consolidate and improve A...

2017-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17860 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...

2017-05-08 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/16989#discussion_r115220025 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -163,6 +173,8 @@ final class ShuffleBlockFetcherIterator(

[GitHub] spark issue #17860: [SPARK-20596][ML][TEST] Consolidate and improve ALS reco...

2017-05-08 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/17860 Merged to master/branch-2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16989#discussion_r115219343 --- Diff: core/src/test/scala/org/apache/spark/scheduler/MapStatusSuite.scala --- @@ -128,4 +130,22 @@ class MapStatusSuite extends SparkFunSuite {

[GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...

2017-05-08 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/16989#discussion_r115219258 --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala --- @@ -128,41 +130,52 @@ private[spark] class CompressedMapStatus( * @param

[GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16989#discussion_r115219013 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -175,33 +187,45 @@ final class ShuffleBlockFetcherIterato

[GitHub] spark issue #17899: [SPARK-20636] Add new optimization rule to flip adjacent...

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17899 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request #17899: [SPARK-20636] Add new optimization rule to flip a...

2017-05-08 Thread ptkool
GitHub user ptkool opened a pull request: https://github.com/apache/spark/pull/17899 [SPARK-20636] Add new optimization rule to flip adjacent Window expressions. ## What changes were proposed in this pull request? Add new optimization rule to eliminate unnecessary shuffling

[GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16989#discussion_r115218468 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -163,6 +173,8 @@ final class ShuffleBlockFetcherIterator(

[GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16989#discussion_r115218041 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -163,6 +173,8 @@ final class ShuffleBlockFetcherIterator(

[GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16989#discussion_r115217559 --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala --- @@ -128,41 +130,52 @@ private[spark] class CompressedMapStatus( * @param

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76565/ Test FAILed. ---

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #76565 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76565/testReport)** for PR 15435 at commit [`b7dcd16`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #17866: [SPARK-20605][Core][Yarn][Mesos] Deprecate not used AM a...

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17866 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17866: [SPARK-20605][Core][Yarn][Mesos] Deprecate not used AM a...

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17866 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76564/ Test FAILed. ---

[GitHub] spark issue #17866: [SPARK-20605][Core][Yarn][Mesos] Deprecate not used AM a...

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17866 **[Test build #76564 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76564/testReport)** for PR 17866 at commit [`ac710c7`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #17896: [SPARK-20373][SQL][SS] Batch queries with 'Dataset/DataF...

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17896 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76568/ Test FAILed. ---

[GitHub] spark issue #17896: [SPARK-20373][SQL][SS] Batch queries with 'Dataset/DataF...

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17896 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17896: [SPARK-20373][SQL][SS] Batch queries with 'Dataset/DataF...

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17896 **[Test build #76568 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76568/testReport)** for PR 17896 at commit [`5637212`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #17300: [SPARK-19956][Core]Optimize a location order of blocks w...

2017-05-08 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/17300 Thanks for merging @cloud-fan, this PR kept dropping form my list ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #17898: Optimize the CartesianRDD to reduce repeatedly da...

2017-05-08 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17898#discussion_r115211527 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -72,8 +72,10 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( overr

[GitHub] spark pull request #17898: Optimize the CartesianRDD to reduce repeatedly da...

2017-05-08 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/17898#discussion_r115211058 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -72,8 +72,10 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( overr

[GitHub] spark pull request #17898: Optimize the CartesianRDD to reduce repeatedly da...

2017-05-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17898#discussion_r115210488 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -72,8 +72,10 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( overri

[GitHub] spark issue #16989: [SPARK-19659] Fetch big blocks to disk when shuffle-read...

2017-05-08 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16989 @cloud-fan More comments on this ? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request #17300: [SPARK-19956][Core]Optimize a location order of b...

2017-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17300 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #17300: [SPARK-19956][Core]Optimize a location order of blocks w...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17300 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] spark issue #17887: [SPARK-20399][SQL] Add a config to fallback string liter...

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17887 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17887: [SPARK-20399][SQL] Add a config to fallback string liter...

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17887 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76563/ Test FAILed. ---

[GitHub] spark issue #17887: [SPARK-20399][SQL] Add a config to fallback string liter...

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17887 **[Test build #76563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76563/testReport)** for PR 17887 at commit [`ab77de7`](https://github.com/apache/spark/commit/a

[GitHub] spark pull request #17644: [SPARK-17729] [SQL] Enable creating hive bucketed...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17644#discussion_r115207897 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -632,9 +632,51 @@ private[spark] class HiveExternalCatalog(co

[GitHub] spark issue #17898: Optimize the CartesianRDD to reduce repeatedly data fetc...

2017-05-08 Thread jtengyp
Github user jtengyp commented on the issue: https://github.com/apache/spark/pull/17898 Here is my test: Environment : 3 workers, each has 10 cores, 30G memory, 1 executor Test data : users : 480,189, each is a 10-dim vector, and items : 17770, each is a 10-dim vector. With

[GitHub] spark pull request #17887: [SPARK-20399][SQL] Add a config to fallback strin...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115207039 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala --- @@ -447,6 +462,44 @@ class ExpressionParserSui

[GitHub] spark issue #17872: [SPARK-20608] allow standby namenodes in spark.yarn.acce...

2017-05-08 Thread morenn520
Github user morenn520 commented on the issue: https://github.com/apache/spark/pull/17872 @jerryshao done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] spark issue #17435: [SPARK-20098][PYSPARK] dataType's typeName fix

2017-05-08 Thread szalai1
Github user szalai1 commented on the issue: https://github.com/apache/spark/pull/17435 @HyukjinKwon sure, I will do it this week. I totally forgot this. Sorry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark pull request #17887: [SPARK-20399][SQL] Add a config to fallback strin...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115205264 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala --- @@ -160,6 +166,15 @@ class ExpressionParserSui

[GitHub] spark pull request #17874: [SPARK-20612][SQL] Throw exception when there is ...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17874#discussion_r115204690 --- Diff: mllib/src/test/scala/org/apache/spark/ml/fpm/FPGrowthSuite.scala --- @@ -83,7 +83,7 @@ class FPGrowthSuite extends SparkFunSuite with MLlibTest

[GitHub] spark issue #17897: [SPARK-20635][SQL] No SQL tab in Spark UI

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17897 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #17796: [SPARK-20519][SQL][CORE]Modify to prevent some po...

2017-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17796 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #17897: [SPARK-20635][SQL] No SQL tab in Spark UI

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17897 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76567/ Test FAILed. ---

[GitHub] spark issue #17897: [SPARK-20635][SQL] No SQL tab in Spark UI

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17897 **[Test build #76567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76567/testReport)** for PR 17897 at commit [`1adaf6e`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #17686: [SPARK-20393][Webu UI] Strengthen Spark to prevent XSS v...

2017-05-08 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17686 @n-marion looks like still some style issues from the checker --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #17796: [SPARK-20519][SQL][CORE]Modify to prevent some possible ...

2017-05-08 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17796 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark pull request #17897: [SPARK-20635][SQL] No SQL tab in Spark UI

2017-05-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17897#discussion_r115202713 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -1025,3 +1025,5 @@ case class ShowCreateTableCommand(table: Tab

[GitHub] spark issue #17844: [SPARK-20548][FLAKY-TEST] share one REPL instance among ...

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17844 **[Test build #76569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76569/testReport)** for PR 17844 at commit [`fd5b43b`](https://github.com/apache/spark/commit/fd

[GitHub] spark pull request #17844: [SPARK-20548][FLAKY-TEST] share one REPL instance...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17844#discussion_r115200884 --- Diff: repl/scala-2.11/src/test/scala/org/apache/spark/repl/ReplSuite.scala --- @@ -373,52 +190,6 @@ class ReplSuite extends SparkFunSuite { }

[GitHub] spark issue #17858: [SPARK-20594][SQL]The staging directory should be append...

2017-05-08 Thread zuotingbing
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/17858 @gatorsmile it seems my mistake, i will try to fix this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #17872: [SPARK-20608] allow standby namenodes in spark.yarn.acce...

2017-05-08 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17872 This change may be conflicted with #17723 , but I think it is easy to resolve, CC @mgummelt . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] spark pull request #17872: [SPARK-20608] allow standby namenodes in spark.ya...

2017-05-08 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/17872#discussion_r115200282 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/HadoopFSCredentialProvider.scala --- @@ -22,6 +22,8 @@ import scala

[GitHub] spark issue #17898: Optimize the CartesianRDD

2017-05-08 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17898 Maybe create a JIRA and update title as Spark PR convention. Since this should be a performance improvement, the difference is expected to show. --- If your project is set up for it, you can reply t

[GitHub] spark pull request #17898: Optimize the CartesianRDD

2017-05-08 Thread jtengyp
Github user jtengyp commented on a diff in the pull request: https://github.com/apache/spark/pull/17898#discussion_r115199537 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -72,8 +72,10 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( overr

[GitHub] spark pull request #17898: Optimize the CartesianRDD

2017-05-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17898#discussion_r115199237 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -72,8 +72,10 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( overri

[GitHub] spark pull request #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can...

2017-05-08 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/17886#discussion_r115196548 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java --- @@ -71,6 +71,10 @@ import org.apache.hive.s

[GitHub] spark issue #17869: [SPARK-20609][CORE]Run the SortShuffleSuite unit tests h...

2017-05-08 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17869 I think this does not look too urgent to merge it without investigating the reason and it is inappropriate to submit a PR without knowing/explaining how it fixes. I suspect this is rela

[GitHub] spark issue #17858: [SPARK-20594][SQL]The staging directory should be append...

2017-05-08 Thread zuotingbing
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/17858 @gatorsmile My production environment is spark 2.0.2 and test successful. Is there something be changed since 2.0.2 for this case? Thanks! --- If your project is set up for it, you can reply to

[GitHub] spark issue #17898: Update CartesianRDD.scala

2017-05-08 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17898 Please read http://spark.apache.org/contributing.html For example, "Update X" is never sufficient as a title. How does this avoid fetching? how much difference does it make? --- If your proje

[GitHub] spark pull request #17872: [SPARK-20608] allow standby namenodes in spark.ya...

2017-05-08 Thread morenn520
Github user morenn520 commented on a diff in the pull request: https://github.com/apache/spark/pull/17872#discussion_r115191861 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/HadoopFSCredentialProvider.scala --- @@ -48,9 +50,16 @@ private[sec

[GitHub] spark issue #17898: Update CartesianRDD.scala

2017-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17898 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request #17898: Update CartesianRDD.scala

2017-05-08 Thread jtengyp
GitHub user jtengyp opened a pull request: https://github.com/apache/spark/pull/17898 Update CartesianRDD.scala In compute, group each iterator to multiple groups, reducing repeatedly data fetching. ## What changes were proposed in this pull request? In compute, gr

[GitHub] spark pull request #17897: [SPARK-20635][SQL] No SQL tab in Spark UI

2017-05-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17897#discussion_r115190940 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala --- @@ -114,7 +114,7 @@ class QueryExecution(val sparkSession: Spar

[GitHub] spark issue #17896: [SPARK-20373][SQL][SS] Batch queries with 'Dataset/DataF...

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17896 **[Test build #76568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76568/testReport)** for PR 17896 at commit [`5637212`](https://github.com/apache/spark/commit/56

[GitHub] spark issue #17896: [SPARK-20373][SQL][SS] Batch queries with 'Dataset/DataF...

2017-05-08 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/17896 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #17897: [SPARK-20635][SQL] No SQL tab in Spark UI

2017-05-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17897 **[Test build #76567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76567/testReport)** for PR 17897 at commit [`1adaf6e`](https://github.com/apache/spark/commit/1a

<    1   2   3   4   5   6   7   >