[GitHub] spark pull request #18590: [SPARK-21365][PYTHON] Deduplicate logics parsing ...

2017-07-10 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/18590#discussion_r126598613 --- Diff: python/pyspark/sql/functions.py --- @@ -2026,16 +2026,26 @@ def __init__(self, func, returnType, name=None):

[GitHub] spark pull request #18543: [SPARK-21319][SQL] Fix memory leak in UnsafeExter...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18543#discussion_r126600430 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java --- @@ -211,7 +211,10 @@ public int compare(Object

[GitHub] spark issue #18597: [SPARK-20456][PYTHON][FOLLOWUP] Fix timezone-dependent d...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18597 **[Test build #79505 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79505/testReport)** for PR 18597 at commit

[GitHub] spark pull request #18228: [SPARK-21007][SQL]Add SQL function - RIGHT && LEF...

2017-07-10 Thread 10110346
Github user 10110346 commented on a diff in the pull request: https://github.com/apache/spark/pull/18228#discussion_r126599834 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -1199,6 +1199,82 @@ case class

[GitHub] spark issue #18580: [SPARK-21354] [SQL] INPUT FILE related functions do not ...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18580 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79496/ Test PASSed. ---

[GitHub] spark issue #18580: [SPARK-21354] [SQL] INPUT FILE related functions do not ...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18580 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18580: [SPARK-21354] [SQL] INPUT FILE related functions do not ...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18580 **[Test build #79496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79496/testReport)** for PR 18580 at commit

[GitHub] spark pull request #18580: [SPARK-21354] [SQL] INPUT FILE related functions ...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18580#discussion_r126599149 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -74,6 +74,15 @@ trait CheckAnalysis extends

[GitHub] spark issue #18597: [SPARK-20456][PYTHON][FOLLOWUP] Fix timezone-dependent d...

2017-07-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18597 Sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18023 **[Test build #79504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79504/testReport)** for PR 18023 at commit

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18405 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18405 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79494/ Test PASSed. ---

[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18023 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79503/ Test FAILed. ---

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18405 **[Test build #79494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79494/testReport)** for PR 18405 at commit

[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18023 **[Test build #79503 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79503/testReport)** for PR 18023 at commit

[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18023 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18023 **[Test build #79503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79503/testReport)** for PR 18023 at commit

[GitHub] spark pull request #18590: [SPARK-21365][PYTHON] Deduplicate logics parsing ...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18590#discussion_r126597140 --- Diff: python/pyspark/sql/types.py --- @@ -806,43 +786,43 @@ def _parse_datatype_string(s): >>> _parse_datatype_string("blabla") # doctest:

[GitHub] spark issue #18305: [SPARK-20988][ML] Logistic regression uses aggregator hi...

2017-07-10 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/18305 I get it in source code. I'm indifferent in tests. If it's easy sure. How does it help uncover bugs though? On Tue, 11 Jul 2017 at 04:42, Yanbo Liang wrote:

[GitHub] spark issue #18597: [SPARK-20456][PYTHON][FOLLOWUP] Fix timezone-dependent d...

2017-07-10 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18597 How about surrounding with SQLConf `spark.sql.session.timeZone` as `America/Los_Angeles` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #17633: [SPARK-20331][SQL] Enhanced Hive partition pruning predi...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17633 LGTM, pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18598: [SPARK-19285] [SQL] Implement UDF0

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18598 **[Test build #79502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79502/testReport)** for PR 18598 at commit

[GitHub] spark issue #18499: [SPARK-21176][WEB UI] Use a single ProxyServlet to proxy...

2017-07-10 Thread aosagie
Github user aosagie commented on the issue: https://github.com/apache/spark/pull/18499 @cloud-fan Hi, I just pushed a change to up the selector threads from 1 to 8. Can I get a retest please? @jiangxb1987 Sorry to bother, but is there anyone available to give guidance on

[GitHub] spark pull request #18598: [SPARK-19285] [SQL] Implement UDF0

2017-07-10 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/18598 [SPARK-19285] [SQL] Implement UDF0 ### What changes were proposed in this pull request? This PR is to implement UDF0. `UDF0` is needed when users need to implement a JAVA UDF with no

[GitHub] spark issue #18582: [SPARK-18619][ML] Make QuantileDiscretizer/Bucketizer/St...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18582 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79497/ Test PASSed. ---

[GitHub] spark issue #18582: [SPARK-18619][ML] Make QuantileDiscretizer/Bucketizer/St...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18582 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18582: [SPARK-18619][ML] Make QuantileDiscretizer/Bucketizer/St...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18582 **[Test build #79497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79497/testReport)** for PR 18582 at commit

[GitHub] spark issue #18597: [SPARK-20456][PYTHON][FOLLOWUP] Fix timezone-dependent d...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18597 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18597: [SPARK-20456][PYTHON][FOLLOWUP] Fix timezone-dependent d...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18597 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79500/ Test PASSed. ---

[GitHub] spark issue #18597: [SPARK-20456][PYTHON][FOLLOWUP] Fix timezone-dependent d...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18597 **[Test build #79500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79500/testReport)** for PR 18597 at commit

[GitHub] spark issue #17633: [SPARK-20331][SQL] Enhanced Hive partition pruning predi...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17633 **[Test build #79501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79501/testReport)** for PR 17633 at commit

[GitHub] spark pull request #17633: [SPARK-20331][SQL] Enhanced Hive partition prunin...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17633#discussion_r126593630 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -589,18 +591,67 @@ private[client] class Shim_v0_13 extends

[GitHub] spark pull request #17633: [SPARK-20331][SQL] Enhanced Hive partition prunin...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17633#discussion_r126593137 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -589,18 +591,67 @@ private[client] class Shim_v0_13 extends

[GitHub] spark pull request #18228: [SPARK-21007][SQL]Add SQL function - RIGHT && LEF...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18228#discussion_r126592966 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -1199,6 +1199,82 @@ case class

[GitHub] spark pull request #17633: [SPARK-20331][SQL] Enhanced Hive partition prunin...

2017-07-10 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/17633#discussion_r126592666 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -589,18 +591,67 @@ private[client] class Shim_v0_13 extends

[GitHub] spark pull request #17633: [SPARK-20331][SQL] Enhanced Hive partition prunin...

2017-07-10 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/17633#discussion_r126592639 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -589,18 +591,67 @@ private[client] class Shim_v0_13 extends

[GitHub] spark issue #18590: [SPARK-21365][PYTHON] Deduplicate logics parsing DDL typ...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18590 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79492/ Test PASSed. ---

[GitHub] spark issue #18590: [SPARK-21365][PYTHON] Deduplicate logics parsing DDL typ...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18590 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17633: [SPARK-20331][SQL] Enhanced Hive partition prunin...

2017-07-10 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/17633#discussion_r126592491 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -589,18 +591,67 @@ private[client] class Shim_v0_13 extends

[GitHub] spark issue #18590: [SPARK-21365][PYTHON] Deduplicate logics parsing DDL typ...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18590 **[Test build #79492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79492/testReport)** for PR 18590 at commit

[GitHub] spark pull request #18574: [SPARK-21350] [SQL] Fix the error message when th...

2017-07-10 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18574#discussion_r126591307 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala --- @@ -123,16 +128,20 @@ class UDFRegistration private[sql]

[GitHub] spark issue #18580: [SPARK-21354] [SQL] INPUT FILE related functions do not ...

2017-07-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18580 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #18597: [SPARK-20456][PYTHON][FOLLOWUP] Fix timezone-dependent d...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18597 **[Test build #79500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79500/testReport)** for PR 18597 at commit

[GitHub] spark issue #18597: [SPARK-20456][PYTHON][FOLLOWUP] Fix timezone-dependent d...

2017-07-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18597 cc @ueshin, could you take a look when you have some time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #18597: [SPARK-20456][PYTHON][FOLLOWUP] Fix timezone-depe...

2017-07-10 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/18597 [SPARK-20456][PYTHON][FOLLOWUP] Fix timezone-dependent doctests in unix_timestamp and from_unixtime ## What changes were proposed in this pull request? This PR proposes to simply

[GitHub] spark issue #17633: [SPARK-20331][SQL] Enhanced Hive partition pruning predi...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17633 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17633: [SPARK-20331][SQL] Enhanced Hive partition pruning predi...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17633 **[Test build #79493 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79493/testReport)** for PR 17633 at commit

[GitHub] spark issue #17633: [SPARK-20331][SQL] Enhanced Hive partition pruning predi...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17633 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79493/ Test PASSed. ---

[GitHub] spark issue #18589: [SPARK-16872][ML] Add Gaussian NB

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18589 **[Test build #79499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79499/testReport)** for PR 18589 at commit

[GitHub] spark issue #18591: [SPARK-21366][SQL][TEST] Add sql test for window functio...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18591 **[Test build #79498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79498/testReport)** for PR 18591 at commit

[GitHub] spark issue #18582: [SPARK-18619][ML] Make QuantileDiscretizer/Bucketizer/St...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18582 **[Test build #79497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79497/testReport)** for PR 18582 at commit

[GitHub] spark pull request #18581: [SPARK-21289][SQL][ML] Supports custom line separ...

2017-07-10 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/18581#discussion_r126589978 --- Diff: mllib/src/main/scala/org/apache/spark/ml/source/libsvm/LibSVMOptions.scala --- @@ -41,11 +41,15 @@ private[libsvm] class LibSVMOptions(@transient

[GitHub] spark pull request #18581: [SPARK-21289][SQL][ML] Supports custom line separ...

2017-07-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18581#discussion_r126589618 --- Diff: mllib/src/main/scala/org/apache/spark/ml/source/libsvm/LibSVMOptions.scala --- @@ -41,11 +41,15 @@ private[libsvm] class

[GitHub] spark pull request #18541: [SPARK-21315][SQL]Skip some spill files when gene...

2017-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18541 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18541: [SPARK-21315][SQL]Skip some spill files when generateIte...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18541 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18459: [SPARK-13534][PYSPARK] Using Apache Arrow to increase pe...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18459 great work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #17633: [SPARK-20331][SQL] Enhanced Hive partition prunin...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17633#discussion_r126588869 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -589,18 +591,67 @@ private[client] class Shim_v0_13 extends

[GitHub] spark pull request #17633: [SPARK-20331][SQL] Enhanced Hive partition prunin...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17633#discussion_r126588744 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -589,18 +591,67 @@ private[client] class Shim_v0_13 extends

[GitHub] spark issue #18582: [SPARK-18619][ML] Make QuantileDiscretizer/Bucketizer/St...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18582 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79495/ Test FAILed. ---

[GitHub] spark issue #18582: [SPARK-18619][ML] Make QuantileDiscretizer/Bucketizer/St...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18582 **[Test build #79495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79495/testReport)** for PR 18582 at commit

[GitHub] spark issue #18582: [SPARK-18619][ML] Make QuantileDiscretizer/Bucketizer/St...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18582 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18589: [SPARK-16872][ML] Add Gaussian NB

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18589 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79491/ Test FAILed. ---

[GitHub] spark issue #18589: [SPARK-16872][ML] Add Gaussian NB

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18589 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17633: [SPARK-20331][SQL] Enhanced Hive partition prunin...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17633#discussion_r126588444 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -589,18 +591,67 @@ private[client] class Shim_v0_13 extends

[GitHub] spark issue #18589: [SPARK-16872][ML] Add Gaussian NB

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18589 **[Test build #79491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79491/testReport)** for PR 18589 at commit

[GitHub] spark pull request #17633: [SPARK-20331][SQL] Enhanced Hive partition prunin...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17633#discussion_r126588383 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -589,18 +591,67 @@ private[client] class Shim_v0_13 extends

[GitHub] spark issue #18591: [SPARK-21366][SQL][TEST] Add sql test for window functio...

2017-07-10 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18591 Okay, let me remove them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18593: [SPARK-21369][Core]Don't use Scala Tuple2 in comm...

2017-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18593 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18593: [SPARK-21369][Core]Don't use Scala Tuple2 in common/netw...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18593 LGTM, merging to master/2.2! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18596: [SPARK-21371] dev/make-distribution.sh scripts use of $@...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18596 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18596: [SPARK-21371] dev/make-distribution.sh scripts us...

2017-07-10 Thread liu-zhaokun
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/spark/pull/18596 [SPARK-21371] dev/make-distribution.sh scripts use of $@ without "" [https://issues.apache.org/jira/browse/SPARK-21371](https://issues.apache.org/jira/browse/SPARK-21371)

[GitHub] spark pull request #18574: [SPARK-21350] [SQL] Fix the error message when th...

2017-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18574 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18574: [SPARK-21350] [SQL] Fix the error message when the numbe...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18574 LGTM, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18300: [SPARK-21043][SQL] Add unionByName in Dataset

2017-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18300 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18574: [SPARK-21350] [SQL] Fix the error message when th...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18574#discussion_r126587004 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala --- @@ -123,16 +128,20 @@ class UDFRegistration private[sql]

[GitHub] spark issue #18591: [SPARK-21366][SQL][TEST] Add sql test for window functio...

2017-07-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18591 At least these three test cases are not related to Hive compatibility in `WindowQuerySuite ` --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18580: [SPARK-21354] [SQL] INPUT FILE related functions do not ...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18580 **[Test build #79496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79496/testReport)** for PR 18580 at commit

[GitHub] spark issue #18300: [SPARK-21043][SQL] Add unionByName in Dataset

2017-07-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18300 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18594: [SPARK-20904][core] Don't report task failures to driver...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18594 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79485/ Test PASSed. ---

[GitHub] spark issue #18594: [SPARK-20904][core] Don't report task failures to driver...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18594 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18594: [SPARK-20904][core] Don't report task failures to driver...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18594 **[Test build #79485 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79485/testReport)** for PR 18594 at commit

[GitHub] spark pull request #18581: [SPARK-21289][SQL][ML] Supports custom line separ...

2017-07-10 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/18581#discussion_r126585940 --- Diff: mllib/src/main/scala/org/apache/spark/ml/source/libsvm/LibSVMOptions.scala --- @@ -41,11 +41,15 @@ private[libsvm] class LibSVMOptions(@transient

[GitHub] spark pull request #18581: [SPARK-21289][SQL][ML] Supports custom line separ...

2017-07-10 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/18581#discussion_r126585768 --- Diff: mllib/src/main/scala/org/apache/spark/ml/source/libsvm/LibSVMOptions.scala --- @@ -41,11 +41,15 @@ private[libsvm] class LibSVMOptions(@transient

[GitHub] spark issue #18582: [SPARK-18619][ML] Make QuantileDiscretizer/Bucketizer/St...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18582 **[Test build #79495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79495/testReport)** for PR 18582 at commit

[GitHub] spark issue #18595: [SPARK-21370][SS] Create distinction between read-only a...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18595 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18595: [SPARK-21370][SS] Create distinction between read-only a...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18595 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79487/ Test PASSed. ---

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18405 **[Test build #79494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79494/testReport)** for PR 18405 at commit

[GitHub] spark issue #18595: [SPARK-21370][SS] Create distinction between read-only a...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18595 **[Test build #79487 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79487/testReport)** for PR 18595 at commit

[GitHub] spark pull request #18405: [SPARK-21194][SQL] Fail the putNullmethod when co...

2017-07-10 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/18405#discussion_r126584992 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala --- @@ -758,6 +758,35 @@ class ColumnarBatchSuite

[GitHub] spark issue #18593: [SPARK-21369][Core]Don't use Scala Tuple2 in common/netw...

2017-07-10 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18593 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #18305: [SPARK-20988][ML] Logistic regression uses aggreg...

2017-07-10 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/18305#discussion_r126582816 --- Diff: mllib/src/test/scala/org/apache/spark/ml/optim/aggregator/LogisticAggregatorSuite.scala --- @@ -0,0 +1,254 @@ +/* + * Licensed to the

[GitHub] spark issue #18574: [SPARK-21350] [SQL] Fix the error message when the numbe...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18574 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18574: [SPARK-21350] [SQL] Fix the error message when the numbe...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18574 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79486/ Test PASSed. ---

[GitHub] spark issue #18118: [SPARK-20199][ML] : Provided featureSubsetStrategy to GB...

2017-07-10 Thread pralabhkumar
Github user pralabhkumar commented on the issue: https://github.com/apache/spark/pull/18118 ping @sethah @MLnick --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18574: [SPARK-21350] [SQL] Fix the error message when the numbe...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18574 **[Test build #79486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79486/testReport)** for PR 18574 at commit

[GitHub] spark issue #18487: [SPARK-21243][Core] Limit no. of map outputs in a shuffl...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18487 Will this be convered by https://github.com/apache/spark/pull/18388 ? And another concern is how shall we expect users to tune this config? Can users just tune `spark.reducer.maxReqsInFlight`

[GitHub] spark issue #18591: [SPARK-21366][SQL][TEST] Add sql test for window functio...

2017-07-10 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18591 also cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18591: [SPARK-21366][SQL][TEST] Add sql test for window functio...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18591 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79484/ Test PASSed. ---

[GitHub] spark pull request #18595: [SPARK-21370][SS] Create distinction between read...

2017-07-10 Thread brkyvz
Github user brkyvz closed the pull request at: https://github.com/apache/spark/pull/18595 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18591: [SPARK-21366][SQL][TEST] Add sql test for window functio...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18591 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

  1   2   3   4   5   >