[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-02 Thread jmchung
Github user jmchung commented on the issue: https://github.com/apache/spark/pull/18865 @gatorsmile Thanks for your feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19110: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19110 **[Test build #81352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81352/testReport)** for PR 19110 at commit

[GitHub] spark issue #19110: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-09-02 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19110 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #19018: [SPARK-21801][SPARKR][TEST] unit test randomly fail with...

2017-09-02 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19018 cc @felixcheung I encounter RTest failed again even when this seed added. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81350/console error: ``` Failed

[GitHub] spark issue #19110: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19110 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19110: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19110 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81350/ Test FAILed. ---

[GitHub] spark pull request #18270: [SPARK-21055][SQL] replace grouping__id with grou...

2017-09-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18270#discussion_r136708766 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -954,6 +954,15 @@ class Analyzer( try {

[GitHub] spark pull request #18270: [SPARK-21055][SQL] replace grouping__id with grou...

2017-09-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18270#discussion_r136708762 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -863,6 +854,15 @@ class Analyzer( case q:

[GitHub] spark issue #19110: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19110 **[Test build #81350 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81350/testReport)** for PR 19110 at commit

[GitHub] spark pull request #18865: [SPARK-21610][SQL] Corrupt records are not handle...

2017-09-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18865#discussion_r136708714 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -17,7 +17,7 @@ package

[GitHub] spark pull request #18865: [SPARK-21610][SQL] Corrupt records are not handle...

2017-09-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18865#discussion_r136708708 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2034,4 +2034,31 @@ class JsonSuite extends

[GitHub] spark pull request #18270: [SPARK-21055][SQL] replace grouping__id with grou...

2017-09-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18270#discussion_r136708657 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -954,6 +954,15 @@ class Analyzer( try {

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18869 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18869 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81347/ Test PASSed. ---

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18869 **[Test build #81347 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81347/testReport)** for PR 18869 at commit

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19082 **[Test build #81351 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81351/testReport)** for PR 19082 at commit

[GitHub] spark pull request #18270: [SPARK-21055][SQL] replace grouping__id with grou...

2017-09-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18270#discussion_r136708299 --- Diff: sql/core/src/test/resources/sql-tests/results/group-analytics.sql.out --- @@ -223,12 +223,19 @@ grouping_id() can only be used with

[GitHub] spark issue #19110: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19110 **[Test build #81350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81350/testReport)** for PR 19110 at commit

[GitHub] spark issue #18281: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-09-02 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/18281 I take this PR over in #19110 because the original author is busy but we need merge this PR soon. Thanks! --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request #18865: [SPARK-21610][SQL] Corrupt records are not handle...

2017-09-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18865#discussion_r136708174 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala --- @@ -114,6 +114,17 @@ class JsonFileFormat

[GitHub] spark pull request #19110: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-09-02 Thread WeichenXu123
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/19110 [SPARK-21027][ML][PYTHON] Added tunable parallelism to one vs. rest in both Scala mllib and Pyspark ## What changes were proposed in this pull request? Added tunable parallelism to

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18869 **[Test build #81349 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81349/testReport)** for PR 18869 at commit

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18869 **[Test build #81348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81348/testReport)** for PR 18869 at commit

[GitHub] spark issue #18869: [SPARK-21654][SQL] Complement SQL predicates expression ...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18869 **[Test build #81347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81347/testReport)** for PR 18869 at commit

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-02 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r136706616 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -178,11 +179,50 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-02 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r136706593 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -178,11 +179,50 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark issue #18270: [SPARK-21055][SQL] replace grouping__id with grouping_id...

2017-09-02 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18270 Thanks for notification. Actually we implement the same logic with hive, though there's a bug ... --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81346/ Test PASSed. ---

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81346 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81346/testReport)** for PR 18975 at commit

[GitHub] spark pull request #18869: [SPARK-21654][SQL] Complement SQL predicates expr...

2017-09-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18869#discussion_r136706140 --- Diff: sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql --- @@ -0,0 +1,42 @@ +-- In +select 1 in(1, 2, 3); +select 1

[GitHub] spark pull request #18869: [SPARK-21654][SQL] Complement SQL predicates expr...

2017-09-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18869#discussion_r136706025 --- Diff: sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql --- @@ -0,0 +1,42 @@ +-- In --- End diff -- The test cases

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81346 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81346/testReport)** for PR 18975 at commit

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18975 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #18869: [SPARK-21654][SQL] Complement SQL predicates expr...

2017-09-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18869#discussion_r136704544 --- Diff: sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql --- @@ -0,0 +1,42 @@ +-- In --- End diff -- Let me

[GitHub] spark pull request #18869: [SPARK-21654][SQL] Complement SQL predicates expr...

2017-09-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18869#discussion_r136704469 --- Diff: sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql --- @@ -0,0 +1,42 @@ +-- In +select 1 in(1, 2, 3); +select 1

[GitHub] spark pull request #18869: [SPARK-21654][SQL] Complement SQL predicates expr...

2017-09-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18869#discussion_r136704438 --- Diff: sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql --- @@ -0,0 +1,42 @@ +-- In --- End diff -- If we do not

[GitHub] spark pull request #19100: [SPARK-21891] [SQL] Add TBLPROPERTIES to DDL stat...

2017-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #19109: Update index.md

2017-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19109#discussion_r136702130 --- Diff: docs/index.md --- @@ -24,7 +24,7 @@ source, visit [Building Spark](building-spark.html). Spark runs on both Windows and UNIX-like

[GitHub] spark issue #19109: Update index.md

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19109 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #19109: Update index.md

2017-09-02 Thread demoonism
GitHub user demoonism opened a pull request: https://github.com/apache/spark/pull/19109 Update index.md Change wording to avoid confusion ## What changes were proposed in this pull request? Change the wording in the installation doc to avoid confusion ## How was

[GitHub] spark issue #18270: [SPARK-21055][SQL] replace grouping__id with grouping_id...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18270 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18270: [SPARK-21055][SQL] replace grouping__id with grouping_id...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18270 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81345/ Test FAILed. ---

[GitHub] spark issue #18270: [SPARK-21055][SQL] replace grouping__id with grouping_id...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18270 **[Test build #81345 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81345/testReport)** for PR 18270 at commit

[GitHub] spark issue #18270: [SPARK-21055][SQL] replace grouping__id with grouping_id...

2017-09-02 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/spark/pull/18270 @jinxing64 I think you may revert the changes in Spark, and use the same logic of grouping__id as hive. Keep the wrong result consistently as hive did. --- If your project is set up for it, you

[GitHub] spark issue #18270: [SPARK-21055][SQL] replace grouping__id with grouping_id...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18270 **[Test build #81345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81345/testReport)** for PR 18270 at commit

[GitHub] spark issue #19106: [SPARK-21770][ML] ProbabilisticClassificationModel fix c...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19106 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19106: [SPARK-21770][ML] ProbabilisticClassificationModel fix c...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19106 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81344/ Test PASSed. ---

[GitHub] spark issue #19106: [SPARK-21770][ML] ProbabilisticClassificationModel fix c...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19106 **[Test build #81344 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81344/testReport)** for PR 19106 at commit

[GitHub] spark issue #19108: [SPARK-21898][ML] Feature parity for KolmogorovSmirnovTe...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19108 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19108: [SPARK-21898][ML] Feature parity for KolmogorovSmirnovTe...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19108 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81343/ Test PASSed. ---

[GitHub] spark issue #19108: [SPARK-21898][ML] Feature parity for KolmogorovSmirnovTe...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19108 **[Test build #81343 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81343/testReport)** for PR 19108 at commit

[GitHub] spark issue #18270: [SPARK-21055][SQL] replace grouping__id with grouping_id...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18270 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18270: [SPARK-21055][SQL] replace grouping__id with grouping_id...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18270 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81342/ Test FAILed. ---

[GitHub] spark issue #18270: [SPARK-21055][SQL] replace grouping__id with grouping_id...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18270 **[Test build #81342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81342/testReport)** for PR 18270 at commit

[GitHub] spark issue #19106: [SPARK-21770][ML] ProbabilisticClassificationModel fix c...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19106 **[Test build #81344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81344/testReport)** for PR 19106 at commit

[GitHub] spark pull request #19106: [SPARK-21770][ML] ProbabilisticClassificationMode...

2017-09-02 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/19106#discussion_r136696592 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala --- @@ -245,6 +245,13 @@ private[ml] object

[GitHub] spark issue #19108: [SPARK-21898][ML] Feature parity for KolmogorovSmirnovTe...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19108 **[Test build #81343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81343/testReport)** for PR 19108 at commit

[GitHub] spark pull request #19108: [SPARK-21898][ML] Feature parity for KolmogorovSm...

2017-09-02 Thread WeichenXu123
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/19108 [SPARK-21898][ML] Feature parity for KolmogorovSmirnovTest in MLlib ## What changes were proposed in this pull request? Feature parity for KolmogorovSmirnovTest in MLlib.

[GitHub] spark issue #19090: [SPARK-21877][DEPLOY, WINDOWS] Handle quotes in Windows ...

2017-09-02 Thread minixalpha
Github user minixalpha commented on the issue: https://github.com/apache/spark/pull/19090 I design two groups test cases: - Test cases about windows command scripts options - Examples in Spark Document All these test cases works well. ## Test cases

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-02 Thread jmchung
Github user jmchung commented on the issue: https://github.com/apache/spark/pull/18865 @viirya Thanks, the description of PR has been updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #18270: [SPARK-21055][SQL] replace grouping__id with grouping_id...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18270 **[Test build #81342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81342/testReport)** for PR 18270 at commit

[GitHub] spark issue #18270: [SPARK-21055][SQL] replace grouping__id with grouping_id...

2017-09-02 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/spark/pull/18270 @gatorsmile I had already tried to resolve grouping__id in ResolveFunctions. But ResolveFunctions is behind ResolveGroupingAnalytics. grouping__id may change in ResolveGroupingAnalytics. --- If

[GitHub] spark pull request #18270: [SPARK-21055][SQL] replace grouping__id with grou...

2017-09-02 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/spark/pull/18270#discussion_r136695110 --- Diff: sql/core/src/test/resources/sql-tests/results/group-analytics.sql.out --- @@ -223,12 +223,19 @@ grouping_id() can only be used with

[GitHub] spark pull request #18270: [SPARK-21055][SQL] replace grouping__id with grou...

2017-09-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18270#discussion_r136694895 --- Diff: sql/core/src/test/resources/sql-tests/results/group-analytics.sql.out --- @@ -223,12 +223,19 @@ grouping_id() can only be used with

[GitHub] spark issue #18270: [SPARK-21055][SQL] replace grouping__id with grouping_id...

2017-09-02 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/spark/pull/18270 why failed? Couldn't I add order by? ```java org.scalatest.exceptions.TestFailedException: Expected "...Y CUBE(course, year)[ ORDER BY grouping__id, course, year]", but got "...Y

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-02 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18865 @jmchung Please also update the description too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18865 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81340/ Test PASSed. ---

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18865 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18865 **[Test build #81340 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81340/testReport)** for PR 18865 at commit

[GitHub] spark pull request #19106: [SPARK-21770][ML] ProbabilisticClassificationMode...

2017-09-02 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/19106#discussion_r136692759 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/ProbabilisticClassifierSuite.scala --- @@ -23,6 +23,7 @@ import

[GitHub] spark pull request #19105: [SPARK-21897][PYTHON][R] Add unionByName API to D...

2017-09-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19105#discussion_r136692400 --- Diff: R/pkg/R/DataFrame.R --- @@ -2714,6 +2714,40 @@ setMethod("unionAll", union(x, y) }) +#' Return a new

[GitHub] spark issue #19105: [SPARK-21897][PYTHON][R] Add unionByName API to DataFram...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19105 **[Test build #81341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81341/testReport)** for PR 19105 at commit

[GitHub] spark issue #19105: [SPARK-21897][PYTHON][R] Add unionByName API to DataFram...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19105 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81341/ Test PASSed. ---

[GitHub] spark issue #19105: [SPARK-21897][PYTHON][R] Add unionByName API to DataFram...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19105 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19105: [SPARK-21897][PYTHON][R] Add unionByName API to DataFram...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19105 **[Test build #81341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81341/testReport)** for PR 19105 at commit

[GitHub] spark pull request #19106: [SPARK-21770][ML] ProbabilisticClassificationMode...

2017-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19106#discussion_r136691526 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala --- @@ -245,6 +245,13 @@ private[ml] object

[GitHub] spark issue #19105: [SPARK-21897][PYTHON][R] Add unionByName API to DataFram...

2017-09-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19105 Oh, yea. I made a mistake during copying and pasting the example in the description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #19105: [SPARK-21897][PYTHON][R] Add unionByName API to D...

2017-09-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19105#discussion_r136691380 --- Diff: R/pkg/R/DataFrame.R --- @@ -2714,6 +2714,40 @@ setMethod("unionAll", union(x, y) }) +#' Return a new

[GitHub] spark pull request #19105: [SPARK-21897][PYTHON][R] Add unionByName API to D...

2017-09-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/19105#discussion_r136691370 --- Diff: R/pkg/R/DataFrame.R --- @@ -2714,6 +2714,40 @@ setMethod("unionAll", union(x, y) }) +#' Return a new

[GitHub] spark issue #19105: [SPARK-21897][PYTHON][R] Add unionByName API to DataFram...

2017-09-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19105 do you mean for your example in the PR description something different? it says ``` head(union(limit(df1, 2), limit(df2, 2))) ``` --- If your project is set up for it, you can

[GitHub] spark pull request #17014: [SPARK-18608][ML] Fix double-caching in ML algori...

2017-09-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17014#discussion_r136691195 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -304,16 +304,14 @@ class KMeans @Since("1.5.0") ( override def

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18865 **[Test build #81340 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81340/testReport)** for PR 18865 at commit

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-02 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18865 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81338/ Test FAILed. ---

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18865 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81338 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81338/testReport)** for PR 18975 at commit

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18865 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81339/ Test FAILed. ---

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18865 **[Test build #81339 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81339/testReport)** for PR 18865 at commit

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-02 Thread jmchung
Github user jmchung commented on the issue: https://github.com/apache/spark/pull/18865 Thanks @viirya's suggestion, the redundant comment is removed and `withTempPath` is applied in the test case. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18865 **[Test build #81339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81339/testReport)** for PR 18865 at commit