Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19061
The PR is updated. Thank you for review, @vanzin !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For a
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r143077626
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +463,60 @@ final class OnlineLDAOptimizer extends LDAOptim
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19394#discussion_r143077148
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
---
@@ -73,25 +73,37 @@ case class BroadcastExchan
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19061#discussion_r143076954
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -434,7 +434,7 @@ class SparkContext(config: SparkConf) extends Logging {
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19061#discussion_r143076726
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -598,6 +598,11 @@ object SparkSubmit extends CommandLineUtils with
Logg
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19061#discussion_r143076481
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -434,7 +434,7 @@ class SparkContext(config: SparkConf) extends Logging {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19061#discussion_r143073410
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -203,6 +203,10 @@ package object config {
private[spark] val HISTO
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19061#discussion_r143073506
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -598,6 +598,11 @@ object SparkSubmit extends CommandLineUtils with
Logging {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19061#discussion_r143073447
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -434,7 +434,7 @@ class SparkContext(config: SparkConf) extends Logging {
_st
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19061#discussion_r143073586
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -399,6 +399,18 @@ class SparkSubmitSuite
mainClass should be ("o
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19061#discussion_r143073559
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -399,6 +399,18 @@ class SparkSubmitSuite
mainClass should be ("o
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19424#discussion_r143072487
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownOperatorsToDataSource.scala
---
@@ -0,0 +1,99 @@
+/*
+ *
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r143069049
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +463,60 @@ final class OnlineLDAOptimizer extends LDAOpti
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r143068229
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +463,60 @@ final class OnlineLDAOptimizer extends LDAOptim
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18924
**[Test build #82487 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82487/testReport)**
for PR 18924 at commit
[`2942082`](https://github.com/apache/spark/commit/29
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r143067455
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +463,60 @@ final class OnlineLDAOptimizer extends LDAOptim
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r143066229
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +463,60 @@ final class OnlineLDAOptimizer extends LDAOpti
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143048261
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143063348
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143051494
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143011936
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143020551
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r143064794
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +463,60 @@ final class OnlineLDAOptimizer extends LDAOpti
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143029928
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143029396
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143036042
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143051749
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143050445
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143050632
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143053337
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143034710
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143053094
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143050902
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143020469
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143033624
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143021666
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143051105
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143050245
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143034368
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143034586
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143011531
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143048444
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143050140
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143052196
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143020756
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143048339
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143030468
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143007246
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r142992652
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143022987
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143053455
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143051704
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143020307
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143033876
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/Word2VecCBOWSolver.scala ---
@@ -0,0 +1,344 @@
+/*
+ * Licensed to the Apache Software Fou
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/19394
Yes, we've been running this in production for a few weeks now.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19394
Is the fix being used in the Netflix production environment?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.o
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19394
This is a pretty cool fix
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user rdblue reopened a pull request:
https://github.com/apache/spark/pull/19394
[SPARK-22170][SQL] Reduce memory consumption in broadcast joins.
## What changes were proposed in this pull request?
This updates the broadcast join code path to lazily decompress pages an
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/19394
@rxin, any idea why this would fail ConfigBehaviorSuite? I don't think the
failure is related because that test doesn't use a broadcast join. Should I
rebase on master?
---
---
Github user rdblue closed the pull request at:
https://github.com/apache/spark/pull/19394
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19394#discussion_r143060736
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -228,7 +228,7 @@ class SQLMetricsSuite extends SparkFun
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19394
**[Test build #82486 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82486/testReport)**
for PR 19394 at commit
[`3b43e11`](https://github.com/apache/spark/commit/3b
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r143060674
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +463,60 @@ final class OnlineLDAOptimizer extends LDAOpti
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r143060537
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +463,60 @@ final class OnlineLDAOptimizer extends LDAOpti
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r143056727
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +463,60 @@ final class OnlineLDAOptimizer extends LDAOptim
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r143055573
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +463,60 @@ final class OnlineLDAOptimizer extends LDAOptim
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r143058244
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +463,60 @@ final class OnlineLDAOptimizer extends LDAOptim
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r143057944
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +463,60 @@ final class OnlineLDAOptimizer extends LDAOptim
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19440
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82485/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19440
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19440
**[Test build #82485 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82485/testReport)**
for PR 19440 at commit
[`473bbf0`](https://github.com/apache/spark/commit/4
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19090
Tested this, looks good to me
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional command
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19419
I can see them from the browser.
LGTM except two minor comments, @krishna-pandey .
---
-
To unsubscribe, e-mail: review
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19419#discussion_r143048963
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -89,6 +92,15 @@ private[spark] object JettyUtils extends Logging {
Github user hning86 closed the pull request at:
https://github.com/apache/spark/pull/19441
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user hning86 opened a pull request:
https://github.com/apache/spark/pull/19441
Update JobExecutionStatus.java
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please expl
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19419#discussion_r143043339
--- Diff: conf/spark-defaults.conf.template ---
@@ -19,9 +19,16 @@
# This is useful for setting default environmental settings.
# Examp
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/19439
@thunterdb @jkbradley @yanboliang Would you be able to take a look at the
new image reader? This is taken from the spark-images package written by
@dakirsa @drdarshan @imatiach-msft. Thank y
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r143032320
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,67 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col)
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r143033289
--- Diff: python/pyspark/worker.py ---
@@ -74,17 +74,35 @@ def wrap_udf(f, return_type):
def wrap_pandas_udf(f, return_type):
-ar
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82484/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19439
**[Test build #82484 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82484/testReport)**
for PR 19439 at commit
[`52e740b`](https://github.com/apache/spark/commit/5
Github user akopich commented on the issue:
https://github.com/apache/spark/pull/18924
I have conducted some performance testing with random data.
The new implementation turns out to be notably faster.
```
OLD with hyper-parameter optimization : 237 sec
OLD
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18924
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18924
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82482/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18924
**[Test build #82482 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82482/testReport)**
for PR 18924 at commit
[`68ca837`](https://github.com/apache/spark/commit/6
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19440
cc @maropu @rednaxelafx
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: r
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19440
**[Test build #82485 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82485/testReport)**
for PR 19440 at commit
[`473bbf0`](https://github.com/apache/spark/commit/47
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15666
I am sorry for this delay @mariusvniekerk. Would you have some time to
proceed this one please?
---
-
To unsubscribe, e-mail
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143018955
--- Diff: python/pyspark/context.py ---
@@ -863,6 +863,21 @@ def addPyFile(self, path):
import importlib
importlib.inva
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143019603
--- Diff: python/pyspark/tests.py ---
@@ -435,6 +436,19 @@ def test_add_file_locally(self):
with open(download_path) as test_file:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143015274
--- Diff: R/pkg/tests/fulltests/test_context.R ---
@@ -167,6 +167,18 @@ test_that("spark.lapply should perform simple
transforms", {
sparkR.sessi
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143014933
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,32 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
su
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143018036
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -168,6 +168,27 @@ private[spark] object TestUtils {
createCompiledClass(cl
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143015101
--- Diff: R/pkg/tests/fulltests/test_context.R ---
@@ -167,6 +167,18 @@ test_that("spark.lapply should perform simple
transforms", {
sparkR.sessi
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143017669
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1845,6 +1859,21 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143017806
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1845,6 +1859,21 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r14301
--- Diff: R/pkg/tests/fulltests/test_context.R ---
@@ -167,6 +167,18 @@ test_that("spark.lapply should perform simple
transforms", {
sparkR.sessi
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/19440
[SPARK-21871][SQL] Fix infinite loop when bytecode size is larger than
spark.sql.codegen.hugeMethodLimit
## What changes were proposed in this pull request?
When exceeding `spark.sql.codegen
101 - 200 of 311 matches
Mail list logo
