[GitHub] spark pull request #19911: [SPARK-22717][SQL] Correct cascade default for po...

2017-12-06 Thread danielvdende
Github user danielvdende commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155335791 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -100,5 +100,5 @@ private object PostgresDialect extends JdbcDi

[GitHub] spark pull request #19911: [SPARK-22717][SQL] Correct cascade default for po...

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155334735 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -100,5 +100,5 @@ private object PostgresDialect extends JdbcD

[GitHub] spark pull request #19911: [SPARK-22717][SQL] Correct cascade default for po...

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155333091 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -100,5 +100,5 @@ private object PostgresDialect extends JdbcD

[GitHub] spark pull request #19911: [SPARK-22717][SQL] Correct cascade default for po...

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155332414 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -100,5 +100,5 @@ private object PostgresDialect extends JdbcD

[GitHub] spark issue #19896: [SPARK-22693][SQL] CreateNamedStruct and InSet should no...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19896 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19896: [SPARK-22693][SQL] CreateNamedStruct and InSet should no...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19896 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84564/ Test PASSed. ---

[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19908 **[Test build #84571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84571/testReport)** for PR 19908 at commit [`e7cdbd7`](https://github.com/apache/spark/commit/e7

[GitHub] spark issue #19896: [SPARK-22693][SQL] CreateNamedStruct and InSet should no...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19896 **[Test build #84564 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84564/testReport)** for PR 19896 at commit [`36537d8`](https://github.com/apache/spark/commit/3

[GitHub] spark pull request #19911: [SPARK-22717][SQL] Correct cascade default for po...

2017-12-06 Thread danielvdende
Github user danielvdende commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155331702 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -100,5 +100,5 @@ private object PostgresDialect extends JdbcDi

[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

2017-12-06 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19908 @cloud-fan @kiszk @viirya may you please review this? Thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #19911: [SPARK-22717][SQL] Correct cascade default for postgres

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19911 **[Test build #4005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4005/testReport)** for PR 19911 at commit [`40bd8ac`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #19911: [SPARK-22717][SQL] Correct cascade default for po...

2017-12-06 Thread danielvdende
Github user danielvdende commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155330583 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -100,5 +100,5 @@ private object PostgresDialect extends JdbcDi

[GitHub] spark pull request #19911: [SPARK-22717][SQL] Correct cascade default for po...

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155330593 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -100,5 +100,5 @@ private object PostgresDialect extends JdbcD

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-06 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/19893 I've taken a look at the failed test but seems like unrelated. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apac

[GitHub] spark issue #19913: [SPARK-22720] [SS] Make EventTimeWatermark Extend UnaryN...

2017-12-06 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/19913 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apach

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19893 **[Test build #4006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4006/testReport)** for PR 19893 at commit [`0d45a5b`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #19911: [SPARK-22717][SQL] Correct cascade default for po...

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155328166 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -100,5 +100,5 @@ private object PostgresDialect extends JdbcD

[GitHub] spark pull request #19911: [SPARK-22717][SQL] Correct cascade default for po...

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155325104 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -100,5 +100,5 @@ private object PostgresDialect extends JdbcD

[GitHub] spark pull request #19741: [SPARK-14228][CORE][YARN] Lost executor of RPC di...

2017-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19741 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19741: [SPARK-14228][CORE][YARN] Lost executor of RPC disassoci...

2017-12-06 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19741 LGTM, merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revie

[GitHub] spark issue #19907: [SPARK-22712][SQL] Use `buildReaderWithPartitionValues` ...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19907 **[Test build #84570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84570/testReport)** for PR 19907 at commit [`f69fc4e`](https://github.com/apache/spark/commit/f6

[GitHub] spark issue #19914: [SPARK-22699][SQL] GenerateSafeProjection should not use...

2017-12-06 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19914 @cloud-fan @kiszk @viirya may you please review this? Thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #19914: [SPARK-22699][SQL] GenerateSafeProjection should not use...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19914 **[Test build #84569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84569/testReport)** for PR 19914 at commit [`6d2ce8e`](https://github.com/apache/spark/commit/6d

[GitHub] spark pull request #19911: [SPARK-22717][SQL] Correct cascade default for po...

2017-12-06 Thread bolkedebruin
Github user bolkedebruin commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155318711 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -100,5 +100,5 @@ private object PostgresDialect extends JdbcDi

[GitHub] spark pull request #19914: [SPARK-22699][SQL] GenerateSafeProjection should ...

2017-12-06 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/19914 [SPARK-22699][SQL] GenerateSafeProjection should not use global variables for struct ## What changes were proposed in this pull request? GenerateSafeProjection is defining a mutable state

[GitHub] spark pull request #19911: [SPARK-22717][SQL] Correct cascade default for po...

2017-12-06 Thread bolkedebruin
Github user bolkedebruin commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155318011 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -100,5 +100,5 @@ private object PostgresDialect extends JdbcDi

[GitHub] spark issue #19717: [SPARK-22646] [Submission] Spark on Kubernetes - basic s...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19717 **[Test build #84568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84568/testReport)** for PR 19717 at commit [`3a0b8e3`](https://github.com/apache/spark/commit/3a

[GitHub] spark pull request #19905: [SPARK-22710] ConfigBuilder.fallbackConf should t...

2017-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19905 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19913: [SPARK-22720] [SS] Make EventTimeWatermark Extend UnaryN...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19913 **[Test build #84567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84567/testReport)** for PR 19913 at commit [`2ce27df`](https://github.com/apache/spark/commit/2c

[GitHub] spark issue #19905: [SPARK-22710] ConfigBuilder.fallbackConf should trigger ...

2017-12-06 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19905 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19836: [SPARK-22618][CORE] Catch exception in removeRDD to stop...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19836 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84562/ Test PASSed. ---

[GitHub] spark issue #19836: [SPARK-22618][CORE] Catch exception in removeRDD to stop...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19836 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #19913: [SPARK-22720] [SS] Make EventTimeWatermark UnaryN...

2017-12-06 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/19913 [SPARK-22720] [SS] Make EventTimeWatermark UnaryNode ## What changes were proposed in this pull request? Our Analyzer and Optimizer has multiple rules for `UnaryNode`. After making `EventTim

[GitHub] spark issue #19836: [SPARK-22618][CORE] Catch exception in removeRDD to stop...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19836 **[Test build #84562 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84562/testReport)** for PR 19836 at commit [`e2ad8c3`](https://github.com/apache/spark/commit/e

[GitHub] spark pull request #19717: [SPARK-22646] [Submission] Spark on Kubernetes - ...

2017-12-06 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/19717#discussion_r155314730 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala --- @@ -388,6 +388,33 @@ class SparkSubmitSuite conf.get("spark.ui.

[GitHub] spark pull request #19907: [SPARK-22712][SQL] Use `buildReaderWithPartitionV...

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19907#discussion_r155313387 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala --- @@ -167,8 +169,10 @@ class OrcFileFormat

[GitHub] spark pull request #19717: [SPARK-22646] [Submission] Spark on Kubernetes - ...

2017-12-06 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/19717#discussion_r155313063 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala --- @@ -388,6 +388,33 @@ class SparkSubmitSuite conf.get("spark.ui

[GitHub] spark pull request #19907: [SPARK-22712][SQL] Use `buildReaderWithPartitionV...

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19907#discussion_r155312307 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala --- @@ -167,8 +169,10 @@ class OrcFileFormat

[GitHub] spark pull request #19717: [SPARK-22646] [Submission] Spark on Kubernetes - ...

2017-12-06 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/19717#discussion_r155311310 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala --- @@ -388,6 +388,33 @@ class SparkSubmitSuite conf.get("spark.ui.

[GitHub] spark pull request #19717: [SPARK-22646] [Submission] Spark on Kubernetes - ...

2017-12-06 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/19717#discussion_r155311302 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -41,6 +41,10 @@ package object config { .bytesConf(ByteUnit.

[GitHub] spark pull request #19717: [SPARK-22646] [Submission] Spark on Kubernetes - ...

2017-12-06 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/19717#discussion_r155303789 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala --- @@ -388,6 +388,33 @@ class SparkSubmitSuite conf.get("spark.ui

[GitHub] spark pull request #19717: [SPARK-22646] [Submission] Spark on Kubernetes - ...

2017-12-06 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/19717#discussion_r155305418 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala --- @@ -55,14 +63,26 @@ private[spark] object Confi

[GitHub] spark pull request #19717: [SPARK-22646] [Submission] Spark on Kubernetes - ...

2017-12-06 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/19717#discussion_r155300795 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -41,6 +41,10 @@ package object config { .bytesConf(ByteUnit

[GitHub] spark pull request #19717: [SPARK-22646] [Submission] Spark on Kubernetes - ...

2017-12-06 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/19717#discussion_r155306429 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala --- @@ -119,5 +130,46 @@ private[spark] object Conf

[GitHub] spark pull request #19911: [SPARK-22717][SQL] Correct cascade default for po...

2017-12-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155306118 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala --- @@ -100,5 +100,5 @@ private object PostgresDialect extends JdbcDial

[GitHub] spark issue #19911: [SPARK-22717][SQL] Correct cascade default for postgres

2017-12-06 Thread danielvdende
Github user danielvdende commented on the issue: https://github.com/apache/spark/pull/19911 @srowen yep, I can add the details from the JIRA to the PR if you like (just to make it easier to read this PR in future if necessary) ---

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19901 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19901 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84561/ Test PASSed. ---

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19901 **[Test build #84561 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84561/testReport)** for PR 19901 at commit [`740f1a0`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #19885: [SPARK-22587] Spark job fails if fs.defaultFS and applic...

2017-12-06 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/19885 if you make a path of each of these and call getFileSystem() on them, you will end up with two different FS instances in the same JVM. But they'll both be talking to the same namenode using th

[GitHub] spark pull request #19864: [SPARK-22673][SQL] InMemoryRelation should utiliz...

2017-12-06 Thread CodingCat
Github user CodingCat commented on a diff in the pull request: https://github.com/apache/spark/pull/19864#discussion_r155296970 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -37,8 +37,10 @@ object InMemoryRelation {

[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84566/testReport)** for PR 19912 at commit [`962faab`](https://github.com/apache/spark/commit/96

[GitHub] spark pull request #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-06 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/19912 [SPARK-22719][SQL]Refactor ConstantPropagation ## What changes were proposed in this pull request? The current time complexity of ConstantPropagation is O(n^2), which can be slow whe

[GitHub] spark pull request #19900: [SPARK-22695][SQL] ScalaUDF should not use global...

2017-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19900 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19861 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84565/ Test FAILed. ---

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19861 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19861 **[Test build #84565 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84565/testReport)** for PR 19861 at commit [`8329a6b`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #19900: [SPARK-22695][SQL] ScalaUDF should not use global variab...

2017-12-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19900 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19896: [SPARK-22693][SQL] CreateNamedStruct and InSet should no...

2017-12-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19896 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apa

[GitHub] spark pull request #19899: [SPARK-22704][SQL] Least and Greatest use less gl...

2017-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19899 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19899: [SPARK-22704][SQL] Least and Greatest use less global va...

2017-12-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19899 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19899: [SPARK-22704][SQL] Least and Greatest use less global va...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19899 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84560/ Test PASSed. ---

[GitHub] spark issue #19899: [SPARK-22704][SQL] Least and Greatest use less global va...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19899 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19899: [SPARK-22704][SQL] Least and Greatest use less global va...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19899 **[Test build #84560 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84560/testReport)** for PR 19899 at commit [`e1ed6c1`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19861 **[Test build #84565 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84565/testReport)** for PR 19861 at commit [`8329a6b`](https://github.com/apache/spark/commit/83

[GitHub] spark issue #19900: [SPARK-22695][SQL] ScalaUDF should not use global variab...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19900 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84559/ Test PASSed. ---

[GitHub] spark issue #19900: [SPARK-22695][SQL] ScalaUDF should not use global variab...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19900 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19900: [SPARK-22695][SQL] ScalaUDF should not use global variab...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19900 **[Test build #84559 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84559/testReport)** for PR 19900 at commit [`f188d55`](https://github.com/apache/spark/commit/f

[GitHub] spark pull request #19889: [SPARK-22690][ML] Imputer inherit HasOutputCols

2017-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19889 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19864: [SPARK-22673][SQL] InMemoryRelation should utiliz...

2017-12-06 Thread CodingCat
Github user CodingCat commented on a diff in the pull request: https://github.com/apache/spark/pull/19864#discussion_r155287758 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala --- @@ -94,14 +94,16 @@ class CacheManager extends Logging {

[GitHub] spark issue #19836: [SPARK-22618][CORE] Catch exception in removeRDD to stop...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19836 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84553/ Test PASSed. ---

[GitHub] spark issue #19836: [SPARK-22618][CORE] Catch exception in removeRDD to stop...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19836 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19836: [SPARK-22618][CORE] Catch exception in removeRDD to stop...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19836 **[Test build #84553 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84553/testReport)** for PR 19836 at commit [`fbd2497`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19861 **[Test build #84563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84563/testReport)** for PR 19861 at commit [`0dd7f2e`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19861 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19861 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84563/ Test FAILed. ---

[GitHub] spark issue #19896: [SPARK-22693][SQL] CreateNamedStruct and InSet should no...

2017-12-06 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19896 I added back the changes for CreateNamedStruct. May you review this part again too? Thanks. --- - To unsubscribe, e-mail: revie

[GitHub] spark issue #19896: [SPARK-22693][SQL] CreateNamedStruct and InSet should no...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19896 **[Test build #84564 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84564/testReport)** for PR 19896 at commit [`36537d8`](https://github.com/apache/spark/commit/36

[GitHub] spark issue #19900: [SPARK-22695][SQL] ScalaUDF should not use global variab...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19900 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19900: [SPARK-22695][SQL] ScalaUDF should not use global variab...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19900 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84555/ Test PASSed. ---

[GitHub] spark issue #19900: [SPARK-22695][SQL] ScalaUDF should not use global variab...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19900 **[Test build #84555 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84555/testReport)** for PR 19900 at commit [`eef8036`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #19903: [SPARK-20728][SQL][FOLLOWUP] Use an actionable exception...

2017-12-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19903 Thank you, @HyukjinKwon , @cloud-fan , @gatorsmile , @viirya ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apac

[GitHub] spark issue #19911: [SPARK-22717][SQL] Correct cascade default for postgres

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19911 **[Test build #4005 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4005/testReport)** for PR 19911 at commit [`40bd8ac`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19893 **[Test build #4006 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4006/testReport)** for PR 19893 at commit [`0d45a5b`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #19911: [SPARK-22717][SQL] Correct cascade default for postgres

2017-12-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19911 I don't disbelieve you but do you have a reference? is it version-specific or anything? just want to be sure. --- - To unsubscrib

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19861 **[Test build #84563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84563/testReport)** for PR 19861 at commit [`0dd7f2e`](https://github.com/apache/spark/commit/0d

[GitHub] spark issue #19905: [SPARK-22710] ConfigBuilder.fallbackConf should trigger ...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19905 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84551/ Test PASSed. ---

[GitHub] spark issue #19905: [SPARK-22710] ConfigBuilder.fallbackConf should trigger ...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19905 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19905: [SPARK-22710] ConfigBuilder.fallbackConf should trigger ...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19905 **[Test build #84551 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84551/testReport)** for PR 19905 at commit [`028e0fa`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19901 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84557/ Test FAILed. ---

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19901 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19901 **[Test build #84557 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84557/testReport)** for PR 19901 at commit [`6a14e16`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #19896: [SPARK-22693][SQL] InSet should not use global variables

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19896 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84552/ Test PASSed. ---

[GitHub] spark issue #19896: [SPARK-22693][SQL] InSet should not use global variables

2017-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19896 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #19910: [SPARK-22715][SQL] Reuse the same array in Create...

2017-12-06 Thread mgaido91
Github user mgaido91 closed the pull request at: https://github.com/apache/spark/pull/19910 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19896: [SPARK-22693][SQL] InSet should not use global variables

2017-12-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19896 **[Test build #84552 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84552/testReport)** for PR 19896 at commit [`b5bd951`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #19910: [SPARK-22715][SQL] Reuse the same array in CreateNamedSt...

2017-12-06 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19910 I did a quick search, seems we do follow the rule that avoids reusing the data array. Let's restore the change in #19896 --- -

[GitHub] spark issue #19901: [SPARK-22705][SQL] Case, Coalesce, and In use less globa...

2017-12-06 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19901 LGTM too --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.

[GitHub] spark issue #16618: [SPARK-14409][ML][WIP] Add RankingEvaluator

2017-12-06 Thread acompa
Github user acompa commented on the issue: https://github.com/apache/spark/pull/16618 I'm also curious about this @MLnick. Seems like there was a lot of movement earlier this year, but this PR has gotten stale. I can also contribute if @Kornel cannot for any reason. --- --

[GitHub] spark issue #19899: [SPARK-22704][SQL] Least and Greatest use less global va...

2017-12-06 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19899 LGTM, thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@s

<    1   2   3   4   5   6   7   >