Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19939#discussion_r156001886
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -235,6 +239,61 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19939#discussion_r156001560
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -235,6 +239,61 @@ class
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19937
LGTM except one code style comment
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r156000717
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r15631
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -513,26 +513,28 @@ case class SortMergeJoinExec(
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19938
I have the same feeling with @viirya , expressions/operators usually won't
mutate input from children. One concern is how to guarantee this
programmatically, but might be OK as I don't think this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19717
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84701/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19717
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19717
**[Test build #84701 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84701/testReport)**
for PR 19717 at commit
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19927#discussion_r155996272
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -156,54 +153,22 @@ final class OneVsRestModel private[ml] (
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19911
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19911
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84702/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19911
**[Test build #84702 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84702/testReport)**
for PR 19911 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19082
Ya, I was just trying to do that tonight! Thanks for pinging me.
---
-
To unsubscribe, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19082
@maropu could you please resolve conflicts?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19938
Thank you for great thought. Let me think about it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r155989817
--- Diff: pom.xml ---
@@ -185,7 +185,7 @@
2.8
1.8
1.0.0
-0.4.0
+0.8.0-SNAPSHOT
--- End diff --
Please
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19884#discussion_r155983224
--- Diff: python/pyspark/serializers.py ---
@@ -223,27 +223,13 @@ def _create_batch(series, timezone):
series = [series]
series = ((s,
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/19841
It would be great if someone help to merge it to master, Thanks!
@gatorsmile @srowen @HyukjinKwon @wangyum
---
-
To
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155984429
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -513,26 +513,28 @@ case class SortMergeJoinExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155984439
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -513,26 +513,28 @@ case class SortMergeJoinExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155984232
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155984096
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -513,26 +513,28 @@ case class SortMergeJoinExec(
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19721
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19721
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19911
**[Test build #84702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84702/testReport)**
for PR 19911 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19911
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19717
**[Test build #84701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84701/testReport)**
for PR 19717 at commit
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r155979284
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -0,0 +1,240 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r155979118
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2744,6 +2744,42 @@ private[spark] object Utils extends Logging {
}
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r155979008
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -294,6 +298,16 @@ object SparkSubmit extends CommandLineUtils with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19783
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84700/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19783
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19783
**[Test build #84700 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84700/testReport)**
for PR 19783 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19937
@cloud-fan @viirya Could you please review this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19783
**[Test build #84700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84700/testReport)**
for PR 19783 at commit
Github user ron8hu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155964396
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -114,4 +114,171 @@ object
Github user ron8hu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155963930
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/FilterEstimationSuite.scala
---
@@ -359,7 +371,7 @@ class
Github user ron8hu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155963740
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -471,37 +508,47 @@ case
Github user ron8hu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155963622
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -332,8 +332,41 @@ case
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19939
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84697/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19939
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19939
**[Test build #84697 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84697/testReport)**
for PR 19939 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19599
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19599
**[Test build #84699 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84699/testReport)**
for PR 19599 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19599
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84699/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19599
**[Test build #84699 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84699/testReport)**
for PR 19599 at commit
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r155956779
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2744,6 +2744,42 @@ private[spark] object Utils extends Logging {
}
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r155957034
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -0,0 +1,240 @@
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r155956719
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -294,6 +298,16 @@ object SparkSubmit extends CommandLineUtils with
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/19876
@sethah: want to publish the comments from when we were chatting in
Singapore? :p
---
-
To unsubscribe, e-mail:
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r155956360
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark-base/Dockerfile
---
@@ -0,0 +1,43 @@
+#
+# Licensed to the Apache
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19754
I think these are Jenkins specific config related to how the user
credentials are stored (not) securely?
Specifically I donât know how we are saving ASF user and password inside
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19599
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84698/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19599
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19599
**[Test build #84698 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84698/testReport)**
for PR 19599 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19811
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84696/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19811
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19811
**[Test build #84696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84696/testReport)**
for PR 19811 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19939
**[Test build #84697 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84697/testReport)**
for PR 19939 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19599
**[Test build #84698 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84698/testReport)**
for PR 19599 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19939
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19940
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19940
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84695/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19940
**[Test build #84695 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84695/testReport)**
for PR 19940 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19938
They are possibly passed in split functions. But it is hard to image a case
we will change their values in the functions. In SparkSQL, the output from a
child operator are just used as input to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19811
**[Test build #84696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84696/testReport)**
for PR 19811 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155949301
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19938
Can we guarantee 100% that any operation in `consume()` at
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19940
**[Test build #84695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84695/testReport)**
for PR 19940 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19933
No, I understand it. Good news is you can already do this, and the driver
host is actually probably already in the logs. This is definitely not a config
property, no matter what. Whatever your logic
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/19940
[SPARK-22750][SQL] Reuse mutable states when possible
## What changes were proposed in this pull request?
The PR introduces a new method `addSingleMutableState ` to `CodeGenerator`
to
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16578
As I mentioned before, we still don't have enough eyes on this change so
far.
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19938
IIUC, the problem is only happened when we wrongly pass global variables
into split functions and change the values. Will we change the result variables
from aggregation?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19939
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84693/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19939
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19939
**[Test build #84693 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84693/testReport)**
for PR 19939 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19938
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19938
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84694/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19938
**[Test build #84694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84694/testReport)**
for PR 19938 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155944247
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155944205
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155942157
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19939
**[Test build #84693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84693/testReport)**
for PR 19939 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19938
**[Test build #84694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84694/testReport)**
for PR 19938 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19938
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19939
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19938
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19939
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19939
**[Test build #84692 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84692/testReport)**
for PR 19939 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19938
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84691/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19938
**[Test build #84691 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84691/testReport)**
for PR 19938 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19939
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84692/
Test FAILed.
---
93 matches
Mail list logo
