[GitHub] spark issue #20034: [SPARK-22846][SQL] Fix table owner is null when creating...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20034 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20036 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Co...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20036#discussion_r158753678 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -299,7 +299,7 @@ class CodegenContext

[GitHub] spark issue #20075: [SPARK-21208][R] Adds setLocalProperty and getLocalPrope...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20075 **[Test build #85417 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85417/testReport)** for PR 20075 at commit

[GitHub] spark issue #20075: [SPARK-21208][R] Adds setLocalProperty and getLocalPrope...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20075 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85417/ Test PASSed. ---

[GitHub] spark issue #20075: [SPARK-21208][R] Adds setLocalProperty and getLocalPrope...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20075 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20056: [SPARK-22878] [CORE] Count totalDroppedEvents for LiveLi...

Github user Ngone51 commented on the issue: https://github.com/apache/spark/pull/20056 It seems something wrong while testing 'ReplayListenerSuite': ``` [info] ReplayListenerSuite: [info] - Simple replay (97 milliseconds) [info] - Replay compressed inprogress log file

[GitHub] spark issue #14658: [WIP][SPARK-5928][SPARK-6238] Remote Shuffle Blocks cann...

Github user MJFND commented on the issue: https://github.com/apache/spark/pull/14658 Okay, but even if not then increasing the number of shuffle partition should fix it, but its not. On Dec 26, 2017 8:51 PM, "Guoqiang Li" wrote: > Spark

[GitHub] spark issue #14658: [WIP][SPARK-5928][SPARK-6238] Remote Shuffle Blocks cann...

Github user witgo commented on the issue: https://github.com/apache/spark/pull/14658 Spark 2.2 has fixed this issue. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Co...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20036#discussion_r158752728 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -283,7 +283,7 @@ case class InputAdapter(child:

[GitHub] spark issue #18906: [SPARK-21692][PYSPARK][SQL] Add nullability support to P...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18906 Right, let's go ahead. Please let me know anyone has an explicit objection for this one. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19813: [SPARK-22600][SQL] Fix 64kb limit for deeply nested expr...

Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19813 Do we have to sacrifice one of them? If we do then I agree deeply nested expression is more common than a long chain of arithmetic expressions and we should get this patch. I think we should

[GitHub] spark pull request #18906: [SPARK-21692][PYSPARK][SQL] Add nullability suppo...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18906#discussion_r158752315 --- Diff: python/pyspark/sql/tests.py --- @@ -1,3 +1,4 @@ + --- End diff -- Let's remove this line ---

[GitHub] spark issue #18906: [SPARK-21692][PYSPARK][SQL] Add nullability support to P...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18906 **[Test build #85419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85419/testReport)** for PR 18906 at commit

[GitHub] spark issue #18906: [SPARK-21692][PYSPARK][SQL] Add nullability support to P...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18906 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20082: [SPARK-22897][CORE]: Expose stageAttemptId in Tas...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20082#discussion_r158752147 --- Diff: project/MimaExcludes.scala --- @@ -95,7 +95,10 @@ object MimaExcludes { // [SPARK-21087] CrossValidator, TrainValidationSplit

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158751974 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala --- @@ -57,19 +59,15 @@ private[execution] sealed case class

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158751868 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -276,22 +276,28 @@ class PlanParserSuite extends

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158751828 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ColumnPruningSuite.scala --- @@ -38,54 +38,69 @@ class ColumnPruningSuite

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158751840 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala --- @@ -628,14 +628,14 @@ class

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158751759 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ColumnPruningSuite.scala --- @@ -38,54 +38,69 @@ class ColumnPruningSuite

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158751546 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -444,12 +444,22 @@ object ColumnPruning extends

[GitHub] spark pull request #20075: [SPARK-21208][R] Adds setLocalProperty and getLoc...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20075#discussion_r158751340 --- Diff: R/pkg/R/sparkR.R --- @@ -560,10 +560,55 @@ cancelJobGroup <- function(sc, groupId) { #'} #' @note setJobDescription since 2.3.0

[GitHub] spark issue #20061: [SPARK-22890][TEST] Basic tests for DateTimeOperations

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20061 **[Test build #85418 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85418/testReport)** for PR 20061 at commit

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158751339 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -444,12 +444,22 @@ object ColumnPruning extends

[GitHub] spark issue #20075: [SPARK-21208][R] Adds setLocalProperty and getLocalPrope...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20075 **[Test build #85417 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85417/testReport)** for PR 20075 at commit

[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...

Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/20025 Could you please merge this to Master? Thanks @felixcheung --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20056: [SPARK-22878] [CORE] Count totalDroppedEvents for...

Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/20056#discussion_r158751285 --- Diff: core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala --- @@ -25,14 +25,13 @@ import scala.collection.JavaConverters._ import

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158751132 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -608,8 +608,8 @@ trait CheckAnalysis extends

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19683 **[Test build #85416 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85416/testReport)** for PR 19683 at commit

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158751010 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1605,7 +1607,8 @@ class Analyzer(

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158750949 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -695,7 +695,7 @@ class Analyzer(

[GitHub] spark issue #20075: [SPARK-21208][R] Adds setLocalProperty and getLocalPrope...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20075 Yup, they should be handled too. Let me update. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #16611: [SPARK-17967][SPARK-17878][SQL][PYTHON] Support for arra...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16611 Hi @gatorsmile, WDYT about this PR? I was looking through my old PRs to close or update. I wonder if you think it looks fine to go ahead to you. ---

[GitHub] spark issue #19675: [SPARK-14540][BUILD] Support Scala 2.12 closures and Jav...

Github user jvican commented on the issue: https://github.com/apache/spark/pull/19675 Is there any ticket that describes what needs to be done? Otherwise, could you elaborate on it a that I have a clearer idea of what you need to have a 100% working 2.12-compatible Spark? Is the 1%

[GitHub] spark issue #20055: [SPARK-22875][BUILD] Assembly build fails for a high use...

Github user gerashegalov commented on the issue: https://github.com/apache/spark/pull/20055 agreed @srowen, this is a better fix although no other goal seemed affected. Thanks for suggestion! --- - To unsubscribe,

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19683 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85414/ Test FAILed. ---

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19683 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19683 **[Test build #85414 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85414/testReport)** for PR 19683 at commit

[GitHub] spark issue #20056: [SPARK-22878] [CORE] Count totalDroppedEvents for LiveLi...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20056 **[Test build #85415 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85415/testReport)** for PR 20056 at commit

[GitHub] spark issue #14658: [WIP][SPARK-5928][SPARK-6238] Remote Shuffle Blocks cann...

Github user MJFND commented on the issue: https://github.com/apache/spark/pull/14658 If "Remote Shuffle Blocks cannot be more than 2 GB" then setting up spark.sql.shuffle.partitions=value, where value should be such that it has 2gb per executor, like for 200GB of data, we can have

[GitHub] spark pull request #20070: SPARK-22896 Improvement in String interpolation

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20070#discussion_r158744300 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/QuantileDiscretizerExample.scala --- @@ -31,12 +31,11 @@ object QuantileDiscretizerExample {

[GitHub] spark pull request #20070: SPARK-22896 Improvement in String interpolation

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20070#discussion_r158744230 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/CorrelationExample.scala --- @@ -51,10 +51,10 @@ object CorrelationExample {

[GitHub] spark pull request #20070: SPARK-22896 Improvement in String interpolation

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20070#discussion_r158744186 --- Diff: examples/src/main/scala/org/apache/spark/examples/graphx/Analytics.scala --- @@ -145,9 +145,9 @@ object Analytics extends Logging {

[GitHub] spark pull request #20070: SPARK-22896 Improvement in String interpolation

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20070#discussion_r158744360 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/CustomReceiver.scala --- @@ -82,9 +82,9 @@ class CustomReceiver(host: String, port:

[GitHub] spark pull request #20070: SPARK-22896 Improvement in String interpolation

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20070#discussion_r158744210 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/ChiSquareTestExample.scala --- @@ -52,9 +52,9 @@ object ChiSquareTestExample {

[GitHub] spark pull request #20070: SPARK-22896 Improvement in String interpolation

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20070#discussion_r158744255 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/DeveloperApiExample.scala --- @@ -169,10 +169,10 @@ private class MyLogisticRegressionModel(

[GitHub] spark issue #20075: [SPARK-21208][R] Adds setLocalProperty and getLocalPrope...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20075 getLocalProperty Should not be returning invisible, I think. Also can you check if we need to fail for key == NA? ---

[GitHub] spark issue #20073: [SPARK-22843][R] Adds localCheckpoint in R

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20073 Fair enough. Calling it, is good enough. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19683 **[Test build #85414 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85414/testReport)** for PR 19683 at commit

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19683 **[Test build #85413 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85413/testReport)** for PR 19683 at commit

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19683 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85413/ Test FAILed. ---

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19683 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19683 **[Test build #85413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85413/testReport)** for PR 19683 at commit

[GitHub] spark issue #20059: [SPARK-22648][K8s] Add documentation covering init conta...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20059 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85411/ Test PASSed. ---

[GitHub] spark issue #20059: [SPARK-22648][K8s] Add documentation covering init conta...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20059 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20059: [SPARK-22648][K8s] Add documentation covering init conta...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20059 **[Test build #85411 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85411/testReport)** for PR 20059 at commit

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

Github user uzadude commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158737578 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -846,12 +846,13 @@ class Analyzer( //

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

Github user uzadude commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158737560 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -695,7 +695,7 @@ class Analyzer(

[GitHub] spark issue #20084: [SPARK-22904][SQL] Add tests for decimal operations and ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20084 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85412/ Test FAILed. ---

[GitHub] spark issue #20084: [SPARK-22904][SQL] Add tests for decimal operations and ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20084 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20084: [SPARK-22904][SQL] Add tests for decimal operations and ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20084 **[Test build #85412 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85412/testReport)** for PR 20084 at commit

[GitHub] spark issue #20082: [SPARK-22897][CORE]: Expose stageAttemptId in TaskContex...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20082 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85410/ Test FAILed. ---

[GitHub] spark issue #20082: [SPARK-22897][CORE]: Expose stageAttemptId in TaskContex...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20082 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20082: [SPARK-22897][CORE]: Expose stageAttemptId in TaskContex...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20082 **[Test build #85410 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85410/testReport)** for PR 20082 at commit

[GitHub] spark issue #20085: [SPARK-22739][Catalyst][WIP] Additional Expression Suppo...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20085 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20085: [SPARK-22739][Catalyst][WIP] Additional Expression Suppo...

Github user bdrillard commented on the issue: https://github.com/apache/spark/pull/20085 cc: @marmbrus --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20085: [SPARK-22739][Catalyst][WIP] Additional Expressio...

GitHub user bdrillard opened a pull request: https://github.com/apache/spark/pull/20085 [SPARK-22739][Catalyst][WIP] Additional Expression Support for Objects ## What changes were proposed in this pull request? This PR is a work-in-progress adding additional `Expression`

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20070 @srowen I rechecked all scala examples and this is commulative PR for the same. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over...

Github user bdrillard commented on a diff in the pull request: https://github.com/apache/spark/pull/20010#discussion_r158724861 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -158,11 +213,8 @@ object TypeCoercion {

[GitHub] spark pull request #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over...

Github user bdrillard commented on a diff in the pull request: https://github.com/apache/spark/pull/20010#discussion_r158728293 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -158,11 +169,6 @@ object TypeCoercion {

[GitHub] spark issue #20084: [SPARK-22904][SQL] Add tests for decimal operations and ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20084 **[Test build #85412 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85412/testReport)** for PR 20084 at commit

[GitHub] spark issue #20055: [SPARK-22875][BUILD] Assembly build fails for a high use...

Github user srowen commented on the issue: https://github.com/apache/spark/pull/20055 Ping @gerashegalov --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20023: [SPARK-22036][SQL] Decimal multiplication with high prec...

Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20023 @gatorsmile created #20084 for adding tests. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20084: [SPARK-22904][SQL] Add tests for decimal operatio...

GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/20084 [SPARK-22904][SQL] Add tests for decimal operations and string casts ## What changes were proposed in this pull request? Test coverage for arithmetic operations leading to: 1.

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20070 You're correct - I missed other packages. I will re-confirm soon. Thanks. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20070 In scala ? I don't think so. I am re-iterating and doing double check. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

Github user srowen commented on the issue: https://github.com/apache/spark/pull/20070 I think there are many more examples of this; a quick search suggests there are about 40 example files that have some string concatenation. ---

[GitHub] spark pull request #20067: [SPARK-22894][SQL] DateTimeOperations should acce...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20067 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20081: [SPARK-22833][EXAMPLE] Improvement SparkHive Scal...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20081 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20067: [SPARK-22894][SQL] DateTimeOperations should accept SQL ...

Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20067 LGTM Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20067: [SPARK-22894][SQL] DateTimeOperations should acce...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20067#discussion_r158725996 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2760,6 +2760,17 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark issue #20081: [SPARK-22833][EXAMPLE] Improvement SparkHive Scala Examp...

Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20081 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19498: [SPARK-17756][PYTHON][STREAMING] Workaround to avoid ret...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19498 To be honest, I think more correct fix might be just to `_reserialize` but just want to avoid any potential regression by avoiding class check and using existing workaround used. ---

[GitHub] spark pull request #20071: SPARK-22896 Improvement in String interpolation |...

Github user chetkhatri closed the pull request at: https://github.com/apache/spark/pull/20071 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20071: SPARK-22896 Improvement in String interpolation | Graphx

Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20071 @srowen Thanks, Addressed and changes done. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20070 @srowen also i did merge another similiar PR with graphx to here. so Just FYI - we are good. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20056: [SPARK-22878] [CORE] Count totalDroppedEvents for LiveLi...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20056 Just fix and push a commit. It will retest it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20059: [SPARK-22648][K8s] Add documentation covering init conta...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20059 **[Test build #85411 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85411/testReport)** for PR 20059 at commit

[GitHub] spark issue #19498: [SPARK-17756][PYTHON][STREAMING] Workaround to avoid ret...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19498 I just took a look. This looks actually going to bigger change because we will need manually deal with the different de/serializers cases in Python side as well, for example: ```

[GitHub] spark pull request #20059: [SPARK-22648][K8s] Add documentation covering ini...

Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20059#discussion_r158722622 --- Diff: docs/running-on-kubernetes.md --- @@ -528,51 +576,91 @@ specific to Spark on Kubernetes. -

[GitHub] spark issue #20083: Supporting different host for Spark-shuffle

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20083 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20083: Supporting different host for Spark-shuffle

GitHub user pianista215 opened a pull request: https://github.com/apache/spark/pull/20083 Supporting different host for Spark-shuffle ## What changes were proposed in this pull request? Adding an option as spark.shuffle.service.host let you to specify different ip for the

[GitHub] spark pull request #20082: [SPARK-22897][CORE]: Expose stageAttemptId in Tas...

Github user advancedxy commented on a diff in the pull request: https://github.com/apache/spark/pull/20082#discussion_r158721239 --- Diff: project/MimaExcludes.scala --- @@ -95,7 +95,10 @@ object MimaExcludes { // [SPARK-21087] CrossValidator, TrainValidationSplit

[GitHub] spark issue #20082: [SPARK-22897][CORE]: Expose stageAttemptId in TaskContex...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20082 **[Test build #85410 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85410/testReport)** for PR 20082 at commit

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20070 @srowen Absolutely correct, this all in one shot. I did changes in all. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20081: [SPARK-22833][EXAMPLE] Improvement SparkHive Scala Examp...

Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20081 @cloud-fan @srowen I am good with changes proposed. please do merge. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20082: [SPARK-22897][CORE]: Expose stageAttemptId in TaskContex...

Github user advancedxy commented on the issue: https://github.com/apache/spark/pull/20082 >Please explain in the JIRA/PR description about your use case that need to access the stageAttemptId in the executor - we must provide a very good reason to make such a change to a public

[GitHub] spark issue #20082: [SPARK-22897][CORE]: Expose stageAttemptId in TaskContex...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20082 **[Test build #85409 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85409/testReport)** for PR 20082 at commit

[GitHub] spark issue #20082: [SPARK-22897][CORE]: Expose stageAttemptId in TaskContex...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20082 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85409/ Test FAILed. ---

<    1   2   3   4   >