[GitHub] spark issue #20157: [SPARK-22757][K8S] Enable spark.jars and spark.files in ...

2018-01-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20157 Looks good pending tests. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #20138: [SPARK-20664][core] Delete stale application data from S...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20138 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85686/ Test PASSed. ---

[GitHub] spark issue #20138: [SPARK-20664][core] Delete stale application data from S...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20138 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20138: [SPARK-20664][core] Delete stale application data from S...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20138 **[Test build #85686 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85686/testReport)** for PR 20138 at commit [`388858b`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #20157: [SPARK-22757][K8S] Enable spark.jars and spark.files in ...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20157 **[Test build #85698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85698/testReport)** for PR 20157 at commit [`a98a231`](https://github.com/apache/spark/commit/a9

[GitHub] spark issue #20154: [SPARK-22960][k8s] Make build-push-docker-images.sh more...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20154 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20154: [SPARK-22960][k8s] Make build-push-docker-images.sh more...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20154 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85685/ Test PASSed. ---

[GitHub] spark pull request #20157: [SPARK-22757][K8S] Enable spark.jars and spark.fi...

2018-01-04 Thread liyinan926
GitHub user liyinan926 opened a pull request: https://github.com/apache/spark/pull/20157 [SPARK-22757][K8S] Enable spark.jars and spark.files in KUBERNETES mode ## What changes were proposed in this pull request? We missed enabling `spark.files` and `spark.jars` in https://

[GitHub] spark issue #20154: [SPARK-22960][k8s] Make build-push-docker-images.sh more...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20154 **[Test build #85685 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85685/testReport)** for PR 20154 at commit [`2ce48f9`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #20155: [SPARK-22961][REGRESSION] Constant columns should genera...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20155 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85687/ Test PASSed. ---

[GitHub] spark issue #20155: [SPARK-22961][REGRESSION] Constant columns should genera...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20155 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20155: [SPARK-22961][REGRESSION] Constant columns should genera...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20155 **[Test build #85687 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85687/testReport)** for PR 20155 at commit [`9c8f5c2`](https://github.com/apache/spark/commit/9

[GitHub] spark pull request #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSui...

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20147#discussion_r159757298 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -85,6 +90,43 @@ class HiveExternalCatalogVersionsS

[GitHub] spark pull request #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSui...

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20147#discussion_r159755262 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -85,6 +90,43 @@ class HiveExternalCatalogVersionsS

[GitHub] spark pull request #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSui...

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20147#discussion_r159754446 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -56,10 +60,11 @@ class HiveExternalCatalogVersions

[GitHub] spark pull request #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSui...

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20147#discussion_r159756262 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -85,6 +90,43 @@ class HiveExternalCatalogVersionsS

[GitHub] spark pull request #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSui...

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20147#discussion_r159756731 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -85,6 +90,43 @@ class HiveExternalCatalogVersionsS

[GitHub] spark pull request #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSui...

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20147#discussion_r159754913 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -85,6 +90,43 @@ class HiveExternalCatalogVersionsS

[GitHub] spark pull request #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSui...

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20147#discussion_r159755811 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -85,6 +90,43 @@ class HiveExternalCatalogVersionsS

[GitHub] spark pull request #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSui...

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20147#discussion_r159756988 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala --- @@ -85,6 +90,43 @@ class HiveExternalCatalogVersionsS

[GitHub] spark issue #20154: [SPARK-22960][k8s] Make build-push-docker-images.sh more...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20154 **[Test build #85697 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85697/testReport)** for PR 20154 at commit [`ef99214`](https://github.com/apache/spark/commit/ef

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85695 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85695/testReport)** for PR 20148 at commit [`5278ea7`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85695/ Test PASSed. ---

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20154: [SPARK-22960][k8s] Make build-push-docker-images....

2018-01-04 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20154#discussion_r159754427 --- Diff: docs/running-on-kubernetes.md --- @@ -215,8 +218,8 @@ If the pod has encountered a runtime error, the status can be probed further usi kubectl

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85694/ Test PASSed. ---

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85694 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85694/testReport)** for PR 20148 at commit [`92ef568`](https://github.com/apache/spark/commit/9

[GitHub] spark pull request #20154: [SPARK-22960][k8s] Make build-push-docker-images....

2018-01-04 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20154#discussion_r159754082 --- Diff: sbin/build-push-docker-images.sh --- @@ -19,51 +19,131 @@ # This script builds and pushes docker images when run from a release of Spark

[GitHub] spark issue #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSuite shou...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20147 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85689/ Test PASSed. ---

[GitHub] spark issue #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSuite shou...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20147 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20154: [SPARK-22960][k8s] Make build-push-docker-images.sh more...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20154 **[Test build #85696 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85696/testReport)** for PR 20154 at commit [`9a2d6d3`](https://github.com/apache/spark/commit/9a

[GitHub] spark issue #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSuite shou...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20147 **[Test build #85689 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85689/testReport)** for PR 20147 at commit [`e85b813`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

2018-01-04 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/20156 LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.a

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85695 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85695/testReport)** for PR 20148 at commit [`5278ea7`](https://github.com/apache/spark/commit/52

[GitHub] spark pull request #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to ...

2018-01-04 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20156#discussion_r159752504 --- Diff: dev/sparktestsupport/modules.py --- @@ -539,7 +539,7 @@ def __hash__(self): kubernetes = Module( name="kubernetes", depen

[GitHub] spark pull request #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to ...

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20156#discussion_r159751882 --- Diff: dev/sparktestsupport/modules.py --- @@ -539,7 +539,7 @@ def __hash__(self): kubernetes = Module( name="kubernetes", dependenc

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85694 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85694/testReport)** for PR 20148 at commit [`92ef568`](https://github.com/apache/spark/commit/92

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-04 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159751143 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/BasicDriverConfigurationStep.scala --- @@ -119,7 +11

[GitHub] spark pull request #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to ...

2018-01-04 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20156#discussion_r159751012 --- Diff: dev/sparktestsupport/modules.py --- @@ -539,7 +539,7 @@ def __hash__(self): kubernetes = Module( name="kubernetes", depen

[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

2018-01-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20156 @foxish @liyinan926 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85693/ Test FAILed. ---

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85693 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85693/testReport)** for PR 20148 at commit [`6636410`](https://github.com/apache/spark/commit/6

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-04 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159740606 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/BasicDriverConfigurationStep.scala --- @@ -119,7 +119,7

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85693/testReport)** for PR 20148 at commit [`6636410`](https://github.com/apache/spark/commit/66

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-04 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159739212 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/BasicDriverConfigurationStep.scala --- @@ -119,7 +11

[GitHub] spark issue #20013: [SPARK-20657][core] Speed up rendering of the stages pag...

2018-01-04 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/20013 I'll take a look at this either today or tomorrow --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additi

[GitHub] spark pull request #20144: [SPARK-21475][CORE][2nd attempt] Change to use NI...

2018-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20144 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20144: [SPARK-21475][CORE][2nd attempt] Change to use NIO's Fil...

2018-01-04 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/20144 LGTM. Thanks! Merging to master and 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comman

[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20156 **[Test build #85692 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85692/testReport)** for PR 20156 at commit [`edc3e18`](https://github.com/apache/spark/commit/ed

[GitHub] spark pull request #20154: [SPARK-22960][k8s] Make build-push-docker-images....

2018-01-04 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20154#discussion_r159735381 --- Diff: sbin/build-push-docker-images.sh --- @@ -19,51 +19,118 @@ # This script builds and pushes docker images when run from a release of Spark

[GitHub] spark issue #20142: [SPARK-22930][PYTHON][SQL] Improve the description of Ve...

2018-01-04 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/20142 @BryanCutler Yeah I think we could. Let me add it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For addi

[GitHub] spark issue #19671: [SPARK-22297][CORE TESTS] Flaky test: BlockManagerSuite ...

2018-01-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19671 It's not a question of how often, it's that it fails. That's the definition of flaky. It obviously doesn't fail all the time, which is why it's a minor bug. --- ---

[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20152 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20152 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85684/ Test PASSed. ---

[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20152 **[Test build #85684 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85684/testReport)** for PR 20152 at commit [`448dcce`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85690/ Test PASSed. ---

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85690 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85690/testReport)** for PR 20148 at commit [`b17fe4d`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #20142: [SPARK-22930][PYTHON][SQL] Improve the description of Ve...

2018-01-04 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20142 Thanks for doing this @icexelloss ! Should we add a non-deterministic test for `pandas_udf` like [here](https://github.com/apache/spark/commit/ff48b1b338241039a7189e7a3c04333b1256fdb3#diff-7c2f

[GitHub] spark issue #19575: [WIP][SPARK-22221][DOCS] Adding User Documentation for A...

2018-01-04 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/19575 I am happy to help out with some sections. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional c

[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20156 **[Test build #85691 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85691/testReport)** for PR 20156 at commit [`a09a728`](https://github.com/apache/spark/commit/a0

[GitHub] spark pull request #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to ...

2018-01-04 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/20156 [SPARK-22948][k8s] Move SparkPodInitContainer to correct package. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vanzin/spark SPARK-22948 Alte

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20148 **[Test build #85690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85690/testReport)** for PR 20148 at commit [`b17fe4d`](https://github.com/apache/spark/commit/b1

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-04 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159729690 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/SecretVolumeUtils.scala --- @@ -14,23 +14,20 @@ * See the L

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-04 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159729720 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/SecretVolumeUtils.scala --- @@ -14,23 +14,20 @@ * See the L

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159729042 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/SecretVolumeUtils.scala --- @@ -14,23 +14,20 @@ * See the Licen

[GitHub] spark pull request #20148: [SPARK-22953][K8S] Avoids adding duplicated secre...

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20148#discussion_r159729003 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/SecretVolumeUtils.scala --- @@ -14,23 +14,20 @@ * See the Licen

[GitHub] spark issue #20147: [SPARK-22940][SQL] HiveExternalCatalogVersionsSuite shou...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20147 **[Test build #85689 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85689/testReport)** for PR 20147 at commit [`e85b813`](https://github.com/apache/spark/commit/e8

[GitHub] spark pull request #20154: [SPARK-22960][k8s] Make build-push-docker-images....

2018-01-04 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20154#discussion_r159724221 --- Diff: sbin/build-push-docker-images.sh --- @@ -19,51 +19,118 @@ # This script builds and pushes docker images when run from a release of Spark

[GitHub] spark issue #20154: [SPARK-22960][k8s] Make build-push-docker-images.sh more...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20154 **[Test build #85688 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85688/testReport)** for PR 20154 at commit [`e1ea8a7`](https://github.com/apache/spark/commit/e1

[GitHub] spark pull request #20154: [SPARK-22960][k8s] Make build-push-docker-images....

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20154#discussion_r159722529 --- Diff: sbin/build-push-docker-images.sh --- @@ -19,51 +19,118 @@ # This script builds and pushes docker images when run from a release of Spark

[GitHub] spark issue #19575: [WIP][SPARK-22221][DOCS] Adding User Documentation for A...

2018-01-04 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/19575 Yes, I think we do need something to at least highlight some differences if using Arrow. I've been meaning to work on this, just been too busy lately. @icexelloss if you're able to help out on

[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85682/ Test PASSed. ---

[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85682/testReport)** for PR 20010 at commit [`09e49fb`](https://github.com/apache/spark/commit/0

[GitHub] spark pull request #20154: [SPARK-22960][k8s] Make build-push-docker-images....

2018-01-04 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20154#discussion_r159721343 --- Diff: docs/running-on-kubernetes.md --- @@ -16,6 +16,8 @@ Kubernetes scheduler that has been added to Spark. you may setup a test cluster on your

[GitHub] spark pull request #20154: [SPARK-22960][k8s] Make build-push-docker-images....

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20154#discussion_r159721263 --- Diff: sbin/build-push-docker-images.sh --- @@ -19,51 +19,118 @@ # This script builds and pushes docker images when run from a release of Spark

[GitHub] spark pull request #20154: [SPARK-22960][k8s] Make build-push-docker-images....

2018-01-04 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20154#discussion_r159720906 --- Diff: docs/running-on-kubernetes.md --- @@ -16,6 +16,8 @@ Kubernetes scheduler that has been added to Spark. you may setup a test cluster on your loc

[GitHub] spark pull request #20154: [SPARK-22960][k8s] Make build-push-docker-images....

2018-01-04 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20154#discussion_r159720022 --- Diff: sbin/build-push-docker-images.sh --- @@ -19,51 +19,118 @@ # This script builds and pushes docker images when run from a release of Spark

[GitHub] spark pull request #20154: [SPARK-22960][k8s] Make build-push-docker-images....

2018-01-04 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20154#discussion_r159716761 --- Diff: docs/running-on-kubernetes.md --- @@ -16,6 +16,8 @@ Kubernetes scheduler that has been added to Spark. you may setup a test cluster on your loc

[GitHub] spark pull request #20154: [SPARK-22960][k8s] Make build-push-docker-images....

2018-01-04 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20154#discussion_r159719030 --- Diff: sbin/build-push-docker-images.sh --- @@ -19,51 +19,118 @@ # This script builds and pushes docker images when run from a release of Spark

[GitHub] spark issue #20155: [SPARK-22961][REGRESSION] Constant columns should genera...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20155 **[Test build #85687 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85687/testReport)** for PR 20155 at commit [`9c8f5c2`](https://github.com/apache/spark/commit/9c

[GitHub] spark pull request #20155: [SPARK-22961][REGRESSION] Constant columns should...

2018-01-04 Thread adrian-ionescu
GitHub user adrian-ionescu opened a pull request: https://github.com/apache/spark/pull/20155 [SPARK-22961][REGRESSION] Constant columns should generate QueryPlanConstraints ## What changes were proposed in this pull request? #19201 introduced the following regression: given

[GitHub] spark issue #20024: [SPARK-22825][SQL] Fix incorrect results of Casting Arra...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20024 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85681/ Test PASSed. ---

[GitHub] spark issue #20024: [SPARK-22825][SQL] Fix incorrect results of Casting Arra...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20024 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20138: [SPARK-20664][core] Delete stale application data from S...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20138 **[Test build #85686 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85686/testReport)** for PR 20138 at commit [`388858b`](https://github.com/apache/spark/commit/38

[GitHub] spark issue #20024: [SPARK-22825][SQL] Fix incorrect results of Casting Arra...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20024 **[Test build #85681 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85681/testReport)** for PR 20024 at commit [`09fd22e`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #20154: [SPARK-22960][k8s] Make build-push-docker-images.sh more...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20154 **[Test build #85685 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85685/testReport)** for PR 20154 at commit [`2ce48f9`](https://github.com/apache/spark/commit/2c

[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...

2018-01-04 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/20152 cc @gatorsmile @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revie

[GitHub] spark issue #20154: [SPARK-22960][k8s] Make build-push-docker-images.sh more...

2018-01-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20154 @foxish @liyinan926 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20154: [SPARK-22960][k8s] Make build-push-docker-images....

2018-01-04 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/20154 [SPARK-22960][k8s] Make build-push-docker-images.sh more dev-friendly. - Make it possible to build images from a git clone. - Make it easy to use minikube to test things. Also fixed what

[GitHub] spark issue #20153: [SPARK-22392][SQL] data source v2 columnar batch reader

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20153 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85683/ Test FAILed. ---

[GitHub] spark issue #20153: [SPARK-22392][SQL] data source v2 columnar batch reader

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20153 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20153: [SPARK-22392][SQL] data source v2 columnar batch reader

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20153 **[Test build #85683 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85683/testReport)** for PR 20153 at commit [`df89a83`](https://github.com/apache/spark/commit/d

[GitHub] spark pull request #20138: [SPARK-20664][core] Delete stale application data...

2018-01-04 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20138#discussion_r159691083 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -806,6 +867,17 @@ private[history] class FsHistoryProvide

[GitHub] spark pull request #20138: [SPARK-20664][core] Delete stale application data...

2018-01-04 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20138#discussion_r159690722 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -544,73 +621,75 @@ private[history] class FsHistoryProvid

[GitHub] spark pull request #20138: [SPARK-20664][core] Delete stale application data...

2018-01-04 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20138#discussion_r159705360 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -806,6 +867,17 @@ private[history] class FsHistoryProvide

[GitHub] spark issue #20148: [SPARK-22953][K8S] Avoids adding duplicated secret volum...

2018-01-04 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/20148 @jiangxb1987 Updated PR description. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional command

<    1   2   3   4   5   >