Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161499430
--- Diff: python/pyspark/sql/tests.py ---
@@ -4279,6 +4272,386 @@ def test_unsupported_types(self):
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161500723
--- Diff: python/pyspark/sql/tests.py ---
@@ -4279,6 +4272,386 @@ def test_unsupported_types(self):
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161496153
--- Diff: python/pyspark/sql/tests.py ---
@@ -4279,6 +4272,386 @@ def test_unsupported_types(self):
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161495144
--- Diff: python/pyspark/sql/group.py ---
@@ -82,6 +91,13 @@ def agg(self, *exprs):
>>> from pyspark.sql import functions as F
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161507851
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -334,34 +339,51 @@ abstract class SparkStrategies extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161507315
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -288,9 +289,13 @@ abstract class SparkStrategies extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161498029
--- Diff: python/pyspark/sql/tests.py ---
@@ -4279,6 +4272,386 @@ def test_unsupported_types(self):
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161503314
--- Diff: python/pyspark/sql/udf.py ---
@@ -111,6 +111,10 @@ def returnType(self):
and not isinstance(self._returnType_placeholder,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161495918
--- Diff: python/pyspark/sql/tests.py ---
@@ -4279,6 +4272,386 @@ def test_unsupported_types(self):
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161500785
--- Diff: python/pyspark/sql/tests.py ---
@@ -4279,6 +4272,386 @@ def test_unsupported_types(self):
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161507743
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala
---
@@ -42,8 +43,10 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161503031
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala
---
@@ -42,8 +43,10 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161502866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala
---
@@ -42,8 +43,10 @@ import
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161502564
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala
---
@@ -42,8 +43,10 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161501303
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala
---
@@ -42,8 +43,10 @@ import
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/20259
OK, i understand your suggestion.
Can I set the startup time to a metric?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86131/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20268
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20268
**[Test build #86131 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86131/testReport)**
for PR 20268 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20206#discussion_r161496715
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
---
@@ -150,6 +152,10 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20206#discussion_r161496099
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
---
@@ -184,6 +190,43 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20206#discussion_r161495402
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -156,40 +145,14 @@ object FileFormatWriter
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161494664
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala
---
@@ -42,8 +43,10 @@ import
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20259
I don't think this number tells you the system is stable or not. If it did,
how is it actionable to users who don't have any access to investigate further?
Certainly, you should have proper
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19247
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86132/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19247
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19247
**[Test build #86132 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86132/testReport)**
for PR 19247 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19872#discussion_r161491996
--- Diff: python/pyspark/sql/functions.py ---
@@ -2214,6 +2216,37 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
..
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161487862
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1869,6 +1869,65 @@ abstract class DDLSuite extends
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161491069
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -751,6 +751,25 @@ class HiveDDLSuite
}
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161488850
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1869,6 +1869,65 @@ abstract class DDLSuite extends
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161477649
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -800,6 +802,15 @@ case class AlterTableSetLocationCommand(
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161480210
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1869,6 +1869,65 @@ abstract class DDLSuite extends
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161488605
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1869,6 +1869,65 @@ abstract class DDLSuite extends
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161488179
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1869,6 +1869,65 @@ abstract class DDLSuite extends
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r161484346
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -80,10 +80,27 @@ trait
Github user sergey-rubtsov commented on the issue:
https://github.com/apache/spark/pull/20140
@HyukjinKwon, @gatorsmile could you please help find someone to review this?
---
-
To unsubscribe, e-mail:
Github user caneGuy closed the pull request at:
https://github.com/apache/spark/pull/19764
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/20257#discussion_r161472191
--- Diff: docs/ml-features.md ---
@@ -775,7 +775,9 @@ for more details on the API.
-## OneHotEncoder
+## OneHotEncoder (Deprecated
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/20257#discussion_r161477464
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/OneHotEncoderEstimatorExample.scala
---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/20257#discussion_r161475879
--- Diff: docs/ml-features.md ---
@@ -775,7 +775,9 @@ for more details on the API.
-## OneHotEncoder
+## OneHotEncoder (Deprecated
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/20257#discussion_r161473460
--- Diff: docs/ml-features.md ---
@@ -807,6 +809,36 @@ for more details on the API.
+## OneHotEncoderEstimator
+
+[One-hot
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/20257#discussion_r161472954
--- Diff: docs/ml-features.md ---
@@ -775,7 +775,9 @@ for more details on the API.
-## OneHotEncoder
+## OneHotEncoder (Deprecated
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20229
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20229
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86133/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20229
**[Test build #86133 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86133/testReport)**
for PR 20229 at commit
Github user MrBago commented on the issue:
https://github.com/apache/spark/pull/20229
I've rebased on master, I think that should resolve the the issues @viirya
raised.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20229
**[Test build #86133 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86133/testReport)**
for PR 20229 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20163#discussion_r161455317
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala
---
@@ -144,6 +145,7 @@ object EvaluatePython {
}
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20184
The code here should be fine for normal case. The problem is that there're
so many spill files, which requires to maintain lots of handler's buffer. A
lazy buffer allocation could solve this
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20211#discussion_r161453175
--- Diff: python/pyspark/sql/group.py ---
@@ -233,6 +233,27 @@ def apply(self, udf):
| 2| 1.1094003924504583|
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20214
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19247#discussion_r161452270
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
---
@@ -408,6 +420,18 @@ class FileStreamSourceSuite extends
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20214
thanks, merging to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161451478
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala
---
@@ -93,41 +97,76 @@ object DecimalPrecision
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161451267
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala
---
@@ -42,8 +43,10 @@ import
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19247
**[Test build #86132 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86132/testReport)**
for PR 19247 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161450453
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala
---
@@ -42,8 +43,10 @@ import
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19247
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20268
**[Test build #86131 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86131/testReport)**
for PR 20268 at commit
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/20268
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161449017
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1048,6 +1048,16 @@ object SQLConf {
.booleanConf
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20268
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86129/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20268
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19247
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19247
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86130/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19247
**[Test build #86130 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86130/testReport)**
for PR 19247 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20268
**[Test build #86129 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86129/testReport)**
for PR 20268 at commit
301 - 368 of 368 matches
Mail list logo
