[GitHub] spark issue #20304: [SPARK-23139]Read eventLog file with mixed encodings

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20304 Can you also add test case for this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20226: [SPARK-23034][SQL] Override `nodeName` for all *S...

2018-01-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20226#discussion_r162493722 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/LocalTableScanExec.scala --- @@ -30,6 +30,8 @@ case class LocalTableScanExec(

[GitHub] spark pull request #20320: [SPARK-22962][K8S] Fail fast if submission client...

2018-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20320 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20306: [SPARK-23054][SQL][PYSPARK][FOLLOWUP] Use sqlType castin...

2018-01-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20306 @cloud-fan, so, is it ready to go? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20320 Merging to master / 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20320 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/17/ ---

[GitHub] spark pull request #20302: [SPARK-23094] Fix invalid character handling in J...

2018-01-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20302#discussion_r162491837 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/JsonHadoopFsRelationSuite.scala --- @@ -105,4 +107,36 @@ class JsonHadoopFsRelationSuite

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20297 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20297 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86351/ Test PASSed. ---

[GitHub] spark pull request #20302: [SPARK-23094] Fix invalid character handling in J...

2018-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20302 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20297 **[Test build #86351 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86351/testReport)** for PR 20297 at commit

[GitHub] spark issue #20302: [SPARK-23094] Fix invalid character handling in JsonData...

2018-01-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20302 Merged to master and branch-2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20320 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20320 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20320 **[Test build #86359 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86359/testReport)** for PR 20320 at commit

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86359/ Test PASSed. ---

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162489756 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowEvalPythonExec.scala --- @@ -90,8 +90,9 @@ case class

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/17/ Test

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20320 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/17/ ---

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20320 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162477811 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java --- @@ -49,18 +49,8 @@ * After

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162487635 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java --- @@ -50,6 +50,9 @@ *

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162489186 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java --- @@ -98,22 +88,22 @@ public

[GitHub] spark pull request #20321: [SPARK-23152][ML] - Correctly guard against empty...

2018-01-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20321#discussion_r162489182 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala --- @@ -109,7 +109,7 @@ abstract class Classifier[ case

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86350/ Test PASSed. ---

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19872 **[Test build #86350 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86350/testReport)** for PR 19872 at commit

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/20320 The manual tests I did actually use a main app jar located on gcs and http. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20320 Suspected that it would use the same code path - might be worth a manual test of that as well. LGTM from my end. --- - To

[GitHub] spark pull request #20318: Testing k8s PRB on 2.3 branch

2018-01-18 Thread ssuchter
Github user ssuchter closed the pull request at: https://github.com/apache/spark/pull/20318 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20317: Testing k8s PRB branch2

2018-01-18 Thread ssuchter
Github user ssuchter closed the pull request at: https://github.com/apache/spark/pull/20317 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20320 **[Test build #86359 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86359/testReport)** for PR 20320 at commit

[GitHub] spark pull request #20320: [SPARK-22962][K8S] Fail fast if submission client...

2018-01-18 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20320#discussion_r162486330 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/DriverConfigOrchestrator.scala --- @@ -117,6 +117,13 @@

[GitHub] spark pull request #20320: [SPARK-22962][K8S] Fail fast if submission client...

2018-01-18 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20320#discussion_r162486349 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/DriverConfigOrchestrator.scala --- @@ -117,6 +117,13 @@

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/20320 Actually main application jar gets added to `spark.jars` automatically by the submission process so are treated the same as other jars on `spark.jars`. ---

[GitHub] spark pull request #20320: [SPARK-22962][K8S] Fail fast if submission client...

2018-01-18 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20320#discussion_r162484585 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/DriverConfigOrchestrator.scala --- @@ -117,6 +117,13 @@

[GitHub] spark pull request #20320: [SPARK-22962][K8S] Fail fast if submission client...

2018-01-18 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20320#discussion_r162485460 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/DriverConfigOrchestrator.scala --- @@ -117,6 +117,13 @@

[GitHub] spark issue #20308: [SPARK-23142][SS][DOCS] Added docs for continuous proces...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20308 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20308: [SPARK-23142][SS][DOCS] Added docs for continuous proces...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20308 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86358/ Test PASSed. ---

[GitHub] spark issue #20308: [SPARK-23142][SS][DOCS] Added docs for continuous proces...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20308 **[Test build #86358 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86358/testReport)** for PR 20308 at commit

[GitHub] spark issue #20302: [SPARK-23094] Fix invalid character handling in JsonData...

2018-01-18 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20302 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20046 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/20320 Manual tests to verify that using `http://`/`https://`, `gcs://`, and `local://` dependencies works fine. Also verified that using `file://` dependencies results in submission failure due to the

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20046 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86352/ Test FAILed. ---

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20046 **[Test build #86352 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86352/testReport)** for PR 20046 at commit

[GitHub] spark pull request #20322: [SPARK-23133][K8S] Fix passing java options to Ex...

2018-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20322 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20296: [SPARK-23133][K8S] Fix passing java options to Ex...

2018-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20296 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20322 Merging to master / 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20308: [SPARK-23142][SS][DOCS] Added docs for continuous proces...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20308 **[Test build #86358 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86358/testReport)** for PR 20308 at commit

[GitHub] spark issue #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19340 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19340 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/16/ Test

[GitHub] spark issue #20308: [SPARK-23142][SS][DOCS] Added docs for continuous proces...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20308 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/15/ Test

[GitHub] spark issue #20308: [SPARK-23142][SS][DOCS] Added docs for continuous proces...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20308 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-18 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19340 @srowen thank you for pointing out my style issue. Addressed, thanks. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20320 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20320 **[Test build #86357 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86357/testReport)** for PR 20320 at commit

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20320 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/14/ ---

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86357/ Test PASSed. ---

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20320 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/14/ ---

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/14/ Test

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20320 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/20320 Regarding manual tests, our integration tests cover `local://` and `http://` (at least for files). I will do some manual tests on `http://` for jars and `gs://`. ---

[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20322 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/13/ ---

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20320 **[Test build #86357 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86357/testReport)** for PR 20320 at commit

[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20322 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20322 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86356/ Test PASSed. ---

[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20322 **[Test build #86356 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86356/testReport)** for PR 20322 at commit

[GitHub] spark pull request #20320: [SPARK-22962][K8S] Fail fast if submission client...

2018-01-18 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20320#discussion_r162475825 --- Diff: docs/running-on-kubernetes.md --- @@ -117,7 +117,10 @@ This URI is the location of the example jar that is already in the Docker image.

[GitHub] spark pull request #20320: [SPARK-22962][K8S] Fail fast if submission client...

2018-01-18 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20320#discussion_r162475552 --- Diff: docs/running-on-kubernetes.md --- @@ -117,7 +117,10 @@ This URI is the location of the example jar that is already in the Docker image.

[GitHub] spark pull request #20320: [SPARK-22962][K8S] Fail fast if submission client...

2018-01-18 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20320#discussion_r162475425 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/DriverConfigOrchestrator.scala --- @@ -117,6 +117,12 @@

[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20322 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/13/ Test

[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20322 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/13/ ---

[GitHub] spark pull request #20320: [SPARK-22962][K8S] Fail fast if submission client...

2018-01-18 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20320#discussion_r162475338 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/DriverConfigOrchestrator.scala --- @@ -117,6 +117,12 @@

[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20322 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20322 **[Test build #86356 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86356/testReport)** for PR 20322 at commit

[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20322 (And also add "Closes #20296" so that it's automatically closed when we push this.) --- - To unsubscribe, e-mail:

[GitHub] spark issue #20322: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20322 Could you copy the title / description from the other PR instead of referencing it? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20296 Opened https://github.com/apache/spark/pull/20322. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20322: [SPARK-23133][K8S] Fix passing java options to Ex...

2018-01-18 Thread foxish
GitHub user foxish opened a pull request: https://github.com/apache/spark/pull/20322 [SPARK-23133][K8S] Fix passing java options to Executor ## What changes were proposed in this pull request? Supersedes https://github.com/apache/spark/pull/20296 and targets master. cc/

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20296 Yes, we can't change the target branch of a PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20296 I think one of us should do it then - in the interest of time and making the next RC. It looks like the PR author may be in a different timezone. ---

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20296 Normally you should close this and open another PR against the master branch. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20320 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86354/ Test PASSed. ---

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20296 That would explain also why the tests aren't running. @sameeragarwal/@vanzin, can someone with manual merge powers retarget this to the master branch? ---

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20320 **[Test build #86354 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86354/testReport)** for PR 20320 at commit

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20320 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/12/ ---

[GitHub] spark issue #20250: [SPARK-23059][SQL][TEST] Correct some improper with view...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20250 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86347/ Test PASSed. ---

[GitHub] spark issue #20250: [SPARK-23059][SQL][TEST] Correct some improper with view...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20250 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20320: [SPARK-22962][K8S] Fail fast if submission client...

2018-01-18 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20320#discussion_r162465264 --- Diff: docs/running-on-kubernetes.md --- @@ -117,7 +117,10 @@ This URI is the location of the example jar that is already in the Docker image. If

[GitHub] spark pull request #20320: [SPARK-22962][K8S] Fail fast if submission client...

2018-01-18 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20320#discussion_r162465377 --- Diff: docs/running-on-kubernetes.md --- @@ -117,7 +117,10 @@ This URI is the location of the example jar that is already in the Docker image. If

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86346/ Test PASSed. ---

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20250: [SPARK-23059][SQL][TEST] Correct some improper with view...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20250 **[Test build #86347 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86347/testReport)** for PR 20250 at commit

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19872 **[Test build #86346 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86346/testReport)** for PR 19872 at commit

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20296 Good point. @andrusha, can you target it to master instead? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20320 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/12/ ---

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20320 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20320: [SPARK-22962][K8S] Fail fast if submission client local ...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/12/ Test

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20296 Why is this PR against 2.3 but not master? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

<    1   2   3   4   5   6   7   8   9   >