Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20474
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20474
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86948/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20474
**[Test build #86948 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86948/testReport)**
for PR 20474 at commit
[`8b91ef3`](https://github.com/apache/spark/commit/8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86947/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20481
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20481
**[Test build #86947 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86947/testReport)**
for PR 20481 at commit
[`761f1ee`](https://github.com/apache/spark/commit/7
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20481
The logic looks ok. Did you look at adding a test in
`AppStatusListenerSuite` for this? There's already a test for the cleanup, it'd
be nice if it were tweaked to cover the changes here.
---
-
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20481#discussion_r165541492
--- Diff: core/src/main/scala/org/apache/spark/status/storeTypes.scala ---
@@ -134,6 +138,7 @@ private[spark] object TaskIndexNames {
final val STAGE =
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86959 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86959/testReport)**
for PR 20422 at commit
[`a3b85f1`](https://github.com/apache/spark/commit/a3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/501/
Test
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20272
Great, how about explaining that in some place more visible to Spark users
than a PR on github.
---
-
To unsubscribe, e-mail: rev
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86958 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86958/testReport)**
for PR 20422 at commit
[`5677448`](https://github.com/apache/spark/commit/56
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20455
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apach
Github user bersprockets commented on the issue:
https://github.com/apache/spark/pull/20424
@HyukjinKwon @squito
Before merging this, allow me make an alternative PR that actually bypasses
the problem (rather than simply reporting on the problem). If it seems like the
soluti
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20479
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20476
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20477
**[Test build #86957 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86957/testReport)**
for PR 20477 at commit
[`1f61965`](https://github.com/apache/spark/commit/1f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20477
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20476
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/500/
Test
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20477
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/499/
Test
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20476
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20476
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/498/
Test
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20479
**[Test build #86955 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86955/testReport)**
for PR 20479 at commit
[`c2891d0`](https://github.com/apache/spark/commit/c2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20479
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/497/
Test
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20481
**[Test build #86954 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86954/testReport)**
for PR 20481 at commit
[`4c1080a`](https://github.com/apache/spark/commit/4c
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20476
**[Test build #86956 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86956/testReport)**
for PR 20476 at commit
[`12c8035`](https://github.com/apache/spark/commit/12
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20479
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/496/
Test
Github user bersprockets commented on the issue:
https://github.com/apache/spark/pull/20424
Hi @HyukjinKwon
>Do you guys have some more information to add in the error message?
If we go with this solution, I would like to improve the message before the
PR is merged.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20481
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20479#discussion_r165537214
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala
---
@@ -655,4 +655,35 @@ class OrcQuerySuite ext
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20479
Thank you for review and approval!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comman
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20481
**[Test build #86953 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86953/testReport)**
for PR 20481 at commit
[`0424c1d`](https://github.com/apache/spark/commit/04
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/495/
Test
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20481
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/20481
> This is fine, but if you want you can probably replace the filters in the
listener by setting this to -1 for running jobs / stages / others, and starting
iteration at "0".
Not sure if I g
Github user ozzieba commented on the issue:
https://github.com/apache/spark/pull/20272
@vanzin In general Kubernetes makes this super easy:
- The most basic workflow is to use the driver pod name (which is in the
output of Spark Submit, or can be found with `kubectl get pods`), and
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20424
So, I think I am fine. I believe it's already a corner case and I think we
don't have to put a lot of efforts on this ... to be honest. I only wanted to
double check if there is a slight step ba
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20481#discussion_r165529443
--- Diff: core/src/main/scala/org/apache/spark/status/storeTypes.scala ---
@@ -73,6 +73,8 @@ private[spark] class JobDataWrapper(
@JsonIgnore @KVIndex
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20480
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20480
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86944/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20480
**[Test build #86944 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86944/testReport)**
for PR 20480 at commit
[`afe40e5`](https://github.com/apache/spark/commit/a
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20481
> I cannot iterate tasks using two indices.
You can actually; indices can have a parent index, and there's actually a
bunch of examples in `TaskDataWrapper`.
Use them like this.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20479#discussion_r165528709
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala
---
@@ -655,4 +655,35 @@ class OrcQuerySuite exten
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20481
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/494/
Test
Github user bersprockets commented on a diff in the pull request:
https://github.com/apache/spark/pull/20424#discussion_r165528385
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -191,7 +191,20 @@ private[spark] class PythonWorkerFactory(p
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/20481
@vanzin just updated it. I don't fix the task order as I think it's already
using `stage` index and I cannot iterate tasks using two indices.
---
--
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20481
**[Test build #86952 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86952/testReport)**
for PR 20481 at commit
[`f0de4be`](https://github.com/apache/spark/commit/f0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/493/
Test
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20481
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20480
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86943/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20480
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20473#discussion_r165527157
--- Diff: python/run-tests.py ---
@@ -151,6 +151,38 @@ def parse_opts():
return opts
+def _check_dependencies(python_exec, modul
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20480
**[Test build #86943 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86943/testReport)**
for PR 20480 at commit
[`df96f0c`](https://github.com/apache/spark/commit/d
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86951/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20445
**[Test build #86951 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86951/testReport)**
for PR 20445 at commit
[`6389d80`](https://github.com/apache/spark/commit/6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20445#discussion_r165222931
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala
---
@@ -270,16 +270,17 @@ class MicroBatchExecutio
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20445#discussion_r165522181
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala
---
@@ -89,7 +96,7 @@ case class MemoryStream[A : Encoder](id:
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/20445
This PR is currently blocked by a DataSourceV2ScanExec bug, which is being
fixed in this PR https://github.com/apache/spark/pull/20387
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20445
**[Test build #86950 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86950/testReport)**
for PR 20445 at commit
[`478ad17`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86950/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20445
**[Test build #86951 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86951/testReport)**
for PR 20445 at commit
[`6389d80`](https://github.com/apache/spark/commit/63
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/492/
Test
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/491/
Test
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20445
**[Test build #86950 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86950/testReport)**
for PR 20445 at commit
[`478ad17`](https://github.com/apache/spark/commit/47
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20470
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20470
Merging to master / 2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revie
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19616#discussion_r165518653
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -1104,14 +1117,39 @@ private[spark] class Client(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19616#discussion_r165516803
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -51,33 +52,16 @@ import org.apache.spark.util._
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19616#discussion_r165516090
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -784,6 +794,9 @@ private[spark] class Client(
val
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19616#discussion_r165516542
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -1104,14 +1117,39 @@ private[spark] class Client(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19616#discussion_r165515886
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -656,7 +664,9 @@ private[spark] class Client(
// C
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19616#discussion_r165518845
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -1104,14 +1117,39 @@ private[spark] class Client(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19616#discussion_r165515603
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -69,6 +70,10 @@ private[spark] class Client(
p
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19616#discussion_r165516482
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -1104,14 +1117,39 @@ private[spark] class Client(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20462
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20462
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86942/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20462
**[Test build #86942 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86942/testReport)**
for PR 20462 at commit
[`82c276f`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20460
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/488/
---
-
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20262
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20334
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20460
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/488/
---
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20460
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20460
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/490/
Test
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20481#discussion_r165512677
--- Diff: core/src/main/scala/org/apache/spark/status/KVUtils.scala ---
@@ -69,14 +69,17 @@ private[spark] object KVUtils extends Logging {
db
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20460
**[Test build #86949 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86949/testReport)**
for PR 20460 at commit
[`44e489e`](https://github.com/apache/spark/commit/44
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/20481#discussion_r165512101
--- Diff: core/src/main/scala/org/apache/spark/status/KVUtils.scala ---
@@ -69,14 +69,17 @@ private[spark] object KVUtils extends Logging {
db
Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/20460
@jiangxb1987 fixed the check in
https://github.com/apache/spark/pull/20460/commits/44e489eca6c22254fa57ff6f4750e3af85c43e34.
---
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20481#discussion_r165510869
--- Diff: core/src/main/scala/org/apache/spark/status/KVUtils.scala ---
@@ -69,14 +69,17 @@ private[spark] object KVUtils extends Logging {
db
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20474#discussion_r165510071
--- Diff:
core/src/main/scala/org/apache/spark/status/api/v1/OneApplicationResource.scala
---
@@ -51,6 +52,21 @@ private[v1] class AbstractApplicationR
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20474#discussion_r165509830
--- Diff:
core/src/main/scala/org/apache/spark/status/api/v1/OneApplicationResource.scala
---
@@ -51,6 +52,21 @@ private[v1] class AbstractApplicationR
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20474
**[Test build #86948 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86948/testReport)**
for PR 20474 at commit
[`8b91ef3`](https://github.com/apache/spark/commit/8b
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/20460
Yea, we should either move the check to elsewhere or modify it, to avoid
potential failure.
---
-
To unsubscribe, e-mail: re
Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/20460
@jiangxb1987 it seems `spark.cores.max` only applies to standalone and
Mesos coarse-grained modes. In k8s mode, `spark.cores.max` is not applicable. I
think the check really should not be here, b
201 - 300 of 631 matches
Mail list logo
