Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/20520#discussion_r167089783
--- Diff: python/pyspark/ml/tests.py ---
@@ -1620,6 +1621,23 @@ def test_kmeans_summary(self):
self.assertEqual(s.k, 2)
+cla
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20553
**[Test build #87234 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87234/testReport)**
for PR 20553 at commit
[`50ebb50`](https://github.com/apache/spark/commit/50
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/20520#discussion_r167089401
--- Diff: python/pyspark/ml/tests.py ---
@@ -1620,6 +1621,23 @@ def test_kmeans_summary(self):
self.assertEqual(s.k, 2)
+cla
GitHub user liyinan926 opened a pull request:
https://github.com/apache/spark/pull/20553
[SPARK-23285][K8S] Add a config property for specifying physical executor
cores
As discussed in SPARK-23285, this PR introduces a new configuation property
`spark.kubernetes.executor.cores` for
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20545
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20545
**[Test build #87233 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87233/testReport)**
for PR 20545 at commit
[`664a62c`](https://github.com/apache/spark/commit/66
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20545
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/728/
Test
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20545
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20359
Thank you for review and approval, @srowen .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additio
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/20537
I think this PR is ready. I encountered another issue with the non-Arrow
path and filed SPARK-23360. However, that seems to be a different bug than the
one here.
---
--
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20410
Thanks @mgaido91 , #18982 had been sitting for so long, I forgot it was
really the same issue as here! As for the defaults, I think the assumption that
python and scala have the same value is fi
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20520#discussion_r167082120
--- Diff: python/pyspark/ml/tests.py ---
@@ -1620,6 +1621,23 @@ def test_kmeans_summary(self):
self.assertEqual(s.k, 2)
+class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20520#discussion_r167081534
--- Diff: python/pyspark/ml/tests.py ---
@@ -1620,6 +1621,23 @@ def test_kmeans_summary(self):
self.assertEqual(s.k, 2)
+class
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/20550
I'll try to add more typos from other modules. I didn't mean to "pollute" a
minor change and make it bigger (and possibly questionable :))
---
--
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20410
@BryanCutler yes, I see it only now sorry. I am fine either with your
change and this one. Personally, I think that it is not a good idea to transfer
defaults, because it means we might have differ
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20490
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87229/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20490
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20490
**[Test build #87229 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87229/testReport)**
for PR 20490 at commit
[`e9964ca`](https://github.com/apache/spark/commit/e
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20546#discussion_r167072238
--- Diff:
core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala
---
@@ -610,7 +610,7 @@ class StandaloneDynamicAllocationSuite
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20546#discussion_r167072049
--- Diff: core/src/test/scala/org/apache/spark/DistributedSuite.scala ---
@@ -160,10 +160,6 @@ class DistributedSuite extends SparkFunSuite with
Matchers wit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20546#discussion_r167071122
--- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala
---
@@ -24,19 +24,15 @@ import scala.collection.mutable
import sun.nio.c
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20546#discussion_r167070392
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1715,7 +1715,7 @@ class SparkContext(config: SparkConf) extends Logging
{
pr
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20546#discussion_r167071776
--- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala
---
@@ -46,7 +42,7 @@ class StorageStatus(
* Internal representation of the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20546
**[Test build #87232 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87232/testReport)**
for PR 20546 at commit
[`8544380`](https://github.com/apache/spark/commit/85
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20359
FYI, this is tested on a production cluster for two weeks and the deadlock
issue is not reported until now.
---
-
To unsub
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20552
**[Test build #87231 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87231/testReport)**
for PR 20552 at commit
[`87d0bc8`](https://github.com/apache/spark/commit/87
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r167061319
--- Diff: docs/running-on-mesos.md ---
@@ -427,15 +437,30 @@ See the [configuration page](configuration.html) for
information on Spark config
spark.me
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r167061286
--- Diff: docs/running-on-mesos.md ---
@@ -82,6 +82,16 @@ a Spark driver program configured to connect to Mesos.
Alternatively, you can also install Spar
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r167061652
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -106,6 +99,40 @@ trait MesosSched
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r167062039
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -106,6 +99,40 @@ trait MesosSched
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r167062632
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtilsSuite.scala
---
@@ -237,4 +242,157 @@ class Mes
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r167061911
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -106,6 +99,40 @@ trait MesosSched
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r167062542
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtilsSuite.scala
---
@@ -17,16 +17,21 @@
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r167061786
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -106,6 +99,40 @@ trait MesosSched
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r167062721
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtilsSuite.scala
---
@@ -237,4 +242,157 @@ class Mes
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r167062808
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtilsSuite.scala
---
@@ -237,4 +242,157 @@ class Mes
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r167061871
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -106,6 +99,40 @@ trait MesosSched
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20552
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20552
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87230/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20552
**[Test build #87230 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87230/testReport)**
for PR 20552 at commit
[`44de1ea`](https://github.com/apache/spark/commit/4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20552
**[Test build #87230 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87230/testReport)**
for PR 20552 at commit
[`44de1ea`](https://github.com/apache/spark/commit/44
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20552
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/20552
/cc @tdas
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@s
GitHub user jose-torres opened a pull request:
https://github.com/apache/spark/pull/20552
[SPARK-23099][SS] Migrate foreach sink to DataSourceV2
## What changes were proposed in this pull request?
Migrate the foreach sink to the DataSourceV2 API.
## How was this pat
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20490
**[Test build #87229 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87229/testReport)**
for PR 20490 at commit
[`e9964ca`](https://github.com/apache/spark/commit/e9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20490
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/727/
Test
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20490
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20550
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20550
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87225/
Test FAILed.
---
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
ping @MLnick @holdenk , seems like this issue popped up a couple times
recently. Can you please take a look here?
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20550
**[Test build #87225 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87225/testReport)**
for PR 20550 at commit
[`dcbb4da`](https://github.com/apache/spark/commit/d
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20410
@mgaido91 , this is actually the same fix as in #18982 only that also
transfers the default values to Java, which I still think is a good idea
because if users define their own models, it should
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20490
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87224/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20490
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20490
**[Test build #87224 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87224/testReport)**
for PR 20490 at commit
[`a2a0ec8`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20537
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20537
**[Test build #87227 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87227/testReport)**
for PR 20537 at commit
[`94ec45e`](https://github.com/apache/spark/commit/9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20537
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87227/
Test PASSed.
---
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/20520#discussion_r167048301
--- Diff: python/pyspark/ml/tests.py ---
@@ -1620,6 +1621,23 @@ def test_kmeans_summary(self):
self.assertEqual(s.k, 2)
+cla
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/20520#discussion_r167048075
--- Diff: python/pyspark/ml/tests.py ---
@@ -1620,6 +1621,23 @@ def test_kmeans_summary(self):
self.assertEqual(s.k, 2)
+cla
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/726/
Test
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #87228 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87228/testReport)**
for PR 18982 at commit
[`339c793`](https://github.com/apache/spark/commit/33
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20537
**[Test build #87227 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87227/testReport)**
for PR 20537 at commit
[`94ec45e`](https://github.com/apache/spark/commit/94
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20537
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20537
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/725/
Test
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20551
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87226/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20551
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20551
**[Test build #87226 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87226/testReport)**
for PR 20551 at commit
[`7aa4c11`](https://github.com/apache/spark/commit/7
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/20551
cc @gatorsmile Hi Sean, please let me your thoughts.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For a
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20510
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20551
**[Test build #87226 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87226/testReport)**
for PR 20551 at commit
[`7aa4c11`](https://github.com/apache/spark/commit/7a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20551
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20510
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20551
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/724/
Test
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/20551
[SPARK-23271][DOC] Document the empty dataframe write semantics
## What changes were proposed in this pull request?
Document the change in semantics while writing/saving empty dataframes in
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20550
That's fine. As usual please have a look for more if you can.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
F
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/20531#discussion_r167029101
--- Diff: docs/sql-programming-guide.md ---
@@ -1734,7 +1734,7 @@ For detailed usage, please see
[`pyspark.sql.functions.pandas_udf`](api/python/p
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/20531#discussion_r167026621
--- Diff: docs/sql-programming-guide.md ---
@@ -1676,7 +1676,7 @@ Using the above optimizations with Arrow will produce
the same results as when A
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20550
**[Test build #87225 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87225/testReport)**
for PR 20550 at commit
[`dcbb4da`](https://github.com/apache/spark/commit/dc
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20550
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20550
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/723/
Test
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/20550
[MINOR][HIVE] Typo fixes
## What changes were proposed in this pull request?
Typo fixes (with expanding a Hive property)
## How was this patch tested?
local build.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20519#discussion_r167028262
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -180,18 +181,52 @@ private[spark] class PythonWorkerFactory(python
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20548
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20548
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87218/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20548
**[Test build #87218 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87218/testReport)**
for PR 20548 at commit
[`367c70b`](https://github.com/apache/spark/commit/3
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/20531#discussion_r167024836
--- Diff: docs/sql-programming-guide.md ---
@@ -1734,7 +1734,7 @@ For detailed usage, please see
[`pyspark.sql.functions.pandas_udf`](api/python/p
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20547
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20547
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87217/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20547
**[Test build #87217 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87217/testReport)**
for PR 20547 at commit
[`79e2593`](https://github.com/apache/spark/commit/7
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20546
@vanzin In the org.apache.spark.repl.SingletonReplSuite there is a test
named "should clone and clean line object in ClosureCleaner" which uses
getExecutorStorageStatus to calculate memory consu
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20549
I'm not sure there was support to make this change. The value of these
additional metrics is pretty marginal.
---
-
To unsubscrib
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20519#discussion_r167018107
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -180,18 +181,52 @@ private[spark] class PythonWorkerFactory(python
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20519#discussion_r167015747
--- Diff: python/pyspark/daemon.py ---
@@ -177,4 +183,24 @@ def handle_sigterm(*args):
if __name__ == '__main__':
-manager()
+
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20519#discussion_r167014593
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -180,18 +181,52 @@ private[spark] class PythonWorkerFactory(python
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20519#discussion_r167013866
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -180,18 +181,52 @@ private[spark] class PythonWorkerFactory(python
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20519#discussion_r167015476
--- Diff: python/pyspark/daemon.py ---
@@ -79,11 +79,17 @@ def manager():
listen_sock.listen(max(1024, SOMAXCONN))
listen_host, listen_port
Github user sandecho commented on the issue:
https://github.com/apache/spark/pull/20549
ok to test. Jenkins, add to whitelist.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20490
**[Test build #87224 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87224/testReport)**
for PR 20490 at commit
[`a2a0ec8`](https://github.com/apache/spark/commit/a2
201 - 300 of 573 matches
Mail list logo
