[GitHub] spark issue #20894: [SPARK-23786][SQL] Checking column names of csv headers

2018-03-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20894 Yea, I got the point. So, the case is when some files have different header. I was thinking of a case when all files have the same header but the user provided a wrong order of schema

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20343 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20343 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88569/ Test PASSed. ---

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20343 **[Test build #88569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88569/testReport)** for PR 20343 at commit

[GitHub] spark issue #20894: [SPARK-23786][SQL] Checking column names of csv headers

2018-03-25 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/20894 @HyukjinKwon > I think we are fine to just document this like saying them to better use select or renaming it after the load The problem occurs during loading. Could you, please,

[GitHub] spark issue #20208: [SPARK-23007][SQL][TEST] Add schema evolution test suite...

2018-03-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20208 I'll update like the followings. - Remove `Remove a column` part from the description parts (docs/testsuite file doc) while keeping the test cases. - Add a clear description about

[GitHub] spark issue #20901: [SPARK-23792][DOCS] Documentation improvements for datet...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20901 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20901: [SPARK-23792][DOCS] Documentation improvements for datet...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20901 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20901: [SPARK-23792][DOCS] Documentation improvements fo...

2018-03-25 Thread abradbury
GitHub user abradbury opened a pull request: https://github.com/apache/spark/pull/20901 [SPARK-23792][DOCS] Documentation improvements for datetime functions ## What changes were proposed in this pull request? Improved the documentation for the datetime functions in

[GitHub] spark pull request #20208: [SPARK-23007][SQL][TEST] Add schema evolution tes...

2018-03-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20208#discussion_r176933664 --- Diff: docs/sql-programming-guide.md --- @@ -815,6 +815,54 @@ should start with, they can set `basePath` in the data source options. For examp

[GitHub] spark pull request #20208: [SPARK-23007][SQL][TEST] Add schema evolution tes...

2018-03-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20208#discussion_r176933560 --- Diff: docs/sql-programming-guide.md --- @@ -815,6 +815,54 @@ should start with, they can set `basePath` in the data source options. For examp

[GitHub] spark pull request #20208: [SPARK-23007][SQL][TEST] Add schema evolution tes...

2018-03-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20208#discussion_r176933506 --- Diff: docs/sql-programming-guide.md --- @@ -815,6 +815,54 @@ should start with, they can set `basePath` in the data source options. For examp

[GitHub] spark pull request #20208: [SPARK-23007][SQL][TEST] Add schema evolution tes...

2018-03-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20208#discussion_r176933493 --- Diff: docs/sql-programming-guide.md --- @@ -815,6 +815,54 @@ should start with, they can set `basePath` in the data source options. For examp

[GitHub] spark issue #20894: [SPARK-23786][SQL] Checking column names of csv headers

2018-03-25 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/20894 > Does this also fix actual use cases too? Yes, it fixes the real problem. - There are many small csv files in one folder. All files have the same schema and should have the same

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20877 **[Test build #88570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88570/testReport)** for PR 20877 at commit

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1743/

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20877 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88568/ Test FAILed. ---

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20877 **[Test build #88568 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88568/testReport)** for PR 20877 at commit

[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos

2018-03-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20897#discussion_r176931905 --- Diff: docs/mllib-feature-extraction.md --- @@ -278,8 +278,8 @@ for details on the API. multiplication. In other words, it scales each column of

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20343 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20343 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1742/

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1741/

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20343 **[Test build #88569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88569/testReport)** for PR 20343 at commit

[GitHub] spark issue #20343: [SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQueryS...

2018-03-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20343 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20877 **[Test build #88568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88568/testReport)** for PR 20877 at commit

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20877 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20900: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `pandas_u...

2018-03-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20900 LGTM except https://github.com/apache/spark/pull/20900#discussion_r176930776 --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20208: [SPARK-23007][SQL][TEST] Add schema evolution tes...

2018-03-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20208#discussion_r176931126 --- Diff: docs/sql-programming-guide.md --- @@ -815,6 +815,54 @@ should start with, they can set `basePath` in the data source options. For examp

[GitHub] spark pull request #20208: [SPARK-23007][SQL][TEST] Add schema evolution tes...

2018-03-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20208#discussion_r176931027 --- Diff: docs/sql-programming-guide.md --- @@ -815,6 +815,54 @@ should start with, they can set `basePath` in the data source options. For examp

[GitHub] spark pull request #20208: [SPARK-23007][SQL][TEST] Add schema evolution tes...

2018-03-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20208#discussion_r176931012 --- Diff: docs/sql-programming-guide.md --- @@ -815,6 +815,54 @@ should start with, they can set `basePath` in the data source options. For examp

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20877 **[Test build #88567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88567/testReport)** for PR 20877 at commit

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88567/ Test FAILed. ---

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20208: [SPARK-23007][SQL][TEST] Add schema evolution tes...

2018-03-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20208#discussion_r176930962 --- Diff: docs/sql-programming-guide.md --- @@ -815,6 +815,54 @@ should start with, they can set `basePath` in the data source options. For examp

[GitHub] spark issue #20900: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `pandas_u...

2018-03-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20900 From a very quick look for the case "Try to be sneaky and don't use keywords with partial:". Seems it's due to type mismatch. This seems working fine (in Python 3): ``` >>>

[GitHub] spark pull request #20900: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `p...

2018-03-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20900#discussion_r176930776 --- Diff: python/pyspark/sql/functions.py --- @@ -2155,6 +2155,8 @@ def udf(f=None, returnType=StringType()): in boolean expressions and it

[GitHub] spark issue #20900: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `pandas_u...

2018-03-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20900 @mstewart141, just to be clear, the error: ``` ValueError: Function has keyword-only parameters or annotations, use getfullargspec() API which can support them ``` is

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1740/

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20877 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20877 **[Test build #88567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88567/testReport)** for PR 20877 at commit

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20877 @cloud-fan, @MaxGekk, and @hvanhovell, would you mind taking a look please when you have some time? I think this is pretty similar with https://github.com/apache/spark/pull/20727 except one

[GitHub] spark issue #20877: [SPARK-23765][SQL] Supports custom line separator for js...

2018-03-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20877 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

<    1   2