Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178427033
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/CreateJacksonParser.scala
---
@@ -39,11 +40,36 @@ private[sql] object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178427011
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2065,29 +2065,238 @@ class JsonSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178426994
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2065,29 +2065,238 @@ class JsonSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178426903
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2065,29 +2065,238 @@ class JsonSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178426879
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -86,14 +86,30 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178426866
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2065,29 +2065,238 @@ class JsonSuite extends
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20849
Let's make the point clear. There are two things, _1. one for line-by-line
parsing_ and _2. JSON parsing via Jackson_.
The test you pointed out looks still a bit weird because Jackson
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20849
From a quick look and wild guess, `UTF-16` case would be alone problematic
because we are going to make the delimiter with a BOM bit `0xFF 0xFE 0x0D 0x00
0x0A 0x00`.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20849
@MaxGekk, So to make it clear, it parses line by line correctly regardless
of BOM if we set `lineSep` + `encoding` fine but it fails to parse each line as
JSON via Jackson since we explicitly
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18853
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18853
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1882/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18853
**[Test build #88780 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88780/testReport)**
for PR 18853 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20935#discussion_r178425464
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnStatsSuite.scala
---
@@ -18,18 +18,35 @@
package
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20935#discussion_r178425406
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala
---
@@ -323,18 +324,31 @@ private[columnar] final class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20935#discussion_r178425525
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnarTestUtils.scala
---
@@ -54,12 +54,22 @@ object ColumnarTestUtils {
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/18853
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20954
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88777/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20954
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18853
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18853
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88778/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18853
**[Test build #88778 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88778/testReport)**
for PR 18853 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20954
**[Test build #88777 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88777/testReport)**
for PR 20954 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20940
@edwinalu please take a look
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88725/testReport
---
-
To
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20907#discussion_r178425007
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -185,6 +187,47 @@ class KMeansModel private[ml] (
}
}
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20949
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20949
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88779/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20949
**[Test build #88779 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88779/testReport)**
for PR 20949 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20949
**[Test build #88779 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88779/testReport)**
for PR 20949 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20949#discussion_r178424628
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -513,6 +513,43 @@ class CSVSuite extends
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20949
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20948
I think https://github.com/apache/spark/pull/20928 includes this. Let that
PR fix it and close this one.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19560
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19560
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88775/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19560
**[Test build #88775 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88775/testReport)**
for PR 19560 at commit
101 - 134 of 134 matches
Mail list logo
