Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21269#discussion_r186782118
--- Diff: docs/sql-programming-guide.md ---
@@ -1812,6 +1812,8 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
- Since
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21269
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apa
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21259
Thank you all. SPARK-24112 is closed and the doc issue goes as [FOLLOWUP PR
for SPARK-23355](https://github.com/apache/spark/pull/21269).
---
Github user dongjoon-hyun closed the pull request at:
https://github.com/apache/spark/pull/21259
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21269
**[Test build #90372 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90372/testReport)**
for PR 21269 at commit
[`1647961`](https://github.com/apache/spark/commit/16
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/21269
[SPARK-23355][SQL][DOC][FOLLOWUP] Add migration doc for TBLPROPERTIES
## What changes were proposed in this pull request?
In Apache Spark 2.4,
[SPARK-23355](https://issues.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21028
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90370/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21028
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21028
**[Test build #90370 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90370/testReport)**
for PR 21028 at commit
[`964f7af`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19498
**[Test build #90371 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90371/testReport)**
for PR 19498 at commit
[`174ec21`](https://github.com/apache/spark/commit/17
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21189
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/21252
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revie
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21118
> If we want to go this way, I think we should fully bring back #10511 to
make this contract explicitly, i.e. which operator produce unsafe row and which
operator only accepts unsafe row as input.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21189
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21212
@jinxing64
> I guess your concern is ArrayBuffer will do lots of copy as size of
elements grows, and we don't need fast random access in
ShuffleBlockFetcherIterator
my concern wasn't th
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21199#discussion_r186764630
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousTextSocketSource.scala
---
@@ -0,0 +1,304 @@
+/*
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21199#discussion_r186765402
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousTextSocketSource.scala
---
@@ -0,0 +1,304 @@
+/*
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21257#discussion_r186772705
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
---
@@ -207,9 +207,25 @@ case class
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21185#discussion_r186772234
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -229,6 +229,23 @@ private[spark] class Executor(
ManagementFactory.get
Github user squito closed the pull request at:
https://github.com/apache/spark/pull/21185
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21185
I'm closing this in favor of https://github.com/apache/spark/pull/21190
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.ap
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21230
Sounds good to me. Lets plan on getting this one in to fix the current
problem, and commit the other approach when stats are fixed.
---
-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90368/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90368 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90368/testReport)**
for PR 21252 at commit
[`4a8a061`](https://github.com/apache/spark/commit/4
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21252#discussion_r186739581
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1238,6 +1238,14 @@ object SQLConf {
.booleanConf
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21028
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3041/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21028
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21252#discussion_r186736697
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1238,6 +1238,14 @@ object SQLConf {
.booleanConf
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21028
**[Test build #90370 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90370/testReport)**
for PR 21028 at commit
[`964f7af`](https://github.com/apache/spark/commit/96
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21268
@nrchakradhar if the load balancer fills the header `X-Forwarded-Context`
with the proper base path, then this will work.
---
-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r186728795
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -28,6 +30,34 @@ import org.apache.spa
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3040/
Tes
Github user nrchakradhar commented on the issue:
https://github.com/apache/spark/pull/21268
@mgaido91 Just a query. Is this specific to Knox only or will it work when
the HistoryServer UI is proxied by different load balancer?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21211
Thanks @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21268
**[Test build #90369 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90369/testReport)**
for PR 21268 at commit
[`c7fafd6`](https://github.com/apache/spark/commit/c7
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21254
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21211
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20787#discussion_r186725257
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1194,13 +1194,21 @@ case class AddMon
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21254
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21211
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21189
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21189
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90365/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21189
**[Test build #90365 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90365/testReport)**
for PR 21189 at commit
[`f72084e`](https://github.com/apache/spark/commit/f
Github user zheh12 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21257#discussion_r186719888
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
---
@@ -207,9 +207,25 @@ case class Ins
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3039/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90368 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90368/testReport)**
for PR 21252 at commit
[`4a8a061`](https://github.com/apache/spark/commit/4a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90366/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21268
**[Test build #90366 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90366/testReport)**
for PR 21268 at commit
[`0af9c2a`](https://github.com/apache/spark/commit/0
Github user efimpoberezkin commented on the issue:
https://github.com/apache/spark/pull/20936
@tdas Hi, seems like it's good to go. Could you merge this when you have
time?
---
-
To unsubscribe, e-mail: reviews-unsu
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3038/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21236
**[Test build #90367 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90367/testReport)**
for PR 21236 at commit
[`6aa90ef`](https://github.com/apache/spark/commit/6a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21268
**[Test build #90366 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90366/testReport)**
for PR 21268 at commit
[`0af9c2a`](https://github.com/apache/spark/commit/0a
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21268
@jerryshao may you please review this when you have time? Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/21268
[SPARK-24209][SHS] Automatic retrieve proxyBase from Knox headers
## What changes were proposed in this pull request?
The PR retrieves the proxyBase automatically from the header
`X-Forwa
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r186710034
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -28,6 +30,34 @@ import org.apache.spark.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21257#discussion_r186707079
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
---
@@ -207,9 +207,25 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r186706829
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -28,6 +30,34 @@ import org.apache.spark
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21106#discussion_r186706306
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
@@ -108,7 +108,31 @@ abstract class UnsafeProjection
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21129
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21129
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90360/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21129
**[Test build #90360 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90360/testReport)**
for PR 21129 at commit
[`54f73af`](https://github.com/apache/spark/commit/5
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21028#discussion_r186690973
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -28,6 +30,34 @@ import org.apache.spark.
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/21149
@maropu @hvanhovell thanks very much!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186677863
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -100,17 +101,18 @@ abstract class Expression extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186681857
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression, dataT
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186683015
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -56,19 +57,19 @@ import org.apache.spark.
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186674665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -623,8 +624,14 @@ case class Cast(child: Expression, dataT
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186679356
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -119,7 +121,7 @@ abstract class Expression extends T
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186679287
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186679018
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
}
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21193
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90362/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21193
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21193
**[Test build #90362 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90362/testReport)**
for PR 21193 at commit
[`53b329a`](https://github.com/apache/spark/commit/5
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21231#discussion_r186673964
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -147,7 +148,44 @@ case class SortPrefix(child: So
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21267#discussion_r186673789
--- Diff: python/pyspark/context.py ---
@@ -211,9 +211,23 @@ def _do_init(self, master, appName, sparkHome,
pyFiles, environment, batchSize,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21231#discussion_r186672482
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -147,7 +148,44 @@ case class SortPrefix(child: SortOr
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21267#discussion_r186670486
--- Diff: python/pyspark/context.py ---
@@ -211,9 +211,23 @@ def _do_init(self, master, appName, sparkHome,
pyFiles, environment, batchSize,
for
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186670840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186670675
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -114,6 +114,113 @@ object JavaCode {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21149
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r186669860
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -119,7 +121,7 @@ abstract class Expression exten
Github user sujith71955 commented on the issue:
https://github.com/apache/spark/pull/20611
Currently all the load command use-cases with wildcard in a load path are
blocked for the users
---
-
To unsubscribe, e-mai
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21149
LGTM - merging to master. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21189
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user andrusha commented on the issue:
https://github.com/apache/spark/pull/21095
@liyinan926 that's the idea. We should have a single step to mount all
kinds of volumes including hostPath and emptyDir. The only problem is the
configuration awkwardness.
---
--
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21231#discussion_r186668643
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -147,7 +148,44 @@ case class SortPrefix(child: So
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21189
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3037/
Tes
Github user sujith71955 commented on the issue:
https://github.com/apache/spark/pull/20611
@wzhfy @HyukjinKwon @jiangxb1987 @gatorsmile @vinodkc, Please let me know
for any suggestions regarding this PR. I covered all scenarios related to this
PR. Working fine.
---
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21231
LGTM cc: @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21231#discussion_r186667062
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SortOrderExpressionsSuite.scala
---
@@ -0,0 +1,96 @@
+/*
+ * License
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21149
ping @hvanhovell @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21189
**[Test build #90365 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90365/testReport)**
for PR 21189 at commit
[`f72084e`](https://github.com/apache/spark/commit/f7
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186663637
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/udtf_replicate_rows.sql ---
@@ -0,0 +1,41 @@
+CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186663298
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/udtf_replicate_rows.sql ---
@@ -0,0 +1,41 @@
+CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186662955
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,54 @@ case class Stack(children: Seq[Exp
301 - 400 of 456 matches
Mail list logo
