[GitHub] spark issue #21067: [SPARK-23980][K8S] Resilient Spark driver on Kubernetes

2018-07-12 Thread baluchicken
Github user baluchicken commented on the issue: https://github.com/apache/spark/pull/21067 @foxish I just checked on a Google Kubernetes Cluster with Kubernetes version 1.10.4-gke.2. I created a two node cluster and I emulated "network partition" with iptables rules (node running the

[GitHub] spark issue #21751: [SPARK-24208][SQL][FOLLOWUP] Move test cases to proper l...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21751 **[Test build #92921 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92921/testReport)** for PR 21751 at commit

[GitHub] spark issue #21635: [SPARK-24594][YARN] Introducing metrics for YARN

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21635 **[Test build #92934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92934/testReport)** for PR 21635 at commit

[GitHub] spark issue #21690: [SPARK-24713]AppMatser of spark streaming kafka OOM if t...

2018-07-12 Thread yuanboliu
Github user yuanboliu commented on the issue: https://github.com/apache/spark/pull/21690 @koeninger Sorry to interrupt, could you take a look at my patch? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-07-12 Thread mn-mikke
Github user mn-mikke commented on the issue: https://github.com/apache/spark/pull/21747 IMHO, we could directly use ```DataType.equalsIgnoreCaseAndNullability``` instead of ```sameType``` to make sure that ```mergeTwoDataTypes``` won't blow up if the trait is misused. The proper

[GitHub] spark pull request #21635: [SPARK-24594][YARN] Introducing metrics for YARN

2018-07-12 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/21635#discussion_r202015739 --- Diff: docs/monitoring.md --- @@ -435,6 +435,7 @@ set of sinks to which metrics are reported. The following instances are currentl * `executor`:

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21747 **[Test build #92933 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92933/testReport)** for PR 21747 at commit

[GitHub] spark issue #21526: [SPARK-24515][CORE] No need to warning when output commi...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21526 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92931/ Test FAILed. ---

[GitHub] spark issue #21526: [SPARK-24515][CORE] No need to warning when output commi...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21526 **[Test build #92931 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92931/testReport)** for PR 21526 at commit

[GitHub] spark issue #21526: [SPARK-24515][CORE] No need to warning when output commi...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21526 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21565: [SPARK-24558][Core]wrong Idle Timeout value is used in c...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21565 **[Test build #92932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92932/testReport)** for PR 21565 at commit

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-07-12 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/21618 gental ping @cloud-fan @gatorsmile @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21745 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92920/ Test PASSed. ---

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21745 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21652: [SPARK-24551][K8S] Add integration tests for secr...

2018-07-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21652#discussion_r202007781 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala --- @@ -232,6

[GitHub] spark pull request #21652: [SPARK-24551][K8S] Add integration tests for secr...

2018-07-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21652#discussion_r202007703 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala --- @@ -0,0

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21745 **[Test build #92920 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92920/testReport)** for PR 21745 at commit

[GitHub] spark issue #21526: [SPARK-24515][CORE] No need to warning when output commi...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21526 **[Test build #92931 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92931/testReport)** for PR 21526 at commit

[GitHub] spark pull request #21526: [SPARK-24515][CORE] No need to warning when outpu...

2018-07-12 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21526#discussion_r202006002 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -357,6 +357,11 @@ package object config { .intConf

[GitHub] spark pull request #21526: [SPARK-24515][CORE] No need to warning when outpu...

2018-07-12 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21526#discussion_r202005902 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -357,6 +357,11 @@ package object config { .intConf

[GitHub] spark pull request #21526: [SPARK-24515][CORE] No need to warning when outpu...

2018-07-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21526#discussion_r202005442 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -357,6 +357,11 @@ package object config { .intConf

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-07-12 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21747 How about making a temporary helper function for `sameType` in `ComplexTypeMergingExpression`? You read the config for case sensitivity in a driver side, and hold it as a field value in the closure.

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix type coercions and nullabi...

2018-07-12 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r202002501 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -184,6 +184,17 @@ object TypeCoercion { }

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix type coercions and nullabi...

2018-07-12 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r202001514 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -179,11 +180,13 @@ case class

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-07-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21747 ah, that's hard to fix, maybe just leave it, since Spark 2.4 is coming. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/896/

[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21667 **[Test build #92930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92930/testReport)** for PR 21667 at commit

[GitHub] spark issue #21447: [SPARK-24339][SQL]Add project for transform/map/reduce s...

2018-07-12 Thread xdcjie
Github user xdcjie commented on the issue: https://github.com/apache/spark/pull/21447 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21667 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20795 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92919/ Test PASSed. ---

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20795 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21526: [SPARK-24515][CORE] No need to warning when output commi...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21526 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20795 **[Test build #92919 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92919/testReport)** for PR 20795 at commit

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21747 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92925/ Test FAILed. ---

[GitHub] spark issue #21526: [SPARK-24515][CORE] No need to warning when output commi...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21526 **[Test build #92929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92929/testReport)** for PR 21526 at commit

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21747 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21526: [SPARK-24515][CORE] No need to warning when output commi...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21526 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92929/ Test FAILed. ---

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21747 **[Test build #92925 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92925/testReport)** for PR 21747 at commit

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21552 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21552 **[Test build #92928 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92928/testReport)** for PR 21552 at commit

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21552 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92928/ Test FAILed. ---

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21552 **[Test build #92928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92928/testReport)** for PR 21552 at commit

[GitHub] spark issue #21526: [SPARK-24515][CORE] No need to warning when output commi...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21526 **[Test build #92929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92929/testReport)** for PR 21526 at commit

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21745 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21745 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92918/ Test PASSed. ---

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21745 **[Test build #92918 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92918/testReport)** for PR 21745 at commit

[GitHub] spark issue #21635: [SPARK-24594][YARN] Introducing metrics for YARN

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21635 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92927/ Test PASSed. ---

[GitHub] spark issue #21635: [SPARK-24594][YARN] Introducing metrics for YARN

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21635 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21635: [SPARK-24594][YARN] Introducing metrics for YARN

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21635 **[Test build #92927 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92927/testReport)** for PR 21635 at commit

[GitHub] spark issue #21180: [SPARK-22674][PYTHON] Disabled _hack_namedtuple for pick...

2018-07-12 Thread superbobry
Github user superbobry commented on the issue: https://github.com/apache/spark/pull/21180 Hey @HyukjinKwon, apologies for yet another ping. Should I ask for someone else to review the PR on the spark-dev mailing list? ---

[GitHub] spark issue #21541: [SPARK-20168][Streaming Kinesis] Setting the timestamp d...

2018-07-12 Thread yashs360
Github user yashs360 commented on the issue: https://github.com/apache/spark/pull/21541 Any reviews here please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21562: [Trivial][ML] GMM unpersist RDD after training

2018-07-12 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/21562 @felixcheung Would you mind make a final pass? Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #21635: [SPARK-24594][YARN] Introducing metrics for YARN

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21635 **[Test build #92927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92927/testReport)** for PR 21635 at commit

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21745 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21745 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92917/ Test FAILed. ---

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21745 **[Test build #92917 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92917/testReport)** for PR 21745 at commit

[GitHub] spark pull request #21635: [SPARK-24594][YARN] Introducing metrics for YARN

2018-07-12 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/21635#discussion_r201979140 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -309,6 +312,11 @@ private[spark] class

[GitHub] spark issue #21743: [SPARK-24767][Launcher] Propagate MDC to spark-submit th...

2018-07-12 Thread yifeih
Github user yifeih commented on the issue: https://github.com/apache/spark/pull/21743 ping @vanzin. thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21589: [SPARK-24591][CORE] Number of cores and executors...

2018-07-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21589#discussion_r201973111 --- Diff: R/pkg/R/context.R --- @@ -435,3 +435,31 @@ setCheckpointDir <- function(directory) { sc <- getSparkContext()

[GitHub] spark issue #21754: [SPARK-24705][SQL] Cannot reuse an exchange operator wit...

2018-07-12 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21754 @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21552 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-12 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21664 The problem is that the job hanging,and user will be misleading since no more information print. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #21745: [SPARK-24781][SQL] Using a reference from Dataset...

2018-07-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21745#discussion_r201971954 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1167,7 +1169,8 @@ class Analyzer(

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21552 **[Test build #92926 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92926/testReport)** for PR 21552 at commit

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21552 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92926/ Test FAILed. ---

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21552 **[Test build #92926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92926/testReport)** for PR 21552 at commit

[GitHub] spark pull request #21552: [SPARK-24544][SQL] Print actual failure cause whe...

2018-07-12 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21552#discussion_r201970972 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -131,6 +132,8 @@ private[sql] class HiveSessionCatalog(

[GitHub] spark pull request #21745: [SPARK-24781][SQL] Using a reference from Dataset...

2018-07-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21745#discussion_r201971131 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1167,7 +1169,8 @@ class Analyzer(

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21747 **[Test build #92925 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92925/testReport)** for PR 21747 at commit

[GitHub] spark issue #21733: [SPARK-24763][SS] Remove redundant key data from value i...

2018-07-12 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/spark/pull/21733 @arunmahadevan @jose-torres

[GitHub] spark pull request #21589: [SPARK-24591][CORE] Number of cores and executors...

2018-07-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21589#discussion_r201968413 --- Diff: R/pkg/R/context.R --- @@ -435,3 +435,31 @@ setCheckpointDir <- function(directory) { sc <- getSparkContext()

[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-12 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/21664 You already got an uncaught exception, there's no need to add warning log. Besides, this is a fatal error, how will let the job continue with such error? ---

[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-12 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21664 @jerryshao I think at least we should print a warning,not let job hanging?Thanks --- - To unsubscribe, e-mail:

[GitHub] spark issue #21526: [SPARK-24515][CORE] No need to warning when output commi...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21526 **[Test build #92923 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92923/testReport)** for PR 21526 at commit

[GitHub] spark issue #21526: [SPARK-24515][CORE] No need to warning when output commi...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21526 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92923/ Test FAILed. ---

[GitHub] spark issue #21526: [SPARK-24515][CORE] No need to warning when output commi...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21526 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21526: [SPARK-24515][CORE] No need to warning when output commi...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21526 **[Test build #92923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92923/testReport)** for PR 21526 at commit

[GitHub] spark issue #21704: [SPARK-24734][SQL] Fix type coercions and nullabilities ...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21704 **[Test build #92922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92922/testReport)** for PR 21704 at commit

[GitHub] spark issue #20701: [SPARK-23528][ML] Add numIter to ClusteringSummary

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20701 **[Test build #92924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92924/testReport)** for PR 20701 at commit

[GitHub] spark issue #20701: [SPARK-23528][ML] Add numIter to ClusteringSummary

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20701 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/895/

[GitHub] spark issue #21751: [SPARK-24208][SQL][FOLLOWUP] Move test cases to proper l...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21751 **[Test build #92921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92921/testReport)** for PR 21751 at commit

[GitHub] spark issue #20629: [SPARK-23451][ML] Deprecate KMeans.computeCost

2018-07-12 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20629 @holdenk @sethah any more comments on this? As 2.4 release is approaching I think it would be great to have this in, so we can remove the deprecated APIs in 3.0... Thanks. ---

[GitHub] spark issue #21704: [SPARK-24734][SQL] Fix type coercions and nullabilities ...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21704 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21751: [SPARK-24208][SQL][FOLLOWUP] Move test cases to proper l...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21751 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/893/

[GitHub] spark issue #20701: [SPARK-23528][ML] Add numIter to ClusteringSummary

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20701 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21704: [SPARK-24734][SQL] Fix type coercions and nullabilities ...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21704 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/894/

[GitHub] spark issue #21751: [SPARK-24208][SQL][FOLLOWUP] Move test cases to proper l...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21751 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21526: [SPARK-24515][CORE] No need to warning when outpu...

2018-07-12 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21526#discussion_r201963160 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -1053,7 +1053,10 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])

[GitHub] spark pull request #21526: [SPARK-24515][CORE] No need to warning when outpu...

2018-07-12 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/21526#discussion_r201962635 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -1053,7 +1053,10 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])

[GitHub] spark pull request #21751: [SPARK-24208][SQL][FOLLOWUP] Move test cases to p...

2018-07-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21751#discussion_r201962341 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala --- @@ -557,4 +558,21 @@ class AnalysisSuite extends

[GitHub] spark pull request #21184: [WIP][SPARK-24051][SQL] Replace Aliases with the ...

2018-07-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21184#discussion_r201961786 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -284,6 +288,80 @@ class Analyzer( } }

[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-12 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/21664 The issue is not introduced by Spark itself, it is introduced by user code, is it better to fix in the user side rather than in Spark? Besides, I'm not so sure that Spark should take

[GitHub] spark pull request #21184: [WIP][SPARK-24051][SQL] Replace Aliases with the ...

2018-07-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21184#discussion_r201957701 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -2265,4 +2266,15 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark issue #20356: [SPARK-23185][SQL] Make the configuration "spark.default...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20356 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

2018-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21061 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-07-12 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21061 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21664: [SPARK-24687][CORE] NoClassDefFoundError will not be cat...

2018-07-12 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/21664 @jiangxb1987 Thanks, i update the description of this pr.Stage 33 never be scheduled.and job not abort --- - To unsubscribe,

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21745 **[Test build #92920 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92920/testReport)** for PR 21745 at commit

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21745 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/892/

<    1   2   3   4   5   >