[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21745 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21745: [SPARK-24781][SQL] Using a reference from Dataset...

2018-07-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21745#discussion_r201945591 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1167,7 +1169,8 @@ class Analyzer( case

[GitHub] spark pull request #21745: [SPARK-24781][SQL] Using a reference from Dataset...

2018-07-12 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21745#discussion_r201930407 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1167,7 +1169,8 @@ class Analyzer( case

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20795 **[Test build #92919 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92919/testReport)** for PR 20795 at commit

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21745 **[Test build #92918 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92918/testReport)** for PR 21745 at commit

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21745 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/891/

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-07-12 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/20795 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21745 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21556: [SPARK-24549][SQL] Support Decimal type push down...

2018-07-12 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/21556#discussion_r201928990 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -248,29 +371,29 @@ private[parquet] class

[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92913/ Test FAILed. ---

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20795 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92915/ Test FAILed. ---

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21747 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21747 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92914/ Test FAILed. ---

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20795 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21667 **[Test build #92913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92913/testReport)** for PR 21667 at commit

[GitHub] spark issue #21447: [SPARK-24339][SQL]Add project for transform/map/reduce s...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21447 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21747 **[Test build #92914 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92914/testReport)** for PR 21747 at commit

[GitHub] spark issue #21447: [SPARK-24339][SQL]Add project for transform/map/reduce s...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21447 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92916/ Test FAILed. ---

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20795 **[Test build #92915 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92915/testReport)** for PR 20795 at commit

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21745 **[Test build #92917 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92917/testReport)** for PR 21745 at commit

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21745 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21745 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/890/

[GitHub] spark pull request #21556: [SPARK-24549][SQL] Support Decimal type push down...

2018-07-12 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/21556#discussion_r201927646 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -202,6 +283,16 @@ private[parquet] class

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the ext...

2018-07-12 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r201926692 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1204,16 +1207,32 @@ class Analyzer( * only

[GitHub] spark pull request #21556: [SPARK-24549][SQL] Support Decimal type push down...

2018-07-12 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/21556#discussion_r201925142 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -225,12 +316,44 @@ private[parquet] class

[GitHub] spark pull request #21556: [SPARK-24549][SQL] Support Decimal type push down...

2018-07-12 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/21556#discussion_r201924695 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -225,12 +316,44 @@ private[parquet] class

[GitHub] spark issue #21447: [SPARK-24339][SQL]Add project for transform/map/reduce s...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21447 **[Test build #92916 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92916/testReport)** for PR 21447 at commit

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix type coercions and nullabi...

2018-07-12 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r201924130 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -610,27 +636,27 @@ object TypeCoercion {

[GitHub] spark issue #21447: [SPARK-24339][SQL]Add project for transform/map/reduce s...

2018-07-12 Thread xdcjie
Github user xdcjie commented on the issue: https://github.com/apache/spark/pull/21447 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21754: [SPARK-24705][SQL] Cannot reuse an exchange operator wit...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21754 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92910/ Test PASSed. ---

[GitHub] spark issue #21754: [SPARK-24705][SQL] Cannot reuse an exchange operator wit...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21754 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21754: [SPARK-24705][SQL] Cannot reuse an exchange operator wit...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21754 **[Test build #92910 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92910/testReport)** for PR 21754 at commit

[GitHub] spark pull request #21753: [SPARK-24790][SQL] Allow complex aggregate expres...

2018-07-12 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/spark/pull/21753#discussion_r201922330 --- Diff: sql/core/src/test/resources/sql-tests/results/pivot.sql.out --- @@ -192,3 +192,33 @@ struct<> -- !query 12 output

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the ext...

2018-07-12 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r201921920 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/LookupFunctionsSuite.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the ext...

2018-07-12 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r201921878 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/LookupFunctionsSuite.scala --- @@ -0,0 +1,70 @@ +/* + * Licensed to

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20795 **[Test build #92915 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92915/testReport)** for PR 20795 at commit

[GitHub] spark issue #21753: [SPARK-24790][SQL] Allow complex aggregate expressions i...

2018-07-12 Thread maryannxue
Github user maryannxue commented on the issue: https://github.com/apache/spark/pull/21753 @maropu It's not a bug. It works as I specified in my original PR, and you can also refer to https://docs.oracle.com/database/121/SQLRF/img_text/pivot_clause.htm, which only allows a form of

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-07-12 Thread mn-mikke
Github user mn-mikke commented on the issue: https://github.com/apache/spark/pull/21747 Thanks guys for triggering the builds, but I must implement a fix first. It's failing since the code is accessing ```SQLConf``` from executors (```doCodeGen```->

[GitHub] spark pull request #21589: [SPARK-24591][CORE] Number of cores and executors...

2018-07-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21589#discussion_r201920416 --- Diff: R/pkg/R/context.R --- @@ -435,3 +435,31 @@ setCheckpointDir <- function(directory) { sc <- getSparkContext()

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix containsNull of Concat for...

2018-07-12 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r201919906 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -48,7 +48,8 @@ case class

[GitHub] spark issue #21668: [SPARK-24690][SQL] Add a new config to control plan stat...

2018-07-12 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21668 @cloud-fan If no problem, could you check #20345 and merge it first? Based on that, I'd like to start refactoring for the approach. ---

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21589 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92907/ Test PASSed. ---

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21589 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

<    1   2   3   4   5