Github user rxin commented on the issue:
https://github.com/apache/spark/pull/19868
can somebody explain to me what the pr description has to do with
missingFiles? I'm probably missing something but i feel the implementation is
very different from the pr description.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22192
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96211/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22192
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22192
**[Test build #96211 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96211/testReport)**
for PR 22192 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22457
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22459
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22173
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22173
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96208/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22173
**[Test build #96208 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96208/testReport)**
for PR 22173 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22462
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22462
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22462
**[Test build #96225 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96225/testReport)**
for PR 22462 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22462
cc @cloud-fan, this actually bugged me. Mind taking a look when you are
available please?
---
-
To unsubscribe, e-mail:
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/22462
[SPARK-25460][SS] DataSourceV2: SS sources do not respect
SessionConfigSupport
## What changes were proposed in this pull request?
This PR proposes to respect `SessionConfigSupport`
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/22449
@WeichenXu123 I think we should fix the test instead of removing "//" from
URI if authority is empty. Because both "scheme:/" and "scheme:///" are valid.
~~~scala
scala> val u1 = new
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/22461
@gatorsmile Thanks a lot!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22461
**[Test build #96224 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96224/testReport)**
for PR 22461 at commit
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/22461
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user suryag10 commented on the issue:
https://github.com/apache/spark/pull/22433
@mridulm @liyinan926 @jacobdr @ifilonenko
code check for space,"/" handling is already present at
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22461
add to whitelist
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22392
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user suryag10 commented on the issue:
https://github.com/apache/spark/pull/22433
> > Agreed with @mridulm that the naming restriction is specific to k8s and
should be handled in a k8s specific way, e.g., somewhere around
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22443
**[Test build #96223 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96223/testReport)**
for PR 22443 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22443
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22443
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22443
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16677
I'm convinced, there are 2 major issues:
1. abusing shuffle. we need a new mechanism for driver to analyze some
statistics about data (records per map task)
2. too many small tasks. We
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22459
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96210/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22459
**[Test build #96210 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96210/testReport)**
for PR 22459 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22192
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96212/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22192
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22192
**[Test build #96212 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96212/testReport)**
for PR 22192 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22443
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96213/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22443
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22443
**[Test build #96213 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96213/testReport)**
for PR 22443 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16677
ok after thinking about it more, i think we should just revert all of these
changes and go back to the drawing board. here's why:
1. the prs change some of the most common/core parts of spark,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22448
**[Test build #96222 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96222/testReport)**
for PR 22448 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22448
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22448
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22456#discussion_r218666270
--- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
@@ -31,7 +31,7 @@ import org.apache.spark.util.Utils
/**
* Result
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16677#discussion_r218665902
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -93,25 +96,93 @@ trait BaseLimitExec extends UnaryExecNode with
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22448#discussion_r218662840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -106,6 +107,22 @@ object TypeCoercion {
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22381#discussion_r218660634
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -503,9 +503,12 @@ private[spark] object AppStatusStore {
/**
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22460
**[Test build #4341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4341/testReport)**
for PR 22460 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22460
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96218/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22460
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/19773
@maropu @dongjoon-hyun Great thanks for your guidance !
```
Apache Spark already supports changing column types as a part of schema
evolution. Especially, ORC vectorized reader support
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22447
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22461
To `[SPARK-25453][SQL][TEST]`
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22447
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22461
Thanks! LGTM, too.
@gatorsmile @HyukjinKwon Can you trigger tests?
btw, the jenkins does not run these docker integration tests?
---
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22461
cc @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22447
**[Test build #96221 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96221/testReport)**
for PR 22447 at commit
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22461
Could you add `[TEST]` to title, otherwise LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22447
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22461
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21632
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21632
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22461
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22461
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22456
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22456
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96206/
Test PASSed.
---
GitHub user seancxmao opened a pull request:
https://github.com/apache/spark/pull/22461
[SPARK-25453] OracleIntegrationSuite IllegalArgumentException: Timestamp
format must be -mm-dd hh:mm:ss[.f]
## What changes were proposed in this pull request?
This PR aims to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21632
**[Test build #96220 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96220/testReport)**
for PR 21632 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22456
**[Test build #96206 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96206/testReport)**
for PR 22456 at commit
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/21632#discussion_r218657097
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -66,6 +69,9 @@ class DecisionTreeClassifier
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/21632#discussion_r218657039
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -65,6 +68,9 @@ class DecisionTreeRegressor
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/21632#discussion_r218657065
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -97,28 +103,48 @@ class DecisionTreeClassifier
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21632
**[Test build #96219 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96219/testReport)**
for PR 21632 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21632
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21632
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hthuynh2 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21527#discussion_r218656012
--- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
@@ -50,7 +50,9 @@ private[spark] sealed trait MapStatus {
private[spark]
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22460
**[Test build #96218 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96218/testReport)**
for PR 22460 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22460
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22460
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/22460
DO NOT MERGE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/squito/spark debugging
Alternatively you can review and apply these changes as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22457
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96209/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22457
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22451
**[Test build #96217 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96217/testReport)**
for PR 22451 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22457
**[Test build #96209 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96209/testReport)**
for PR 22457 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22451
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22451
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16677
Let me take an example from the PR description
> For example, we have three partitions with rows (100, 100, 50)
respectively. In global limit of 100 rows, we may take (34, 33, 33) rows for
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16677#discussion_r218652707
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -93,25 +96,93 @@ trait BaseLimitExec extends UnaryExecNode with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96205/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96205 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96205/testReport)**
for PR 22237 at commit
Github user stanzhai commented on the issue:
https://github.com/apache/spark/pull/18544
The issue has been addressed a long time ago @cloud-fan @maropu
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22448
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96204/
Test PASSed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16677#discussion_r218651545
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -93,25 +96,93 @@ trait BaseLimitExec extends UnaryExecNode with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22448
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22448
**[Test build #96204 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96204/testReport)**
for PR 22448 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22456#discussion_r218651070
--- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
@@ -31,7 +31,7 @@ import org.apache.spark.util.Utils
/**
*
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22381
**[Test build #96215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96215/testReport)**
for PR 22381 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22414
How about this?
https://github.com/apache/spark/compare/master...maropu:pr22414
IMO simple fixes and tests are better.
---
-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22165
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
1 - 100 of 554 matches
Mail list logo
