GitHub user zuotingbing reopened a pull request:
https://github.com/apache/spark/pull/20864
[SPARK-23745][SQL]Remove the directories of the
âhive.downloaded.resources.dirâ when HiveThriftServer2 stopped
## What changes were proposed in this pull request?
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22448
@ueshin
> I was thinking whether or not we should handle the case like
widenTest(DecimalType(3, 2), DecimalType(5, 1), Some(DecimalType(...))), which
is currently None?
Thank you
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22448#discussion_r218346135
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -31,6 +32,7 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22448#discussion_r218337303
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -31,6 +32,7 @@ import
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22448
@cloud-fan
> I think it's a bug fix instead of an improvement. findTightestCommonType
is used for binary operators and it should be easy to write some end-to-end
test cases to verify the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22165
**[Test build #96173 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96173/testReport)**
for PR 22165 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22165
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22165
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22165#discussion_r218328998
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -84,20 +88,20 @@ private[spark] class BarrierCoordinator(
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22448
@ueshin Can you please explain a bit ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/19773#discussion_r218324420
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -350,16 +366,11 @@ case class AlterTableChangeColumnCommand(
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22448
I'm just wondering we should care about the case like `decimal(3, 2)` vs.
`decimal(5, 1)`?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22402
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22402
**[Test build #96172 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96172/testReport)**
for PR 22402 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22402
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22411
We can't merge new features to maintenance branches(2.4 as well), so we
don't need to rush here, as this feature can only be available in the next
release.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22402
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22448#discussion_r218322027
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -106,6 +108,22 @@ object TypeCoercion {
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22443
@dongjoon-hyun we are trying to avoid the overhead of scalatest, not sbt.
So this LGTM
---
-
To unsubscribe, e-mail:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22448#discussion_r218321366
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -89,10 +91,10 @@ object TypeCoercion {
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22448#discussion_r218321144
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -106,6 +108,22 @@ object TypeCoercion {
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22448
I think it's a bug fix instead of an improvement. `findTightestCommonType`
is used for binary operators and it should be easy to write some end-to-end
test cases to verify the bug.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22441
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22448#discussion_r218320357
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -106,6 +108,22 @@ object TypeCoercion {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22441
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22441
**[Test build #96171 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96171/testReport)**
for PR 22441 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22448
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22448
**[Test build #96170 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96170/testReport)**
for PR 22448 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22448
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22448#discussion_r218319943
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -89,10 +91,10 @@ object TypeCoercion {
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22448
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22441
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22441
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96168/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22441
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96167/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22448
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22448
**[Test build #96169 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96169/testReport)**
for PR 22448 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22448
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96169/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22441
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22441
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22441
**[Test build #96167 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96167/testReport)**
for PR 22441 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22441
**[Test build #96168 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96168/testReport)**
for PR 22441 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21217
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22448#discussion_r218310175
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -89,10 +91,10 @@ object TypeCoercion {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22440
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r218309924
--- Diff: python/pyspark/sql/session.py ---
@@ -252,6 +253,22 @@ def newSession(self):
"""
return self.__class__(self._sc,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22440
Thanks! Merged to master/2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22448
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22448
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22448
**[Test build #96169 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96169/testReport)**
for PR 22448 at commit
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22448
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22448
[SPARK-25417][SQL] Improve findTightestCommonType to coerce Integral and
decimal types
## What changes were proposed in this pull request?
Currently `findTightestCommonType` is not able to
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22420
The change LGTM.
Please change the PR against `master` branch as per @dongjoon-hyun 's
suggestion.
It would be nice to have a better PR description :)
---
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22443#discussion_r218308258
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala
---
@@ -17,29 +17,28 @@
package
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r218307450
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala
---
@@ -16,11 +16,33 @@
*/
package
501 - 554 of 554 matches
Mail list logo
