Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r220977575
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -50,7 +52,26 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r220973430
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1245,3 +1245,27 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r220962782
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -33,11 +33,13 @@ import
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22558
Also cc @michaelmior and @cloud-fan .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22484#discussion_r220959695
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala
---
@@ -34,621 +34,539 @@ import
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22569
**[Test build #96701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96701/testReport)**
for PR 22569 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22569
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22569
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/21990
I'm +1 on switching to the builder and not using the private interface.
---
-
To unsubscribe, e-mail:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22425#discussion_r220956727
--- Diff: dev/tox.ini ---
@@ -14,6 +14,8 @@
# limitations under the License.
[pycodestyle]
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22569#discussion_r220955679
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/OpenHashSetSuite.scala ---
@@ -255,4 +255,16 @@ class OpenHashSetSuite extends SparkFunSuite
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/20503
I _think_ this could be good to backport into 2.4 assuming the current RC
fails if @ashashwat has the chance to update it and no one sees any issues with
including this in a backport to that
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/20503
Sure let's add a test with a unicode string to it if there's concern about
that and make sure the existing repr with named fields is covered the same test
case since I don't see an existing
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22569
LGTM except one minor comment
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22569#discussion_r220954056
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/OpenHashSetSuite.scala ---
@@ -255,4 +255,16 @@ class OpenHashSetSuite extends SparkFunSuite
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22425#discussion_r220950524
--- Diff: dev/tox.ini ---
@@ -14,6 +14,8 @@
# limitations under the License.
[pycodestyle]
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22425#discussion_r220950740
--- Diff: dev/tox.ini ---
@@ -14,6 +14,8 @@
# limitations under the License.
[pycodestyle]
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22568#discussion_r220948793
--- Diff: python/pyspark/sql/tests.py ---
@@ -5714,24 +5755,31 @@ def test_wrong_args(self):
pandas_udf(lambda x, y: x,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22568#discussion_r220948302
--- Diff: python/pyspark/sql/tests.py ---
@@ -5525,32 +5525,73 @@ def data(self):
.withColumn("v", explode(col('vs'))).drop('vs')
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22568#discussion_r220943714
--- Diff: python/pyspark/sql/tests.py ---
@@ -5525,32 +5525,73 @@ def data(self):
.withColumn("v", explode(col('vs'))).drop('vs')
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22568#discussion_r220948939
--- Diff: python/pyspark/sql/tests.py ---
@@ -5714,24 +5755,31 @@ def test_wrong_args(self):
pandas_udf(lambda x, y: x,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22568#discussion_r220944429
--- Diff: python/pyspark/sql/tests.py ---
@@ -5525,32 +5525,73 @@ def data(self):
.withColumn("v", explode(col('vs'))).drop('vs')
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/22295
nvm, the merge script only triggers the edits if we have conflicts. If you
can update 3.0 to 2.5 I'd be happy to merge.
---
-
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/22295
LGTM except the 3.0 to 2.5 I'll change that during the merge.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21522
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21522
**[Test build #96700 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96700/testReport)**
for PR 21522 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21522
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96700/
Test FAILed.
---
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17654
Thanks for working on this, remove duplicated code is great. I'm curious as
to why we couldn't remove some of the function calls to super and instead
depend on inheritance?
If it's the
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22570
Exactly same opinion with Sean's.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/22305
Gental ping @cloud-fan @gatorsmile @HyukjinKwon @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21522
**[Test build #96700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96700/testReport)**
for PR 21522 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #96699 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96699/testReport)**
for PR 22379 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/21522
cc @jkbradley as the reporter of this issue you might want to take a look.
---
-
To unsubscribe, e-mail:
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/21522
Jenkins ok to test.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22570
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22570
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22570
**[Test build #96698 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96698/testReport)**
for PR 22570 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22570#discussion_r220933694
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestServer.scala ---
@@ -91,7 +91,7 @@ private[rest] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22569
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22569
**[Test build #96697 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96697/testReport)**
for PR 22569 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22569
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22569
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22569
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22569
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96688/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22569
**[Test build #96688 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96688/testReport)**
for PR 22569 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22570
**[Test build #96696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96696/testReport)**
for PR 22570 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22570
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96696/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22570
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22570
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22570
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22570
**[Test build #96696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96696/testReport)**
for PR 22570 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/22138
Just rebased.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22138
**[Test build #96695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96695/testReport)**
for PR 22138 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22570
**[Test build #96694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96694/testReport)**
for PR 22570 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22563
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22570
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22570
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96694/
Test FAILed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22563
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22570
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22570
**[Test build #96694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96694/testReport)**
for PR 22570 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22570
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22570
cc @dongjoon-hyun @HyukjinKwon @srowen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/22570
[SPARK-25553][BUILD] Add EmptyInterpolatedStringChecker to scalastyle config
## What changes were proposed in this pull request?
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22568
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22568
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96692/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22568
**[Test build #96692 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96692/testReport)**
for PR 22568 at commit
Github user sandeep-katta commented on the issue:
https://github.com/apache/spark/pull/22466
I am running the same test case with hive version **1.2.1.spark2** and it
is passing,can I know with what hive version CI is running and how
org.apache.hive.jdbc.HiveStatement and external
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21588
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96685/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21588
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21588
**[Test build #96685 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96685/testReport)**
for PR 21588 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21257
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22563
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22528
> Another concern here is, we have another place to control the compression
codec (where we usually delegate to HDFS libraries).
I was considering using Compressor API but its streaming
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22563
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96687/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22563
**[Test build #96687 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96687/testReport)**
for PR 22563 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22010
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user Tianny commented on the issue:
https://github.com/apache/spark/pull/9168
@jackiehff Have you solved the problemï¼I met the error same as you.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22010
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r220908825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/FailureSafeParser.scala
---
@@ -15,50 +15,51 @@
* limitations under the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22568
**[Test build #96692 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96692/testReport)**
for PR 22568 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96684/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96693/testReport)**
for PR 22237 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #96684 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96684/testReport)**
for PR 22237 at commit
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r220905353
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/FailureSafeParser.scala
---
@@ -15,50 +15,51 @@
* limitations under the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22566
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22566
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96682/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22566
**[Test build #96682 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96682/testReport)**
for PR 22566 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22010
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96680/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22010
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96686/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22484
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22010
**[Test build #96680 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96680/testReport)**
for PR 22010 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22484
**[Test build #96686 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96686/testReport)**
for PR 22484 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22361
It looks very intersting talk. Since I cannot join the SAIS unfortunally, I
will watch this in live stream.
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22558
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96679/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22558
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22558
**[Test build #96679 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96679/testReport)**
for PR 22558 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22562
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22562
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
301 - 400 of 625 matches
Mail list logo
