[GitHub] spark issue #22569: [SPARK-25542][Core][Test] Move flaky test in OpenHashMap...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22569 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96738/ Test PASSed. ---

[GitHub] spark issue #22569: [SPARK-25542][Core][Test] Move flaky test in OpenHashMap...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22569 **[Test build #96738 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96738/testReport)** for PR 22569 at commit

[GitHub] spark issue #21157: [SPARK-22674][PYTHON] Removed the namedtuple pickling pa...

2018-09-28 Thread superbobry
Github user superbobry commented on the issue: https://github.com/apache/spark/pull/21157 > so this change would introduce a pretty big regression? The change does introduce a regression as some namedtuples will become unpicklable. However, it makes pickling in PySpark more

[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22577 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96737/ Test PASSed. ---

[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22577 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22577 **[Test build #96737 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96737/testReport)** for PR 22577 at commit

[GitHub] spark issue #22583: [SPARK-10816][SS] SessionWindow support for Structure St...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22583 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22583: [SPARK-10816][SS] SessionWindow support for Structure St...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22583 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22566: [SPARK-25458][SQL] Support FOR ALL COLUMNS in ANALYZE TA...

2018-09-28 Thread juliuszsompolski
Github user juliuszsompolski commented on the issue: https://github.com/apache/spark/pull/22566 LGTM. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22583: [SPARK-10816][SS] SessionWindow support for Structure St...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22583 **[Test build #96753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96753/testReport)** for PR 22583 at commit

[GitHub] spark issue #22566: [SPARK-25458][SQL] Support FOR ALL COLUMNS in ANALYZE TA...

2018-09-28 Thread juliuszsompolski
Github user juliuszsompolski commented on the issue: https://github.com/apache/spark/pull/22566 jenkins retest this --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22583: [SPARK-10816][SS] SessionWindow support for Struc...

2018-09-28 Thread xuanyuanking
GitHub user xuanyuanking opened a pull request: https://github.com/apache/spark/pull/22583 [SPARK-10816][SS] SessionWindow support for Structure Streaming ## What changes were proposed in this pull request? As the discussion in

[GitHub] spark issue #22571: [SPARK-25392][Spark Job History]Inconsistent behaviour f...

2018-09-28 Thread sandeep-katta
Github user sandeep-katta commented on the issue: https://github.com/apache/spark/pull/22571 cc @cloud-fan Please review --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22580: [SPARK-25508][SQL] Refactor OrcReadBenchmark to use main...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22580 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22580: [SPARK-25508][SQL] Refactor OrcReadBenchmark to use main...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22580 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96743/ Test PASSed. ---

[GitHub] spark issue #22580: [SPARK-25508][SQL] Refactor OrcReadBenchmark to use main...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22580 **[Test build #96743 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96743/testReport)** for PR 22580 at commit

[GitHub] spark issue #22566: [SPARK-25458][SQL] Support FOR ALL COLUMNS in ANALYZE TA...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22566 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96739/ Test FAILed. ---

[GitHub] spark issue #22566: [SPARK-25458][SQL] Support FOR ALL COLUMNS in ANALYZE TA...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22566 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22566: [SPARK-25458][SQL] Support FOR ALL COLUMNS in ANALYZE TA...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22566 **[Test build #96739 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96739/testReport)** for PR 22566 at commit

[GitHub] spark issue #22582: [SPARK-25505][SQL][FOLLOWUP] Fix for attributes cosmetic...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22582 **[Test build #96752 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96752/testReport)** for PR 22582 at commit

[GitHub] spark issue #22582: [SPARK-25505][SQL][FOLLOWUP] Fix for attributes cosmetic...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22582 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22582: [SPARK-25505][SQL][FOLLOWUP] Fix for attributes cosmetic...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22582 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22442: [SPARK-25447][SQL] Support JSON options by schema_of_jso...

2018-09-28 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22442 @rxin @gatorsmile Do you have any objections of merging the PR? --- - To unsubscribe, e-mail:

[GitHub] spark issue #22582: [SPARK-25505][SQL][FOLLOWUP] Fix for attributes cosmetic...

2018-09-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22582 cc @gatorsmile @maryannxue --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #22582: [SPARK-25505][SQL][FOLLOWUP] Fix for attributes c...

2018-09-28 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/22582 [SPARK-25505][SQL][FOLLOWUP] Fix for attributes cosmetically different in Pivot clause ## What changes were proposed in this pull request? #22519 introduced a bug when the attributes in

[GitHub] spark issue #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_json

2018-09-28 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22237 > I actually was thinking about targeting 3.0 but looks now we are going ahead for 2.5. This bit is what I am less sure of for now actually. The PR definitely changes existing behavior of

[GitHub] spark issue #22519: [SPARK-25505][SQL] The output order of grouping columns ...

2018-09-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22519 Should we also mention this in the migration guide? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22528: [SPARK-25513][SQL] Read zipped CSV and JSON

2018-09-28 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22528 Since there is no consensus, I am going to close the PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #22581: [SPARK-25565][BUILD] Add scalastyle rule to check...

2018-09-28 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22581#discussion_r221213500 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -975,7 +975,7 @@ object SQLConf { "checkpoint

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22379 **[Test build #96751 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96751/testReport)** for PR 22379 at commit

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-28 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22379 jenkins, retest this, please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-28 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22519#discussion_r221212734 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -554,8 +554,11 @@ class Analyzer(

[GitHub] spark issue #22577: [CORE][MINOR] Fix obvious error and compiling for Scala ...

2018-09-28 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/22577 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22466: [SPARK-25464][SQL]On dropping the Database it will drop ...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22466 **[Test build #96750 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96750/testReport)** for PR 22466 at commit

[GitHub] spark issue #22568: [SPARK-23401][PYTHON][TESTS] Add more data types for Pan...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22568 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22568: [SPARK-23401][PYTHON][TESTS] Add more data types for Pan...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22568 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96747/ Test FAILed. ---

[GitHub] spark issue #22568: [SPARK-23401][PYTHON][TESTS] Add more data types for Pan...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22568 **[Test build #96747 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96747/testReport)** for PR 22568 at commit

[GitHub] spark issue #22574: [SPARK-25559][SQL] Just remove the unsupported predicate...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22574 **[Test build #96749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96749/testReport)** for PR 22574 at commit

[GitHub] spark issue #22581: [SPARK-25565][BUILD] Add scalastyle rule to check add Lo...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22581 **[Test build #96748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96748/testReport)** for PR 22581 at commit

[GitHub] spark issue #22574: [SPARK-25559][SQL] Just remove the unsupported predicate...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22574 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22581: [SPARK-25565][BUILD] Add scalastyle rule to check add Lo...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22581 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22574: [SPARK-25559][SQL] Just remove the unsupported predicate...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22574 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22581: [SPARK-25565][BUILD] Add scalastyle rule to check add Lo...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22581 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22581: [SPARK-25565][BUILD] Add scalastyle rule to check...

2018-09-28 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/22581 [SPARK-25565][BUILD] Add scalastyle rule to check add Locale.ROOT to .toLowerCase and .toUpperCase for internal calls ## What changes were proposed in this pull request? This PR adds

[GitHub] spark issue #22574: [SPARK-25559][SQL] Just remove the unsupported predicate...

2018-09-28 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22574 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT when toUpp...

2018-09-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22531 Thank you @seancxmao. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22568: [SPARK-23401][PYTHON][TESTS] Add more data types for Pan...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22568 **[Test build #96747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96747/testReport)** for PR 22568 at commit

[GitHub] spark pull request #22568: [SPARK-23401][PYTHON][TESTS] Add more data types ...

2018-09-28 Thread AlexanderKoryagin
Github user AlexanderKoryagin commented on a diff in the pull request: https://github.com/apache/spark/pull/22568#discussion_r221203078 --- Diff: python/pyspark/sql/tests.py --- @@ -5525,32 +5525,73 @@ def data(self): .withColumn("v", explode(col('vs'))).drop('vs')

[GitHub] spark pull request #22579: [SPARK-25429][SQL] Use Set instead of Array to im...

2018-09-28 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22579#discussion_r221202958 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala --- @@ -83,7 +83,7 @@ class SQLAppStatusListener( //

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22375 **[Test build #96746 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96746/testReport)** for PR 22375 at commit

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22375 **[Test build #96745 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96745/testReport)** for PR 22375 at commit

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96745/ Test FAILed. ---

[GitHub] spark issue #9168: [SPARK-11182] HDFS Delegation Token will be expired when ...

2018-09-28 Thread Tianny
Github user Tianny commented on the issue: https://github.com/apache/spark/pull/9168 @jackiehff My Hadoop cluster version is 2.6.0-cdh5.13.1. But still have the problem. I'm working on it trying to upgrade the spark version to latest version 2.3.2. By the way,I sent a email

[GitHub] spark issue #9168: [SPARK-11182] HDFS Delegation Token will be expired when ...

2018-09-28 Thread Tianny
Github user Tianny commented on the issue: https://github.com/apache/spark/pull/9168 > @Tianny,we just upgrade our hadoop cluster version to 2.6.0-cdh5.11.2 then the error disappered! My Hadoop cluster version is 2.6.0-cdh5.13.1. But still have the problem. I'm working on

[GitHub] spark issue #22568: [SPARK-23401][PYTHON][TESTS] Add more data types for Pan...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22568 **[Test build #96744 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96744/testReport)** for PR 22568 at commit

[GitHub] spark issue #22568: [SPARK-23401][PYTHON][TESTS] Add more data types for Pan...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22568 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96744/ Test PASSed. ---

[GitHub] spark issue #22568: [SPARK-23401][PYTHON][TESTS] Add more data types for Pan...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22568 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22375 **[Test build #96745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96745/testReport)** for PR 22375 at commit

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT when toUpp...

2018-09-28 Thread seancxmao
Github user seancxmao commented on the issue: https://github.com/apache/spark/pull/22531 @HyukjinKwon Please go ahead since you've already been working on this. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #22375: [SPARK-25388][Test][SQL] Detect incorrect nullabl...

2018-09-28 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22375#discussion_r221194592 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala --- @@ -35,6 +36,13 @@ class

[GitHub] spark pull request #22568: [SPARK-23401][PYTHON][TESTS] Add more data types ...

2018-09-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22568#discussion_r221194037 --- Diff: python/pyspark/sql/tests.py --- @@ -5525,32 +5525,73 @@ def data(self): .withColumn("v", explode(col('vs'))).drop('vs')

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96742/ Test FAILed. ---

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22375 **[Test build #96742 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96742/testReport)** for PR 22375 at commit

[GitHub] spark pull request #22568: [SPARK-23401][PYTHON][TESTS] Add more data types ...

2018-09-28 Thread AlexanderKoryagin
Github user AlexanderKoryagin commented on a diff in the pull request: https://github.com/apache/spark/pull/22568#discussion_r221186971 --- Diff: python/pyspark/sql/tests.py --- @@ -5714,24 +5755,31 @@ def test_wrong_args(self): pandas_udf(lambda x, y: x,

[GitHub] spark pull request #22568: [SPARK-23401][PYTHON][TESTS] Add more data types ...

2018-09-28 Thread AlexanderKoryagin
Github user AlexanderKoryagin commented on a diff in the pull request: https://github.com/apache/spark/pull/22568#discussion_r221186913 --- Diff: python/pyspark/sql/tests.py --- @@ -5714,24 +5755,31 @@ def test_wrong_args(self): pandas_udf(lambda x, y: x,

[GitHub] spark issue #22568: [SPARK-23401][PYTHON][TESTS] Add more data types for Pan...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22568 **[Test build #96744 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96744/testReport)** for PR 22568 at commit

[GitHub] spark pull request #22568: [SPARK-23401][PYTHON][TESTS] Add more data types ...

2018-09-28 Thread AlexanderKoryagin
Github user AlexanderKoryagin commented on a diff in the pull request: https://github.com/apache/spark/pull/22568#discussion_r221186790 --- Diff: python/pyspark/sql/tests.py --- @@ -5525,32 +5525,73 @@ def data(self): .withColumn("v", explode(col('vs'))).drop('vs')

[GitHub] spark issue #22580: [SPARK-25508][SQL] Refactor OrcReadBenchmark to use main...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22580 **[Test build #96743 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96743/testReport)** for PR 22580 at commit

[GitHub] spark pull request #22568: [SPARK-23401][PYTHON][TESTS] Add more data types ...

2018-09-28 Thread AlexanderKoryagin
Github user AlexanderKoryagin commented on a diff in the pull request: https://github.com/apache/spark/pull/22568#discussion_r221186707 --- Diff: python/pyspark/sql/tests.py --- @@ -5525,32 +5525,73 @@ def data(self): .withColumn("v", explode(col('vs'))).drop('vs')

[GitHub] spark issue #22580: [SPARK-25508][SQL] Refactor OrcReadBenchmark to use main...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22580 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22580: [SPARK-25508][SQL] Refactor OrcReadBenchmark to use main...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22580 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22580: [SPARK-25508][SQL] Refactor OrcReadBenchmark to u...

2018-09-28 Thread yucai
GitHub user yucai opened a pull request: https://github.com/apache/spark/pull/22580 [SPARK-25508][SQL] Refactor OrcReadBenchmark to use main method ## What changes were proposed in this pull request? Refactor OrcReadBenchmark to use main method. Generate benchmark

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22375 **[Test build #96742 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96742/testReport)** for PR 22375 at commit

[GitHub] spark issue #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT when toUpp...

2018-09-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22531 Oh, you mean @seancxmao is going to take over? Let me open a PR directly since I have some changes in local if you don't mind. ---

[GitHub] spark pull request #22443: [SPARK-25339][TEST] Refactor FilterPushdownBenchm...

2018-09-28 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22443#discussion_r221183362 --- Diff: core/src/main/scala/org/apache/spark/util/BenchmarkBase.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #22568: [SPARK-23401][PYTHON][TESTS] Add more data types ...

2018-09-28 Thread AlexanderKoryagin
Github user AlexanderKoryagin commented on a diff in the pull request: https://github.com/apache/spark/pull/22568#discussion_r221183502 --- Diff: python/pyspark/sql/tests.py --- @@ -5525,32 +5525,73 @@ def data(self): .withColumn("v", explode(col('vs'))).drop('vs')

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22375 **[Test build #96741 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96741/testReport)** for PR 22375 at commit

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96741/ Test FAILed. ---

[GitHub] spark issue #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT when toUpp...

2018-09-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22531 Thanks, will open a PR shortly. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #22443: [SPARK-25339][TEST] Refactor FilterPushdownBenchm...

2018-09-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22443#discussion_r221181595 --- Diff: core/src/main/scala/org/apache/spark/util/BenchmarkBase.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #22443: [SPARK-25339][TEST] Refactor FilterPushdownBenchm...

2018-09-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22443#discussion_r221181428 --- Diff: core/src/main/scala/org/apache/spark/util/BenchmarkBase.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #22443: [SPARK-25339][TEST] Refactor FilterPushdownBenchm...

2018-09-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22443#discussion_r221181170 --- Diff: core/src/main/scala/org/apache/spark/util/BenchmarkBase.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #22531: [SPARK-25415][SQL][FOLLOW-UP] Add Locale.ROOT when toUpp...

2018-09-28 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22531 @HyukjinKwon @seancxmao will take it over: [SPARK-25565](https://issues.apache.org/jira/browse/SPARK-25565) --- - To

[GitHub] spark pull request #22579: [SPARK-25429][SQL] Use Set instead of Array to im...

2018-09-28 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/22579#discussion_r221177626 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala --- @@ -83,7 +83,7 @@ class SQLAppStatusListener(

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22375 **[Test build #96741 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96741/testReport)** for PR 22375 at commit

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22375: [SPARK-25388][Test][SQL] Detect incorrect nullable of Da...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22375 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22484: [SPARK-25476][SPARK-25510][TEST] Refactor AggregateBench...

2018-09-28 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22484 @dongjoon-hyun Other refactorings are waiting for this commit. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22579: [SPARK-25429][SQL] Use Set instead of Array to improve l...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22579 **[Test build #96740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96740/testReport)** for PR 22579 at commit

[GitHub] spark issue #22579: [SPARK-25429][SQL] Use Set instead of Array to improve l...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22579 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22579: [SPARK-25429][SQL] Use Set instead of Array to improve l...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22579 Test PASSed. Refer to this link for build results (access rights to CI server needed):

<    1   2   3   4   5   >