Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/22620#discussion_r222698014
--- Diff: python/pyspark/sql/udf.py ---
@@ -310,9 +319,11 @@ def register(self, name, f, returnType=None):
"Invalid returnType:
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r222699236
--- Diff: python/pyspark/sql/session.py ---
@@ -231,6 +231,7 @@ def __init__(self, sparkContext, jsparkSession=None):
or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22060
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22060
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22347
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96937/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22347
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22060
**[Test build #96940 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96940/testReport)**
for PR 22060 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22347
**[Test build #96937 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96937/testReport)**
for PR 22347 at commit
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/22060
@maropu I'll follow up on this. I started the test again and I'll keep
track of "which rules violate the assumption" and "which tests can reproduce
the violation" in this PR.
---
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/22060
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22615#discussion_r222695007
--- Diff: hadoop-cloud/pom.xml ---
@@ -166,45 +166,35 @@
httpcore
${hadoop.deps.scope}
+
+ org.apache.hadoop
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22626
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96931/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22626
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22626
**[Test build #96931 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96931/testReport)**
for PR 22626 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22615
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96930/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22615
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22615
**[Test build #96930 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96930/testReport)**
for PR 22615 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21688
**[Test build #96939 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96939/testReport)**
for PR 21688 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21688
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22626
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22626
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96933/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22626
**[Test build #96933 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96933/testReport)**
for PR 22626 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22603
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96932/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22603
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22603
**[Test build #96932 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96932/testReport)**
for PR 22603 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/22623
Please update the title as it seems cut off.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r222653808
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ParseMode.scala
---
@@ -51,6 +56,8 @@ object ParseMode extends Logging {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r222651484
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -550,59 +550,93 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r222651368
--- Diff: docs/sql-programming-guide.md ---
@@ -1890,6 +1890,10 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
#
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96929 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96929/testReport)**
for PR 22466 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22466
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96929/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22572
**[Test build #96938 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96938/testReport)**
for PR 22572 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22572
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22621
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22621
thanks, merging to master/2.4!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22621#discussion_r222642107
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -517,4 +517,57 @@ class SQLMetricsSuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21596
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96928/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21596
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21596
**[Test build #96928 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96928/testReport)**
for PR 21596 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22610
**[Test build #96935 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96935/testReport)**
for PR 22610 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22610
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96935/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22610
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user Dooyoung-Hwang commented on the issue:
https://github.com/apache/spark/pull/22347
I added example code of issue case to the content of PR.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22621
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22621
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96927/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22627
**[Test build #96936 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96936/testReport)**
for PR 22627 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22621
**[Test build #96927 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96927/testReport)**
for PR 22621 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22627
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22627
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96936/
Test PASSed.
---
Github user Dooyoung-Hwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22347#discussion_r222623133
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -348,30 +349,30 @@ abstract class SparkPlan extends
Github user Dooyoung-Hwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22347#discussion_r222622501
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -348,30 +349,30 @@ abstract class SparkPlan extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22627
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22627
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96934/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22627
**[Test build #96934 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96934/testReport)**
for PR 22627 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22347
**[Test build #96937 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96937/testReport)**
for PR 22347 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/22618
LGTM. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22627
**[Test build #96936 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96936/testReport)**
for PR 22627 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22627
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22627
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/22627
@zsxwing
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22610
**[Test build #96935 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96935/testReport)**
for PR 22610 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22627
**[Test build #96934 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96934/testReport)**
for PR 22627 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22610
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user tdas opened a pull request:
https://github.com/apache/spark/pull/22627
[SPARK-25639] [DOCS] Added docs for foreachBatch, python foreach and
multiple watermarks
## What changes were proposed in this pull request?
Added
- Python foreach
- Scala, Java and
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22610#discussion_r222617651
--- Diff: python/pyspark/worker.py ---
@@ -84,13 +84,36 @@ def wrap_scalar_pandas_udf(f, return_type):
arrow_return_type =
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22610
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22594
This needs a JIRA as it's a non-trivial bug fix. This also doesn't explain
the problem at all. The problem is that records may be incremented by more than
1 at a time, right?
That should be
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22610
So I've added a bit document for this. @HyukjinKwon @BryanCutler please
check it when you have time.
---
-
To unsubscribe,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22610#discussion_r222616380
--- Diff: python/pyspark/worker.py ---
@@ -84,13 +84,36 @@ def wrap_scalar_pandas_udf(f, return_type):
arrow_return_type =
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r222614709
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala
---
@@ -137,16 +139,44 @@ object TimeWindow {
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22593
This is fine, although unfortunately there are lots of instances of this
type of formatting error. We don't need to fix them all, but what about looking
for similar instances in `Column` and
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22623
The only thing I'm confused about is, right now when the `SparkException`
is thrown instead of its cause, wouldn't you get a big stack trace starting
with the `SparkException`? that `SparkException`
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22621
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21816
**[Test build #4356 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4356/testReport)**
for PR 21816 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22626
**[Test build #96933 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96933/testReport)**
for PR 22626 at commit
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22375#discussion_r222604522
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -221,6 +227,12 @@ trait
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22626
add to whitelist
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22626
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22375#discussion_r222604455
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -69,11 +69,17 @@ trait
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22603
**[Test build #96932 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96932/testReport)**
for PR 22603 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22626
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22626
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user peter-toth commented on the issue:
https://github.com/apache/spark/pull/22603
Thanks @dongjoon-hyun for the review. I've fixed your findings.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22626
**[Test build #96931 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96931/testReport)**
for PR 22626 at commit
GitHub user MaxGekk opened a pull request:
https://github.com/apache/spark/pull/22626
[SPARK-25638][SQL] Adding new function - to_csv()
## What changes were proposed in this pull request?
New functions takes a struct and converts it to a CSV strings using passed
CSV
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22621#discussion_r222601659
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -517,4 +517,57 @@ class SQLMetricsSuite extends
Github user peter-toth commented on the issue:
https://github.com/apache/spark/pull/22617
cc @dongjoon-hyun @seancxmao
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22615
**[Test build #96930 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96930/testReport)**
for PR 22615 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22615
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22615
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22615#discussion_r222594164
--- Diff: dev/appveyor-install-dependencies.ps1 ---
@@ -95,7 +95,7 @@ $env:MAVEN_OPTS = "-Xmx2g -XX:ReservedCodeCacheSize=512m"
Pop-Location
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22466
**[Test build #96929 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96929/testReport)**
for PR 22466 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21596
**[Test build #96928 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96928/testReport)**
for PR 21596 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21596
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22621
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22621
**[Test build #96927 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96927/testReport)**
for PR 22621 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22621
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22621
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22572
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96925/
Test FAILed.
---
401 - 500 of 535 matches
Mail list logo
