Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22696
nice catch! Shall we mention this in the migration guide? It is a behavior
change (despite the previous was a wrong behavior), so I think warning users
might be a good thing. LGTM otherwise.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97245/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97245 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97245/testReport)**
for PR 22379 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #97263 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97263/testReport)**
for PR 22379 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/22677
Though it looks a little strange, the log content is actually right, I
don't think we want to make the last report timestamp to current time (that can
confuse users what happened before that
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22697
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22697
**[Test build #97262 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97262/testReport)**
for PR 22697 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22697
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22697
**[Test build #97261 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97261/testReport)**
for PR 22697 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22697
**[Test build #97260 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97260/testReport)**
for PR 22697 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22697
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97258/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22697
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22697
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22657
**[Test build #97259 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97259/testReport)**
for PR 22657 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22697
**[Test build #97258 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97258/testReport)**
for PR 22697 at commit
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/22697
[SPARK-25700][SQL][BRANCH-2.4] Partially revert append mode support in Data
Source V2
## What changes were proposed in this pull request?
This PR proposes to partially revert
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/spark/pull/22686
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22686
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22686
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22686
**[Test build #97257 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97257/testReport)**
for PR 22686 at commit
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/spark/pull/22686
[SPARK-25700][SQL] Partially revert append mode support in Data Source V2
## What changes were proposed in this pull request?
This PR partially revert
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22480
Than's interesting. Thanks for sharing it. There obviously should be a
throughout investigation about it.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22688
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97246/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22688
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22429
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22429
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97256/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22429
**[Test build #97256 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97256/testReport)**
for PR 22429 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22657
> Then yes, it's a better place. Sorry for the back and forth!
@cloud-fan Never mind. I will return it back. Thank you for reviewing it.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22688
**[Test build #97246 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97246/testReport)**
for PR 22688 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22657
Ah sorry I misread it as `DateTimeUtils` before...
Then yes, it's a better place. Sorry for the back and forth!
---
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22429
**[Test build #97256 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97256/testReport)**
for PR 22429 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22696
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22696
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22654
@gatorsmile Could you look at it one more time, please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22696#discussion_r224422094
--- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql ---
@@ -73,3 +73,9 @@ where b.z != b.z;
-- SPARK-24369 multiple distinct
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22696#discussion_r224421873
--- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql ---
@@ -73,3 +73,9 @@ where b.z != b.z;
-- SPARK-24369 multiple distinct
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22696
**[Test build #97254 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97254/testReport)**
for PR 22696 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22696
cc @hvanhovell @gatorsmile @viirya @mgaido91 @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22583
**[Test build #97255 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97255/testReport)**
for PR 22583 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22583
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22583
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22696
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22696
**[Test build #97252 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97252/testReport)**
for PR 22696 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22696
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22429
**[Test build #97253 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97253/testReport)**
for PR 22429 at commit
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/22696
[SPARK-25708][SQL] HAVING without GROUP BY means global aggregate
## What changes were proposed in this pull request?
According to the SQL standard, when a query contains `HAVING`, it
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r224418619
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala ---
@@ -167,6 +172,58 @@ package object util {
Github user brkyvz commented on the issue:
https://github.com/apache/spark/pull/22674
I would just up the timeout in that suite. Now that we're pushing a bunch
more stuff to the LiveListenerBus, it may not be draining quickly enough. On
slow jenkins' it could likely cause flakiness.
Github user sadhen commented on the issue:
https://github.com/apache/spark/pull/22685
OK. Nevermind.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user sadhen closed the pull request at:
https://github.com/apache/spark/pull/22685
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22657
> let's define it in the test scope.
What's the test scope here? Both `DateTimeTestUtils` and `SparkFunSuite`
are used in test suites only.
---
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r224415554
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/CatalystDataToAvro.scala
---
@@ -52,7 +52,7 @@ case class CatalystDataToAvro(child:
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r224415510
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -633,4 +633,14 @@ package object config {
.stringConf
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97244/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97244 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97244/testReport)**
for PR 22237 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22375#discussion_r224414454
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -69,11 +69,17 @@ trait
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22375#discussion_r224414284
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -69,11 +69,22 @@ trait
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22674
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22674
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22674
**[Test build #97251 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97251/testReport)**
for PR 22674 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22639
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22639
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3879/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22639
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22657
If it's only used in test let's define it in the test scope.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22674
I couldn't reproduce it locally, let me try again
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22674
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22639
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22639
**[Test build #97250 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97250/testReport)**
for PR 22639 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22639
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97250/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22661
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97243/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22639
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3879/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22661
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22661
**[Test build #97243 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97243/testReport)**
for PR 22661 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22639
**[Test build #97250 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97250/testReport)**
for PR 22639 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22661
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22661
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22661
**[Test build #97249 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97249/testReport)**
for PR 22661 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22347
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22347
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97242/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22695
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22347
**[Test build #97242 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97242/testReport)**
for PR 22347 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22695
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22695
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user heary-cao opened a pull request:
https://github.com/apache/spark/pull/22695
[MINOR][SQL]remove Redundant semicolons
## What changes were proposed in this pull request?
remove Redundant semicolons in SortMergeJoinExecï¼ thanks.
## How was this patch
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22676
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97240/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22676
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22676
**[Test build #97240 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97240/testReport)**
for PR 22676 at commit
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/22639
@mccheah Thanks for taking a look. Overall nice suggestion, I am okay with
idea of having a pod, I am struggling with creating a pod for socket server, I
can only think of non trivial options.
Github user pquentin commented on the issue:
https://github.com/apache/spark/pull/22480
@HyukjinKwon We were also bitten by this as Spark users. I use pyenv to get
Python versions on macOS 10.14. I noticed that Python 3.5.4 is not affected
(the workaround is not needed), but 3.5.5 is
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22661#discussion_r224396901
--- Diff: sql/core/benchmarks/JoinBenchmark-results.txt ---
@@ -0,0 +1,80 @@
+Java HotSpot(TM) 64-Bit Server VM 1.8.0_151-b12 on Mac OS X 10.12.6
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22375
**[Test build #97248 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97248/testReport)**
for PR 22375 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22375
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22375
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22664
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97241/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22664
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
401 - 500 of 599 matches
Mail list logo
