[GitHub] spark issue #22730: [SPARK-16775][CORE] Remove deprecated accumulator v1 API...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22730 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97407/ Test FAILed. ---

[GitHub] spark issue #22730: [SPARK-16775][CORE] Remove deprecated accumulator v1 API...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22730 **[Test build #97407 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97407/testReport)** for PR 22730 at commit [`7e80692`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #22730: [SPARK-16775][CORE] Remove deprecated accumulator v1 API...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22730 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21669 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4000/ ---

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-10-15 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21669 I went through the code again, and the main thing for me is that following this whole "steps" thing in the k8s backend still seems really hard to me. It feels like related code gets scattered around

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21669 **[Test build #97408 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97408/testReport)** for PR 21669 at commit [`dd95fca`](https://github.com/apache/spark/commit/dd

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-10-15 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21669 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark issue #22730: [SPARK-16775][CORE] Remove deprecated accumulator v1 API...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22730 **[Test build #97407 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97407/testReport)** for PR 22730 at commit [`7e80692`](https://github.com/apache/spark/commit/7e

[GitHub] spark issue #22560: [SPARK-25547][SQL] Pluggable JDBC connection factory

2018-10-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22560 Sorry for the late reply. Could we hold this PR since we are actively working on the data source API V2? Will revisit it after that. Also cc @gengliangwang @cloud-fan FYI, I just marke

[GitHub] spark issue #22730: [SPARK-16775][CORE] Remove deprecated accumulator v1 API...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22730 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22730: [SPARK-16775][CORE] Remove deprecated accumulator v1 API...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22730 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3999/

[GitHub] spark issue #22731: [SPARK-25674][FOLLOW-UP] Update the stats for each Colum...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22731 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22731: [SPARK-25674][FOLLOW-UP] Update the stats for each Colum...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22731 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3998/

[GitHub] spark issue #22731: [SPARK-25674][FOLLOW-UP] Update the stats for each Colum...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22731 **[Test build #97406 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97406/testReport)** for PR 22731 at commit [`7c3fd54`](https://github.com/apache/spark/commit/7c

[GitHub] spark pull request #22731: [SPARK-25674][FOLLOW-UP] Update the stats for eac...

2018-10-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22731#discussion_r225262559 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala --- @@ -106,15 +106,16 @@ class FileScanRDD( //

[GitHub] spark pull request #22681: [SPARK-25682][k8s] Package example jars in same t...

2018-10-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22681#discussion_r225259793 --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile --- @@ -18,6 +18,7 @@ FROM openjdk:8-alpine ARG spark_jar

[GitHub] spark issue #22731: [SPARK-25674][FOLLOW-UP] Update the stats for each Colum...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22731 **[Test build #97405 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97405/testReport)** for PR 22731 at commit [`8731588`](https://github.com/apache/spark/commit/87

[GitHub] spark issue #22731: [SPARK-25674][FOLLOW-UP] Update the stats for each Colum...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22731 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3997/

[GitHub] spark issue #22731: [SPARK-25674][FOLLOW-UP] Update the stats for each Colum...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22731 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22731: [SPARK-25674][FOLLOW-UP] Update the stats for each Colum...

2018-10-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22731 cc @10110346 @srowen @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #22263: [SPARK-25269][SQL] SQL interface support specify Storage...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22263 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97395/ Test PASSed. ---

[GitHub] spark pull request #22731: [SPARK-25674][FOLLOW-UP] Update the stats for eac...

2018-10-15 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/22731 [SPARK-25674][FOLLOW-UP] Update the stats for each ColumnarBatch ## What changes were proposed in this pull request? This PR is a follow-up of https://github.com/apache/spark/pull/22594 . Thi

[GitHub] spark issue #22263: [SPARK-25269][SQL] SQL interface support specify Storage...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22263 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22263: [SPARK-25269][SQL] SQL interface support specify Storage...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22263 **[Test build #97395 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97395/testReport)** for PR 22263 at commit [`8809311`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #22722: [SPARK-24432][k8s] Add support for dynamic resource allo...

2018-10-15 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/22722 @huafengw we are working on a new shuffle service + dynamic resource allocation design for k8s, and decided to not adopt the approach we used in the fork. @mccheah. --- ---

[GitHub] spark pull request #22726: [SPARK-25727][FOLLOWUP] Move outputOrdering to ca...

2018-10-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22726 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22730: [SPARK-16775][CORE] Remove deprecated accumulator v1 API...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22730 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22730: [SPARK-16775][CORE] Remove deprecated accumulator v1 API...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22730 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97403/ Test FAILed. ---

[GitHub] spark issue #22730: [SPARK-16775][CORE] Remove deprecated accumulator v1 API...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22730 **[Test build #97403 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97403/testReport)** for PR 22730 at commit [`4c6a9b4`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #22729: [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkar...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22729 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22729: [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkar...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22729 **[Test build #97404 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97404/testReport)** for PR 22729 at commit [`29edd40`](https://github.com/apache/spark/commit/29

[GitHub] spark issue #22468: [SPARK-25374][SQL] SafeProjection supports fallback to a...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22468 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97393/ Test PASSed. ---

[GitHub] spark issue #22468: [SPARK-25374][SQL] SafeProjection supports fallback to a...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22468 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22730: [SPARK-16775][CORE] Remove deprecated accumulator v1 API...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22730 **[Test build #97403 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97403/testReport)** for PR 22730 at commit [`4c6a9b4`](https://github.com/apache/spark/commit/4c

[GitHub] spark issue #22729: [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkar...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22729 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3996/

[GitHub] spark issue #22730: [SPARK-16775][CORE] Remove deprecated accumulator v1 API...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22730 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22730: [SPARK-16775][CORE] Remove deprecated accumulator v1 API...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22730 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3995/

[GitHub] spark issue #22468: [SPARK-25374][SQL] SafeProjection supports fallback to a...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22468 **[Test build #97393 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97393/testReport)** for PR 22468 at commit [`f658ac9`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #22703: [SPARK-25705][BUILD][STREAMING][test-maven] Remove Kafka...

2018-10-15 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22703 So far looking good to those who have looked, and it passed Maven and SBT tests. I think this will help reduce complexity a bit (and test time in some cases), so will go for it tomorrow. --- -

[GitHub] spark pull request #22730: [SPARK-16775][CORE] Remove deprecated accumulator...

2018-10-15 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/22730 [SPARK-16775][CORE] Remove deprecated accumulator v1 APIs ## What changes were proposed in this pull request? Remove deprecated accumulator v1 ## How was this patch tested?

[GitHub] spark issue #22729: [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkar...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22729 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97402/ Test FAILed. ---

[GitHub] spark issue #22729: [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkar...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22729 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22729: [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkar...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22729 **[Test build #97402 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97402/testReport)** for PR 22729 at commit [`4a31de3`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22379 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22379 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97383/ Test PASSed. ---

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22379 **[Test build #97383 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97383/testReport)** for PR 22379 at commit [`b26e49e`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #22726: [SPARK-25727][FOLLOWUP] Move outputOrdering to case clas...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22726 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22726: [SPARK-25727][FOLLOWUP] Move outputOrdering to case clas...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22726 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97392/ Test PASSed. ---

[GitHub] spark issue #22726: [SPARK-25727][FOLLOWUP] Move outputOrdering to case clas...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22726 **[Test build #97392 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97392/testReport)** for PR 22726 at commit [`b74f4d5`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #22729: [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkar...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22729 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22729: [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkar...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22729 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3994/

[GitHub] spark issue #22729: [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkar...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22729 **[Test build #97402 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97402/testReport)** for PR 22729 at commit [`4a31de3`](https://github.com/apache/spark/commit/4a

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22379 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22379 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97385/ Test PASSed. ---

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22379 **[Test build #97385 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97385/testReport)** for PR 22379 at commit [`93d094f`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #22725: [SPARK-24610][[CORE][FOLLOW-UP]fix reading small files v...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22725 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97378/ Test PASSed. ---

[GitHub] spark issue #22725: [SPARK-24610][[CORE][FOLLOW-UP]fix reading small files v...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22725 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22725: [SPARK-24610][[CORE][FOLLOW-UP]fix reading small files v...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22725 **[Test build #97378 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97378/testReport)** for PR 22725 at commit [`54ffcdb`](https://github.com/apache/spark/commit/5

[GitHub] spark pull request #22729: [SPARK-25737][CORE] Remove JavaSparkContextVararg...

2018-10-15 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/22729 [SPARK-25737][CORE] Remove JavaSparkContextVarargsWorkaround ## What changes were proposed in this pull request? Remove JavaSparkContextVarargsWorkaround ## How was this patch teste

[GitHub] spark issue #22728: [SPARK-25736][SQL][TEST] add tests to verify the behavio...

2018-10-15 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22728 Yea, it is definitely good to add document and test for current behavior. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.

[GitHub] spark issue #22728: [SPARK-25736][SQL][TEST] add tests to verify the behavio...

2018-10-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22728 BTW MySQL doesn't support `count(a, b)` but supports `count(distinct a, b)`, the result is same as Spark. --- - To unsubscribe

[GitHub] spark issue #22728: [SPARK-25736][SQL][TEST] add tests to verify the behavio...

2018-10-15 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22728 this is indeed the behavior I'd expect. Good to add tests to enforce the behavior. Did you check other RDBMs apart from Postgres? --- -

[GitHub] spark pull request #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-10-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22379#discussion_r225218562 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -777,7 +777,6 @@ case class SchemaOfJson(

[GitHub] spark pull request #22724: [SPARK-25734][SQL] Literal should have a value co...

2018-10-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22724#discussion_r225218350 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -196,6 +197,31 @@ object Literal { case ot

[GitHub] spark issue #22728: [SPARK-25736][SQL][TEST] add tests to verify the behavio...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22728 **[Test build #97401 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97401/testReport)** for PR 22728 at commit [`708d7fd`](https://github.com/apache/spark/commit/70

[GitHub] spark issue #22728: [SPARK-25736][SQL][TEST] add tests to verify the behavio...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22728 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22728: [SPARK-25736][SQL][TEST] add tests to verify the behavio...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22728 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3993/

[GitHub] spark issue #22728: [SPARK-25736][SQL][TEST] add tests to verify the behavio...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22728 **[Test build #97400 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97400/testReport)** for PR 22728 at commit [`62b4b84`](https://github.com/apache/spark/commit/62

[GitHub] spark issue #22728: [SPARK-25736][SQL][TEST] add tests to verify the behavio...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22728 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3992/

[GitHub] spark issue #22728: [SPARK-25736][SQL][TEST] add tests to verify the behavio...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22728 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22728: [SPARK-25736][SQL][TEST] add tests to verify the behavio...

2018-10-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22728 cc @gatorsmile @mgaido91 @viirya --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #22728: [SPARK-25736][SQL][TEST] add tests to verify the ...

2018-10-15 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/22728 [SPARK-25736][SQL][TEST] add tests to verify the behavior of multi-column count ## What changes were proposed in this pull request? AFAIK multi-column count is not widely supported by th

[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22721 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97387/ Test PASSed. ---

[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22721 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22713: [SPARK-25691][SQL] Use semantic equality in AliasViewChi...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22713 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97380/ Test PASSed. ---

[GitHub] spark issue #22713: [SPARK-25691][SQL] Use semantic equality in AliasViewChi...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22713 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22721: [SPARK-25403][SQL] Refreshes the table after inserting t...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22721 **[Test build #97387 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97387/testReport)** for PR 22721 at commit [`37fed41`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #22713: [SPARK-25691][SQL] Use semantic equality in AliasViewChi...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22713 **[Test build #97380 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97380/testReport)** for PR 22713 at commit [`c4aaa8d`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22198 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22198 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97386/ Test PASSed. ---

[GitHub] spark issue #22219: [SPARK-25224][SQL] Improvement of Spark SQL ThriftServer...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22219 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22219: [SPARK-25224][SQL] Improvement of Spark SQL ThriftServer...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22219 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97388/ Test PASSed. ---

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22198 **[Test build #97386 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97386/testReport)** for PR 22198 at commit [`9a6da27`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #22219: [SPARK-25224][SQL] Improvement of Spark SQL ThriftServer...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22219 **[Test build #97388 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97388/testReport)** for PR 22219 at commit [`2a41b70`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #22705: [SPARK-25704][CORE][WIP] Allocate a bit less than Int.Ma...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22705 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22705: [SPARK-25704][CORE][WIP] Allocate a bit less than Int.Ma...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22705 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3991/

[GitHub] spark issue #22705: [SPARK-25704][CORE][WIP] Allocate a bit less than Int.Ma...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22705 **[Test build #97399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97399/testReport)** for PR 22705 at commit [`c811476`](https://github.com/apache/spark/commit/c8

[GitHub] spark pull request #22705: [SPARK-25704][CORE][WIP] Allocate a bit less than...

2018-10-15 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22705#discussion_r225208317 --- Diff: core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala --- @@ -195,7 +196,11 @@ object ChunkedByteBuffer { val is = new File

[GitHub] spark issue #22706: [SPARK-25716][SQL][MINOR] remove unnecessary collection ...

2018-10-15 Thread maryannxue
Github user maryannxue commented on the issue: https://github.com/apache/spark/pull/22706 @srowen I don't think this would make a big difference performance-wise, but if it's the right change, it just looks cleaner now. Anyone have any idea why it wasn't like this before? --- -

[GitHub] spark issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support par...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20999 **[Test build #97398 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97398/testReport)** for PR 20999 at commit [`146aa32`](https://github.com/apache/spark/commit/14

[GitHub] spark issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support par...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20999 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support par...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20999 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3990/

[GitHub] spark pull request #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new...

2018-10-15 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22288#discussion_r225198423 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala --- @@ -503,6 +505,89 @@ class TaskSchedulerImplSuite extends SparkF

[GitHub] spark issue #22713: [SPARK-25691][SQL] Use semantic equality in AliasViewChi...

2018-10-15 Thread maryannxue
Github user maryannxue commented on the issue: https://github.com/apache/spark/pull/22713 We do need a test case here anyway. Ideally it would be just as simple as #22701 but the difficulty is in declaring a view. --- -

[GitHub] spark pull request #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new...

2018-10-15 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22288#discussion_r225193634 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -415,9 +419,61 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark issue #22724: [SPARK-25734][SQL] Literal should have a value correspon...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22724 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97384/ Test FAILed. ---

[GitHub] spark pull request #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new...

2018-10-15 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22288#discussion_r225185389 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -597,6 +597,16 @@ package object config { .checkValue(v =>

[GitHub] spark issue #22724: [SPARK-25734][SQL] Literal should have a value correspon...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22724 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22724: [SPARK-25734][SQL] Literal should have a value correspon...

2018-10-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22724 **[Test build #97384 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97384/testReport)** for PR 22724 at commit [`9115d26`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support par...

2018-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20999 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

<    1   2   3   4   5   6   >