[GitHub] spark issue #22768: [SPARK-21402][SQL][BACKPORT-2.2] Fix java array of struc...

2018-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22768 Could you close this PR? Auto-close is only working for `master` branch PR. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22770: [SPARK-25771][PYSPARK]Fix improper synchronization in Py...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22770 **[Test build #97559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97559/testReport)** for PR 22770 at commit

[GitHub] spark issue #22770: [SPARK-25771][PYSPARK]Fix improper synchronization in Py...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22770 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22770: [SPARK-25771][PYSPARK]Fix improper synchronization in Py...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22770 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22770: [SPARK-25771][PYSPARK]Fix improper synchronizatio...

2018-10-18 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/22770#discussion_r226459546 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala --- @@ -278,7 +289,7 @@ private[spark] class

[GitHub] spark pull request #22770: [SPARK-25771][PYSPARK]Fix improper synchronizatio...

2018-10-18 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/22770#discussion_r226459609 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala --- @@ -163,7 +172,9 @@ private[spark] class

[GitHub] spark pull request #22770: [SPARK-25771][PYSPARK]Fix improper synchronizatio...

2018-10-18 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/22770 [SPARK-25771][PYSPARK]Fix improper synchronization in PythonWorkerFactory ## What changes were proposed in this pull request? Fix the following issues in PythonWorkerFactory -

[GitHub] spark issue #22766: [SPARK-25768][SQL] fix constant argument expecting UDAFs

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22766 **[Test build #97558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97558/testReport)** for PR 22766 at commit

[GitHub] spark issue #22768: [SPARK-21402][SQL][BACKPORT-2.2] Fix java array of struc...

2018-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22768 Thank you, @vofque . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22768: [SPARK-21402][SQL][BACKPORT-2.2] Fix java array of struc...

2018-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22768 Merged to `branch-2.2`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22766: [SPARK-25768][SQL] fix constant argument expecting UDAFs

2018-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22766 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22769: [SPARK-24499][DOC][FOLLOW-UP] Split the page of sql-prog...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22769 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22769: [SPARK-24499][DOC][FOLLOW-UP] Split the page of sql-prog...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22769 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97555/ Test PASSed. ---

[GitHub] spark issue #22769: [SPARK-24499][DOC][FOLLOW-UP] Split the page of sql-prog...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22769 **[Test build #97555 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97555/testReport)** for PR 22769 at commit

[GitHub] spark pull request #22768: [SPARK-21402][SQL][BACKPORT-2.2] Fix java array o...

2018-10-18 Thread vofque
Github user vofque commented on a diff in the pull request: https://github.com/apache/spark/pull/22768#discussion_r226456443 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanWithArraySuite.java --- @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22768: [SPARK-21402][SQL][BACKPORT-2.2] Fix java array o...

2018-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22768#discussion_r226455012 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanWithArraySuite.java --- @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #22504: [SPARK-25118][Submit] Persist Driver Logs in Clie...

2018-10-18 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22504#discussion_r226454499 --- Diff: core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala --- @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new execut...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22288 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new execut...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22288 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22504: [SPARK-25118][Submit] Persist Driver Logs in Clie...

2018-10-18 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22504#discussion_r226453812 --- Diff: docs/configuration.md --- @@ -266,6 +266,37 @@ of the most common options to set are: Only has effect in Spark standalone mode or Mesos

[GitHub] spark issue #22504: [SPARK-25118][Submit] Persist Driver Logs in Client mode...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22504 **[Test build #97557 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97557/testReport)** for PR 22504 at commit

[GitHub] spark issue #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new execut...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22288 **[Test build #97556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97556/testReport)** for PR 22288 at commit

[GitHub] spark issue #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new execut...

2018-10-18 Thread dhruve
Github user dhruve commented on the issue: https://github.com/apache/spark/pull/22288 Failure is unrelated. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new execut...

2018-10-18 Thread dhruve
Github user dhruve commented on the issue: https://github.com/apache/spark/pull/22288 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22769: [SPARK-24499][DOC][FOLLOW-UP] Split the page of sql-prog...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22769 **[Test build #97555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97555/testReport)** for PR 22769 at commit

[GitHub] spark issue #22769: [SPARK-24499][DOC][FOLLOW-UP] Split the page of sql-prog...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22769 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22769: [SPARK-24499][DOC][FOLLOW-UP] Split the page of sql-prog...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22769 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22769: [SPARK-24499][DOC][FOLLOW-UP] Split the page of s...

2018-10-18 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/22769 [SPARK-24499][DOC][FOLLOW-UP] Split the page of sql-programming-guide.html to multiple separate pages ## What changes were proposed in this pull request? Forgot to clean remove the link

[GitHub] spark issue #22769: [SPARK-24499][DOC][FOLLOW-UP] Split the page of sql-prog...

2018-10-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22769 cc @dongjoon-hyun @xuanyuanking --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22383 Yeah, I think we just can't do this unfortunately. It was worth looking into. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22752: [SPARK-24787][CORE] Revert hsync in EventLoggingListener...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22752 **[Test build #97554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97554/testReport)** for PR 22752 at commit

[GitHub] spark issue #22768: [SPARK-21402][SQL][BACKPORT-2.2] Fix java array of struc...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22768 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97545/ Test PASSed. ---

[GitHub] spark issue #22768: [SPARK-21402][SQL][BACKPORT-2.2] Fix java array of struc...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22768 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22768: [SPARK-21402][SQL][BACKPORT-2.2] Fix java array of struc...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22768 **[Test build #97545 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97545/testReport)** for PR 22768 at commit

[GitHub] spark issue #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new execut...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22288 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new execut...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22288 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97542/ Test FAILed. ---

[GitHub] spark issue #22288: [SPARK-22148][SPARK-15815][Scheduler] Acquire new execut...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22288 **[Test build #97542 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97542/testReport)** for PR 22288 at commit

[GitHub] spark issue #22766: [SPARK-25768][SQL] fix constant argument expecting UDAFs

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22766 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22766: [SPARK-25768][SQL] fix constant argument expecting UDAFs

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22766 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97549/ Test FAILed. ---

[GitHub] spark issue #22766: [SPARK-25768][SQL] fix constant argument expecting UDAFs

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22766 **[Test build #97549 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97549/testReport)** for PR 22766 at commit

[GitHub] spark issue #22547: [SPARK-25528][SQL] data source V2 read side API refactor...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22547 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22547: [SPARK-25528][SQL] data source V2 read side API refactor...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22547 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97540/ Test PASSed. ---

[GitHub] spark pull request #22501: [SPARK-25492][TEST] Refactor WideSchemaBenchmark ...

2018-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22501#discussion_r226442573 --- Diff: sql/core/benchmarks/WideSchemaBenchmark-results.txt --- @@ -1,117 +1,145 @@ -Java HotSpot(TM) 64-Bit Server VM 1.8.0_92-b14 on Mac OS X

[GitHub] spark issue #22547: [SPARK-25528][SQL] data source V2 read side API refactor...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22547 **[Test build #97540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97540/testReport)** for PR 22547 at commit

[GitHub] spark pull request #22501: [SPARK-25492][TEST] Refactor WideSchemaBenchmark ...

2018-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22501#discussion_r226440992 --- Diff: sql/core/benchmarks/WideSchemaBenchmark-results.txt --- @@ -1,117 +1,145 @@ -Java HotSpot(TM) 64-Bit Server VM 1.8.0_92-b14 on Mac OS X

[GitHub] spark pull request #22501: [SPARK-25492][TEST] Refactor WideSchemaBenchmark ...

2018-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22501#discussion_r226439834 --- Diff: sql/core/benchmarks/WideSchemaBenchmark-results.txt --- @@ -1,117 +1,145 @@ -Java HotSpot(TM) 64-Bit Server VM 1.8.0_92-b14 on Mac OS X

[GitHub] spark pull request #22677: [SPARK-25683][Core] Updated the log for the first...

2018-10-18 Thread shivusondur
Github user shivusondur commented on a diff in the pull request: https://github.com/apache/spark/pull/22677#discussion_r226439337 --- Diff: core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala --- @@ -169,7 +169,8 @@ private class AsyncEventQueue(

[GitHub] spark issue #22677: [SPARK-25683][Core] Updated the log for the firstTime ev...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22677 **[Test build #97553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97553/testReport)** for PR 22677 at commit

[GitHub] spark issue #22746: [SPARK-24499][SQL][DOC] Split the page of sql-programmin...

2018-10-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22746 Thanks! Merged to master/2.4. For 2.4 branch, I manually removed the migration guide from 2.4 to 3.0. --- - To unsubscribe,

[GitHub] spark pull request #22752: [SPARK-24787][CORE] Revert hsync in EventLoggingL...

2018-10-18 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/22752#discussion_r226429600 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/config.scala --- @@ -64,4 +64,11 @@ private[spark] object config {

[GitHub] spark pull request #22746: [SPARK-24499][SQL][DOC] Split the page of sql-pro...

2018-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22746 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22746: [SPARK-24499][SQL][DOC] Split the page of sql-programmin...

2018-10-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22746 We might miss something in the code review. Let us play the new doc and see whether we miss anything in the code review. ---

[GitHub] spark issue #22746: [SPARK-24499][SQL][DOC] Split the page of sql-programmin...

2018-10-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22746 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22750: [SPARK-25747][SQL] remove ColumnarBatchScan.needsUnsafeR...

2018-10-18 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/22750 Do we need to update the description? For example, `needsUnsafeRowConversion` exists in `DataSourceScanExec` now. --- - To

[GitHub] spark pull request #22732: [SPARK-25044][FOLLOW-UP] Change ScalaUDF construc...

2018-10-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22732#discussion_r226424308 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala --- @@ -39,29 +42,29 @@ import

[GitHub] spark pull request #22504: [SPARK-25118][Submit] Persist Driver Logs in Clie...

2018-10-18 Thread ankuriitg
Github user ankuriitg commented on a diff in the pull request: https://github.com/apache/spark/pull/22504#discussion_r226421974 --- Diff: core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala --- @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22504: [SPARK-25118][Submit] Persist Driver Logs in Clie...

2018-10-18 Thread ankuriitg
Github user ankuriitg commented on a diff in the pull request: https://github.com/apache/spark/pull/22504#discussion_r226421401 --- Diff: docs/configuration.md --- @@ -266,6 +266,37 @@ of the most common options to set are: Only has effect in Spark standalone mode or Mesos

[GitHub] spark pull request #22752: [SPARK-24787][CORE] Revert hsync in EventLoggingL...

2018-10-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22752#discussion_r22642 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/config.scala --- @@ -64,4 +64,11 @@ private[spark] object config {

[GitHub] spark issue #21777: [WIP][SPARK-24498][SQL] Add JDK compiler for runtime cod...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21777 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21777: [WIP][SPARK-24498][SQL] Add JDK compiler for runtime cod...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21777 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22504: [SPARK-25118][Submit] Persist Driver Logs in Clie...

2018-10-18 Thread ankuriitg
Github user ankuriitg commented on a diff in the pull request: https://github.com/apache/spark/pull/22504#discussion_r226418231 --- Diff: core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala --- @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #21777: [WIP][SPARK-24498][SQL] Add JDK compiler for runtime cod...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21777 **[Test build #97552 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97552/testReport)** for PR 21777 at commit

[GitHub] spark pull request #22752: [SPARK-24787][CORE] Revert hsync in EventLoggingL...

2018-10-18 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/22752#discussion_r226416951 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/config.scala --- @@ -64,4 +64,11 @@ private[spark] object config {

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22455 **[Test build #97551 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97551/testReport)** for PR 22455 at commit

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22455 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22455 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-18 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22383 Spark's class only reason to exist is so we do *not* use the Guava class, since everyone and their pet want to use a different version of Guava (and Spark shades it for that reason). ---

[GitHub] spark pull request #22752: [SPARK-24787][CORE] Revert hsync in EventLoggingL...

2018-10-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22752#discussion_r226409012 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/config.scala --- @@ -64,4 +64,11 @@ private[spark] object config {

[GitHub] spark issue #22466: [SPARK-25464][SQL] Create Database to the location,only ...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22466 **[Test build #97550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97550/testReport)** for PR 22466 at commit

[GitHub] spark pull request #22752: [SPARK-24787][CORE] Revert hsync in EventLoggingL...

2018-10-18 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22752#discussion_r226407844 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -541,6 +542,23 @@ private[history] class

[GitHub] spark issue #22766: [SPARK-25768][SQL] fix constant argument expecting UDAFs

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22766 **[Test build #97549 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97549/testReport)** for PR 22766 at commit

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-18 Thread mmolimar
Github user mmolimar commented on the issue: https://github.com/apache/spark/pull/22383 I agree @srowen. What do you think about reusing the current implementation we already have, for example, in the guava lib instead of having that class in Spark? ---

[GitHub] spark issue #22466: [SPARK-25464][SQL] Create Database to the location,only ...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22466 **[Test build #97548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97548/testReport)** for PR 22466 at commit

[GitHub] spark issue #22675: [SPARK-25347][ML][DOC] Spark datasource for image/libsvm...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22675 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22675: [SPARK-25347][ML][DOC] Spark datasource for image/libsvm...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22675 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97541/ Test PASSed. ---

[GitHub] spark issue #22675: [SPARK-25347][ML][DOC] Spark datasource for image/libsvm...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22675 **[Test build #97541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97541/testReport)** for PR 22675 at commit

[GitHub] spark pull request #22504: [SPARK-25118][Submit] Persist Driver Logs in Clie...

2018-10-18 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22504#discussion_r226395358 --- Diff: core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala --- @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22504: [SPARK-25118][Submit] Persist Driver Logs in Clie...

2018-10-18 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22504#discussion_r226400385 --- Diff: docs/configuration.md --- @@ -266,6 +266,37 @@ of the most common options to set are: Only has effect in Spark standalone mode or Mesos

[GitHub] spark pull request #22504: [SPARK-25118][Submit] Persist Driver Logs in Clie...

2018-10-18 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22504#discussion_r226394446 --- Diff: core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala --- @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22504: [SPARK-25118][Submit] Persist Driver Logs in Clie...

2018-10-18 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22504#discussion_r226391941 --- Diff: core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala --- @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22504: [SPARK-25118][Submit] Persist Driver Logs in Clie...

2018-10-18 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22504#discussion_r226396957 --- Diff: core/src/test/scala/org/apache/spark/util/logging/DriverLoggerSuite.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22504: [SPARK-25118][Submit] Persist Driver Logs in Clie...

2018-10-18 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22504#discussion_r226397391 --- Diff: core/src/test/scala/org/apache/spark/util/logging/DriverLoggerSuite.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #22504: [SPARK-25118][Submit] Persist Driver Logs in Clie...

2018-10-18 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22504#discussion_r226395070 --- Diff: core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #22766: [SPARK-25768][SQL] fix constant argument expecting UDAFs

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22766 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97547/ Test FAILed. ---

[GitHub] spark issue #22766: [SPARK-25768][SQL] fix constant argument expecting UDAFs

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22766 **[Test build #97547 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97547/testReport)** for PR 22766 at commit

[GitHub] spark issue #22766: [SPARK-25768][SQL] fix constant argument expecting UDAFs

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22766 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22766: [SPARK-25768][SQL] fix constant argument expecting UDAFs

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22766 **[Test build #97547 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97547/testReport)** for PR 22766 at commit

[GitHub] spark issue #22767: [SPARK-21402][SQL][BACKPORT-2.3] Fix java array of struc...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22767 **[Test build #97546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97546/testReport)** for PR 22767 at commit

[GitHub] spark issue #22768: [SPARK-21402][SQL][BACKPORT-2.2] Fix java array of struc...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22768 **[Test build #97545 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97545/testReport)** for PR 22768 at commit

[GitHub] spark pull request #22756: [SPARK-25758][ML] Deprecate computeCost on Bisect...

2018-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22756 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22547: [SPARK-25528][SQL] data source V2 read side API refactor...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22547 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97538/ Test PASSed. ---

[GitHub] spark issue #22547: [SPARK-25528][SQL] data source V2 read side API refactor...

2018-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22547 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22766: [SPARK-25768][SQL] fix constant argument expecting UDAFs

2018-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22766 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22756: [SPARK-25758][ML] Deprecate computeCost on BisectingKMea...

2018-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22756 Thank you, @mgaido91 and all! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22547: [SPARK-25528][SQL] data source V2 read side API refactor...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22547 **[Test build #97538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97538/testReport)** for PR 22547 at commit

[GitHub] spark issue #22767: [SPARK-21402][SQL][BACKPORT-2.3] Fix java array of struc...

2018-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22767 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22466: [SPARK-25464][SQL] Create Database to the location,only ...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22466 **[Test build #97544 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97544/testReport)** for PR 22466 at commit

[GitHub] spark issue #22756: [SPARK-25758][ML] Deprecate computeCost on BisectingKMea...

2018-10-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22756 Merged to master/branch-2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22466: [SPARK-25464][SQL] Create Database to the location,only ...

2018-10-18 Thread sandeep-katta
Github user sandeep-katta commented on the issue: https://github.com/apache/spark/pull/22466 > Btw, what if `create database if not exists ...`? Seems like an exception will be thrown if the table exists even if we specify `if not exists`? Good catch :+1: ,I have updated

[GitHub] spark issue #22765: [SPARK-25757][Build] Upgrade netty-all from 4.1.17.Final...

2018-10-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22765 **[Test build #97543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97543/testReport)** for PR 22765 at commit

<    1   2   3   4   5   6   7   8   >