Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22760
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22760
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22760
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4641/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22275
**[Test build #98284 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98284/testReport)**
for PR 22275 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22760
**[Test build #98283 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98283/testReport)**
for PR 22760 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22805
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98277/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22805
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22760
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4641/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22805
**[Test build #98277 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98277/testReport)**
for PR 22805 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22760
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98282/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22760
**[Test build #98282 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98282/testReport)**
for PR 22760 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22760
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22760
**[Test build #98282 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98282/testReport)**
for PR 22760 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22880
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22880
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98278/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22880
**[Test build #98278 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98278/testReport)**
for PR 22880 at commit
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22805#discussion_r229512765
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -63,6 +66,8 @@
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22608
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22608
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4640/
---
Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/22805
@mccheah since he had some comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user boy-uber commented on the issue:
https://github.com/apache/spark/pull/22429
> > @boy-uber the thing you are suggesting is a pretty big undertaking and
beyond the scope of this PR.
> > If you are going to add structured plans to the explain output, you
probably also
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22608
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4640/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22608
**[Test build #98281 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98281/testReport)**
for PR 22608 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22818
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98274/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22818
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22818
**[Test build #98274 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98274/testReport)**
for PR 22818 at commit
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/22805
@mccheah and @liyinan926 for merge
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22146
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/22146
Ok I'm going to merge this into master. Thanks everyone for the feedback.
Follow up discussions around validation can be addressed in follow up patches.
---
Github user peter-toth commented on a diff in the pull request:
https://github.com/apache/spark/pull/22617#discussion_r229480460
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArrayBenchmark.scala
---
@@ -68,9 +100,7 @@ object
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/22788#discussion_r229479893
--- Diff:
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out
---
@@ -161,7 +161,7 @@ SELECT db1.t1.i1 FROM t1, mydb2.t1
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22847#discussion_r229478558
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -812,6 +812,17 @@ object SQLConf {
.intConf
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22881
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22881
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22805
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22881
**[Test build #98280 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98280/testReport)**
for PR 22881 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22805
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4638/
---
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22881
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22805
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4638/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22805
**[Test build #98279 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98279/testReport)**
for PR 22805 at commit
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/22805
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22895
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98272/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22895
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22895
**[Test build #98272 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98272/testReport)**
for PR 22895 at commit
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/22896
appveyor timeout #fml
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22880
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22805
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22880
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22880
**[Test build #98278 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98278/testReport)**
for PR 22880 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22805
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4636/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22805
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/22880#discussion_r229451788
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala
---
@@ -202,11 +204,15 @@ private[parquet]
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22805
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4636/
---
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/22880#discussion_r229451108
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala
---
@@ -182,18 +182,20 @@ private[parquet]
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/22880#discussion_r229450720
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
---
@@ -93,13 +141,14 @@ private[parquet]
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/22880#discussion_r229449812
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
---
@@ -49,34 +49,82 @@ import
Github user aokolnychyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22857#discussion_r229449496
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -736,3 +736,60 @@ object CombineConcats extends
Github user aokolnychyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22857#discussion_r229449194
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -2578,4 +2578,45 @@ class DataFrameSuite extends QueryTest with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22897
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22897
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22897
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4635/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22805
**[Test build #98277 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98277/testReport)**
for PR 22805 at commit
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/22805
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user aokolnychyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22857#discussion_r229445682
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -736,3 +736,60 @@ object CombineConcats extends
Github user aokolnychyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22857#discussion_r229445313
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -736,3 +736,60 @@ object CombineConcats extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22897
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22897
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98276/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22897
**[Test build #98276 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98276/testReport)**
for PR 22897 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22897
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4635/
---
Github user aokolnychyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22857#discussion_r229442843
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -736,3 +736,60 @@ object CombineConcats extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22788
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98270/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22788
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22788
**[Test build #98270 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98270/testReport)**
for PR 22788 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22897
**[Test build #98276 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98276/testReport)**
for PR 22897 at commit
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/22896
nteresting... still get the `StartTag` error in the build log:
```
Error: StartTag: invalid element name [68]
Execution halted
```
it's orthogonal to this PR, but
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22897
Please take a look at the parent bug before commenting on this patch in
isolation:
https://issues.apache.org/jira/browse/SPARK-25874
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22896
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22896
**[Test build #98275 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98275/testReport)**
for PR 22896 at commit
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/22897
[SPARK-25875][k8s] Merge code to set up driver command into a single step.
Right now there are 3 different classes dealing with building the driver
command to run inside the pod, one for each
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22896
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98275/
Test PASSed.
---
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22880
I can confirm that this fixes
https://issues.apache.org/jira/browse/SPARK-25879
cc @cloud-fan @gatorsmile
Thanks.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22896
**[Test build #98275 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98275/testReport)**
for PR 22896 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22896
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22896
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/22896
i am confused, though, as to why this wasn't caught during the PR that
added this file:
https://github.com/apache/spark/pull/22455
on the centos workers, there was an error message
GitHub user shaneknapp opened a pull request:
https://github.com/apache/spark/pull/22896
found some extra whitespace in the R tests
## What changes were proposed in this pull request?
during my ubuntu-port testing, i found some extra whitespace that for some
reason wasn't
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22818
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22818
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22617#discussion_r229419433
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArrayBenchmark.scala
---
@@ -68,9 +100,7 @@ object
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22771
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22713
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98268/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22818
**[Test build #98274 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98274/testReport)**
for PR 22818 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22713
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22713
**[Test build #98268 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98268/testReport)**
for PR 22713 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22771
Thanks! Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/22771
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user xiao-chen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22881#discussion_r229403073
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
---
@@ -471,4 +473,42 @@ object SparkHadoopUtil {
Github user rvesse commented on the issue:
https://github.com/apache/spark/pull/22805
Did a bunch more testing on our internal K8S clusters today after rebasing
this onto master. I am now happy that this is ready for final review and
merging so I have removed the `[WIP]` tag
---
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22805#discussion_r229400780
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -42,6 +42,9 @@
101 - 200 of 486 matches
Mail list logo
