[GitHub] spark issue #23124: [SPARK-25829][SQL] remove duplicated map keys with last ...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23124 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23124: [SPARK-25829][SQL] remove duplicated map keys with last ...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23124 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #23025: [SPARK-26024][SQL]: Update documentation for repa...

2018-11-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23025#discussion_r236970732 --- Diff: R/pkg/R/DataFrame.R --- @@ -767,6 +767,14 @@ setMethod("repartition", #' using \code{spark.sql.shuffle.partitions}

[GitHub] spark issue #23124: [SPARK-25829][SQL] remove duplicated map keys with last ...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23124 **[Test build #99357 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99357/testReport)** for PR 23124 at commit

[GitHub] spark issue #22575: [SPARK-24630][SS] Support SQLStreaming in Spark

2018-11-27 Thread stczwd
Github user stczwd commented on the issue: https://github.com/apache/spark/pull/22575 I hive send an email to Ryan Blue. > > > Can you send a mail to Ryan blue for adding this SPIP topic in tomorrow meeting. Meeting will be conducted tomorrow 05:00 pm PST. If you confirm

[GitHub] spark pull request #21957: [SPARK-24994][SQL] When the data type of the fiel...

2018-11-27 Thread 10110346
Github user 10110346 commented on a diff in the pull request: https://github.com/apache/spark/pull/21957#discussion_r236965962 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala --- @@ -269,7 +269,8 @@ case class FileSourceScanExec( }

[GitHub] spark issue #23128: [SPARK-26142][SQL] Implement shuffle read metrics in SQL

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23128 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23128: [SPARK-26142][SQL] Implement shuffle read metrics in SQL

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23128 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22163: [SPARK-25166][CORE]Reduce the number of write operations...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22163 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22163: [SPARK-25166][CORE]Reduce the number of write operations...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22163 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99348/ Test PASSed. ---

[GitHub] spark issue #22163: [SPARK-25166][CORE]Reduce the number of write operations...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22163 **[Test build #99348 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99348/testReport)** for PR 22163 at commit

[GitHub] spark issue #23128: [SPARK-26142][SQL] Implement shuffle read metrics in SQL

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23128 **[Test build #99355 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99355/testReport)** for PR 23128 at commit

[GitHub] spark issue #23153: [SPARK-26147][SQL] only pull out unevaluable python udf ...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23153 **[Test build #99356 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99356/testReport)** for PR 23153 at commit

[GitHub] spark issue #23052: [SPARK-26081][SQL] Prevent empty files for empty partiti...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23052 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23052: [SPARK-26081][SQL] Prevent empty files for empty partiti...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23052 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23153: [SPARK-26147][SQL] only pull out unevaluable python udf ...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23153 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23153: [SPARK-26147][SQL] only pull out unevaluable python udf ...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23153 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23124: [SPARK-25829][SQL] remove duplicated map keys wit...

2018-11-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/23124#discussion_r236962499 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala --- @@ -0,0 +1,118 @@ +/* + * Licensed to

[GitHub] spark issue #23128: [SPARK-26142][SQL] Implement shuffle read metrics in SQL

2018-11-27 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/23128 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23052: [SPARK-26081][SQL] Prevent empty files for empty partiti...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23052 **[Test build #99354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99354/testReport)** for PR 23052 at commit

[GitHub] spark issue #23052: [SPARK-26081][SQL] Prevent empty files for empty partiti...

2018-11-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23052 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22590: [SPARK-25574][SQL]Add an option `keepQuotes` for parsing...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22590 **[Test build #99353 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99353/testReport)** for PR 22590 at commit

[GitHub] spark pull request #23124: [SPARK-25829][SQL] remove duplicated map keys wit...

2018-11-27 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/23124#discussion_r236955791 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala --- @@ -0,0 +1,118 @@ +/* + * Licensed to the

[GitHub] spark pull request #23124: [SPARK-25829][SQL] remove duplicated map keys wit...

2018-11-27 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/23124#discussion_r236958252 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilderSuite.scala --- @@ -0,0 +1,91 @@ +/* + * Licensed to

[GitHub] spark issue #22590: [SPARK-25574][SQL]Add an option `keepQuotes` for parsing...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22590 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22590: [SPARK-25574][SQL]Add an option `keepQuotes` for parsing...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22590 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22590: [SPARK-25574][SQL]Add an option `keepQuotes` for parsing...

2018-11-27 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/22590 @HyukjinKwon I think it is not important. but our customers need this feature. Yeah, it is better to find a way to set the arbitrary parse settings options ---

[GitHub] spark pull request #23086: [SPARK-25528][SQL] data source v2 API refactor (b...

2018-11-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/23086#discussion_r236957293 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/Table.java --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #23128: [SPARK-26142][SQL] Implement shuffle read metrics in SQL

2018-11-27 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/23128 python UT failed cause jvm crush. retest this pleas. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #23124: [SPARK-25829][SQL] remove duplicated map keys wit...

2018-11-27 Thread bersprockets
Github user bersprockets commented on a diff in the pull request: https://github.com/apache/spark/pull/23124#discussion_r236952729 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala --- @@ -0,0 +1,118 @@ +/* + * Licensed to

[GitHub] spark issue #23162: [MINOR][DOC] Correct some document description errors

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23162 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23162: [MINOR][DOC] Correct some document description errors

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23162 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23160: [SPARK-26196]Total tasks title in the stage page is inco...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23160 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99345/ Test PASSed. ---

[GitHub] spark issue #23162: [MINOR][DOC] Correct some document description errors

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23162 **[Test build #99352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99352/testReport)** for PR 23162 at commit

[GitHub] spark issue #23160: [SPARK-26196]Total tasks title in the stage page is inco...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23160 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23160: [SPARK-26196]Total tasks title in the stage page is inco...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23160 **[Test build #99345 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99345/testReport)** for PR 23160 at commit

[GitHub] spark issue #23160: [SPARK-26196]Total tasks title in the stage page is inco...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23160 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99346/ Test PASSed. ---

[GitHub] spark issue #23160: [SPARK-26196]Total tasks title in the stage page is inco...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23160 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23160: [SPARK-26196]Total tasks title in the stage page is inco...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23160 **[Test build #99346 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99346/testReport)** for PR 23160 at commit

[GitHub] spark pull request #23162: [MINOR][DOC] Correct some document description er...

2018-11-27 Thread 10110346
GitHub user 10110346 opened a pull request: https://github.com/apache/spark/pull/23162 [MINOR][DOC] Correct some document description errors ## What changes were proposed in this pull request? Correct some document description errors. ## How was this patch tested?

[GitHub] spark pull request #23124: [SPARK-25829][SQL] remove duplicated map keys wit...

2018-11-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/23124#discussion_r236949897 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -558,8 +558,11 @@ private[parquet]

[GitHub] spark issue #23128: [SPARK-26142][SQL] Implement shuffle read metrics in SQL

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23128 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99347/ Test FAILed. ---

[GitHub] spark issue #23128: [SPARK-26142][SQL] Implement shuffle read metrics in SQL

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23128 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23128: [SPARK-26142][SQL] Implement shuffle read metrics in SQL

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23128 **[Test build #99347 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99347/testReport)** for PR 23128 at commit

[GitHub] spark issue #22575: [SPARK-24630][SS] Support SQLStreaming in Spark

2018-11-27 Thread sujith71955
Github user sujith71955 commented on the issue: https://github.com/apache/spark/pull/22575 > > Can you send a mail to Ryan blue for adding this SPIP topic in tomorrow meeting. Meeting will be conducted tomorrow 05:00 pm PST. If you confirm then we can also attend the meeting. >

[GitHub] spark pull request #23127: [SPARK-26159] Codegen for LocalTableScanExec and ...

2018-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23127 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #23127: [SPARK-26159] Codegen for LocalTableScanExec and RDDScan...

2018-11-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23127 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22575: [SPARK-24630][SS] Support SQLStreaming in Spark

2018-11-27 Thread stczwd
Github user stczwd commented on the issue: https://github.com/apache/spark/pull/22575 > Can you send a mail to Ryan blue for adding this SPIP topic in tomorrow meeting. Meeting will be conducted tomorrow 05:00 pm PST. If you confirm then we can also attend the meeting. I

[GitHub] spark issue #23083: [SPARK-26114][CORE] ExternalSorter's readingIterator fie...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23083 **[Test build #99351 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99351/testReport)** for PR 23083 at commit

[GitHub] spark issue #23083: [SPARK-26114][CORE] ExternalSorter's readingIterator fie...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23083 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23083: [SPARK-26114][CORE] ExternalSorter's readingIterator fie...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23083 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23083: [SPARK-26114][CORE] ExternalSorter's readingIterator fie...

2018-11-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23083 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23161: [SPARK-26189][R]Fix unionAll doc in SparkR

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23161 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23161: [SPARK-26189][R]Fix unionAll doc in SparkR

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23161 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99350/ Test PASSed. ---

[GitHub] spark issue #23161: [SPARK-26189][R]Fix unionAll doc in SparkR

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23161 **[Test build #99350 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99350/testReport)** for PR 23161 at commit

[GitHub] spark issue #22575: [SPARK-24630][SS] Support SQLStreaming in Spark

2018-11-27 Thread sujith71955
Github user sujith71955 commented on the issue: https://github.com/apache/spark/pull/22575 Can you send a mail to Ryan blue for adding this SPIP topic in tomorrow meeting. Meeting will be conducted tomorrow 05:00 pm PST. If you confirm then we can also attend the meeting.

[GitHub] spark issue #22575: [SPARK-24630][SS] Support SQLStreaming in Spark

2018-11-27 Thread stczwd
Github user stczwd commented on the issue: https://github.com/apache/spark/pull/22575 > ![image](https://user-images.githubusercontent.com/12999161/49129177-ab056680-f2f4-11e8-8f71-4695ebc045c1.png) I have removed the 'stream' keyword. > There is a DatasourceV2 community

[GitHub] spark issue #22575: [SPARK-24630][SS] Support SQLStreaming in Spark

2018-11-27 Thread sujith71955
Github user sujith71955 commented on the issue: https://github.com/apache/spark/pull/22575 cc @koeninger --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22575: [SPARK-24630][SS] Support SQLStreaming in Spark

2018-11-27 Thread sujith71955
Github user sujith71955 commented on the issue: https://github.com/apache/spark/pull/22575 ![image](https://user-images.githubusercontent.com/12999161/49129177-ab056680-f2f4-11e8-8f71-4695ebc045c1.png) There is a DatasourceV2 community synch meetup tomorrow which is

[GitHub] spark issue #23161: [SPARK-26189][R]Fix unionAll doc in SparkR

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23161 **[Test build #99350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99350/testReport)** for PR 23161 at commit

[GitHub] spark issue #23161: [SPARK-26189][R]Fix unionAll doc in SparkR

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23161 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23161: [SPARK-26189][R]Fix unionAll doc in SparkR

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23161 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensi...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23144 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99349/ Test FAILed. ---

[GitHub] spark issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensi...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23144 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23161: [SPARK-26189][R]Fix unionAll doc in SparkR

2018-11-27 Thread huaxingao
GitHub user huaxingao opened a pull request: https://github.com/apache/spark/pull/23161 [SPARK-26189][R]Fix unionAll doc in SparkR ## What changes were proposed in this pull request? Fix unionAll doc in SparkR ## How was this patch tested? Manually ran

[GitHub] spark issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensi...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23144 **[Test build #99349 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99349/testReport)** for PR 23144 at commit

[GitHub] spark issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensi...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23144 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensi...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23144 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensi...

2018-11-27 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/23144 Using an optional `normalize` function argument maybe OK, I will have a try. --- - To unsubscribe, e-mail:

[GitHub] spark issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensi...

2018-11-27 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/23144 @srowen To adopt an optional `normalize` function argument, we may need to create a new class `StringParam` and add the argument into it. But this will be a breaking change, since existing

[GitHub] spark issue #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensi...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23144 **[Test build #99349 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99349/testReport)** for PR 23144 at commit

[GitHub] spark pull request #23104: [SPARK-26138][SQL] Cross join requires push Local...

2018-11-27 Thread guoxiaolongzte
Github user guoxiaolongzte commented on a diff in the pull request: https://github.com/apache/spark/pull/23104#discussion_r236929433 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -459,6 +459,7 @@ object LimitPushDown extends

[GitHub] spark issue #22163: [SPARK-25166][CORE]Reduce the number of write operations...

2018-11-27 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/22163 cc @kiszk @maropu --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22163: [SPARK-25166][CORE]Reduce the number of write operations...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22163 **[Test build #99348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99348/testReport)** for PR 22163 at commit

[GitHub] spark issue #22163: [SPARK-25166][CORE]Reduce the number of write operations...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22163 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23128: [SPARK-26142][SQL] Implement shuffle read metrics in SQL

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23128 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23128: [SPARK-26142][SQL] Implement shuffle read metrics in SQL

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23128 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22163: [SPARK-25166][CORE]Reduce the number of write operations...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22163 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #23126: [SPARK-26158] [MLLIB] fix covariance accuracy pro...

2018-11-27 Thread KyleLi1985
Github user KyleLi1985 commented on a diff in the pull request: https://github.com/apache/spark/pull/23126#discussion_r236927771 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/linalg/distributed/RowMatrixSuite.scala --- @@ -266,6 +266,16 @@ class RowMatrixSuite extends

[GitHub] spark pull request #23126: [SPARK-26158] [MLLIB] fix covariance accuracy pro...

2018-11-27 Thread KyleLi1985
Github user KyleLi1985 commented on a diff in the pull request: https://github.com/apache/spark/pull/23126#discussion_r236927721 --- Diff: mllib/src/test/java/org/apache/spark/ml/feature/JavaPCASuite.java --- @@ -67,7 +66,7 @@ public void testPCA() { JavaRDD dataRDD =

[GitHub] spark issue #23128: [SPARK-26142][SQL] Implement shuffle read metrics in SQL

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23128 **[Test build #99347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99347/testReport)** for PR 23128 at commit

[GitHub] spark pull request #23128: [SPARK-26142][SQL] Implement shuffle read metrics...

2018-11-27 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/23128#discussion_r236926403 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ShuffledRowRDD.scala --- @@ -154,7 +156,10 @@ class ShuffledRowRDD(

[GitHub] spark pull request #23055: [SPARK-26080][PYTHON] Disable 'spark.executor.pys...

2018-11-27 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23055#discussion_r236926113 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala --- @@ -74,8 +74,13 @@ private[spark] abstract class BasePythonRunner[IN,

[GitHub] spark issue #23154: [SPARK-26195][SQL] Correct exception messages in some cl...

2018-11-27 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/23154 LGTM,thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23159: [SPARK-26191][SQL] Control truncation of Spark plans via...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23159 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99342/ Test PASSed. ---

[GitHub] spark issue #23159: [SPARK-26191][SQL] Control truncation of Spark plans via...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23159 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23159: [SPARK-26191][SQL] Control truncation of Spark plans via...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23159 **[Test build #99342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99342/testReport)** for PR 23159 at commit

[GitHub] spark pull request #23154: [SPARK-26195][SQL] Correct exception messages in ...

2018-11-27 Thread lcqzte10192193
Github user lcqzte10192193 commented on a diff in the pull request: https://github.com/apache/spark/pull/23154#discussion_r236923346 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java --- @@ -510,42 +510,42 @@ public

[GitHub] spark pull request #23154: [SPARK-26195][SQL] Correct exception messages in ...

2018-11-27 Thread lcqzte10192193
Github user lcqzte10192193 commented on a diff in the pull request: https://github.com/apache/spark/pull/23154#discussion_r236923308 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -204,10 +204,10 @@ case class

[GitHub] spark pull request #23151: [SPARK-26180][CORE][TEST] Add a withCreateTempDir...

2018-11-27 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/23151#discussion_r236922709 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -105,5 +105,16 @@ abstract class SparkFunSuite logInfo(s"\n\n=

[GitHub] spark issue #22575: [SPARK-24630][SS] Support SQLStreaming in Spark

2018-11-27 Thread stczwd
Github user stczwd commented on the issue: https://github.com/apache/spark/pull/22575 @sujithjay Please refer [SPARK-24630](https://issues.apache.org/jira/browse/SPARK-24630) for more details. --- - To

[GitHub] spark pull request #23154: [SPARK-26195][SQL] Correct exception messages in ...

2018-11-27 Thread 10110346
Github user 10110346 commented on a diff in the pull request: https://github.com/apache/spark/pull/23154#discussion_r236920634 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java --- @@ -510,42 +510,42 @@ public void

[GitHub] spark pull request #23154: [SPARK-26195][SQL] Correct exception messages in ...

2018-11-27 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/23154#discussion_r236919935 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -258,7 +258,7 @@ case class GeneratorOuter(child:

[GitHub] spark pull request #23151: [SPARK-26180][CORE][TEST] Add a withCreateTempDir...

2018-11-27 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/23151#discussion_r236919725 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -105,5 +105,16 @@ abstract class SparkFunSuite logInfo(s"\n\n=

[GitHub] spark pull request #23154: [SPARK-26195][SQL] Correct exception messages in ...

2018-11-27 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/23154#discussion_r236919395 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -204,10 +204,10 @@ case class UnresolvedGenerator(name:

[GitHub] spark issue #23154: [SPARK-26195][SQL] Correct exception messages in some cl...

2018-11-27 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/23154 @lcqzte10192193 I am sorry for my misunderstanding The original code in `VectorizedRleValuesReader.java` was correct. Could you please revert you change? ---

[GitHub] spark issue #23160: [SPARK-26196]Total tasks title in the stage page is inco...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23160 **[Test build #99346 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99346/testReport)** for PR 23160 at commit

[GitHub] spark issue #23160: [SPARK-26196]Total tasks title in the stage page is inco...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23160 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23160: [SPARK-26196]Total tasks title in the stage page is inco...

2018-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23160 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23160: [SPARK-26196]Total tasks title in the stage page is inco...

2018-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23160 **[Test build #99345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99345/testReport)** for PR 23160 at commit

  1   2   3   4   5   >