[GitHub] [spark] AmplabJenkins removed a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514064747 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514064740 Merged build finished. Test PASSed. This

[GitHub] [spark] SparkQA removed a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
SparkQA removed a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514052849 **[Test build #108034 has

[GitHub] [spark] AmplabJenkins commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514064740 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514064747 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
SparkQA commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514064520 **[Test build #108034 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base URL: https://github.com/apache/spark/pull/25233#issuecomment-514062730 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base URL: https://github.com/apache/spark/pull/25233#issuecomment-514063864 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins removed a comment on issue #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base URL: https://github.com/apache/spark/pull/25233#issuecomment-514062306 Can one of the admins verify this patch?

[GitHub] [spark] Udbhav30 commented on issue #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base

2019-07-22 Thread GitBox
Udbhav30 commented on issue #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base URL: https://github.com/apache/spark/pull/25233#issuecomment-514062796 Hi @HyukjinKwon can you please review this thanks

[GitHub] [spark] AmplabJenkins commented on issue #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base URL: https://github.com/apache/spark/pull/25233#issuecomment-514062730 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base URL: https://github.com/apache/spark/pull/25233#issuecomment-514062306 Can one of the admins verify this patch?

[GitHub] [spark] Udbhav30 opened a new pull request #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base

2019-07-22 Thread GitBox
Udbhav30 opened a new pull request #25233: [SPARK-28391][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_implicit.sql' into UDF test base URL: https://github.com/apache/spark/pull/25233 ## What changes were proposed in this pull request? This PR adds some tests converted from

[GitHub] [spark] SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514058402 **[Test build #108035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108035/testReport)** for PR

[GitHub] [spark] chenjunjiedada edited a comment on issue #24879: [SPARK-28042][K8S] Support using volume mount as local storage

2019-07-22 Thread GitBox
chenjunjiedada edited a comment on issue #24879: [SPARK-28042][K8S] Support using volume mount as local storage URL: https://github.com/apache/spark/pull/24879#issuecomment-514057779 @rvesse @vanzin In summary, if the user specifies the directory that cannot be found in current volume

[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514058033 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514058030 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514058033 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514058030 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] chenjunjiedada commented on issue #24879: [SPARK-28042][K8S] Support using volume mount as local storage

2019-07-22 Thread GitBox
chenjunjiedada commented on issue #24879: [SPARK-28042][K8S] Support using volume mount as local storage URL: https://github.com/apache/spark/pull/24879#issuecomment-514057779 @rvesse @vanzin In summary, if the user specifies the directory that cannot be found in current volume (which

[GitHub] [spark] AmplabJenkins removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514056453 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514056445 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514056445 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514056453 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
SparkQA removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514028148 **[Test build #108029 has

[GitHub] [spark] SparkQA commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
SparkQA commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514056107 **[Test build #108029 has

[GitHub] [spark] HeartSaVioR edited a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-22 Thread GitBox
HeartSaVioR edited a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-514048478 Here's a part of test code Kafka has been doing with new poll.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514053811 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514053805 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514053811 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514053805 Merged build finished. Test PASSed. This is an

[GitHub] [spark] zhengruifeng edited a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
zhengruifeng edited a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514041986 The expected cost without range check is `E(cost(apply2)) = log(NNZ)`; while the one with range check is

[GitHub] [spark] SparkQA commented on issue #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface

2019-07-22 Thread GitBox
SparkQA commented on issue #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface URL: https://github.com/apache/spark/pull/25189#issuecomment-514052850 **[Test build #108033 has

[GitHub] [spark] SparkQA commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
SparkQA commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514052849 **[Test build #108034 has

[GitHub] [spark] zhengruifeng edited a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
zhengruifeng edited a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514041986 The expected cost without range check is `E(cost(apply2)) = log(NNZ)`; while the one with range check is

[GitHub] [spark] AmplabJenkins removed a comment on issue #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface URL: https://github.com/apache/spark/pull/25189#issuecomment-514052465 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface URL: https://github.com/apache/spark/pull/25189#issuecomment-514052470 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface URL: https://github.com/apache/spark/pull/25189#issuecomment-514052470 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface URL: https://github.com/apache/spark/pull/25189#issuecomment-514052465 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514051070 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514051063 Merged build finished. Test FAILed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514051063 Merged build finished. Test FAILed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514051070 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514051057 **[Test build #108032 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108032/testReport)** for PR

[GitHub] [spark] SparkQA removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
SparkQA removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514050378 **[Test build #108032 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108032/testReport)**

[GitHub] [spark] zhengruifeng edited a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
zhengruifeng edited a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514041986 The expected cost without range check is `E(cost(apply2)) = log(NNZ)`; while the one with range check is

[GitHub] [spark] SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514050378 **[Test build #108032 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108032/testReport)** for PR

[GitHub] [spark] zhengruifeng edited a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
zhengruifeng edited a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514035619 I test the perf among current impl (`apply`) , direct binary-search (`apply2`), binary-seach with extra range

[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514050057 Merged build finished. Test PASSed. This is an

[GitHub] [spark] maropu commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array

2019-07-22 Thread GitBox
maropu commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#discussion_r306124653 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514050061 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514050061 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-514050057 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] beliefer commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array

2019-07-22 Thread GitBox
beliefer commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#discussion_r306124403 ## File path:

[GitHub] [spark] zhengruifeng edited a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
zhengruifeng edited a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514041986 The expected cost without range check is `E(cost(apply2)) = log(NNZ)`; while the one with range check is

[GitHub] [spark] zhengruifeng edited a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
zhengruifeng edited a comment on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514041986 The expected cost without range check is `E(cost(apply2)) = log(NNZ)`; while the one with range check is

[GitHub] [spark] maropu commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array

2019-07-22 Thread GitBox
maropu commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#discussion_r306124119 ## File path:

[GitHub] [spark] HeartSaVioR edited a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-22 Thread GitBox
HeartSaVioR edited a comment on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-514048478 Here's a part of test code Kafka has been doing with new poll.

[GitHub] [spark] HeartSaVioR commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2019-07-22 Thread GitBox
HeartSaVioR commented on issue #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector URL: https://github.com/apache/spark/pull/25135#issuecomment-514048478 Here's a part of test code Kafka has been doing with new poll.

[GitHub] [spark] beliefer commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array

2019-07-22 Thread GitBox
beliefer commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#discussion_r306122925 ## File path:

[GitHub] [spark] beliefer commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array

2019-07-22 Thread GitBox
beliefer commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#discussion_r306122505 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone

2019-07-22 Thread GitBox
HyukjinKwon commented on a change in pull request #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone URL: https://github.com/apache/spark/pull/25047#discussion_r306121633 ## File path: python/pyspark/tests/test_context.py ## @@ -273,7

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone

2019-07-22 Thread GitBox
HyukjinKwon commented on a change in pull request #25047: [WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone URL: https://github.com/apache/spark/pull/25047#discussion_r306121558 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-514045154 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-514045159 Test PASSed. Refer to this link for build results

[GitHub] [spark] AmplabJenkins commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-514045159 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-514045154 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-22 Thread GitBox
SparkQA removed a comment on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-514014636 **[Test build #108027 has

[GitHub] [spark] HyukjinKwon commented on issue #25225: [SPARK-28469][SQL] Change CalendarIntervalType's readable string representation from calendarinterval to interval

2019-07-22 Thread GitBox
HyukjinKwon commented on issue #25225: [SPARK-28469][SQL] Change CalendarIntervalType's readable string representation from calendarinterval to interval URL: https://github.com/apache/spark/pull/25225#issuecomment-514044823 +1 too

[GitHub] [spark] SparkQA commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF)

2019-07-22 Thread GitBox
SparkQA commented on issue #24958: [SPARK-28153][PYTHON] Use AtomicReference at InputFileBlockHolder (to support input_file_name with Python UDF) URL: https://github.com/apache/spark/pull/24958#issuecomment-514044796 **[Test build #108027 has

[GitHub] [spark] dongjoon-hyun closed pull request #25225: [SPARK-28469][SQL] Change CalendarIntervalType's readable string representation from calendarinterval to interval

2019-07-22 Thread GitBox
dongjoon-hyun closed pull request #25225: [SPARK-28469][SQL] Change CalendarIntervalType's readable string representation from calendarinterval to interval URL: https://github.com/apache/spark/pull/25225 This is an

[GitHub] [spark] dongjoon-hyun commented on issue #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface

2019-07-22 Thread GitBox
dongjoon-hyun commented on issue #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface URL: https://github.com/apache/spark/pull/25189#issuecomment-514044307 #25225 is merged now. Could you rebase this PR?

[GitHub] [spark] dongjoon-hyun commented on issue #25225: [SPARK-28469][SQL] Change CalendarIntervalType's readable string representation from calendarinterval to interval

2019-07-22 Thread GitBox
dongjoon-hyun commented on issue #25225: [SPARK-28469][SQL] Change CalendarIntervalType's readable string representation from calendarinterval to interval URL: https://github.com/apache/spark/pull/25225#issuecomment-514043510 Yep. I think it's okay by itself. Thank you for the pointer.

[GitHub] [spark] SparkQA commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_having.sql' into UDF test base

2019-07-22 Thread GitBox
SparkQA commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_having.sql' into UDF test base URL: https://github.com/apache/spark/pull/25161#issuecomment-514042578 **[Test build #108031 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_having.sql' into UDF test base

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_having.sql' into UDF test base URL: https://github.com/apache/spark/pull/25161#issuecomment-514042256 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_having.sql' into UDF test base

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_having.sql' into UDF test base URL: https://github.com/apache/spark/pull/25161#issuecomment-514042253 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_having.sql' into UDF test base

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_having.sql' into UDF test base URL: https://github.com/apache/spark/pull/25161#issuecomment-514042253 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_having.sql' into UDF test base

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_having.sql' into UDF test base URL: https://github.com/apache/spark/pull/25161#issuecomment-514042256 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] zhengruifeng commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
zhengruifeng commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514041986 The expected cost without range check is `E(cost(apply2)) = log(NNZ)`; while the one with range check is

[GitHub] [spark] shivusondur commented on a change in pull request #25161: [SPARK-28390][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_having.sql' into UDF test base

2019-07-22 Thread GitBox
shivusondur commented on a change in pull request #25161: [SPARK-28390][SQL][PYTHON][TESTS] Convert and port 'pgSQL/select_having.sql' into UDF test base URL: https://github.com/apache/spark/pull/25161#discussion_r306117675 ## File path:

[GitHub] [spark] SparkQA commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
SparkQA commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514041249 **[Test build #108030 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514040919 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514040916 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514040916 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514040919 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] maropu commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array

2019-07-22 Thread GitBox
maropu commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#discussion_r306114834 ## File path:

[GitHub] [spark] gczsjdy commented on a change in pull request #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-22 Thread GitBox
gczsjdy commented on a change in pull request #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#discussion_r306100833 ## File path: core/src/main/java/org/apache/spark/shuffle/sort/io/LocalDiskShuffleDataIO.java

[GitHub] [spark] gczsjdy commented on a change in pull request #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-22 Thread GitBox
gczsjdy commented on a change in pull request #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#discussion_r306109354 ## File path:

[GitHub] [spark] zhengruifeng commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization

2019-07-22 Thread GitBox
zhengruifeng commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization URL: https://github.com/apache/spark/pull/25178#issuecomment-514035619 I test the perf among current impl (`apply`) , direct binary-search (`apply2`), binary-seach with extra range check

[GitHub] [spark] ulysses-you commented on a change in pull request #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType

2019-07-22 Thread GitBox
ulysses-you commented on a change in pull request #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType URL: https://github.com/apache/spark/pull/25198#discussion_r306109902 ## File path:

[GitHub] [spark] beliefer commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array

2019-07-22 Thread GitBox
beliefer commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#discussion_r306106058 ## File path:

[GitHub] [spark] SparkQA commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
SparkQA commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514028148 **[Test build #108029 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514027746 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514027750 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514027750 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink URL: https://github.com/apache/spark/pull/25232#issuecomment-514027677 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink URL: https://github.com/apache/spark/pull/25232#issuecomment-514027677 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink URL: https://github.com/apache/spark/pull/25232#issuecomment-514027673 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

2019-07-22 Thread GitBox
AmplabJenkins commented on issue #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file URL: https://github.com/apache/spark/pull/25134#issuecomment-514027746 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink

2019-07-22 Thread GitBox
AmplabJenkins removed a comment on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink URL: https://github.com/apache/spark/pull/25232#issuecomment-514027673 Merged build finished. Test PASSed. This is

  1   2   3   4   5   6   7   8   >