[GitHub] [spark] wangyum closed pull request #25480: [SPARK-28763][SQL][TEST] Flaky Tests: SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type

2019-08-21 Thread GitBox
wangyum closed pull request #25480: [SPARK-28763][SQL][TEST] Flaky Tests: SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type URL: https://github.com/apache/spark/pull/25480 This is an automa

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25480: [SPARK-28763][SQL][TEST] Flaky Tests: SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type

2019-08-21 Thread GitBox
dongjoon-hyun commented on a change in pull request #25480: [SPARK-28763][SQL][TEST] Flaky Tests: SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type URL: https://github.com/apache/spark/pull/25480#discussion_r316483932 ## File path: sql/hive-thrif

[GitHub] [spark] dongjoon-hyun commented on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
dongjoon-hyun commented on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25508#issuecomment-523732445 Thank you for update this, too. @xuanyuanking . cc @kiszk

[GitHub] [spark] SparkQA commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
SparkQA commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523731949 **[Test build #109548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBu

[GitHub] [spark] AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523731523 Test PASSed. Refer to this link for build results (access rights to CI server ne

[GitHub] [spark] AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523731518 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523731542 Test PASSed. Ref

[GitHub] [spark] AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523731535 Merged build finish

[GitHub] [spark] AmplabJenkins commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523731542 Test PASSed. Refer to th

[GitHub] [spark] AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523731518 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523731535 Merged build finished. Test

[GitHub] [spark] dongjoon-hyun commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
dongjoon-hyun commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523731615 Thank you for update, @xuanyuanking .

[GitHub] [spark] AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523731523 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dongjoon-hyun commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created

2019-08-21 Thread GitBox
dongjoon-hyun commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523731405 Hi, guys. I already trigger

[GitHub] [spark] akirillov commented on a change in pull request #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
akirillov commented on a change in pull request #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#discussion_r316483033 ## File path: resource-managers/mesos/src/main/scala/org/apache/spar

[GitHub] [spark] SparkQA commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hi

2019-08-21 Thread GitBox
SparkQA commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523730524 **[Test build #109547 has starte

[GitHub] [spark] wangyum commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hi

2019-08-21 Thread GitBox
wangyum commented on issue #25542: [SPARK-28840][SQL][test-hadoop3.2]conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523730383 retest this please -

[GitHub] [spark] wangyum commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive

2019-08-21 Thread GitBox
wangyum commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523729811 Yes. I can reproduce this issue. Please add `[te

[GitHub] [spark] xuanyuanking commented on issue #25491: [SPARK-28699][SQL] Disable using radix sort for ShuffleExchangeExec in repartition case

2019-08-21 Thread GitBox
xuanyuanking commented on issue #25491: [SPARK-28699][SQL] Disable using radix sort for ShuffleExchangeExec in repartition case URL: https://github.com/apache/spark/pull/25491#issuecomment-523727865 Thank you all for the discussion and guidance. After discussing with Wenchen, while we fi

[GitHub] [spark] wangyum commented on a change in pull request #25480: [SPARK-28763][SQL][TEST] Flaky Tests: SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type

2019-08-21 Thread GitBox
wangyum commented on a change in pull request #25480: [SPARK-28763][SQL][TEST] Flaky Tests: SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type URL: https://github.com/apache/spark/pull/25480#discussion_r316480344 ## File path: sql/hive-thriftserve

[GitHub] [spark] sandeep-katta commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive

2019-08-21 Thread GitBox
sandeep-katta commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523727557 please use hadoop-3.2 as it comes with Hiv

[GitHub] [spark] wangyum commented on a change in pull request #25480: [SPARK-28763][SQL][TEST] Flaky Tests: SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type

2019-08-21 Thread GitBox
wangyum commented on a change in pull request #25480: [SPARK-28763][SQL][TEST] Flaky Tests: SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type URL: https://github.com/apache/spark/pull/25480#discussion_r316480265 ## File path: sql/hive-thriftserve

[GitHub] [spark] wangyum commented on a change in pull request #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation

2019-08-21 Thread GitBox
wangyum commented on a change in pull request #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation URL: https://github.com/apache/spark/pull/24715#discussion_r316479433 ## File path: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollec

[GitHub] [spark] wangyum commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive

2019-08-21 Thread GitBox
wangyum commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523725659 It seems `--jars sql/hive/src/test/resources/SPA

[GitHub] [spark] SparkQA commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4

2019-08-21 Thread GitBox
SparkQA commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4 URL: https://github.com/apache/spark/pull/25546#issuecomment-523724838 **[Test build #109546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109546/testRepor

[GitHub] [spark] AmplabJenkins removed a comment on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4 URL: https://github.com/apache/spark/pull/25546#issuecomment-523724460 Merged build finished. Test PASSed. Thi

[GitHub] [spark] AmplabJenkins removed a comment on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4 URL: https://github.com/apache/spark/pull/25546#issuecomment-523724463 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://am

[GitHub] [spark] AmplabJenkins commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4 URL: https://github.com/apache/spark/pull/25546#issuecomment-523724463 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.

[GitHub] [spark] AmplabJenkins commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4 URL: https://github.com/apache/spark/pull/25546#issuecomment-523724460 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4

2019-08-21 Thread GitBox
SparkQA commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4 URL: https://github.com/apache/spark/pull/25546#issuecomment-523723375 **[Test build #109545 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109545/testRepor

[GitHub] [spark] zhengruifeng commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4

2019-08-21 Thread GitBox
zhengruifeng commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4 URL: https://github.com/apache/spark/pull/25546#issuecomment-523723471 friendly ping @dongjoon-hyun @srowen This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4 URL: https://github.com/apache/spark/pull/25546#issuecomment-523722976 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://am

[GitHub] [spark] AmplabJenkins removed a comment on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.4 URL: https://github.com/apache/spark/pull/25546#issuecomment-523722972 Merged build finished. Test PASSed. Thi

[GitHub] [spark] AmplabJenkins commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.3

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.3 URL: https://github.com/apache/spark/pull/25546#issuecomment-523722972 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.3

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.3 URL: https://github.com/apache/spark/pull/25546#issuecomment-523722976 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.

[GitHub] [spark] zhengruifeng opened a new pull request #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.3

2019-08-21 Thread GitBox
zhengruifeng opened a new pull request #25546: [SPARK-28780][ML] deprecate LinearSVCModel.setWeightCol for 2.3.3 URL: https://github.com/apache/spark/pull/25546 ### What changes were proposed in this pull request? deprecate `LinearSVCModel.setWeightCol`, and make it a no-op ##

[GitHub] [spark] AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523722230 Test FAILed. Refer to this link for build results (access rights to CI server ne

[GitHub] [spark] AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523722230 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
SparkQA commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523722217 **[Test build #109543 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestB

[GitHub] [spark] AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-52374 Merged build finished. Test FAILed. --

[GitHub] [spark] AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-52374 Merged build finished. Test FAILed. --

[GitHub] [spark] SparkQA removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
SparkQA removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523720417 **[Test build #109543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullR

[GitHub] [spark] xuanyuanking commented on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
xuanyuanking commented on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25508#issuecomment-523722200 Supply UT for this cherry-pick in the last commit.

[GitHub] [spark] gatorsmile closed pull request #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution

2019-08-21 Thread GitBox
gatorsmile closed pull request #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution URL: https://github.com/apache/spark/pull/25456 This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] SparkQA commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
SparkQA commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523721871 **[Test build #109544 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109544

[GitHub] [spark] AmplabJenkins removed a comment on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523721530 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523721523 Merged build finished. Test PASSed. --

[GitHub] [spark] gatorsmile commented on issue #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution

2019-08-21 Thread GitBox
gatorsmile commented on issue #25456: [SPARK-28739][SQL] Add a simple cost check for Adaptive Query Execution URL: https://github.com/apache/spark/pull/25456#issuecomment-523721683 Thanks! Merged to master. This is an automat

[GitHub] [spark] AmplabJenkins commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523721530 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://

[GitHub] [spark] AmplabJenkins commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523721523 Merged build finished. Test PASSed. T

[GitHub] [spark] xuanyuanking commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
xuanyuanking commented on issue #25509: [SPARK-28699][CORE][2.4] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25509#issuecomment-523721002 Yeah, sorry for the missing, add UT in 9a6cca8. ---

[GitHub] [spark] beliefer removed a comment on issue #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array

2019-08-21 Thread GitBox
beliefer removed a comment on issue #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#issuecomment-522446741 @dongjoon-hyun Could you take a look at this PR? -

[GitHub] [spark] beliefer commented on issue #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array

2019-08-21 Thread GitBox
beliefer commented on issue #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#issuecomment-523720817 @maropu I have followed your suggestion, could you take a look again? ---

[GitHub] [spark] SparkQA commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true

2019-08-21 Thread GitBox
SparkQA commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true URL: https://github.com/apache/spark/pull/25520#issuecomment-523720404 **[Test build #109541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109541/test

[GitHub] [spark] SparkQA commented on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
SparkQA commented on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25508#issuecomment-523720415 **[Test build #109542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109542

[GitHub] [spark] SparkQA commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
SparkQA commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523720417 **[Test build #109543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBu

[GitHub] [spark] AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523720025 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523720033 Test PASSed. Refer to this link for build results (access rights to CI server ne

[GitHub] [spark] AmplabJenkins removed a comment on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true URL: https://github.com/apache/spark/pull/25520#issuecomment-523720006 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true URL: https://github.com/apache/spark/pull/25520#issuecomment-523720010 Test PASSed. Refer to this link for build results (access rights to CI server needed): https

[GitHub] [spark] AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523720025 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523720033 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true URL: https://github.com/apache/spark/pull/25520#issuecomment-523720010 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampla

[GitHub] [spark] AmplabJenkins commented on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25508#issuecomment-523719985 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://

[GitHub] [spark] AmplabJenkins commented on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25508#issuecomment-523719977 Merged build finished. Test PASSed. T

[GitHub] [spark] AmplabJenkins removed a comment on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25508#issuecomment-523719977 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage URL: https://github.com/apache/spark/pull/25508#issuecomment-523719985 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true URL: https://github.com/apache/spark/pull/25520#issuecomment-523720006 Merged build finished. Test PASSed. This i

[GitHub] [spark] akirillov commented on a change in pull request #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
akirillov commented on a change in pull request #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#discussion_r316473395 ## File path: resource-managers/mesos/src/main/scala/org/apache/spar

[GitHub] [spark] cloud-fan commented on a change in pull request #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#discussion_r316472213 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/Pa

[GitHub] [spark] cloud-fan commented on a change in pull request #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#discussion_r316472090 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource

[GitHub] [spark] cloud-fan commented on a change in pull request #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#discussion_r316472026 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ##

[GitHub] [spark] AmplabJenkins removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523717013 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523717007 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523717007 Merged build finished. Test PASSed. ---

[GitHub] [spark] triplesheep commented on issue #25538: Fix minor typo in SQLConf

2019-08-21 Thread GitBox
triplesheep commented on issue #25538: Fix minor typo in SQLConf URL: https://github.com/apache/spark/pull/25538#issuecomment-523716945 @gengliangwang Done and the issue is SPARK-28844. Thanks for reviewing :) This is an auto

[GitHub] [spark] AmplabJenkins commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523717013 Test PASSed. Refer to this link for build results (access rights to CI server needed): https

[GitHub] [spark] AmplabJenkins removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523716159 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
SparkQA removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523715899 **[Test build #109540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBui

[GitHub] [spark] AmplabJenkins removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523716156 Merged build finished. Test FAILed. ---

[GitHub] [spark] AmplabJenkins commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523716159 Test FAILed. Refer to this link for build results (access rights to CI server needed): https:

[GitHub] [spark] AmplabJenkins commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523716156 Merged build finished. Test FAILed. ---

[GitHub] [spark] SparkQA commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
SparkQA commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523716147 **[Test build #109540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/10

[GitHub] [spark] hddong commented on a change in pull request #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
hddong commented on a change in pull request #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#discussion_r316470177 ## File path: examples/src/main/java/org/apache/spark/examples/streaming/JavaDir

[GitHub] [spark] SparkQA commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
SparkQA commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523715899 **[Test build #109540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109

[GitHub] [spark] cloud-fan commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion

2019-08-21 Thread GitBox
cloud-fan commented on issue #25453: [SPARK-28730][SQL] Configurable type coercion policy for table insertion URL: https://github.com/apache/spark/pull/25453#issuecomment-523715573 > Any thoughts on whether we can get rid of legacy mode for v1 if we implement ANSI mode? The general

[GitHub] [spark] AmplabJenkins removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523715447 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523715442 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523715442 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25412: [SPARK-28691][EXAMPLES] Add Java/Scala DirectKerberizedKafkaWordCount examples URL: https://github.com/apache/spark/pull/25412#issuecomment-523715447 Test PASSed. Refer to this link for build results (access rights to CI server needed): https

[GitHub] [spark] AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523714683 Test FAILed. Refer to this link for build results (access rights to CI server ne

[GitHub] [spark] srowen commented on a change in pull request #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
srowen commented on a change in pull request #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#discussion_r316469445 ## File path: resource-managers/mesos/src/main/scala/org/apache/spark/s

[GitHub] [spark] SparkQA removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
SparkQA removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523714333 **[Test build #109539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullR

[GitHub] [spark] AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523714676 Merged build finished. Test FAILed. --

[GitHub] [spark] AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523714683 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523714676 Merged build finished. Test FAILed. --

[GitHub] [spark] SparkQA commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
SparkQA commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523714671 **[Test build #109539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestB

[GitHub] [spark] WeichenXu123 commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true

2019-08-21 Thread GitBox
WeichenXu123 commented on issue #25520: [SPARK-28621][SQL] Make spark.sql.crossJoin.enabled default value true URL: https://github.com/apache/spark/pull/25520#issuecomment-523714438 @maropu Yep, we can move the `CheckCartesianProducts` to planner stage and fix some mismatching errors. B

[GitHub] [spark] SparkQA commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
SparkQA commented on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523714333 **[Test build #109539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBu

[GitHub] [spark] AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25500: [SPARK-28778][MESOS] Fixed executors advertised address when running in virtual network URL: https://github.com/apache/spark/pull/25500#issuecomment-523713914 Merged build finished. Test PASSed. --

<    1   2   3   4   5   6   7   8   9   10   >