[GitHub] [spark] HeartSaVioR edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
HeartSaVioR edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#issuecomment-526394910 Just skimmed the design doc (need to take a look deeply on fault tolerance) and it's basically known appro

[GitHub] [spark] viirya commented on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test

2019-08-29 Thread GitBox
viirya commented on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test URL: https://github.com/apache/spark/pull/25624#issuecomment-526399431 make a tiny change to corresponding modules? This is an au

[GitHub] [spark] maropu commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
maropu commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r319311479 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec

[GitHub] [spark] HeartSaVioR edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
HeartSaVioR edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#issuecomment-526394910 Just skimmed the design doc (need to take a look deeply on fault tolerance) and it's basically known appro

[GitHub] [spark] maropu commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
maropu commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r319311315 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
HeartSaVioR commented on a change in pull request #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#discussion_r319309947 ## File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/Kafk

[GitHub] [spark] SparkQA commented on issue #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE

2019-08-29 Thread GitBox
SparkQA commented on issue #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE URL: https://github.com/apache/spark/pull/25502#issuecomment-526397155 **[Test build #109922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109922/testReport)**

[GitHub] [spark] maropu commented on a change in pull request #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
maropu commented on a change in pull request #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r319308665 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregat

[GitHub] [spark] AmplabJenkins removed a comment on issue #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE URL: https://github.com/apache/spark/pull/25502#issuecomment-526396781 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.c

[GitHub] [spark] maropu commented on a change in pull request #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
maropu commented on a change in pull request #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r319308567 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregat

[GitHub] [spark] AmplabJenkins removed a comment on issue #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE URL: https://github.com/apache/spark/pull/25502#issuecomment-526396777 Merged build finished. Test PASSed. This is a

[GitHub] [spark] AmplabJenkins commented on issue #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE URL: https://github.com/apache/spark/pull/25502#issuecomment-526396777 Merged build finished. Test PASSed. This is an automa

[GitHub] [spark] AmplabJenkins commented on issue #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE URL: https://github.com/apache/spark/pull/25502#issuecomment-526396781 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkel

[GitHub] [spark] brkyvz commented on a change in pull request #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE

2019-08-29 Thread GitBox
brkyvz commented on a change in pull request #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE URL: https://github.com/apache/spark/pull/25502#discussion_r319307485 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ##

[GitHub] [spark] HeartSaVioR edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
HeartSaVioR edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#issuecomment-526394910 Just skimmed the design doc (need to take a look deeply on fault tolerance) and it's basically known appro

[GitHub] [spark] HeartSaVioR edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
HeartSaVioR edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#issuecomment-526394910 Just skimmed the design doc (need to take a look deeply on fault tolerance) and it's basically known appro

[GitHub] [spark] viirya edited a comment on issue #25576: [SPARK-28866][ML] Persist item factors RDD when checkpointing in ALS

2019-08-29 Thread GitBox
viirya edited a comment on issue #25576: [SPARK-28866][ML] Persist item factors RDD when checkpointing in ALS URL: https://github.com/apache/spark/pull/25576#issuecomment-526378257 In the implicit case, we don't do .count() after .checkpoint(), because in later computeFactors, we materiali

[GitHub] [spark] HeartSaVioR edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
HeartSaVioR edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#issuecomment-526394910 Just skimmed the design doc (need to take a look deeply on fault tolerance) and it's basically known appro

[GitHub] [spark] HeartSaVioR commented on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
HeartSaVioR commented on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#issuecomment-526394910 Just skimmed the design doc (need to take a look deeply on fault tolerance) and it's basically known approach wha

[GitHub] [spark] rdblue commented on a change in pull request #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE

2019-08-29 Thread GitBox
rdblue commented on a change in pull request #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE URL: https://github.com/apache/spark/pull/25502#discussion_r319304123 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ##

[GitHub] [spark] SparkQA commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
SparkQA commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526390461 **[Test build #109921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109921/testRep

[GitHub] [spark] AmplabJenkins removed a comment on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526390027 Merged build finished. Test PASSed. T

[GitHub] [spark] AmplabJenkins commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526390030 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.c

[GitHub] [spark] AmplabJenkins removed a comment on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526390030 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://

[GitHub] [spark] AmplabJenkins commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526390027 Merged build finished. Test PASSed. This is a

[GitHub] [spark] maropu commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
maropu commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526389900 yea, I found some weird behaviours... give me more time to check... -

[GitHub] [spark] rdblue commented on a change in pull request #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE

2019-08-29 Thread GitBox
rdblue commented on a change in pull request #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE URL: https://github.com/apache/spark/pull/25502#discussion_r319300747 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ##

[GitHub] [spark] rdblue commented on a change in pull request #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE

2019-08-29 Thread GitBox
rdblue commented on a change in pull request #25502: [SPARK-28668][SQL] Support V2SessionCatalog for ALTER TABLE URL: https://github.com/apache/spark/pull/25502#discussion_r319300747 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ##

[GitHub] [spark] AmplabJenkins removed a comment on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test URL: https://github.com/apache/spark/pull/25624#issuecomment-526388265 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test URL: https://github.com/apache/spark/pull/25624#issuecomment-526388270 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab

[GitHub] [spark] SparkQA commented on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test

2019-08-29 Thread GitBox
SparkQA commented on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test URL: https://github.com/apache/spark/pull/25624#issuecomment-526388717 **[Test build #109920 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109920/testReport)**

[GitHub] [spark] dongjoon-hyun commented on issue #25555: [SPARK-28852][SQL] Implement SparkGetCatalogsOperation for Thrift Server

2019-08-29 Thread GitBox
dongjoon-hyun commented on issue #2: [SPARK-28852][SQL] Implement SparkGetCatalogsOperation for Thrift Server URL: https://github.com/apache/spark/pull/2#issuecomment-526388572 Sorry, guys. It seems to be my environment issue. ---

[GitHub] [spark] HeartSaVioR commented on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
HeartSaVioR commented on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#issuecomment-526388376 Before reviewing the design, I may need to say, you are encouraged to at least mention it if you borrow the code

[GitHub] [spark] dongjoon-hyun commented on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test

2019-08-29 Thread GitBox
dongjoon-hyun commented on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test URL: https://github.com/apache/spark/pull/25624#issuecomment-526388364 Hi, @dbtsai . Is there a way to trigger this on PR?

[GitHub] [spark] AmplabJenkins commented on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test URL: https://github.com/apache/spark/pull/25624#issuecomment-526388270 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berk

[GitHub] [spark] AmplabJenkins commented on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test URL: https://github.com/apache/spark/pull/25624#issuecomment-526388265 Merged build finished. Test PASSed. This is an auto

[GitHub] [spark] dongjoon-hyun opened a new pull request #25624: Add more profiles for JDK8/11 build test

2019-08-29 Thread GitBox
dongjoon-hyun opened a new pull request #25624: Add more profiles for JDK8/11 build test URL: https://github.com/apache/spark/pull/25624 -Pyarn -Pmesos -Pkubernetes -Phive -Phive-thriftserver -Phadoop-3.2 -Phadoop-cloud ### What changes were proposed in this pull request?

[GitHub] [spark] SparkQA commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
SparkQA commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-526382995 **[Test build #109919 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109919/testReport)** for PR 25600 at

[GitHub] [spark] AmplabJenkins commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-526382453 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/

[GitHub] [spark] AmplabJenkins removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-526382448 Merged build finished. Test PASSed. This is an automated mes

[GitHub] [spark] AmplabJenkins removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-526382453 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/

[GitHub] [spark] AmplabJenkins commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-526382448 Merged build finished. Test PASSed. This is an automated message fro

[GitHub] [spark] AmplabJenkins removed a comment on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526382107 Merged build finished. Test PASSed. This is an aut

[GitHub] [spark] AmplabJenkins removed a comment on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526382110 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.ber

[GitHub] [spark] SparkQA commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
SparkQA commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526382077 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribu

[GitHub] [spark] AmplabJenkins commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526382107 Merged build finished. Test PASSed. This is an automated m

[GitHub] [spark] AmplabJenkins commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526382110 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.ed

[GitHub] [spark] viirya commented on issue #25576: [SPARK-28866][ML] Persist item factors RDD when checkpointing in ALS

2019-08-29 Thread GitBox
viirya commented on issue #25576: [SPARK-28866][ML] Persist item factors RDD when checkpointing in ALS URL: https://github.com/apache/spark/pull/25576#issuecomment-526378257 In the implicit case, we don't do .count() after .checkpoint(), because in later computeFactors, we materialize the

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25555: [SPARK-28852][SQL] Implement SparkGetCatalogsOperation for Thrift Server

2019-08-29 Thread GitBox
dongjoon-hyun edited a comment on issue #2: [SPARK-28852][SQL] Implement SparkGetCatalogsOperation for Thrift Server URL: https://github.com/apache/spark/pull/2#issuecomment-526376387 ~Hi, All. This seems to break JDK11 compilation (building with JDK11).~ ~Could you take a lo

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25555: [SPARK-28852][SQL] Implement SparkGetCatalogsOperation for Thrift Server

2019-08-29 Thread GitBox
dongjoon-hyun edited a comment on issue #2: [SPARK-28852][SQL] Implement SparkGetCatalogsOperation for Thrift Server URL: https://github.com/apache/spark/pull/2#issuecomment-526376387 ~Hi, All. This seems to break JDK11 compilation.~ ~Could you take a look at this? Otherwise,

[GitHub] [spark] SparkQA commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
SparkQA commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526376773 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-u

[GitHub] [spark] dongjoon-hyun commented on issue #25555: [SPARK-28852][SQL] Implement SparkGetCatalogsOperation for Thrift Server

2019-08-29 Thread GitBox
dongjoon-hyun commented on issue #2: [SPARK-28852][SQL] Implement SparkGetCatalogsOperation for Thrift Server URL: https://github.com/apache/spark/pull/2#issuecomment-526376387 Hi, All. This seems to break JDK11 compilation. Could you take a look at this? Otherwise, we need t

[GitHub] [spark] AmplabJenkins removed a comment on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526374429 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berk

[GitHub] [spark] AmplabJenkins commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526374420 Merged build finished. Test FAILed. This is an automated m

[GitHub] [spark] SparkQA removed a comment on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
SparkQA removed a comment on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526374060 **[Test build #109918 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109918/testReport)*

[GitHub] [spark] SparkQA commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
SparkQA commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526374411 **[Test build #109918 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109918/testReport)** for

[GitHub] [spark] AmplabJenkins removed a comment on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526374420 Merged build finished. Test FAILed. This is an aut

[GitHub] [spark] AmplabJenkins commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526374429 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu

[GitHub] [spark] SparkQA commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
SparkQA commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526374060 **[Test build #109918 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109918/testReport)** for P

[GitHub] [spark] rdblue commented on issue #25610: [SPARK-28899][SQL][TEST] merge the testing in-memory v2 catalogs from catalyst and core

2019-08-29 Thread GitBox
rdblue commented on issue #25610: [SPARK-28899][SQL][TEST] merge the testing in-memory v2 catalogs from catalyst and core URL: https://github.com/apache/spark/pull/25610#issuecomment-526373699 Thanks! This is an automated mes

[GitHub] [spark] AmplabJenkins removed a comment on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526255381 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.ber

[GitHub] [spark] jinxingwang commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix

2019-08-29 Thread GitBox
jinxingwang commented on issue #25614: [WIP][SPARK-28887][Kubernetes] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-526371935 ok to test This is an automated message from the Apache Git

[GitHub] [spark] maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r319257094 ## File path: sql/core/src/main/scala/org/apache/spark/sql/dynamicpruning/PartitionPruning.scala ##

[GitHub] [spark] rdblue commented on a change in pull request #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog

2019-08-29 Thread GitBox
rdblue commented on a change in pull request #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog URL: https://github.com/apache/spark/pull/25507#discussion_r319274871 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/InsertIntoTests.scala

[GitHub] [spark] rdblue commented on a change in pull request #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog

2019-08-29 Thread GitBox
rdblue commented on a change in pull request #25507: [SPARK-28667][SQL] Support InsertInto through the V2SessionCatalog URL: https://github.com/apache/spark/pull/25507#discussion_r319274650 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/InsertIntoTests.scala

[GitHub] [spark] vanzin commented on a change in pull request #24901: [SPARK-28091[CORE] Extend Spark metrics system with user-defined metrics using executor plugins

2019-08-29 Thread GitBox
vanzin commented on a change in pull request #24901: [SPARK-28091[CORE] Extend Spark metrics system with user-defined metrics using executor plugins URL: https://github.com/apache/spark/pull/24901#discussion_r319273502 ## File path: core/src/main/java/org/apache/spark/ExecutorPlugin

[GitHub] [spark] planga82 commented on issue #25598: [SPARK-28542][DOCS][WebUI] Stages Tab

2019-08-29 Thread GitBox
planga82 commented on issue #25598: [SPARK-28542][DOCS][WebUI] Stages Tab URL: https://github.com/apache/spark/pull/25598#issuecomment-526362297 Thank you very much @srowen for all your comments. I have fixed all comments. I have tried to explain only not obvious things to keep the documen

[GitHub] [spark] AmplabJenkins removed a comment on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock URL: https://github.com/apache/spark/pull/25612#issuecomment-526359057 Test PASSed. Refer to this link for build results (access rights to CI server neede

[GitHub] [spark] AmplabJenkins removed a comment on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock URL: https://github.com/apache/spark/pull/25612#issuecomment-526359049 Merged build finished. Test PASSed. -

[GitHub] [spark] planga82 commented on a change in pull request #25598: [SPARK-28542][DOCS][WebUI] Stages Tab

2019-08-29 Thread GitBox
planga82 commented on a change in pull request #25598: [SPARK-28542][DOCS][WebUI] Stages Tab URL: https://github.com/apache/spark/pull/25598#discussion_r319269676 ## File path: docs/web-ui.md ## @@ -94,9 +94,76 @@ This page displays the details of a specific job identified

[GitHub] [spark] dongjoon-hyun commented on issue #25610: [SPARK-28899][SQL][TEST] merge the testing in-memory v2 catalogs from catalyst and core

2019-08-29 Thread GitBox
dongjoon-hyun commented on issue #25610: [SPARK-28899][SQL][TEST] merge the testing in-memory v2 catalogs from catalyst and core URL: https://github.com/apache/spark/pull/25610#issuecomment-526359435 Yey! Congratulation, @rdblue !!! 😄 --

[GitHub] [spark] AmplabJenkins commented on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock URL: https://github.com/apache/spark/pull/25612#issuecomment-526359057 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock URL: https://github.com/apache/spark/pull/25612#issuecomment-526359049 Merged build finished. Test PASSed. -

[GitHub] [spark] SparkQA removed a comment on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock

2019-08-29 Thread GitBox
SparkQA removed a comment on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock URL: https://github.com/apache/spark/pull/25612#issuecomment-526312253 **[Test build #109917 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequ

[GitHub] [spark] SparkQA commented on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock

2019-08-29 Thread GitBox
SparkQA commented on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock URL: https://github.com/apache/spark/pull/25612#issuecomment-526358308 **[Test build #109917 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuil

[GitHub] [spark] planga82 commented on a change in pull request #25598: [SPARK-28542][DOCS][WebUI] Stages Tab

2019-08-29 Thread GitBox
planga82 commented on a change in pull request #25598: [SPARK-28542][DOCS][WebUI] Stages Tab URL: https://github.com/apache/spark/pull/25598#discussion_r319268163 ## File path: docs/web-ui.md ## @@ -94,9 +94,76 @@ This page displays the details of a specific job identified

[GitHub] [spark] AmplabJenkins commented on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock URL: https://github.com/apache/spark/pull/25612#issuecomment-526356044 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock URL: https://github.com/apache/spark/pull/25612#issuecomment-526356035 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins removed a comment on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock URL: https://github.com/apache/spark/pull/25612#issuecomment-526356044 Test PASSed. Refer to this link for build results (access rights to CI server neede

[GitHub] [spark] AmplabJenkins removed a comment on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock URL: https://github.com/apache/spark/pull/25612#issuecomment-526356035 Merged build finished. Test PASSed. -

[GitHub] [spark] SparkQA removed a comment on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock

2019-08-29 Thread GitBox
SparkQA removed a comment on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock URL: https://github.com/apache/spark/pull/25612#issuecomment-526309304 **[Test build #109916 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequ

[GitHub] [spark] SparkQA commented on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock

2019-08-29 Thread GitBox
SparkQA commented on issue #25612: [SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained KeyLock URL: https://github.com/apache/spark/pull/25612#issuecomment-526355439 **[Test build #109916 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuil

[GitHub] [spark] BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs

2019-08-29 Thread GitBox
BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs URL: https://github.com/apache/spark/pull/24981#discussion_r319261673 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/FlatMapGroupsI

[GitHub] [spark] BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs

2019-08-29 Thread GitBox
BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs URL: https://github.com/apache/spark/pull/24981#discussion_r319258592 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/pyth

[GitHub] [spark] BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs

2019-08-29 Thread GitBox
BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs URL: https://github.com/apache/spark/pull/24981#discussion_r319211663 ## File path: python/pyspark/serializers.py ## @@ -401,6 +401,35 @@ def __repr__(

[GitHub] [spark] BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs

2019-08-29 Thread GitBox
BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs URL: https://github.com/apache/spark/pull/24981#discussion_r319258254 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/pyth

[GitHub] [spark] BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs

2019-08-29 Thread GitBox
BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs URL: https://github.com/apache/spark/pull/24981#discussion_r319256055 ## File path: python/pyspark/worker.py ## @@ -343,6 +377,30 @@ def map_batch(batc

[GitHub] [spark] BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs

2019-08-29 Thread GitBox
BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs URL: https://github.com/apache/spark/pull/24981#discussion_r319211690 ## File path: python/pyspark/serializers.py ## @@ -401,6 +401,35 @@ def __repr__(

[GitHub] [spark] BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs

2019-08-29 Thread GitBox
BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs URL: https://github.com/apache/spark/pull/24981#discussion_r319257236 ## File path: python/pyspark/worker.py ## @@ -359,10 +417,24 @@ def map_batch(bat

[GitHub] [spark] BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs

2019-08-29 Thread GitBox
BryanCutler commented on a change in pull request #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs URL: https://github.com/apache/spark/pull/24981#discussion_r319224687 ## File path: python/pyspark/worker.py ## @@ -343,6 +377,30 @@ def map_batch(batc

[GitHub] [spark] maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r319259323 ## File path: sql/core/src/main/scala/org/apache/spark/sql/dynamicpruning/PartitionPruning.scala ##

[GitHub] [spark] maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r319257094 ## File path: sql/core/src/main/scala/org/apache/spark/sql/dynamicpruning/PartitionPruning.scala ##

[GitHub] [spark] maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r319249870 ## File path: sql/core/src/main/scala/org/apache/spark/sql/dynamicpruning/PartitionPruning.scala ##

[GitHub] [spark] maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r319249733 ## File path: sql/core/src/main/scala/org/apache/spark/sql/dynamicpruning/PartitionPruning.scala ##

[GitHub] [spark] maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r319249181 ## File path: sql/core/src/main/scala/org/apache/spark/sql/dynamicpruning/PartitionPruning.scala ##

[GitHub] [spark] maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
maryannxue commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r319248395 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/DynamicPruning.scala

[GitHub] [spark] rdblue commented on issue #25610: [SPARK-28899][SQL][TEST] merge the testing in-memory v2 catalogs from catalyst and core

2019-08-29 Thread GitBox
rdblue commented on issue #25610: [SPARK-28899][SQL][TEST] merge the testing in-memory v2 catalogs from catalyst and core URL: https://github.com/apache/spark/pull/25610#issuecomment-526337340 Merged to master. This is an aut

[GitHub] [spark] rdblue closed pull request #25610: [SPARK-28899][SQL][TEST] merge the testing in-memory v2 catalogs from catalyst and core

2019-08-29 Thread GitBox
rdblue closed pull request #25610: [SPARK-28899][SQL][TEST] merge the testing in-memory v2 catalogs from catalyst and core URL: https://github.com/apache/spark/pull/25610 This is an automated message from the Apache Git Serv

[GitHub] [spark] rdblue commented on issue #25610: [SPARK-28899][SQL][TEST] merge the testing in-memory v2 catalogs from catalyst and core

2019-08-29 Thread GitBox
rdblue commented on issue #25610: [SPARK-28899][SQL][TEST] merge the testing in-memory v2 catalogs from catalyst and core URL: https://github.com/apache/spark/pull/25610#issuecomment-526336088 +1 This is an automated message

[GitHub] [spark] rdblue commented on issue #25104: [SPARK-28341][SQL] create a public API for V2SessionCatalog

2019-08-29 Thread GitBox
rdblue commented on issue #25104: [SPARK-28341][SQL] create a public API for V2SessionCatalog URL: https://github.com/apache/spark/pull/25104#issuecomment-526332354 @cloud-fan, I had a couple of minor comments, but not blockers and overall it looks good to me. +1 when tests pass. I

<    1   2   3   4   5   6   7   >