[GitHub] [spark] SparkQA commented on issue #25767: [SPARK-29062][SQL] Add V1_BATCH_WRITE to the TableCapabilityChecks

2019-09-20 Thread GitBox
SparkQA commented on issue #25767: [SPARK-29062][SQL] Add V1_BATCH_WRITE to the TableCapabilityChecks URL: https://github.com/apache/spark/pull/25767#issuecomment-533430424 **[Test build #111049 has

[GitHub] [spark] AmplabJenkins commented on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle "NOT IN" condition when using "JOIN" URL: https://github.com/apache/spark/pull/25854#issuecomment-533430519 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-09-20 Thread GitBox
SparkQA removed a comment on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle "NOT IN" condition when using "JOIN" URL: https://github.com/apache/spark/pull/25854#issuecomment-533375387 **[Test build #111037 has

[GitHub] [spark] SparkQA commented on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-09-20 Thread GitBox
SparkQA commented on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle "NOT IN" condition when using "JOIN" URL: https://github.com/apache/spark/pull/25854#issuecomment-533429921 **[Test build #111037 has

[GitHub] [spark] brkyvz commented on issue #25767: [SPARK-29062][SQL] Add V1_BATCH_WRITE to the TableCapabilityChecks

2019-09-20 Thread GitBox
brkyvz commented on issue #25767: [SPARK-29062][SQL] Add V1_BATCH_WRITE to the TableCapabilityChecks URL: https://github.com/apache/spark/pull/25767#issuecomment-533429740 retest this please This is an automated message from

[GitHub] [spark] AmplabJenkins removed a comment on issue #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#issuecomment-532953957 Can one of the admins verify this patch?

[GitHub] [spark] wangyum commented on issue #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-20 Thread GitBox
wangyum commented on issue #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#issuecomment-533429345 ok to test This is an

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-20 Thread GitBox
AngersZh commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#discussion_r326488795 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-20 Thread GitBox
cloud-fan commented on a change in pull request #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#discussion_r326488722 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533427105 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] cloud-fan commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec

2019-09-20 Thread GitBox
cloud-fan commented on issue #25830: [SPARK-29140][SQL] Handle parameters having "array" of javaType properly in HashAggregateExec URL: https://github.com/apache/spark/pull/25830#issuecomment-533427358 I think the added test well demonstrate that there are agg functions take complex input

[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533426968 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533426959 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533427096 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
SparkQA removed a comment on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533426624 **[Test build #111047 has

[GitHub] [spark] AmplabJenkins commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533427105 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
SparkQA commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533427084 **[Test build #111047 has

[GitHub] [spark] AmplabJenkins commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533426959 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533427096 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
AmplabJenkins commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533426968 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] cloud-fan commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable

2019-09-20 Thread GitBox
cloud-fan commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable URL: https://github.com/apache/spark/pull/25849#discussion_r326487867 ## File path:

[GitHub] [spark] SparkQA commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
SparkQA commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533426624 **[Test build #111047 has

[GitHub] [spark] adrian-wang commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-20 Thread GitBox
adrian-wang commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#discussion_r326487977 ## File path:

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-20 Thread GitBox
AngersZh commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#discussion_r326487653 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#issuecomment-533426592 I'm a normal user, @AngersZh . > For the normal user , it's a little not

[GitHub] [spark] cloud-fan commented on issue #25771: [SPARK-28970][SQL] Implement USE CATALOG/NAMESPACE for Data Source V2

2019-09-20 Thread GitBox
cloud-fan commented on issue #25771: [SPARK-28970][SQL] Implement USE CATALOG/NAMESPACE for Data Source V2 URL: https://github.com/apache/spark/pull/25771#issuecomment-533426161 I would expect it to fail. `USE CATALOG non-existing` should fail too.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
AmplabJenkins removed a comment on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533386288 Can one of the admins verify this patch?

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-20 Thread GitBox
AngersZh commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#discussion_r326486841 ## File path:

[GitHub] [spark] wangyum commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
wangyum commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533425746 ok to test This is an

[GitHub] [spark] AngersZhuuuu commented on issue #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-20 Thread GitBox
AngersZh commented on issue #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#issuecomment-533425404 > Sorry, but why `Scientific counting` is not human-readable? For me, it's also good

[GitHub] [spark] wangyum commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-20 Thread GitBox
wangyum commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#discussion_r326485621 ## File path:

[GitHub] [spark] wangyum commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-20 Thread GitBox
wangyum commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#discussion_r326485662 ## File path:

[GitHub] [spark] adrian-wang commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-20 Thread GitBox
adrian-wang commented on issue #25863: [SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-533424353 How about just clean up the staging dir before write job starts?

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#discussion_r326485241 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25844: [SPARK-29167][SQL] Make Metrics of Analyzer/Optimizer use Scientific counting human readable URL: https://github.com/apache/spark/pull/25844#issuecomment-533423938 Sorry, but why `Scientific counting` is not human-readable? For me, it's also good

[GitHub] [spark] dongjoon-hyun commented on issue #25855: [SPARK-29053][WEBUI] Spark UI JDBC/ODBC Server tab sorting is not working on Duration column

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25855: [SPARK-29053][WEBUI] Spark UI JDBC/ODBC Server tab sorting is not working on Duration column URL: https://github.com/apache/spark/pull/25855#issuecomment-533423242 Thanks, @amanomer . I'll review again after you update this PR.

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25838: [SPARK-29158][SQL] Expose SerializableConfiguration for DataSource V2 developers

2019-09-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #25838: [SPARK-29158][SQL] Expose SerializableConfiguration for DataSource V2 developers URL: https://github.com/apache/spark/pull/25838#discussion_r326483862 ## File path:

[GitHub] [spark] adrian-wang commented on issue #25850: [SPARK-29177] [Core] fix zombie tasks after stage abort

2019-09-20 Thread GitBox
adrian-wang commented on issue #25850: [SPARK-29177] [Core] fix zombie tasks after stage abort URL: https://github.com/apache/spark/pull/25850#issuecomment-533422409 @xuanyuanking Could you please help review this? This is

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25838: [SPARK-29158][SQL] Expose SerializableConfiguration for DataSource V2 developers

2019-09-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #25838: [SPARK-29158][SQL] Expose SerializableConfiguration for DataSource V2 developers URL: https://github.com/apache/spark/pull/25838#discussion_r326483756 ## File path:

[GitHub] [spark] dongjoon-hyun closed pull request #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-20 Thread GitBox
dongjoon-hyun closed pull request #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837 This is an automated message from the Apache Git

[GitHub] [spark] dongjoon-hyun commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty

2019-09-20 Thread GitBox
dongjoon-hyun commented on issue #25837: [SPARK-29161][CORE][SQL][STREAMING] Unify default wait time for waitUntilEmpty URL: https://github.com/apache/spark/pull/25837#issuecomment-533421118 Since this passed Jenkins already and the last commit is recovered to the original code, we don't

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable

2019-09-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable URL: https://github.com/apache/spark/pull/25849#discussion_r326481536 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable

2019-09-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable URL: https://github.com/apache/spark/pull/25849#discussion_r326481103 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable

2019-09-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable URL: https://github.com/apache/spark/pull/25849#discussion_r326481103 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable

2019-09-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable URL: https://github.com/apache/spark/pull/25849#discussion_r326481103 ## File path:

<    5   6   7   8   9   10