[GitHub] [spark] juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI

2019-11-25 Thread GitBox
juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI URL: https://github.com/apache/spark/pull/26378#discussion_r350148040 ## File path:

[GitHub] [spark] juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI

2019-11-25 Thread GitBox
juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI URL: https://github.com/apache/spark/pull/26378#discussion_r350109159 ## File path:

[GitHub] [spark] juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI

2019-11-25 Thread GitBox
juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI URL: https://github.com/apache/spark/pull/26378#discussion_r350112560 ## File path:

[GitHub] [spark] juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI

2019-11-25 Thread GitBox
juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI URL: https://github.com/apache/spark/pull/26378#discussion_r350280888 ## File path:

[GitHub] [spark] juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI

2019-11-25 Thread GitBox
juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI URL: https://github.com/apache/spark/pull/26378#discussion_r350110689 ## File path:

[GitHub] [spark] juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI

2019-11-25 Thread GitBox
juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI URL: https://github.com/apache/spark/pull/26378#discussion_r35028 ## File path:

[GitHub] [spark] juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI

2019-11-25 Thread GitBox
juliuszsompolski commented on a change in pull request #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI URL: https://github.com/apache/spark/pull/26378#discussion_r350111802 ## File path:

[GitHub] [spark] tgravescs commented on a change in pull request #26658: [SPARK-30015][BUILD] Move hive-storage-api dependency from `hive-2.3` to `sql/core`

2019-11-25 Thread GitBox
tgravescs commented on a change in pull request #26658: [SPARK-30015][BUILD] Move hive-storage-api dependency from `hive-2.3` to `sql/core` URL: https://github.com/apache/spark/pull/26658#discussion_r350253261 ## File path: core/pom.xml ## @@ -164,6 +164,10 @@

[GitHub] [spark] AmplabJenkins removed a comment on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description URL: https://github.com/apache/spark/pull/26659#issuecomment-558223927 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description URL: https://github.com/apache/spark/pull/26659#issuecomment-558223932 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description URL: https://github.com/apache/spark/pull/26659#issuecomment-558223932 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description URL: https://github.com/apache/spark/pull/26659#issuecomment-558223927 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] cloud-fan closed pull request #26593: [SPARK-29890][SQL] DataFrameNaFunctions.fill should handle duplicate columns

2019-11-25 Thread GitBox
cloud-fan closed pull request #26593: [SPARK-29890][SQL] DataFrameNaFunctions.fill should handle duplicate columns URL: https://github.com/apache/spark/pull/26593 This is an automated message from the Apache Git Service. To

[GitHub] [spark] cloud-fan commented on issue #26593: [SPARK-29890][SQL] DataFrameNaFunctions.fill should handle duplicate columns

2019-11-25 Thread GitBox
cloud-fan commented on issue #26593: [SPARK-29890][SQL] DataFrameNaFunctions.fill should handle duplicate columns URL: https://github.com/apache/spark/pull/26593#issuecomment-558223459 thanks, merging to master! This is an

[GitHub] [spark] SparkQA commented on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description

2019-11-25 Thread GitBox
SparkQA commented on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description URL: https://github.com/apache/spark/pull/26659#issuecomment-558223339 **[Test build #114413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114413/testReport)** for

[GitHub] [spark] tgravescs commented on issue #26614: [SPARK-29976] New conf for single task stage speculation

2019-11-25 Thread GitBox
tgravescs commented on issue #26614: [SPARK-29976] New conf for single task stage speculation URL: https://github.com/apache/spark/pull/26614#issuecomment-558223041 note I realize there are a bunch of corner cases here, but take back my suggestion of the number of executors, you could

[GitHub] [spark] AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558220482 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558220475 Build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558219660 **[Test build #114412 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558220363 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558220356 Build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558220475 Build finished. Test FAILed. This is

[GitHub] [spark] AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558220482 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558220356 Build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558220363 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
SparkQA commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558220450 **[Test build #114412 has

[GitHub] [spark] Fokko commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-11-25 Thread GitBox
Fokko commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#discussion_r350270807 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala

[GitHub] [spark] SparkQA commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
SparkQA commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558219660 **[Test build #114412 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-551549935 Can one of the admins verify this patch?

[GitHub] [spark] cloud-fan commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
cloud-fan commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558216991 retest this please This is an automated

[GitHub] [spark] cloud-fan commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
cloud-fan commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558217259 hmmm why are there so many conflicts?

[GitHub] [spark] attilapiros edited a comment on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-11-25 Thread GitBox
attilapiros edited a comment on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-558214745 @tgravescs The block content reading will occur at the client side of the

[GitHub] [spark] srowen commented on a change in pull request #26659: [MINOR][DOC] Fix the CalendarIntervalType description

2019-11-25 Thread GitBox
srowen commented on a change in pull request #26659: [MINOR][DOC] Fix the CalendarIntervalType description URL: https://github.com/apache/spark/pull/26659#discussion_r350263819 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/CalendarIntervalType.scala

[GitHub] [spark] attilapiros commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-11-25 Thread GitBox
attilapiros commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-558214745 @tgravescs The block content reading will occur at the client side of the

[GitHub] [spark] MaxGekk commented on a change in pull request #26659: [MINOR][DOC] Fix the CalendarIntervalType description

2019-11-25 Thread GitBox
MaxGekk commented on a change in pull request #26659: [MINOR][DOC] Fix the CalendarIntervalType description URL: https://github.com/apache/spark/pull/26659#discussion_r350258708 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/CalendarIntervalType.scala

[GitHub] [spark] MaxGekk commented on a change in pull request #26659: [MINOR][DOC] Fix the CalendarIntervalType description

2019-11-25 Thread GitBox
MaxGekk commented on a change in pull request #26659: [MINOR][DOC] Fix the CalendarIntervalType description URL: https://github.com/apache/spark/pull/26659#discussion_r350259667 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/CalendarIntervalType.scala

[GitHub] [spark] MaxGekk commented on a change in pull request #26659: [MINOR][DOC] Fix the CalendarIntervalType description

2019-11-25 Thread GitBox
MaxGekk commented on a change in pull request #26659: [MINOR][DOC] Fix the CalendarIntervalType description URL: https://github.com/apache/spark/pull/26659#discussion_r350257917 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/CalendarIntervalType.scala

[GitHub] [spark] tgravescs commented on issue #26284: [SPARK-29415][Core]Stage Level Sched: Add base ResourceProfile and Request classes

2019-11-25 Thread GitBox
tgravescs commented on issue #26284: [SPARK-29415][Core]Stage Level Sched: Add base ResourceProfile and Request classes URL: https://github.com/apache/spark/pull/26284#issuecomment-558210174 thanks for the reviews, committed and will put up next pr today or tomorrow.

[GitHub] [spark] asfgit closed pull request #26284: [SPARK-29415][Core]Stage Level Sched: Add base ResourceProfile and Request classes

2019-11-25 Thread GitBox
asfgit closed pull request #26284: [SPARK-29415][Core]Stage Level Sched: Add base ResourceProfile and Request classes URL: https://github.com/apache/spark/pull/26284 This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26651: [SPARK-30008][SQL] The dataType of collect_list/collect_set aggs should be ArrayType(_, false)

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26651: [SPARK-30008][SQL] The dataType of collect_list/collect_set aggs should be ArrayType(_, false) URL: https://github.com/apache/spark/pull/26651#issuecomment-558209146 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #26651: [SPARK-30008][SQL] The dataType of collect_list/collect_set aggs should be ArrayType(_, false)

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26651: [SPARK-30008][SQL] The dataType of collect_list/collect_set aggs should be ArrayType(_, false) URL: https://github.com/apache/spark/pull/26651#issuecomment-558209130 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26651: [SPARK-30008][SQL] The dataType of collect_list/collect_set aggs should be ArrayType(_, false)

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26651: [SPARK-30008][SQL] The dataType of collect_list/collect_set aggs should be ArrayType(_, false) URL: https://github.com/apache/spark/pull/26651#issuecomment-558209130 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26651: [SPARK-30008][SQL] The dataType of collect_list/collect_set aggs should be ArrayType(_, false)

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26651: [SPARK-30008][SQL] The dataType of collect_list/collect_set aggs should be ArrayType(_, false) URL: https://github.com/apache/spark/pull/26651#issuecomment-558209146 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA commented on issue #26651: [SPARK-30008][SQL] The dataType of collect_list/collect_set aggs should be ArrayType(_, false)

2019-11-25 Thread GitBox
SparkQA commented on issue #26651: [SPARK-30008][SQL] The dataType of collect_list/collect_set aggs should be ArrayType(_, false) URL: https://github.com/apache/spark/pull/26651#issuecomment-558208448 **[Test build #114411 has

[GitHub] [spark] cloud-fan commented on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description

2019-11-25 Thread GitBox
cloud-fan commented on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description URL: https://github.com/apache/spark/pull/26659#issuecomment-558206727 `ColumnVector.getInterval` has already been updated when we add the days field. I think this is the only one left.

[GitHub] [spark] yaooqinn commented on issue #26651: [SPARK-30008][SQL] The dataType of collect_list/collect_set aggs should be ArrayType(_, false)

2019-11-25 Thread GitBox
yaooqinn commented on issue #26651: [SPARK-30008][SQL] The dataType of collect_list/collect_set aggs should be ArrayType(_, false) URL: https://github.com/apache/spark/pull/26651#issuecomment-558206714 > Can you add end-2-end tests in `DataFrameAggregateSuite`? done. thanks for your

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AngersZh commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#discussion_r350252027 ## File path:

[GitHub] [spark] tgravescs commented on issue #26611: [SPARK-29939][CORE] Add spark.shuffle.mapStatus.compression.codec conf

2019-11-25 Thread GitBox
tgravescs commented on issue #26611: [SPARK-29939][CORE] Add spark.shuffle.mapStatus.compression.codec conf URL: https://github.com/apache/spark/pull/26611#issuecomment-558205249 Yeah I definitely get that and we have left configs internal in the past, it just seemed here the only reason

[GitHub] [spark] tgravescs commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

2019-11-25 Thread GitBox
tgravescs commented on issue #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#issuecomment-558202319 I only skimmed this but overall looks good, like this approach. When fetching the host

[GitHub] [spark] srowen commented on a change in pull request #26658: [SPARK-30015][BUILD] Move hive-storage-api dependency from `hive-2.3` to `sql/core`

2019-11-25 Thread GitBox
srowen commented on a change in pull request #26658: [SPARK-30015][BUILD] Move hive-storage-api dependency from `hive-2.3` to `sql/core` URL: https://github.com/apache/spark/pull/26658#discussion_r350245919 ## File path: pom.xml ## @@ -2184,6 +2185,18 @@

[GitHub] [spark] srowen commented on a change in pull request #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
srowen commented on a change in pull request #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#discussion_r350244711 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26663: [SPARK-30015][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26663: [SPARK-30015][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used URL: https://github.com/apache/spark/pull/26663#issuecomment-558199317 Test PASSed. Refer to this link for build

[GitHub] [spark] AmplabJenkins removed a comment on issue #26663: [SPARK-30015][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26663: [SPARK-30015][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used URL: https://github.com/apache/spark/pull/26663#issuecomment-558199305 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26663: [SPARK-30015][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26663: [SPARK-30015][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used URL: https://github.com/apache/spark/pull/26663#issuecomment-558199317 Test PASSed. Refer to this link for build results

[GitHub] [spark] AmplabJenkins commented on issue #26663: [SPARK-30015][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26663: [SPARK-30015][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used URL: https://github.com/apache/spark/pull/26663#issuecomment-558199305 Merged build finished. Test PASSed.

[GitHub] [spark] maryannxue commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
maryannxue commented on a change in pull request #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#discussion_r350241870 ## File path:

[GitHub] [spark] SparkQA removed a comment on issue #26663: [SPARK-30015][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #26663: [SPARK-30015][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used URL: https://github.com/apache/spark/pull/26663#issuecomment-558136893 **[Test build #114403 has

[GitHub] [spark] SparkQA commented on issue #26663: [SPARK-30015][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used

2019-11-25 Thread GitBox
SparkQA commented on issue #26663: [SPARK-30015][Core] Continuous shuffle block fetching should be disabled by default when the old fetch protocol is used URL: https://github.com/apache/spark/pull/26663#issuecomment-558198406 **[Test build #114403 has

[GitHub] [spark] srowen commented on issue #26611: [SPARK-29939][CORE] Add spark.shuffle.mapStatus.compression.codec conf

2019-11-25 Thread GitBox
srowen commented on issue #26611: [SPARK-29939][CORE] Add spark.shuffle.mapStatus.compression.codec conf URL: https://github.com/apache/spark/pull/26611#issuecomment-558197515 It's an interesting philosophical question. If it's internal, why can users set it at all? I think it means

[GitHub] [spark] srowen commented on a change in pull request #26596: [SPARK-29959][ML][PYSPARK] Summarizer support more metrics

2019-11-25 Thread GitBox
srowen commented on a change in pull request #26596: [SPARK-29959][ML][PYSPARK] Summarizer support more metrics URL: https://github.com/apache/spark/pull/26596#discussion_r350214561 ## File path: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala ## @@ -460,21

[GitHub] [spark] srowen commented on a change in pull request #26596: [SPARK-29959][ML][PYSPARK] Summarizer support more metrics

2019-11-25 Thread GitBox
srowen commented on a change in pull request #26596: [SPARK-29959][ML][PYSPARK] Summarizer support more metrics URL: https://github.com/apache/spark/pull/26596#discussion_r350234273 ## File path: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala ## @@ -460,21

[GitHub] [spark] srowen commented on a change in pull request #26596: [SPARK-29959][ML][PYSPARK] Summarizer support more metrics

2019-11-25 Thread GitBox
srowen commented on a change in pull request #26596: [SPARK-29959][ML][PYSPARK] Summarizer support more metrics URL: https://github.com/apache/spark/pull/26596#discussion_r350228834 ## File path: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala ## @@ -460,21

[GitHub] [spark] tgravescs commented on issue #26614: [SPARK-29976] New conf for single task stage speculation

2019-11-25 Thread GitBox
tgravescs commented on issue #26614: [SPARK-29976] New conf for single task stage speculation URL: https://github.com/apache/spark/pull/26614#issuecomment-558192341 So while I agree that this could easily happen for 2 tasks instead of 1 in cases like when both put on the same executor, if

[GitHub] [spark] AmplabJenkins removed a comment on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string URL: https://github.com/apache/spark/pull/26662#issuecomment-558191447 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string URL: https://github.com/apache/spark/pull/26662#issuecomment-558191435 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string URL: https://github.com/apache/spark/pull/26662#issuecomment-558191435 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string URL: https://github.com/apache/spark/pull/26662#issuecomment-558191447 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string

2019-11-25 Thread GitBox
SparkQA commented on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string URL: https://github.com/apache/spark/pull/26662#issuecomment-558190748 **[Test build #114410 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558187961 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558187952 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558187961 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] tgravescs commented on a change in pull request #26614: [SPARK-29976] New conf for single task stage speculation

2019-11-25 Thread GitBox
tgravescs commented on a change in pull request #26614: [SPARK-29976] New conf for single task stage speculation URL: https://github.com/apache/spark/pull/26614#discussion_r350225270 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@

[GitHub] [spark] AmplabJenkins commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558187952 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
SparkQA commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558187301 **[Test build #114409 has

[GitHub] [spark] Ngone51 opened a new pull request #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
Ngone51 opened a new pull request #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665 ### What changes were proposed in this pull request? Use the same function

[GitHub] [spark] tgravescs commented on issue #26611: [SPARK-29939][CORE] Add spark.shuffle.mapStatus.compression.codec conf

2019-11-25 Thread GitBox
tgravescs commented on issue #26611: [SPARK-29939][CORE] Add spark.shuffle.mapStatus.compression.codec conf URL: https://github.com/apache/spark/pull/26611#issuecomment-558184401 I was out of the office last week, it seems odd to me that we added this config but then we left it internal,

[GitHub] [spark] Ngone51 commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
Ngone51 commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558184615 cc @cloud-fan @dongjoon-hyun

[GitHub] [spark] AmplabJenkins removed a comment on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string URL: https://github.com/apache/spark/pull/26662#issuecomment-558182680 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string URL: https://github.com/apache/spark/pull/26662#issuecomment-558182677 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string URL: https://github.com/apache/spark/pull/26662#issuecomment-558182680 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string URL: https://github.com/apache/spark/pull/26662#issuecomment-558136898 **[Test build #114404 has

[GitHub] [spark] cloud-fan commented on a change in pull request #26633: [SPARK-29994][CORE] Add WILDCARD task location

2019-11-25 Thread GitBox
cloud-fan commented on a change in pull request #26633: [SPARK-29994][CORE] Add WILDCARD task location URL: https://github.com/apache/spark/pull/26633#discussion_r350218666 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskLocation.scala ## @@ -49,6 +49,16

[GitHub] [spark] AmplabJenkins commented on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string URL: https://github.com/apache/spark/pull/26662#issuecomment-558182677 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string

2019-11-25 Thread GitBox
SparkQA commented on issue #26662: [SPARK-30026][SQL] Whitespaces can be identified as delimiters in interval string URL: https://github.com/apache/spark/pull/26662#issuecomment-558182508 **[Test build #114404 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled URL: https://github.com/apache/spark/pull/26664#issuecomment-558181165 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled URL: https://github.com/apache/spark/pull/26664#issuecomment-558181171 Test PASSed. Refer to this link for build results

[GitHub] [spark] AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-558181160 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-558181153 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-558181160 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-558181153 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled URL: https://github.com/apache/spark/pull/26664#issuecomment-558181171 Test PASSed. Refer to this link for build results (access rights

[GitHub] [spark] AmplabJenkins commented on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled URL: https://github.com/apache/spark/pull/26664#issuecomment-558181165 Merged build finished. Test PASSed.

[GitHub] [spark] cloud-fan commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
cloud-fan commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#discussion_r350216473 ## File path:

[GitHub] [spark] SparkQA commented on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled

2019-11-25 Thread GitBox
SparkQA commented on issue #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled URL: https://github.com/apache/spark/pull/26664#issuecomment-558180625 **[Test build #114407 has

[GitHub] [spark] SparkQA commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-11-25 Thread GitBox
SparkQA commented on issue #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#issuecomment-558180552 **[Test build #114408 has

[GitHub] [spark] xuanyuanking commented on a change in pull request #26147: [SPARK-9853][Core][Follow-up] Regularize all the shuffle configurations related to adaptive execution

2019-11-25 Thread GitBox
xuanyuanking commented on a change in pull request #26147: [SPARK-9853][Core][Follow-up] Regularize all the shuffle configurations related to adaptive execution URL: https://github.com/apache/spark/pull/26147#discussion_r350215026 ## File path:

[GitHub] [spark] xuanyuanking opened a new pull request #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled

2019-11-25 Thread GitBox
xuanyuanking opened a new pull request #26664: [SPARK-9853][Doc][Follow-up] Update the description for all the SQLConf affected by spark.sql.adaptive.enabled URL: https://github.com/apache/spark/pull/26664 ### What changes were proposed in this pull request? Update the description for

[GitHub] [spark] Fokko commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-11-25 Thread GitBox
Fokko commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#discussion_r350213716 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala

[GitHub] [spark] Fokko commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-11-25 Thread GitBox
Fokko commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#discussion_r350213677 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala

[GitHub] [spark] Fokko commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

2019-11-25 Thread GitBox
Fokko commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType URL: https://github.com/apache/spark/pull/26644#discussion_r350213508 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/TestUDT.scala

<    2   3   4   5   6   7   8   9   10   11   >