[GitHub] [spark] AmplabJenkins removed a comment on pull request #28387: [SPARK-29339][R][FOLLOW-UP] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620488750 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] wang-zhun commented on pull request #28009: [SPARK-31235][YARN] Separates different categories of applications

2020-04-28 Thread GitBox
wang-zhun commented on pull request #28009: URL: https://github.com/apache/spark/pull/28009#issuecomment-620488942 @tgravescs help look at this PR. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins commented on pull request #28389: [SPARK-31592]bufferPoolsBySize in HeapMemoryAllocator should be thread safe

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28389: URL: https://github.com/apache/spark/pull/28389#issuecomment-620488475 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28387: [SPARK-29339][R][FOLLOW-UP] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620488750 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] fanyunbojerry opened a new pull request #28389: [SPARK-31592]bufferPoolsBySize in HeapMemoryAllocator should be thread safe

2020-04-28 Thread GitBox
fanyunbojerry opened a new pull request #28389: URL: https://github.com/apache/spark/pull/28389 ### What changes were proposed in this pull request? Currently, bufferPoolsBySize in HeapMemoryAllocator uses a Map type whose value type is LinkedList. LinkedList is

[GitHub] [spark] SparkQA commented on pull request #28387: [SPARK-29339][R][FOLLOW-UP] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
SparkQA commented on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620488228 **[Test build #121985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121985/testReport)** for PR 28387 at commit

[GitHub] [spark] MichaelChirico commented on a change in pull request #28387: [SPARK-29339][R][FOLLOW-UP] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
MichaelChirico commented on a change in pull request #28387: URL: https://github.com/apache/spark/pull/28387#discussion_r416463288 ## File path: R/pkg/R/types.R ## @@ -88,11 +88,6 @@ specialtypeshandle <- function(type) { checkSchemaInArrow <- function(schema) {

[GitHub] [spark] AmplabJenkins commented on pull request #28387: [SPARK-29339][R][FOLLOW-UP] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620485227 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28387: [SPARK-29339][R][FOLLOW-UP] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620485227 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28387: [SPARK-29339][R][FOLLOW-UP] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
SparkQA commented on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620484508 **[Test build #121984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121984/testReport)** for PR 28387 at commit

[GitHub] [spark] yaooqinn commented on pull request #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression

2020-04-28 Thread GitBox
yaooqinn commented on pull request #28222: URL: https://github.com/apache/spark/pull/28222#issuecomment-620484345 Checked PostgresSQL(not ANSI interval type) and presto(ANSI), both of them return proper days This is an

[GitHub] [spark] MichaelChirico commented on a change in pull request #28387: [SPARK-29339][R][FOLLOW-UP] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
MichaelChirico commented on a change in pull request #28387: URL: https://github.com/apache/spark/pull/28387#discussion_r416459279 ## File path: R/pkg/R/types.R ## @@ -88,11 +88,6 @@ specialtypeshandle <- function(type) { checkSchemaInArrow <- function(schema) {

[GitHub] [spark] MichaelChirico commented on a change in pull request #28387: [SPARK-29339][R][FOLLOW-UP] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
MichaelChirico commented on a change in pull request #28387: URL: https://github.com/apache/spark/pull/28387#discussion_r416457657 ## File path: R/pkg/R/DataFrame.R ## @@ -1226,8 +1226,7 @@ setMethod("collect", # empty data.frame with 0 columns and 0 rows

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620481044 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620481044 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620480549 **[Test build #121983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121983/testReport)** for PR 28386 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
cloud-fan commented on a change in pull request #28375: URL: https://github.com/apache/spark/pull/28375#discussion_r416448092 ## File path: docs/sql-migration-guide.md ## @@ -59,7 +59,7 @@ license: | - In Spark 3.0, you can use `ADD FILE` to add file directories as well.

[GitHub] [spark] cloud-fan commented on pull request #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression

2020-04-28 Thread GitBox
cloud-fan commented on pull request #28222: URL: https://github.com/apache/spark/pull/28222#issuecomment-620473740 cc @yaooqinn can you take a look? This seems like a hard problem as we have a non-standard interval definition. It's interesting to see what results other systems return,

[GitHub] [spark] maropu commented on pull request #28385: [SPARK-31591][CORE] Fix null name prefix when create directory

2020-04-28 Thread GitBox
maropu commented on pull request #28385: URL: https://github.com/apache/spark/pull/28385#issuecomment-620465500 Why is the method called with null in the shuffle case? Is this an issue in callsite? This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28385: [SPARK-31591][CORE] Fix null name prefix when create directory

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28385: URL: https://github.com/apache/spark/pull/28385#issuecomment-620465474 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28385: [SPARK-31591][CORE] Fix null name prefix when create directory

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28385: URL: https://github.com/apache/spark/pull/28385#issuecomment-620465474 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28385: [SPARK-31591][CORE] Fix null name prefix when create directory

2020-04-28 Thread GitBox
SparkQA commented on pull request #28385: URL: https://github.com/apache/spark/pull/28385#issuecomment-620464831 **[Test build #121982 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121982/testReport)** for PR 28385 at commit

[GitHub] [spark] maropu commented on pull request #28385: [SPARK-31591][CORE] Fix null name prefix when create directory

2020-04-28 Thread GitBox
maropu commented on pull request #28385: URL: https://github.com/apache/spark/pull/28385#issuecomment-620464218 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28387: [SPARK-29339][R][FOLLOW-UP] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
HyukjinKwon commented on a change in pull request #28387: URL: https://github.com/apache/spark/pull/28387#discussion_r416431223 ## File path: R/pkg/R/DataFrame.R ## @@ -1226,8 +1226,7 @@ setMethod("collect", # empty data.frame with 0 columns and 0 rows

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28387: [SPARK-29339][R][FOLLOW-UP] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
HyukjinKwon commented on a change in pull request #28387: URL: https://github.com/apache/spark/pull/28387#discussion_r416429707 ## File path: R/pkg/R/DataFrame.R ## @@ -1226,8 +1226,7 @@ setMethod("collect", # empty data.frame with 0 columns and 0 rows

[GitHub] [spark] igreenfield commented on pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-04-28 Thread GitBox
igreenfield commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-620460159 The failed test does not seems to be connected to the changes in the code This is an automated message

[GitHub] [spark] HyukjinKwon commented on pull request #28367: [SPARK-31573][R] Apply fixed=TRUE as appropriate to regex usage in R

2020-04-28 Thread GitBox
HyukjinKwon commented on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-620458462 Merged to master and branch-3.0. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] cloud-fan commented on a change in pull request #26141: [SPARK-29492][SQL]Reset HiveSession's SessionState conf's ClassLoader when sync mode

2020-04-28 Thread GitBox
cloud-fan commented on a change in pull request #26141: URL: https://github.com/apache/spark/pull/26141#discussion_r416423730 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala ## @@ -72,6 +72,48 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #26141: [SPARK-29492][SQL]Reset HiveSession's SessionState conf's ClassLoader when sync mode

2020-04-28 Thread GitBox
cloud-fan commented on a change in pull request #26141: URL: https://github.com/apache/spark/pull/26141#discussion_r416423419 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala ## @@ -72,6 +72,48 @@ class

[GitHub] [spark] HyukjinKwon commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
HyukjinKwon commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620454937 cc @felixcheung and @shivaram FYI This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620453870 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620453844 **[Test build #121980 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121980/testReport)** for PR 28386 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620449564 **[Test build #121980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121980/testReport)** for PR 28386 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620453862 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620453862 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] xuanyuanking commented on a change in pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-28 Thread GitBox
xuanyuanking commented on a change in pull request #28326: URL: https://github.com/apache/spark/pull/28326#discussion_r416419173 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ## @@ -1040,17 +1034,11 @@ class Column(val expr: Expression) extends

[GitHub] [spark] cloud-fan commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-28 Thread GitBox
cloud-fan commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-620452258 @xuanyuanking can you send a backport PR for 2.4? This is an automated message from the Apache Git Service.

[GitHub] [spark] cloud-fan commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-28 Thread GitBox
cloud-fan commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-620451860 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28366: [WIP][SPARK-31365][SQL] Enable nested predicate pushdown per data sources

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28366: URL: https://github.com/apache/spark/pull/28366#issuecomment-620450142 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620450040 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620450040 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28366: [WIP][SPARK-31365][SQL] Enable nested predicate pushdown per data sources

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28366: URL: https://github.com/apache/spark/pull/28366#issuecomment-620450142 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28366: [WIP][SPARK-31365][SQL] Enable nested predicate pushdown per data sources

2020-04-28 Thread GitBox
SparkQA commented on pull request #28366: URL: https://github.com/apache/spark/pull/28366#issuecomment-620449590 **[Test build #121981 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121981/testReport)** for PR 28366 at commit

[GitHub] [spark] SparkQA commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620449564 **[Test build #121980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121980/testReport)** for PR 28386 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620447533 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620447524 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620442254 **[Test build #121978 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121978/testReport)** for PR 28386 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620447524 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620447503 **[Test build #121978 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121978/testReport)** for PR 28386 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-620446584 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620442764 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-620446584 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-28 Thread GitBox
SparkQA commented on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-620445888 **[Test build #121979 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121979/testReport)** for PR 27978 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-04-28 Thread GitBox
cloud-fan commented on a change in pull request #27627: URL: https://github.com/apache/spark/pull/27627#discussion_r416408564 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -62,38 +62,113 @@ case class Sum(child:

[GitHub] [spark] cloud-fan commented on a change in pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-04-28 Thread GitBox
cloud-fan commented on a change in pull request #27627: URL: https://github.com/apache/spark/pull/27627#discussion_r416407527 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -62,38 +62,113 @@ case class Sum(child:

[GitHub] [spark] dongjoon-hyun commented on pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-28 Thread GitBox
dongjoon-hyun commented on pull request #27803: URL: https://github.com/apache/spark/pull/27803#issuecomment-620444208 Thank you, @maropu . This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on a change in pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-04-28 Thread GitBox
cloud-fan commented on a change in pull request #27627: URL: https://github.com/apache/spark/pull/27627#discussion_r416407135 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -62,38 +62,113 @@ case class Sum(child:

[GitHub] [spark] AmplabJenkins commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620442764 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620442254 **[Test build #121978 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121978/testReport)** for PR 28386 at commit

[GitHub] [spark] sathyaprakashg commented on pull request #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression

2020-04-28 Thread GitBox
sathyaprakashg commented on pull request #28222: URL: https://github.com/apache/spark/pull/28222#issuecomment-620441968 > @sathyaprakashg Please, take a look at the PRs > #26337 > #27262 Thanks @MaxGekk for prompt reply. CalendarInterval change is not required to fix the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620439117 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28349: [SPARK-30642][ML][PYSPARK] LinearSVC blockify input vectors

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28349: URL: https://github.com/apache/spark/pull/28349#issuecomment-620439260 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620438619 **[Test build #121975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121975/testReport)** for PR 28386 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620439110 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620439095 **[Test build #121975 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121975/testReport)** for PR 28386 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28349: [SPARK-30642][ML][PYSPARK] LinearSVC blockify input vectors

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28349: URL: https://github.com/apache/spark/pull/28349#issuecomment-620439260 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620439205 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620439110 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28349: [SPARK-30642][ML][PYSPARK] LinearSVC blockify input vectors

2020-04-28 Thread GitBox
SparkQA commented on pull request #28349: URL: https://github.com/apache/spark/pull/28349#issuecomment-620438687 **[Test build #121976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121976/testReport)** for PR 28349 at commit

[GitHub] [spark] SparkQA commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620438619 **[Test build #121975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121975/testReport)** for PR 28386 at commit

[GitHub] [spark] SparkQA commented on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-28 Thread GitBox
SparkQA commented on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-620438664 **[Test build #121977 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121977/testReport)** for PR 27978 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-04-28 Thread GitBox
cloud-fan commented on a change in pull request #27627: URL: https://github.com/apache/spark/pull/27627#discussion_r416399567 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -62,38 +62,113 @@ case class Sum(child:

[GitHub] [spark] cloud-fan commented on a change in pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-04-28 Thread GitBox
cloud-fan commented on a change in pull request #27627: URL: https://github.com/apache/spark/pull/27627#discussion_r416398914 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -62,38 +62,113 @@ case class Sum(child:

[GitHub] [spark] viirya commented on pull request #28376: [SPARK-31582] [Yarn] Being able to not populate Hadoop classpath

2020-04-28 Thread GitBox
viirya commented on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620437448 One question, for the case mentioned in the description, "One case we have is when a user uses an Apache Spark distribution with its-own embedded hadoop, and submits a job to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-620435924 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] For dynamic partition overwrite operation, fix speculation task conflict issue and FileAlreadyE

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-620435969 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #27978: URL: https://github.com/apache/spark/pull/27978#issuecomment-620435924 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] For dynamic partition overwrite operation, fix speculation task conflict issue and FileAlreadyExistsExc

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-620435969 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] For dynamic partition overwrite operation, fix speculation task conflict issue and FileAlreadyExistsException

2020-04-28 Thread GitBox
SparkQA commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-620435452 **[Test build #121974 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121974/testReport)** for PR 26339 at commit

[GitHub] [spark] MaxGekk commented on pull request #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression

2020-04-28 Thread GitBox
MaxGekk commented on pull request #28222: URL: https://github.com/apache/spark/pull/28222#issuecomment-620432117 @sathyaprakashg Please, take a look at the PRs https://github.com/apache/spark/pull/26337 https://github.com/apache/spark/pull/27262

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620429261 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28381: [SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28381: URL: https://github.com/apache/spark/pull/28381#issuecomment-620429356 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28387: [SPARK-26924][R] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620429212 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620429239 **[Test build #121971 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121971/testReport)** for PR 28386 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620429256 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620429379 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28388: [SPARK-31553][SQL] Revert "[SPARK-29048] Improve performance on Column.isInCollection() with a large size collection"

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28388: URL: https://github.com/apache/spark/pull/28388#issuecomment-620429270 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28381: [SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28381: URL: https://github.com/apache/spark/pull/28381#issuecomment-620429356 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620428768 **[Test build #121971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121971/testReport)** for PR 28386 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620429379 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28387: [SPARK-26924][R] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620429212 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620429256 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28388: [SPARK-31553][SQL] Revert "[SPARK-29048] Improve performance on Column.isInCollection() with a large size collection"

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28388: URL: https://github.com/apache/spark/pull/28388#issuecomment-620429270 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28388: [SPARK-31553][SQL] Revert "[SPARK-29048] Improve performance on Column.isInCollection() with a large size collection"

2020-04-28 Thread GitBox

[GitHub] [spark] MaxGekk commented on pull request #28388: [SPARK-31553][SQL] Revert "[SPARK-29048] Improve performance on Column.isInCollection() with a large size collection"

2020-04-28 Thread GitBox
MaxGekk commented on pull request #28388: URL: https://github.com/apache/spark/pull/28388#issuecomment-620428658 also cc @WeichenXu123 @dongjoon-hyun @maropu This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28387: [SPARK-26924][R] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
SparkQA commented on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620428791 **[Test build #121970 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121970/testReport)** for PR 28387 at commit

[GitHub] [spark] SparkQA commented on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-28 Thread GitBox
SparkQA commented on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620428775 **[Test build #121973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121973/testReport)** for PR 28194 at commit

[GitHub] [spark] sathyaprakashg commented on pull request #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression

2020-04-28 Thread GitBox
sathyaprakashg commented on pull request #28222: URL: https://github.com/apache/spark/pull/28222#issuecomment-620428630 @cloud-fan @MaxGekk @yaooqinn I am looking for help to review this PR created 2 weeks ago. Since you guys were involved in PR related to simillar change

[GitHub] [spark] SparkQA commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620428768 **[Test build #121971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121971/testReport)** for PR 28386 at commit

[GitHub] [spark] SparkQA commented on pull request #28381: [SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

2020-04-28 Thread GitBox
SparkQA commented on pull request #28381: URL: https://github.com/apache/spark/pull/28381#issuecomment-620428796 **[Test build #121972 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121972/testReport)** for PR 28381 at commit

<    2   3   4   5   6   7   8   9   >